bitcoin/test/functional
MarcoFalke bc38bb9a60
Merge #17288: Added TestShell class for interactive Python environments.
19139ee034 Add documentation for test_shell submodule (JamesC)
f5112369cf Add TestShell class (James Chiang)
5155602a63 Move argparse() to init() (JamesC)
2ab01462f4 Move assert num_nodes is set into main() (JamesC)
614c645643 Clear TestNode objects after shutdown (JamesC)
6f40820757 Add closing and flushing of logging handlers (JamesC)
6b71241291 Refactor TestFramework main() into setup/shutdown (JamesC)
ede8b7608e Remove network_event_loop instance in close() (JamesC)

Pull request description:

  This PR refactors BitcoinTestFramework to encapsulate setup and shutdown logic into dedicated methods, and adds a  ~~TestWrapper~~ TestShell child class. This wrapper allows the underlying BitcoinTestFramework to run _between user inputs_ in a REPL environment, such as a Jupyter notebook or any interactive Python3 interpreter.

  The ~~TestWrapper~~ TestShell is motivated by the opportunity to expose the test-framework as a prototyping and educational toolkit. Examples of code prototypes enabled by  ~~TestWrapper~~ TestShell can be found in the Optech [Taproot/Schnorr](https://github.com/bitcoinops/taproot-workshop) workshop repository.

  Usage example:
  ```
  >>> import sys
  >>> sys.path.insert(0, "/path/to/bitcoin/test/functional")
  ```
  ```
  >>> from test_framework.test_wrapper import TestShell
  >>> test = TestShell()
  >>> test.setup(num_nodes=2)
  20XX-XX-XXTXX:XX:XX.XXXXXXX TestFramework (INFO): Initializing test directory /path/to/bitcoin_func_test_XXXXXXX
  ```
  ```
  >>> test.nodes[0].generate(101)
  >>> test.nodes[0].getblockchaininfo()["blocks"]
  101
  ```
  ```
  >>> test.shutdown()
  20XX-XX-XXTXX:XX:XX.XXXXXXX TestFramework (INFO): Stopping nodes
  20XX-XX-XXTXX:XX:XX.XXXXXXX TestFramework (INFO): Cleaning up /path/to/bitcoin_func_test_XXXXXXX on exit
  20XX-XX-XXTXX:XX:XX.XXXXXXX TestFramework (INFO): Tests successful
  ```

  **Overview of changes to BitcoinTestFramework:**

  - Code moved to `setup()/shutdown()` methods.
  - Argument parsing logic encapsulated by `parse_args` method.
  - Success state moved to `BitcoinTestFramework.success`.

  _During Shutdown_

  - `BitcoinTestFramework` logging handlers are flushed and removed.
  - `BitcoinTestFrameowork.nodes` list is cleared.
  - `NetworkThread.network_event_loop` is reset. (NetworkThread class).

  **Behavioural changes:**
  - Test parameters can now also be set when overriding BitcoinTestFramework.setup() in addition to overriding `set_test_params` method.
  - Potential exceptions raised in BitcoinTestFramework.setup() will be handled in main().

  **Added files:**
  - ~~test_wrapper.py~~ `test_shell.py`
  - ~~test-wrapper.md~~ `test-shell.md`

ACKs for top commit:
  jamesob:
    ACK 19139ee034
  jonatack:
    ACK 19139ee034
  jnewbery:
    Rather than invalidate the three ACKs for a minor nit, can you force push back to 19139ee034 please? I think this PR was ready to merge before your last force push.
  jachiang:
    > Rather than invalidate the three ACKs for a minor nit, can you force push back to [19139ee](19139ee034) please? I think this PR was ready to merge before your last force push.
  jnewbery:
    ACK 19139ee034

Tree-SHA512: 0c24f405f295a8580a9c8f1b9e0182b5d753eb08cc331424616dd50a062fb773d3719db4d08943365b1f42ccb965cc363b4bcc5beae27ac90b3460b349ed46b2
2019-11-04 14:54:14 -05:00
..
data Merge #16821: Fix bug where duplicate PSBT keys are accepted 2019-10-09 09:18:27 -04:00
test_framework Add TestShell class 2019-11-04 08:56:56 +01:00
.gitignore
combine_logs.py test: Fix combine_logs.py for AppVeyor build 2019-09-27 12:40:20 +02:00
combined_log_template.html
create_cache.py
example_test.py [qa] Fix race condition in example_test.py 2019-07-25 10:32:07 -04:00
feature_abortnode.py [qa] Test disconnect block failure -> shutdown 2019-06-05 05:05:49 -04:00
feature_assumevalid.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
feature_bip68_sequence.py Merge #17004: validation: Remove REJECT code from CValidationState 2019-10-24 10:49:45 +02:00
feature_block.py [test] rename SegwitVersion1SignatureHash() 2019-10-14 17:13:05 -04:00
feature_blocksdir.py test: Adapt test framework for chains other than "regtest" 2019-07-31 17:00:25 -04:00
feature_cltv.py [logging] Don't log REJECT code when transaction is rejected 2019-10-10 11:19:42 -04:00
feature_config_args.py Merge #15864: Fix datadir handling 2019-08-19 10:01:30 -04:00
feature_csv_activation.py [Consensus] Bury CSV deployment height 2019-08-14 15:52:52 -04:00
feature_dbcrash.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
feature_dersig.py [logging] Don't log REJECT code when transaction is rejected 2019-10-10 11:19:42 -04:00
feature_fee_estimation.py test: Explain why -whitelist is used in feature_fee_estimation 2019-08-02 11:16:24 -04:00
feature_filelock.py QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core 2019-04-25 20:43:04 +00:00
feature_help.py
feature_includeconf.py init: Use InitError for all errors in bitcoind/qt 2019-07-11 19:39:25 -04:00
feature_loadblock.py tests: Add test for loadblock option 2019-10-13 13:09:35 +02:00
feature_logging.py test/contrib: Fix invalid escapes in regex strings 2019-09-03 14:38:38 -04:00
feature_maxuploadtarget.py test: Require standard txs in regtest 2019-06-21 16:45:16 -04:00
feature_minchainwork.py
feature_notifications.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
feature_nulldummy.py [logging] Don't log REJECT code when transaction is rejected 2019-10-10 11:19:42 -04:00
feature_proxy.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
feature_pruning.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
feature_rbf.py test: fix "tx-size-small" errors after default address change 2019-10-14 15:03:11 +02:00
feature_reindex.py
feature_segwit.py [logging] Don't log REJECT code when transaction is rejected 2019-10-10 11:19:42 -04:00
feature_shutdown.py
feature_uacomment.py test/contrib: Fix invalid escapes in regex strings 2019-09-03 14:38:38 -04:00
feature_versionbits_warning.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
interface_bitcoin_cli.py test: Adapt test framework for chains other than "regtest" 2019-07-31 17:00:25 -04:00
interface_http.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
interface_rest.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
interface_rpc.py Add a 'logpath' field to getrpcinfo 2019-05-16 23:01:00 +02:00
interface_zmq.py qa: Relax so that the subscriber is ready before publishing zmq messages 2019-08-28 00:42:29 +01:00
mempool_accept.py [logging] Don't log REJECT code when transaction is rejected 2019-10-10 11:19:42 -04:00
mempool_limit.py test: Require standard txs in regtest 2019-06-21 16:45:16 -04:00
mempool_package_onemore.py Conservatively accept RBF bumps bumping one tx at the package limits 2019-09-04 15:53:14 -04:00
mempool_packages.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
mempool_persist.py test: mempool entry time is persisted 2019-09-19 11:30:28 -04:00
mempool_reorg.py
mempool_resurrect.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
mempool_spend_coinbase.py
mining_basic.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
mining_getblocktemplate_longpoll.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
mining_prioritisetransaction.py test: Require standard txs in regtest 2019-06-21 16:45:16 -04:00
p2p_blocksonly.py Disconnect peers violating blocks-only mode 2019-09-04 14:58:36 -04:00
p2p_compactblocks.py [Consensus] Bury segwit deployment 2019-08-14 15:52:52 -04:00
p2p_disconnect_ban.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
p2p_dos_header_tree.py [logging] Don't log REJECT code when transaction is rejected 2019-10-10 11:19:42 -04:00
p2p_feefilter.py modify p2p_feefilter test to catch rounding error 2019-10-03 14:03:27 -04:00
p2p_fingerprint.py
p2p_invalid_block.py New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137. 2019-06-02 10:25:03 -07:00
p2p_invalid_locator.py
p2p_invalid_messages.py Remove oversized message detection from log and interface 2019-10-23 09:27:25 +02:00
p2p_invalid_tx.py test: Require standard txs in regtest 2019-06-21 16:45:16 -04:00
p2p_leak_tx.py
p2p_leak.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
p2p_mempool.py
p2p_node_network_limited.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
p2p_permissions.py Reformat p2p_permissions.py 2019-08-17 00:43:37 +09:00
p2p_segwit.py [test] rename SegwitVersion1SignatureHash() 2019-10-14 17:13:05 -04:00
p2p_sendheaders.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
p2p_timeouts.py
p2p_tx_download.py test: Use connect_nodes when connecting nodes in the test_framework 2019-09-17 13:08:17 -04:00
p2p_unrequested_blocks.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
README.md Add documentation for test_shell submodule 2019-11-04 16:02:28 +01:00
rpc_bind.py test: Adapt test framework for chains other than "regtest" 2019-07-31 17:00:25 -04:00
rpc_blockchain.py [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response 2019-09-26 15:20:55 +01:00
rpc_createmultisig.py Test sortedmulti descriptor using BIP 67 tests 2019-10-08 13:56:56 -04:00
rpc_decodescript.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_deprecated.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_deriveaddresses.py Give more errors for specific failure conditions 2019-08-16 19:34:01 -04:00
rpc_fundrawtransaction.py test: rm ascii art in rpc_fundrawtransaction 2019-11-01 11:56:53 +01:00
rpc_getblockfilter.py rpc: Add getblockfilter RPC method. 2019-04-06 12:10:55 -07:00
rpc_getblockstats.py rpc: faster getblockstats using BlockUndo data 2019-05-10 08:33:14 -04:00
rpc_getchaintips.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
rpc_help.py
rpc_invalidateblock.py rpc: Add generatetodescriptor 2019-10-30 10:01:32 -04:00
rpc_misc.py util: Add CHECK_NONFATAL and use it in src/rpc 2019-10-18 17:19:36 -04:00
rpc_named_arguments.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_net.py Merge #16987: test: Correct docstring param name. 2019-09-30 12:12:59 -04:00
rpc_preciousblock.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
rpc_psbt.py Merge #16898: test: Remove connect_nodes_bi 2019-09-18 14:41:21 -04:00
rpc_rawtransaction.py [validation] Remove fMissingInputs from AcceptToMemoryPool() 2019-10-29 15:46:45 -04:00
rpc_scantxoutset.py qa: Check scantxoutset result against gettxoutsetinfo 2019-09-09 00:51:31 +01:00
rpc_setban.py test: Remove incorrect and unused try-block in assert_debug_log 2019-09-04 13:10:37 -04:00
rpc_signmessage.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_signrawtransaction.py [rpc] Remove signrawtransaction warning 2019-03-22 10:30:25 -04:00
rpc_txoutproof.py
rpc_uptime.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_users.py test: rpc_users: Make variable names more clear. 2019-07-08 16:13:35 -04:00
test_runner.py Merge #15888: QA: Add wallet_implicitsegwit to test the ability to transform keys between address types 2019-11-01 13:24:50 -04:00
test-shell.md Add documentation for test_shell submodule 2019-11-04 16:02:28 +01:00
tool_wallet.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
wallet_abandonconflict.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_address_types.py test: speed up wallet_address_types by whitelisting peers (immediate tx relay) 2019-10-13 21:11:37 +02:00
wallet_avoidreuse.py Test: Move common function assert_approx() into util.py 2019-09-19 14:53:40 +02:00
wallet_backup.py test: speedup wallet_backup by whitelisting peers (immediate tx relay) 2019-10-13 02:50:08 +02:00
wallet_balance.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
wallet_basic.py Change default address type to bech32 2019-09-26 16:23:32 -04:00
wallet_bumpfee_totalfee_deprecation.py Add RPC bumpfee totalFee deprecation test 2019-07-26 14:09:03 -04:00
wallet_bumpfee.py test: use default address type (bech32) for wallet_bumpfee tests 2019-10-22 16:38:48 +02:00
wallet_coinbase_category.py
wallet_create_tx.py test: Add test for maxtxfee option 2019-07-10 11:58:46 +01:00
wallet_createwallet.py Allow createwallet to take empty passwords to make unencrypted wallets 2019-07-29 11:50:24 -04:00
wallet_disable.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
wallet_dump.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
wallet_encryption.py QA: Fix race condition in wallet_encryption test 2019-07-18 22:31:24 +02:00
wallet_fallbackfee.py
wallet_groups.py Test: Move common function assert_approx() into util.py 2019-09-19 14:53:40 +02:00
wallet_hd.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
wallet_implicitsegwit.py QA: Add wallet_implicitsegwit to test the ability to transform keys between address types 2019-10-30 18:56:25 +00:00
wallet_import_rescan.py test: Fix extra_args in wallet_import_rescan.py 2019-09-19 15:25:00 -04:00
wallet_import_with_label.py Change default address type to bech32 2019-09-26 16:23:32 -04:00
wallet_importmulti.py Avoid using mutable default parameter values 2019-08-26 10:45:25 +00:00
wallet_importprunedfunds.py
wallet_keypool_topup.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
wallet_keypool.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
wallet_labels.py
wallet_listreceivedby.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_listsinceblock.py test: Use connect_nodes when connecting nodes in the test_framework 2019-09-17 13:08:17 -04:00
wallet_listtransactions.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_multiwallet.py wallet: Avoid showing GUI popups on RPC errors 2019-10-08 13:02:14 -04:00
wallet_reorgsrestore.py Add a test wallet_reorgsrestore 2019-08-29 12:01:51 -04:00
wallet_resendwallettransactions.py rpc: Clarify that block count means height excl genesis 2019-07-02 12:28:21 -04:00
wallet_txn_clone.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_txn_doublespend.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_watchonly.py test: add executable flag for wallet_watchonly.py 2019-08-28 18:25:00 +02:00
wallet_zapwallettxes.py

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

mininode.py

Basic code to support P2P connectivity to a bitcoind.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

bignum.py

Helpers for script.py

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: