Andrew Chow b4fb0a3255 Merge bitcoin/bitcoin#26761: wallet: fully migrate address book entries for watchonly/solvable wallets ... 730e14a317 test: wallet: check that labels are migrated to watchonly wallet (Sebastian Falbesoner) d5f4ae7fac wallet: fully migrate address book entries for watchonly/solvable wallets (Sebastian Falbesoner) Pull request description: Currently `migratewallet` migrates the address book (i.e. labels and purposes) for watchonly and solvable wallets only in RAM, but doesn't persist them on disk. Fix this by adding another loop for both of the special wallet types after which writes the corresponding NAME and PURPOSE entries to the database in a single batch. Also adds a corresponding test that checks if labels were migrated correctly for a watchonly wallet. ACKs for top commit: achow101: ACK 730e14a317 furszy: code ACK 730e14a3, left a non-blocking nit. aureleoules: ACK 730e14a317 Tree-SHA512: 159487e11e858924ef762e0190ccaea185bdff239e3d2280c8d63c4ac2649ec71714dc4d53dec644f03488f91c3b4bbbbf3434dad23bc0fcecb6657f353ea766		2023-01-05 12:22:51 -05:00
..
bench	Merge bitcoin/bitcoin#23829: refactor: use braced init for integer literals instead of c style casts	2023-01-05 17:30:52 +01:00
common	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
compat	compat: use STDIN_FILENO over 0	2023-01-04 12:00:25 +00:00
config
consensus	Merge bitcoin/bitcoin#26603: doc: CalculateSequenceLocks: prevHeights entries are set to 0, not removed	2023-01-04 18:07:31 +00:00
crc32c	Update crc32c subtree to latest upstream master	2022-08-13 13:55:38 +01:00
crypto	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
index	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
init	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
interfaces	Merge bitcoin/bitcoin#26752: wallet: Remove mempool_sequence from interface methods	2023-01-04 17:53:58 +00:00
ipc	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
kernel	refactor: Move txmempool_entry.h --> kernel/mempool_entry.h	2022-11-30 10:37:57 +00:00
leveldb	Update leveldb-subtree subtree to latest upstream	2022-09-29 16:43:30 +01:00
logging	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
minisketch	Update minisketch subtree to latest upstream	2022-10-23 15:03:04 +01:00
node	Merge bitcoin/bitcoin#26752: wallet: Remove mempool_sequence from interface methods	2023-01-04 17:53:58 +00:00
policy	Merge bitcoin/bitcoin#26289: Use util::Result in for calculating mempool ancestors	2023-01-03 16:30:55 -05:00
primitives	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
qt	Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages	2023-01-03 18:53:36 -05:00
rpc	Merge bitcoin/bitcoin#26289: Use util::Result in for calculating mempool ancestors	2023-01-03 16:30:55 -05:00
script	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
secp256k1	Update secp256k1 subtree to latest upstream master	2022-06-11 14:55:18 +01:00
support	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
test	Merge bitcoin/bitcoin#23829: refactor: use braced init for integer literals instead of c style casts	2023-01-05 17:30:52 +01:00
univalue	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
util	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
wallet	Merge bitcoin/bitcoin#26761: wallet: fully migrate address book entries for watchonly/solvable wallets	2023-01-05 12:22:51 -05:00
zmq	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
.bear-tidy-config	tidy: enable modernize-use-nullptr	2022-04-26 10:43:33 +01:00
.clang-format
.clang-tidy	Merge bitcoin/bitcoin#25872: Fix issues when calling std::move(const&)	2022-08-31 08:38:24 +01:00
addrdb.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
addrdb.h	[net] Move asmap into NetGroupManager	2022-04-20 14:29:29 +01:00
addrman.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
addrman.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
addrman_impl.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
arith_uint256.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
arith_uint256.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
attributes.h
banman.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
banman.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
base58.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
base58.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bech32.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bech32.h
bitcoin-chainstate.cpp	scripted-diff: rename CChainState -> Chainstate	2022-09-09 11:47:27 -04:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bitcoin-util-res.rc
bitcoin-util.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bitcoind-res.rc
bitcoind.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
blockencodings.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
blockencodings.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
blockfilter.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
blockfilter.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
chain.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
chain.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
chainparams.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
chainparams.h
chainparamsbase.cpp
chainparamsbase.h
chainparamsseeds.h	Merge bitcoin/bitcoin#25853: net: update testnet torv3 hardcoded seeds for 24.x	2022-09-09 10:07:39 +02:00
checkqueue.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
clientversion.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
clientversion.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
coins.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
coins.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
compressor.cpp
compressor.h
core_io.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
core_memusage.h
core_read.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
core_write.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
cuckoocache.h	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
dbwrapper.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
dbwrapper.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
deploymentstatus.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
dummywallet.cpp
external_signer.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
external_signer.h
flatfile.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
flatfile.h
fs.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
fs.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
hash.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
hash.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
headerssync.cpp	Move headerssync logging to BCLog::NET	2022-08-30 12:09:04 -04:00
headerssync.h	Track headers presync progress and log it	2022-08-29 08:10:35 -04:00
httprpc.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
httprpc.h
httpserver.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
httpserver.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
i2p.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
i2p.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
indirectmap.h
init.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
init.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
key.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
key.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
key_io.cpp
key_io.h
logging.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
logging.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
Makefile.am	Merge bitcoin/bitcoin#26298: refactor: Move src/interfaces/*.cpp files to libbitcoin_common.a	2022-12-07 14:54:23 +00:00
Makefile.bench.include	Merge bitcoin/bitcoin#16981: Improve runtime performance of --reindex	2022-11-15 19:23:39 -05:00
Makefile.crc32c.include	build: Create .la library for crc32c	2022-04-26 16:25:38 -04:00
Makefile.leveldb.include	Use more specific path when including memenv.h header	2022-06-23 15:33:01 +02:00
Makefile.minisketch.include
Makefile.qt.include	build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)	2022-09-13 17:15:17 +01:00
Makefile.qt_locale.include
Makefile.qttest.include	build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)	2022-09-13 17:15:17 +01:00
Makefile.test.include	Merge bitcoin/bitcoin#25789: test: clean and extend availablecoins_tests coverage	2023-01-03 12:52:40 -05:00
Makefile.test_fuzz.include	[fuzz] Move ConsumeNetAddr to fuzz/util/net.h	2022-11-17 14:52:45 +00:00
Makefile.test_util.include	refactor: unify test/util/wallet.h with wallet/test/util.h	2022-11-21 17:30:00 -03:00
Makefile.univalue.include
mapport.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
mapport.h
memusage.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
merkleblock.cpp
merkleblock.h
net.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_permissions.cpp
net_permissions.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_processing.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_processing.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_types.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_types.h
netaddress.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
netaddress.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
netbase.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
netbase.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
netgroup.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
netgroup.h	[netgroupman] Remove NetGroupManager::GetAsmap()	2022-04-20 14:35:53 +01:00
netmessagemaker.h
noui.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
noui.h
outputtype.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
outputtype.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
pow.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
pow.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
prevector.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
protocol.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
protocol.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
psbt.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
psbt.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
pubkey.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
pubkey.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
random.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
random.h	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
randomenv.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
randomenv.h
rest.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
rest.h
reverse_iterator.h
scheduler.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
scheduler.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
serialize.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
shutdown.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
shutdown.h
signet.cpp
signet.h
span.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
streams.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
sync.cpp
sync.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
threadsafety.h
timedata.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
timedata.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
tinyformat.h	clang-tidy: Fix modernize-use-nullptr in headers	2022-12-15 20:58:19 +00:00
torcontrol.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
torcontrol.h
txdb.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
txdb.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
txmempool.cpp	Merge bitcoin/bitcoin#19909: refactor: Remove unused CTxMemPool::clear() helper	2023-01-04 08:44:26 +00:00
txmempool.h	Merge bitcoin/bitcoin#19909: refactor: Remove unused CTxMemPool::clear() helper	2023-01-04 08:44:26 +00:00
txorphanage.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
txorphanage.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
txrequest.cpp
txrequest.h
uint256.cpp
uint256.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
undo.h
validation.cpp	Merge bitcoin/bitcoin#26289: Use util::Result in for calculating mempool ancestors	2023-01-03 16:30:55 -05:00
validation.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
validationinterface.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
validationinterface.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
version.h
versionbits.cpp	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
versionbits.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
walletinitinterface.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
warnings.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
warnings.h