MarcoFalke 9158d6f341 Merge #20786: net: [refactor] Prefer integral types in CNodeStats ... faecb74562 Expose integral m_conn_type in CNodeStats, remove m_conn_type_string (Jon Atack) Pull request description: Currently, strings are stored for what are actually integral (strong) enum types. This is fine, because the strings are only used as-is for the debug log and RPC. However, it complicates using them in the GUI. User facing strings in the GUI should be translated and only string literals can be picked up for translation, not runtime `std::string`s. Fix that by removing the `std::string` members and replace them by strong enum integral types. ACKs for top commit: jonatack: Code review ACK faecb74562 theStack: Code review ACK faecb74562 🌲 Tree-SHA512: 24df2bd0645432060e393eb44b8abaf20fe296457d07a867b0e735c3e2e75af7b03fc6bfeca734ec33ab816a7c8e1f8591a5ec342f3afe3098a4e41f5c2cfebb		2021-01-08 15:14:53 +01:00
..
bench	Merge #19055: Add MuHash3072 implementation	2021-01-07 17:57:17 +01:00
compat	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
config
consensus	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
crc32c	build: Update crc32c subtree	2020-12-08 19:26:30 +01:00
crypto	Merge #19055: Add MuHash3072 implementation	2021-01-07 17:57:17 +01:00
index	Merge #19846: build: enable unused member function diagnostic	2021-01-05 12:06:40 +01:00
interfaces	net: Add -natpmp command line option	2021-01-07 18:07:09 +02:00
leveldb
logging
node	net: Add -natpmp command line option	2021-01-07 18:07:09 +02:00
policy	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
primitives	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
qt	gui: Add NAT-PMP network option	2021-01-07 18:07:10 +02:00
rpc	Expose integral m_conn_type in CNodeStats, remove m_conn_type_string	2021-01-07 15:18:44 +01:00
script	Merge #20584: Declare de facto const reference variables/member functions as const	2021-01-07 09:05:09 +01:00
secp256k1	Update secp256k1 subtree to latest master	2020-10-27 23:08:48 -07:00
support	doc: Use https URLs where possible	2021-01-04 12:23:16 +08:00
test	fuzz: Add missing muhash registration	2021-01-08 09:40:50 +01:00
univalue	Update univalue subtree	2020-11-19 15:48:24 +01:00
util	Merge #14501: Fix possible data race when committing block files	2021-01-07 22:07:33 +01:00
wallet	Merge #20584: Declare de facto const reference variables/member functions as const	2021-01-07 09:05:09 +01:00
zmq	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
.clang-format
addrdb.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
addrdb.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
addrman.cpp	Don't declare de facto const reference variables as non-const	2020-12-06 18:44:31 +00:00
addrman.h	Merge #20291: [net] Consolidate logic around calling CAddrMan::Connected()	2020-11-19 16:30:54 +01:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
banman.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
banman.h
base58.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
base58.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
bech32.cpp
bech32.h
bitcoin-cli-res.rc	Drop the leading 0 from the version number	2020-11-18 12:00:57 -05:00
bitcoin-cli.cpp	netinfo: add user help documentation	2021-01-05 21:31:48 +01:00
bitcoin-tx-res.rc	Drop the leading 0 from the version number	2020-11-18 12:00:57 -05:00
bitcoin-tx.cpp	Move TX_MAX_STANDARD_VERSION to policy	2020-12-10 11:12:08 +01:00
bitcoin-wallet-res.rc	Drop the leading 0 from the version number	2020-11-18 12:00:57 -05:00
bitcoin-wallet.cpp	wallet: Add missing check for -descriptors wallet tool option	2020-12-17 20:36:41 +01:00
bitcoind-res.rc	Drop the leading 0 from the version number	2020-11-18 12:00:57 -05:00
bitcoind.cpp	init: Signal-safe instant shutdown	2020-12-15 17:21:06 +01:00
blockencodings.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
blockencodings.h
blockfilter.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
blockfilter.h
bloom.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
bloom.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
chain.cpp
chain.h	chain: Remove UB CChain comparison	2020-08-27 20:07:27 -04:00
chainparams.cpp	Move signet onion seed from v2 to v3	2020-12-15 14:12:01 +01:00
chainparams.h	Remove gArgs global from CreateChainParams to aid testing	2020-09-29 10:20:05 +02:00
chainparamsbase.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
chainparamsbase.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
chainparamsseeds.h	net: Hardcoded seeds update for 0.21	2020-10-25 14:25:00 +01:00
checkqueue.h
clientversion.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
clientversion.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
coins.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
coins.h
compat.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
compressor.cpp
compressor.h
core_io.h	doc: fix various typos	2021-01-04 12:31:31 +08:00
core_memusage.h
core_read.cpp	doc: fix various typos	2021-01-04 12:31:31 +08:00
core_write.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
cuckoocache.h	doc: Use https URLs where possible	2021-01-04 12:23:16 +08:00
dbwrapper.cpp
dbwrapper.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
dummywallet.cpp	wallet: Remove -upgradewallet from dummywallet	2020-11-04 12:16:57 -05:00
flatfile.cpp	Fix possible data race when committing block files	2020-08-25 16:46:46 +00:00
flatfile.h
fs.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
fs.h
hash.cpp	doc: Use https URLs where possible	2021-01-04 12:23:16 +08:00
hash.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
httprpc.cpp	rpc: Validate -rpcauth arguments	2020-11-23 21:02:54 +00:00
httprpc.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
httpserver.cpp	net: Drop unneeded headers when compat.h included	2020-10-22 21:45:20 +03:00
httpserver.h
indirectmap.h
init.cpp	net: Add -natpmp command line option	2021-01-07 18:07:09 +02:00
init.h	Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const	2020-12-06 00:22:40 +00:00
key_io.cpp
key_io.h
key.cpp	doc: Use https URLs where possible	2021-01-04 12:23:16 +08:00
key.h
logging.cpp	Don't declare de facto const member functions as non-const	2020-12-06 18:44:25 +00:00
logging.h	Don't declare de facto const member functions as non-const	2020-12-06 18:44:25 +00:00
Makefile.am	Merge #18077: net: Add NAT-PMP port forwarding support	2021-01-07 19:41:55 +01:00
Makefile.bench.include	net: Add libnatpmp support	2021-01-07 18:07:09 +02:00
Makefile.crc32c.include	build: Update crc32c subtree	2020-12-08 19:26:30 +01:00
Makefile.leveldb.include
Makefile.qt_locale.include	qt: Pre-splitoff translations update	2020-10-27 19:40:44 +01:00
Makefile.qt.include	net: Add libnatpmp support	2021-01-07 18:07:09 +02:00
Makefile.qttest.include	net: Add libnatpmp support	2021-01-07 18:07:09 +02:00
Makefile.test_fuzz.include
Makefile.test_util.include	test: Mock IBD in net_processing fuzzers	2020-11-07 07:50:59 +01:00
Makefile.test.include	Merge #18077: net: Add NAT-PMP port forwarding support	2021-01-07 19:41:55 +01:00
mapport.cpp	net: Add -natpmp command line option	2021-01-07 18:07:09 +02:00
mapport.h	net: Add -natpmp command line option	2021-01-07 18:07:09 +02:00
memusage.h
merkleblock.cpp	doc: fix various typos	2021-01-04 12:31:31 +08:00
merkleblock.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
miner.cpp	Don't declare de facto const member functions as non-const	2020-12-06 18:44:25 +00:00
miner.h	Don't declare de facto const member functions as non-const	2020-12-06 18:44:25 +00:00
net_permissions.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
net_permissions.h	Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers	2020-10-12 12:14:53 -07:00
net_processing.cpp	refactor: Remove nMyStartingHeight from CNode/Connman	2021-01-02 10:24:45 +01:00
net_processing.h	doc: fix various typos	2021-01-04 12:31:31 +08:00
net_types.h
net.cpp	Merge #20786: net: [refactor] Prefer integral types in CNodeStats	2021-01-08 15:14:53 +01:00
net.h	Merge #20786: net: [refactor] Prefer integral types in CNodeStats	2021-01-08 15:14:53 +01:00
netaddress.cpp	Check if Cjdns address is valid	2020-12-14 14:48:52 -03:00
netaddress.h	doc: fix various typos	2021-01-04 12:31:31 +08:00
netbase.cpp	net: update GetNetworkName() with all enum Network cases	2020-10-15 19:21:38 +02:00
netbase.h
netmessagemaker.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
noui.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
noui.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
optional.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
outputtype.cpp
outputtype.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
pow.cpp
pow.h
prevector.h
protocol.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
protocol.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
psbt.cpp	psbt: Assert that tx has a value in UpdatePSBTOutput	2020-12-19 09:45:39 +01:00
psbt.h	scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD	2020-11-26 09:05:59 +00:00
pubkey.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
pubkey.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
random.cpp	Merge #17563: lib: fix a compiler warning: unused GetDevURandom()	2020-08-10 21:30:42 +08:00
random.h
randomenv.cpp	util: Allow use of C++14 chrono literals	2020-12-08 16:47:36 +01:00
randomenv.h
rest.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
reverse_iterator.h
scheduler.cpp
scheduler.h
serialize.h	Support bypassing range check in ReadCompactSize	2020-10-09 10:32:19 +02:00
shutdown.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
shutdown.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
signet.cpp	refactor: Remove SignetTxs::m_valid and use optional instead	2020-09-22 22:31:31 +02:00
signet.h	refactor: Remove SignetTxs::m_valid and use optional instead	2020-09-22 22:31:31 +02:00
span.h	Merge #19387: span: update constructors to match c++20 draft spec and add lifetimebound attribute	2020-11-25 15:18:33 +01:00
streams.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
sync.cpp	sync: Improve CheckLastCritical()	2020-12-10 20:46:29 +02:00
sync.h	[skip ci] sync: Check precondition in LEAVE_CRITICAL_SECTION() macro	2020-12-10 20:46:39 +02:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
timedata.cpp	Avoid the use of abs64 in timedata	2020-10-12 19:50:16 -07:00
timedata.h
tinyformat.h	refactor: Improve use of explicit keyword	2020-12-01 18:36:39 +01:00
torcontrol.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
torcontrol.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
txdb.cpp	Merge #18637: coins: allow cache resize after init	2020-07-29 07:53:19 +02:00
txdb.h
txmempool.cpp	refactor: Clean up CTxMemPool initializer list	2020-10-23 14:41:40 +02:00
txmempool.h	refactor: Improve use of explicit keyword	2020-12-01 18:36:39 +01:00
txrequest.cpp	refactor: Improve use of explicit keyword	2020-12-01 18:36:39 +01:00
txrequest.h	Report and verify expirations	2020-10-12 12:14:53 -07:00
uint256.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
uint256.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
undo.h
validation.cpp	Merge #20584: Declare de facto const reference variables/member functions as const	2021-01-07 09:05:09 +01:00
validation.h	Merge #20575: Do not run functions with necessary side-effects in assert()	2020-12-16 23:14:53 +01:00
validationinterface.cpp	Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas	2020-09-22 11:34:30 -04:00
validationinterface.h	Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas	2020-09-22 11:34:30 -04:00
version.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
versionbits.cpp
versionbits.h
versionbitsinfo.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
versionbitsinfo.h
walletinitinterface.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
warnings.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
warnings.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00