mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-26 18:13:26 +01:00
907a2aa4c7
This fixes test_bitcoin failures on openbsd reported by dhill on IRC. On some systems rand() is a simple LCG over 2^31 and so it produces an even-odd sequence. ApproximateBestSubset was only using the least significant bit and so every run of the iterative solver would be the same for some inputs, resulting in some pretty dumb decisions. Using something other than the least significant bit would paper over the issue but who knows what other way a system's rand() might get us here. Instead we use an internal RNG with a period of something like 2^60 which is well behaved. This also makes it possible to make the selection deterministic for the tests, if we wanted to implement that. |
||
|---|---|---|
| .. | ||
| data | ||
| accounting_tests.cpp | ||
| allocator_tests.cpp | ||
| base32_tests.cpp | ||
| base58_tests.cpp | ||
| base64_tests.cpp | ||
| bignum_tests.cpp | ||
| bloom_tests.cpp | ||
| canonical_tests.cpp | ||
| Checkpoints_tests.cpp | ||
| compress_tests.cpp | ||
| DoS_tests.cpp | ||
| getarg_tests.cpp | ||
| key_tests.cpp | ||
| miner_tests.cpp | ||
| mruset_tests.cpp | ||
| multisig_tests.cpp | ||
| netbase_tests.cpp | ||
| pmt_tests.cpp | ||
| README | ||
| rpc_tests.cpp | ||
| script_P2SH_tests.cpp | ||
| script_tests.cpp | ||
| serialize_tests.cpp | ||
| sigopcount_tests.cpp | ||
| test_bitcoin.cpp | ||
| transaction_tests.cpp | ||
| uint160_tests.cpp | ||
| uint256_tests.cpp | ||
| util_tests.cpp | ||
| wallet_tests.cpp | ||
The sources in this directory are unit test cases. Boost includes a unit testing framework, and since bitcoin already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible). The build system is setup to compile an executable called "test_bitcoin" that runs all of the unit tests. The main source file is called test_bitcoin.cpp, which simply includes other files that contain the actual unit tests (outside of a couple required preprocessor directives). The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is "<source_filename>_tests.cpp" and such files should wrap their tests in a test suite called "<source_filename>_tests". For an examples of this pattern, examine uint160_tests.cpp and uint256_tests.cpp. For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/