bitcoin/test/functional
Andrew Chow c9273f68f6
Merge bitcoin/bitcoin#28287: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation
b3a93b409e test: add functional test for deadlock situation (Martin Zumsande)
3557aa4d0a test: add basic tests for sendmsgtopeer to rpc_net.py (Martin Zumsande)
a9a1d69391 rpc: add test-only sendmsgtopeer rpc (Martin Zumsande)

Pull request description:

  This adds a `sendmsgtopeer` rpc (for testing only) that allows a node to send a message (provided in hex) to a peer.
  While we would usually use a `p2p` object instead of a node for this in the test framework, that isn't possible in situations where this message needs to trigger an actual interaction of multiple nodes.

  Use this rpc to add test coverage for the bug fixed in #27981 (that just got merged):
  The test lets two nodes (almost) simultaneously send a single large (4MB) p2p message to each other, which would have caused a deadlock previously (making this test fail), but succeeds now.

  As can be seen from the discussion in #27981, it was not easy to reproduce this bug without `sendmsgtopeer`. I would imagine that `sendmsgtopeer` could also be helpful in various other test constellations.

ACKs for top commit:
  ajtowns:
    ACK b3a93b409e
  sipa:
    ACK b3a93b409e
  achow101:
    ACK b3a93b409e

Tree-SHA512: 6e22e72402f3c4dd70cddb9e96ea988444720f7a164031df159fbdd48056c8ac77ac53def045d9208a3ca07437c7c8e34f8b4ebc7066c0a84d81cd53f2f4fa5f
2023-08-24 17:34:57 -04:00
..
data descriptor: InferScript, do not return top-level only func as sub descriptor 2023-07-20 11:04:52 -03:00
mocks script, test: fix python linter E275 errors with flake8 5.0.4 2023-01-03 10:59:56 -08:00
test_framework Merge bitcoin/bitcoin#28199: test: tx orphan handling 2023-08-22 17:03:37 -04:00
.gitignore
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
feature_abortnode.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_addrman.py Merge bitcoin/bitcoin#27529: test: fix feature_addrman.py on big-endian systems 2023-07-26 09:42:20 +01:00
feature_anchors.py test: cover addrv2 support in anchors.dat with a TorV3 address 2023-07-19 13:24:44 -04:00
feature_asmap.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
feature_assumevalid.py test: refactor: introduce generate_keypair helper with WIF support 2023-06-19 17:38:14 +02:00
feature_bind_extra.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
feature_bind_port_discover.py
feature_bind_port_externalip.py
feature_bip68_sequence.py test: remove redundant blocks generation logic 2023-01-16 19:14:11 +02:00
feature_block.py test: refactor: deduplicate legacy ECDSA signing for tx inputs 2023-07-03 17:33:41 +02:00
feature_blocksdir.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
feature_cltv.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_coinstatsindex.py Merge bitcoin/bitcoin#27640: test: Return dict in MiniWallet::send_to 2023-05-18 14:26:13 +01:00
feature_config_args.py test: ensure acceptstalefeeestimates is supported only on regtest chain 2023-08-21 07:21:34 +01:00
feature_csv_activation.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_dbcrash.py test: Remove python3.5 workaround in authproxy 2023-03-31 14:26:08 +02:00
feature_dersig.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_dirsymlinks.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_discover.py
feature_fastprune.py test: Simplify feature_fastprune.py 2023-05-02 14:14:00 +02:00
feature_fee_estimation.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
feature_filelock.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
feature_help.py
feature_includeconf.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
feature_index_prune.py init: don't start indexes sync thread prematurely 2023-07-10 10:50:50 -03:00
feature_init.py scripted-diff: rename 'loadblk' thread name to 'initload' 2023-07-07 19:31:27 -03:00
feature_loadblock.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_logging.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
feature_maxtipage.py test: add -maxtipage test for the maximum allowable value 2022-11-14 10:33:17 -05:00
feature_maxuploadtarget.py Merge bitcoin/bitcoin#26714: test: add coverage for unparsable -maxuploadtarget 2023-02-16 15:17:54 +01:00
feature_minchainwork.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
feature_notifications.py Remove the syscall sandbox 2023-06-16 10:38:19 +01:00
feature_nulldummy.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_posix_fs_permissions.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
feature_presegwit_node_upgrade.py
feature_proxy.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
feature_pruning.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
feature_rbf.py test: Return dict in MiniWallet::send_to 2023-05-12 15:26:50 +02:00
feature_reindex.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_remove_pruned_files_on_startup.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_segwit.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_settings.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
feature_shutdown.py
feature_signet.py test: Throw error when -signetchallenge is non-hex 2023-05-25 19:24:05 +02:00
feature_startupnotify.py Merge bitcoin/bitcoin#27884: test: Use TestNode datadir_path or chain_path where possible 2023-06-29 09:51:53 +01:00
feature_taproot.py test: add secp256k1 module with FE (field element) and GE (group element) classes 2023-06-27 09:34:48 -04:00
feature_txindex_compatibility.py test: Drop 22.x node from TxindexCompatibilityTest 2023-07-25 15:51:19 +02:00
feature_uacomment.py
feature_unsupported_utxo_db.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_utxo_set_hash.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
feature_versionbits_warning.py Remove the syscall sandbox 2023-06-16 10:38:19 +01:00
interface_bitcoin_cli.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
interface_http.py
interface_rest.py test: fix PEP484 no implicit optional argument types errors 2023-06-29 16:14:07 -06:00
interface_rpc.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
interface_usdt_coinselection.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
interface_usdt_mempool.py test: Disable known broken USDT test 2023-07-17 13:49:00 +02:00
interface_usdt_net.py Manage exceptions in bcc callback functions 2023-06-19 14:38:32 +02:00
interface_usdt_utxocache.py Manage exceptions in bcc callback functions 2023-06-19 14:38:32 +02:00
interface_usdt_validation.py Manage exceptions in bcc callback functions 2023-06-19 14:38:32 +02:00
interface_zmq.py test: refactor: replace unnecessary BytesIO uses 2023-04-01 14:15:17 +02:00
mempool_accept_wtxid.py
mempool_accept.py test: refactor: introduce generate_keypair helper with WIF support 2023-06-19 17:38:14 +02:00
mempool_compatibility.py test: Use clean chain in MempoolCompatibilityTest 2023-07-25 15:24:04 +02:00
mempool_datacarrier.py test: Add -datacarriersize=2 tests 2023-06-08 11:53:45 +02:00
mempool_dust.py test: refactor: introduce generate_keypair helper with WIF support 2023-06-19 17:38:14 +02:00
mempool_expiry.py [functional test] prioritisation is not removed during replacement and expiry 2023-05-10 21:10:44 +01:00
mempool_limit.py [test] mempool full in package accept 2023-04-17 12:35:23 +01:00
mempool_package_limits.py test: fix mature utxos addition to wallet in mempool_package_limits 2023-05-19 09:13:30 -03:00
mempool_package_onemore.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
mempool_packages.py test: Move test_chain_listunspent wallet check from mempool_packages to wallet_basic 2023-05-26 09:02:55 +02:00
mempool_persist.py Add importmempool RPC 2023-08-07 11:33:34 +02:00
mempool_reorg.py test: Fix intermittent issue in mempool_reorg 2023-08-22 11:08:46 +02:00
mempool_resurrect.py test: simplify tests by using the pre-mined chain 2023-01-16 19:14:21 +02:00
mempool_sigoplimit.py test: Return dict in MiniWallet::send_to 2023-05-12 15:26:50 +02:00
mempool_spend_coinbase.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
mempool_unbroadcast.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
mempool_updatefromblock.py test: simplify and speedup mempool_updatefromblock.py by using MiniWallet 2023-02-03 17:23:26 +01:00
mining_basic.py RPC/Mining: Document template_request better for getblocktemplate 2023-07-22 01:29:11 +00:00
mining_getblocktemplate_longpoll.py test: Fix intermittent issue in mining_getblocktemplate_longpoll.py 2023-06-23 15:21:29 +02:00
mining_prioritisetransaction.py [mempool] clear mapDeltas entry if prioritisetransaction sets delta to 0 2023-05-10 21:10:44 +01:00
p2p_add_connections.py
p2p_addr_relay.py script, test: fix python linter E275 errors with flake8 5.0.4 2023-01-03 10:59:56 -08:00
p2p_addrfetch.py
p2p_addrv2_relay.py test: cover TorV3 address in p2p_addrv2_relay 2023-07-10 10:07:45 -04:00
p2p_block_sync.py
p2p_blockfilters.py index: Enable reindex-chainstate with active indexes 2023-05-17 11:14:28 -04:00
p2p_blocksonly.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
p2p_compactblocks_blocksonly.py
p2p_compactblocks_hb.py
p2p_compactblocks.py Add tests for parallel compact block downloads 2023-05-23 13:07:49 -04:00
p2p_disconnect_ban.py Merge bitcoin/bitcoin#26794: test: test banlist database recreation 2023-04-27 10:18:57 +01:00
p2p_dns_seeds.py
p2p_dos_header_tree.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_eviction.py test: refactor: simplify p2p_eviction.py by using MiniWallet 2023-01-19 16:11:27 +01:00
p2p_feefilter.py test: remove redundant blocks generation logic 2023-01-16 19:14:11 +02:00
p2p_filter.py test: Return dict in MiniWallet::send_to 2023-05-12 15:26:50 +02:00
p2p_fingerprint.py
p2p_getaddr_caching.py test: drop duplicate getaddrs from p2p_getaddr_caching 2023-07-25 10:34:29 -04:00
p2p_getdata.py
p2p_headers_sync_with_minchainwork.py test: Avoid rpc timeout in p2p_headers_sync_with_minchainwork 2023-01-23 16:35:13 +01:00
p2p_i2p_ports.py
p2p_i2p_sessions.py doc: clarify -i2pacceptincoming help documentation 2023-01-09 08:18:47 -08:00
p2p_ibd_stalling.py test: fix intermittent errors in p2p_ibd_stalling.py 2023-01-27 15:28:21 -05:00
p2p_ibd_txrelay.py
p2p_initial_headers_sync.py
p2p_invalid_block.py
p2p_invalid_locator.py test: python E721 updates 2023-07-31 12:13:46 -06:00
p2p_invalid_messages.py test: p2p: check misbehavior for non-continuous headers messages 2023-05-21 15:21:35 +02:00
p2p_invalid_tx.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_leak_tx.py test: fix intermittent failure in p2p_leak_tx.py 2023-06-12 14:46:15 -04:00
p2p_leak.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_message_capture.py script, test: add missing python type annotations 2023-06-29 16:13:51 -06:00
p2p_net_deadlock.py test: add functional test for deadlock situation 2023-08-22 13:45:26 -04:00
p2p_nobloomfilter_messages.py
p2p_node_network_limited.py lint: enable E722 do not use bare except 2023-02-18 11:24:09 +00:00
p2p_orphan_handling.py [functional test] transaction orphan handling 2023-08-14 15:54:31 +01:00
p2p_permissions.py test: refactor: introduce replace_in_config helper 2023-01-28 23:49:55 +01:00
p2p_ping.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_segwit.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
p2p_sendheaders.py scripted-diff: Rename nUnconnectingHeaders and fPreferHeaders 2023-03-30 14:56:34 +02:00
p2p_sendtxrcncl.py test, refactor: Reorder sendtxrcncl tests for better readability 2022-11-14 12:04:08 +02:00
p2p_timeouts.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_tx_download.py test: refactor: simplify p2p_tx_download.py by using MiniWallet 2023-01-19 16:08:55 +01:00
p2p_tx_privacy.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
p2p_unrequested_blocks.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
README.md
rpc_bind.py
rpc_blockchain.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
rpc_createmultisig.py Merge bitcoin/bitcoin#27884: test: Use TestNode datadir_path or chain_path where possible 2023-06-29 09:51:53 +01:00
rpc_decodescript.py descriptor: InferScript, do not return top-level only func as sub descriptor 2023-07-20 11:04:52 -03:00
rpc_deprecated.py
rpc_deriveaddresses.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_dumptxoutset.py Merge bitcoin/bitcoin#27572: test: dedup file hashing using sha256sum_file helper 2023-08-02 11:53:35 +01:00
rpc_estimatefee.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_generate.py rpc: Add submit option to generateblock 2023-03-10 10:39:14 +01:00
rpc_getblockfilter.py
rpc_getblockfrompeer.py test: add block sync to getblockfrompeer.py 2023-05-30 14:17:17 -04:00
rpc_getblockstats.py test: Test exclusion of OP_RETURN from getblockstats 2022-10-23 01:33:41 +02:00
rpc_getchaintips.py
rpc_getdescriptorinfo.py Switch hardened derivation marker to h in descriptors 2023-04-04 18:33:08 +02:00
rpc_help.py RPC: Allow RPC methods accepting options to take named parameters 2023-05-03 11:27:51 -05:00
rpc_invalid_address_message.py use 'byte'/'bytes' for bech32(m) validation error 2023-05-25 06:30:10 +00:00
rpc_invalidateblock.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_mempool_info.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
rpc_misc.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_named_arguments.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_net.py test: add basic tests for sendmsgtopeer to rpc_net.py 2023-08-22 13:28:15 -04:00
rpc_packages.py [test] package cpfp bumps parents <mempoolminfee but >=minrelaytxfee 2023-04-17 09:52:25 +01:00
rpc_preciousblock.py lint: enable E722 do not use bare except 2023-02-18 11:24:09 +00:00
rpc_psbt.py test: remove redundant test values 2023-07-27 06:54:32 -06:00
rpc_rawtransaction.py Add test for unspendable transactions and parameter 'maxburnamount' to sendrawtransaction. 2023-02-20 11:38:52 -07:00
rpc_scanblocks.py Merge bitcoin/bitcoin#26780: rpc: simplify scan blocks 2023-05-01 09:10:11 -04:00
rpc_scantxoutset.py Merge bitcoin/bitcoin#26076: Switch hardened derivation marker to h 2023-05-08 13:31:28 -04:00
rpc_setban.py test: add coverage for -bantime 2023-03-15 12:26:50 -03:00
rpc_signer.py scripted-diff: Specify Python major version explicitly on Windows 2023-08-03 14:57:45 +01:00
rpc_signmessagewithprivkey.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_signrawtransactionwithkey.py test: use common assert_signing_completed_successfully helper 2023-07-27 06:37:55 -06:00
rpc_txoutproof.py test: simplify tests by using the pre-mined chain 2023-01-16 19:14:21 +02:00
rpc_uptime.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_users.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
rpc_validateaddress.py use 'byte'/'bytes' for bech32(m) validation error 2023-05-25 06:30:10 +00:00
rpc_whitelist.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
test_runner.py Merge bitcoin/bitcoin#28287: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation 2023-08-24 17:34:57 -04:00
test-shell.md doc: test: update TestShell instructions 2023-06-16 22:55:36 +01:00
tool_signet_miner.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
tool_wallet.py Merge bitcoin/bitcoin#27572: test: dedup file hashing using sha256sum_file helper 2023-08-02 11:53:35 +01:00
wallet_abandonconflict.py wallet, tests: mark unconflicted txs as inactive 2023-05-14 10:45:21 -04:00
wallet_address_types.py Switch hardened derivation marker to h in descriptors 2023-04-04 18:33:08 +02:00
wallet_avoid_mixing_output_types.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_avoidreuse.py refactor: use address_to_scriptpubkey to retrieve addresses scriptpubkey 2023-03-28 16:58:16 +01:00
wallet_backup.py test: wallet_backup.py, fix intermittent failure in "restore using dumped wallet" 2023-08-23 09:41:24 -03:00
wallet_backwards_compatibility.py Merge bitcoin/bitcoin#27869: wallet: Give deprecation warning when loading a legacy wallet 2023-07-06 10:47:41 +01:00
wallet_balance.py rpc: return block hash & height in getbalances, gettransaction & getwalletinfo JSONs 2023-04-26 16:07:47 +02:00
wallet_basic.py test: fix 'unknown named parameter' test in wallet_basic 2023-08-21 20:59:15 -03:00
wallet_blank.py test: refactor: introduce generate_keypair helper with WIF support 2023-06-19 17:38:14 +02:00
wallet_bumpfee.py test: remove redundant test values 2023-07-27 06:54:32 -06:00
wallet_change_address.py wallet: reuse change dest when recreating TX with avoidpartialspends 2023-02-15 10:14:30 -05:00
wallet_coinbase_category.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_conflicts.py Add wallets_conflicts 2023-05-14 10:45:27 -04:00
wallet_create_tx.py test: wallet_create_tx.py fix race 2023-03-23 17:06:54 -03:00
wallet_createwallet.py test: refactor: introduce generate_keypair helper with WIF support 2023-06-19 17:38:14 +02:00
wallet_crosschain.py test: refactor: introduce replace_in_config helper 2023-01-28 23:49:55 +01:00
wallet_descriptor.py qa: Close SQLite connection properly 2023-08-02 19:29:01 +01:00
wallet_disable.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_dump.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_encryption.py Test case for passphrases with null characters 2023-02-21 14:40:59 -05:00
wallet_fallbackfee.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_fast_rescan.py refactor: use address_to_scriptpubkey to retrieve addresses scriptpubkey 2023-03-28 16:58:16 +01:00
wallet_fundrawtransaction.py test: locked_wallet, skip default fee estimation 2023-08-10 09:50:53 -03:00
wallet_groups.py test: fix immediate tx relay in wallet_groups.py 2023-01-26 02:56:34 +01:00
wallet_hd.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
wallet_implicitsegwit.py script, test: fix python linter E275 errors with flake8 5.0.4 2023-01-03 10:59:56 -08:00
wallet_import_rescan.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00
wallet_import_with_label.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_importdescriptors.py Merge bitcoin/bitcoin#26076: Switch hardened derivation marker to h 2023-05-08 13:31:28 -04:00
wallet_importmulti.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_importprunedfunds.py test: refactor: introduce generate_keypair helper with WIF support 2023-06-19 17:38:14 +02:00
wallet_inactive_hdchains.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
wallet_keypool_topup.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
wallet_keypool.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00
wallet_labels.py wallet: Replace use of purpose strings with an enum 2023-04-11 15:55:31 -04:00
wallet_listdescriptors.py Merge bitcoin/bitcoin#26076: Switch hardened derivation marker to h 2023-05-08 13:31:28 -04:00
wallet_listreceivedby.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_listsinceblock.py test: refactor: introduce generate_keypair helper with WIF support 2023-06-19 17:38:14 +02:00
wallet_listtransactions.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
wallet_migration.py test: check backup from migratewallet can be successfully restored 2023-08-11 16:40:23 -03:00
wallet_miniscript.py qa: make sure we don't let unspendable Miniscript descriptors be imported 2023-07-01 12:12:26 +02:00
wallet_multisig_descriptor_psbt.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00
wallet_multiwallet.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
wallet_orphanedreward.py rpc: return block hash & height in getbalances, gettransaction & getwalletinfo JSONs 2023-04-26 16:07:47 +02:00
wallet_pruning.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
wallet_reorgsrestore.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
wallet_resendwallettransactions.py test: fix intermittent failure in wallet_resendwallettransactions.py 2023-07-19 14:14:59 -04:00
wallet_send.py test: remove redundant test values 2023-07-27 06:54:32 -06:00
wallet_sendall.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00
wallet_signer.py scripted-diff: Specify Python major version explicitly on Windows 2023-08-03 14:57:45 +01:00
wallet_signmessagewithaddress.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_signrawtransactionwithwallet.py test: add coverage for passing an invalid sighashtype 2023-07-27 06:37:54 -06:00
wallet_simulaterawtx.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_startup.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_taproot.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00
wallet_timelock.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00
wallet_transactiontime_rescan.py test: Replace threading with concurrent.futures 2023-03-21 09:49:39 +01:00
wallet_txn_clone.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_txn_doublespend.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_upgradewallet.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
wallet_watchonly.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports.
  • If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: