Bitcoin Core integration/staging tree
Go to file
MeshCollider 7263424458
Merge #16001: Give WalletModel::UnlockContext move semantics
0b09a57ae Give WalletModel::UnlockContext move semantics (Pieter Wuille)

Pull request description:

  WalletModel::UnlockContext seems to implement "move upon copy" semantics; with C++11 this can be done more safely using move semantics (making attempts to actually copy fail instead).

  Not a big deal if this isn't worth review time.

ACKs for commit 0b09a5:
  Empact:
    utACK 0b09a57aec
  jonasschnelli:
    utACK 0b09a57aec
  jb55:
    utACK 0b09a57aec

Tree-SHA512: f827856586afd03666c2d9f50320776afb3dd511ac1bcd293b330f015acd1588551b163dccc97b1351301e3295f4c74d90e5754bcee89faeadf6437d7db165c8
2019-05-20 00:13:53 +12:00
.github Get more info about GUI-related issue on Linux 2018-12-27 06:53:07 +02:00
.travis tests: Fail if RPC has been added without tests 2019-05-15 14:27:18 -04:00
.tx qt: Pre-0.18 split-off translations update 2019-02-04 15:24:37 +01:00
build_msvc Align MSVC build options with Linux build ones 2019-04-27 10:11:52 +03:00
build-aux/m4 Bump minimum Qt version to 5.5.1 2019-02-14 11:12:30 +01:00
contrib Merge #15863: scripts and tools: Ensure repos are up-to-date in gitian-build.py 2019-05-17 16:47:52 -04:00
depends Remove Windows 32 bit build 2019-05-03 13:41:27 -04:00
doc Merge #15922: doc: Explain how to pass in non-fundamental types into functions 2019-05-17 11:27:22 -04:00
share Merge #15548: build: use full version string in setup.exe 2019-03-12 10:43:08 +01:00
src Merge #16001: Give WalletModel::UnlockContext move semantics 2019-05-20 00:13:53 +12:00
test Merge #15990: Add tests and documentation for blocksonly 2019-05-16 19:05:24 +02:00
.appveyor.yml appveyor: Write @PACKAGE_NAME@ to config 2019-04-26 13:07:11 -04:00
.cirrus.yml cirrus ci: Inital config 2019-02-03 10:24:39 -05:00
.gitattributes Separate protocol versioning from clientversion 2014-10-29 00:24:40 -04:00
.gitignore .gitignore: Don't ignore depends patches 2019-05-07 21:33:54 -04:00
.python-version .python-version: Specify full version 3.5.6 2019-03-02 12:06:26 -05:00
.style.yapf test: .style.yapf: Set column_limit=160 2019-03-04 18:28:13 -05:00
.travis.yml tests: Fail if RPC has been added without tests 2019-05-15 14:27:18 -04:00
autogen.sh Add "export LC_ALL=C" to all shell scripts 2018-06-14 15:27:52 +02:00
configure.ac build with -fstack-reuse=none 2019-05-15 15:41:28 -04:00
CONTRIBUTING.md docs: Clarify PR guidelines w/re documentation 2019-04-11 12:54:20 -04:00
COPYING [Trivial] Update license year range to 2019 2018-12-31 04:27:59 +01:00
INSTALL.md Update INSTALL landing redirection notice for build instructions. 2016-10-06 12:27:23 +13:00
libbitcoinconsensus.pc.in Unify package name to as few places as possible without major changes 2015-12-14 02:11:10 +00:00
Makefile.am Merge #12051: add missing debian contrib file to tarball 2019-04-29 08:48:39 -04:00
README.md docs: Update Transifex links 2019-03-02 17:42:33 +08:00

Bitcoin Core integration/staging tree

Build Status

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.