bitcoin/test/functional
W. J. van der Laan 6419bdfeb1
Merge bitcoin/bitcoin#23093: Add ability to flush keypool and always flush when upgrading non-HD to HD
6531599f42 test: Add check that newkeypool flushes change addresses too (Samuel Dobson)
84fa19c77a Add release notes for keypool flush changes (Samuel Dobson)
f9603ee4e0 Add test for flushing keypool with newkeypool (Samuel Dobson)
6f6f7bb36c Make legacy wallet upgrades from non-HD to HD always flush the keypool (Samuel Dobson)
2434b10781 Fix outdated keypool size default (Samuel Dobson)
22cc797ca5 Add newkeypool RPC to flush the keypool (Samuel Dobson)

Pull request description:

  This PR makes two main changes:
  1) Adds a new RPC `newkeypool` which will entirely flush and refill the keypool.
  2) When upgradewallet is called on old, non-HD wallets upgrading them to HD, we now always flush the keypool and generate a new one, to immediately start using the HD generated keys.

  This PR is motivated by a number of users with old, pre-compressed-key wallets upgrading them and being confused about why they still can't generate p2sh-segwit or bech32 addresses -- this is due to uncompressed keys remaining in the keypool post-upgrade and being illegal in these newer address formats. There is currently no easy way to flush the keypool other than to call `getnewaddress` a hundred/thousand times or an ugly hack of using a `sethdseed` call.

ACKs for top commit:
  laanwj:
    re-ACK 6531599f42
  meshcollider:
    Added new commit 6531599f42 to avoid invalidating previous ACKs.
  instagibbs:
    ACK 6531599f42

Tree-SHA512: 50c79c5d42dd27ab0ecdbfdc4071fdaa1b2dbb2f9195ed325b007106ff19226419ce57fe5b1539c0c24101b12f5e034bbcfb7bbb0451b766cb1071295383d774
2021-10-14 18:05:58 +02:00
..
data Merge bitcoin/bitcoin#22363: test: refactor: use script_util helpers for creating P2{PKH,SH,WPKH,WSH} scripts 2021-07-09 11:17:58 +02:00
mocks
test_framework Merge bitcoin/bitcoin#23118: test: refactor: introduce script_util helper for creating P2PK scripts 2021-10-07 15:41:57 +02:00
.gitignore
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_abortnode.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_addrman.py scripted-diff: Rename CAddrMan to AddrMan 2021-09-28 22:21:10 -04:00
feature_anchors.py test: Remove useless overwrite 2021-09-03 16:14:57 +02:00
feature_asmap.py test: avoid non-determinism in asmap-addrman test 2021-09-24 22:00:24 +02:00
feature_assumevalid.py Use COINBASE_MATURITY constant in functional tests. 2021-05-31 07:32:28 +02:00
feature_backwards_compatibility.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_bind_extra.py net: don't bind on 0.0.0.0 if binds are restricted to Tor 2021-07-07 15:46:38 +02:00
feature_bip68_sequence.py test: Replace satoshi_round with int() or Decimal() 2021-10-06 15:16:59 +02:00
feature_block.py test: Activate all regtest softforks at height 1, unless overridden 2021-09-16 18:53:04 +02:00
feature_blockfilterindex_prune.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_blocksdir.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_cltv.py test: Activate all regtest softforks at height 1, unless overridden 2021-09-16 18:53:04 +02:00
feature_coinstatsindex.py test: fix confusing off-by-one nValue in feature_coinstatsindex.py 2021-09-19 21:23:24 +02:00
feature_config_args.py test: Fix tests on Windows 2021-09-08 18:58:31 +02:00
feature_csv_activation.py test: Activate all regtest softforks at height 1, unless overridden 2021-09-16 18:53:04 +02:00
feature_dbcrash.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
feature_dersig.py test: Activate all regtest softforks at height 1, unless overridden 2021-09-16 18:53:04 +02:00
feature_fee_estimation.py qa: test fee estimation with replacement transactions 2021-09-29 17:24:28 +02:00
feature_filelock.py test: use f-strings in feature_filelock.py 2021-08-18 12:39:18 +08:00
feature_help.py test: use f-strings in feature_help.py 2021-08-18 12:39:18 +08:00
feature_includeconf.py Cleanup -includeconf error message 2021-05-21 10:54:12 +02:00
feature_loadblock.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_logging.py test: use f-strings in feature_logging.py 2021-08-18 12:39:18 +08:00
feature_maxuploadtarget.py test: Set peertimeout in write_config 2021-09-13 09:41:58 +02:00
feature_minchainwork.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_notifications.py Merge bitcoin/bitcoin#20487: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) 2021-10-04 22:45:43 +02:00
feature_nulldummy.py Introduce -testactivationheight=name@height setting 2021-09-16 18:52:59 +02:00
feature_presegwit_node_upgrade.py Introduce -testactivationheight=name@height setting 2021-09-16 18:52:59 +02:00
feature_proxy.py test: use f-strings in feature_proxy.py 2021-08-18 12:39:20 +08:00
feature_pruning.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_rbf.py test: use miniwallet in test_rpc() function in feature_rbf.py 2021-09-29 20:43:45 +05:30
feature_reindex.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_segwit.py test: introduce script_util helper for creating P2PK scripts 2021-09-29 14:09:14 +02:00
feature_settings.py test: use f-strings in feature_settings.py 2021-08-18 12:39:19 +08:00
feature_shutdown.py
feature_signet.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_syscall_sandbox.py Add syscall sandboxing (seccomp-bpf) 2021-10-01 13:51:10 +00:00
feature_taproot.py test: introduce script_util helper for creating P2PK scripts 2021-09-29 14:09:14 +02:00
feature_uacomment.py
feature_utxo_set_hash.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_versionbits_warning.py Add syscall sandboxing (seccomp-bpf) 2021-10-01 13:51:10 +00:00
interface_bitcoin_cli.py cli: Display all proxies in -getinfo 2021-09-20 18:52:04 +08:00
interface_http.py test: use f-strings in interface_*.py tests 2021-08-18 12:39:20 +08:00
interface_rest.py rest: Return error when header count is not integral 2021-10-12 09:10:19 +02:00
interface_rpc.py test: use f-strings in interface_*.py tests 2021-08-18 12:39:20 +08:00
interface_zmq.py Use self.generate not node.generate throughout tests 2021-10-06 12:18:33 +13:00
mempool_accept_wtxid.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_accept.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_compatibility.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_expiry.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_limit.py fix typos in logging messages 2021-09-14 00:58:25 +05:30
mempool_package_limits.py Merge bitcoin/bitcoin#22582: test: a test to check descendant limits 2021-09-09 15:42:12 +02:00
mempool_package_onemore.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_packages.py test: Replace satoshi_round with int() or Decimal() 2021-10-06 15:16:59 +02:00
mempool_persist.py Merge bitcoin/bitcoin#23061: Fix (inverse) meaning of -persistmempool 2021-09-27 10:12:14 +02:00
mempool_reorg.py test: Replace MiniWallet scan_blocks with rescan_utxos 2021-09-20 08:31:04 +02:00
mempool_resurrect.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_spend_coinbase.py test: Replace MiniWallet scan_blocks with rescan_utxos 2021-09-20 08:31:04 +02:00
mempool_unbroadcast.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_updatefromblock.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mining_basic.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mining_getblocktemplate_longpoll.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mining_prioritisetransaction.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_add_connections.py
p2p_addr_relay.py test: use test_framework.p2p P2P_SERVICES in functional tests 2021-09-19 14:20:48 +02:00
p2p_addrfetch.py test: use test_framework.p2p P2P_SERVICES in functional tests 2021-09-19 14:20:48 +02:00
p2p_addrv2_relay.py test: use test_framework.p2p P2P_SERVICES in functional tests 2021-09-19 14:20:48 +02:00
p2p_blockfilters.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_blocksonly.py p2p: Rename fBlocksOnly, Add test 2021-09-12 12:53:50 +02:00
p2p_compactblocks_blocksonly.py Use self.generate not node.generate throughout tests 2021-10-06 12:18:33 +13:00
p2p_compactblocks_hb.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_compactblocks.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_disconnect_ban.py
p2p_dns_seeds.py [test] Test the delay before querying DNS seeds 2021-07-30 11:15:49 -07:00
p2p_dos_header_tree.py scripted-diff: test: rename FromHex to from_hex 2021-06-21 14:33:59 +02:00
p2p_eviction.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_feefilter.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_filter.py test: use MiniWallet for p2p_filter.py 2021-09-27 13:55:25 +02:00
p2p_fingerprint.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_getaddr_caching.py
p2p_getdata.py
p2p_i2p_ports.py test: ensure I2P ports are handled as expected 2021-07-09 11:19:37 +02:00
p2p_ibd_txrelay.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_invalid_block.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_invalid_locator.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_invalid_messages.py test: refactor: remove hex_str_to_bytes helper 2021-08-01 19:26:51 +02:00
p2p_invalid_tx.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_leak_tx.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_leak.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_message_capture.py
p2p_nobloomfilter_messages.py
p2p_node_network_limited.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_permissions.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_ping.py
p2p_segwit.py test: introduce script_util helper for creating P2PK scripts 2021-09-29 14:09:14 +02:00
p2p_sendheaders.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_timeouts.py
p2p_tx_download.py test: introduce tx_from_hex helper for tx deserialization 2021-06-21 14:28:05 +02:00
p2p_unrequested_blocks.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
README.md Enable TLS in links in documentation 2021-09-16 22:00:20 +00:00
rpc_bind.py
rpc_blockchain.py test: Add -testactivationheight tests to rpc_blockchain 2021-09-24 15:32:00 +02:00
rpc_createmultisig.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_decodescript.py test: refactor: remove hex_str_to_bytes helper 2021-08-01 19:26:51 +02:00
rpc_deprecated.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_deriveaddresses.py
rpc_dumptxoutset.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_estimatefee.py
rpc_fundrawtransaction.py Fix intermittent test failures due to missing sync_all 2021-10-06 12:19:04 +13:00
rpc_generate.py
rpc_generateblock.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_getblockfilter.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_getblockstats.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_getchaintips.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_getdescriptorinfo.py
rpc_help.py
rpc_invalid_address_message.py Add BECH32_INVALID_VERSION test 2021-09-21 19:25:21 -03:00
rpc_invalidateblock.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_misc.py blockstorage: use debug log category 2021-10-11 21:45:49 +10:00
rpc_named_arguments.py
rpc_net.py Merge bitcoin/bitcoin#23036: test: use test_framework.p2p P2P_SERVICES constant in functional tests 2021-09-23 17:13:02 +08:00
rpc_packages.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_preciousblock.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_psbt.py Fix intermittent test failures due to missing sync_all 2021-10-06 12:19:04 +13:00
rpc_rawtransaction.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_scantxoutset.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_setban.py style: remove () from assert in rpc_setban.py 2021-06-21 15:29:28 +02:00
rpc_signer.py Add syscall sandboxing (seccomp-bpf) 2021-10-01 13:51:10 +00:00
rpc_signmessagewithprivkey.py test: added test for disabled wallet 2021-08-12 18:14:56 +05:30
rpc_signrawtransaction.py test: introduce script_util helper for creating P2PK scripts 2021-09-29 14:09:14 +02:00
rpc_txoutproof.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_uptime.py
rpc_users.py
rpc_whitelist.py
test_runner.py Merge bitcoin/bitcoin#20487: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) 2021-10-04 22:45:43 +02:00
test-shell.md scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
tool_wallet.py Merge bitcoin/bitcoin#22788: scripted-diff: Use generate* from TestFramework 2021-09-09 14:02:45 +02:00
wallet_abandonconflict.py Test transactions conflicted by double spend in listtransactions 2021-10-02 15:27:40 +02:00
wallet_address_types.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_avoidreuse.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_backup.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_balance.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_basic.py Remove -rescan startup parameter 2021-09-30 12:06:27 +13:00
wallet_bumpfee.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_coinbase_category.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_create_tx.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_createwallet.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_descriptor.py Use generate* from TestFramework 2021-08-19 19:02:11 +02:00
wallet_disable.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_dump.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_encryption.py
wallet_fallbackfee.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_groups.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_hd.py Remove -rescan startup parameter 2021-09-30 12:06:27 +13:00
wallet_implicitsegwit.py
wallet_import_rescan.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_import_with_label.py
wallet_importdescriptors.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_importmulti.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_importprunedfunds.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_keypool_topup.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_keypool.py test: Add check that newkeypool flushes change addresses too 2021-10-14 16:52:59 +13:00
wallet_labels.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_listdescriptors.py Merge bitcoin/bitcoin#21500: wallet, rpc: add an option to list private descriptors 2021-08-09 14:09:07 +12:00
wallet_listreceivedby.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_listsinceblock.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_listtransactions.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_multiwallet.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_orphanedreward.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_reorgsrestore.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_resendwallettransactions.py test: remove ToHex helper, use .serialize().hex() instead 2021-06-21 14:30:03 +02:00
wallet_send.py Fix intermittent test failures due to missing sync_all 2021-10-06 12:19:04 +13:00
wallet_signer.py Add syscall sandboxing (seccomp-bpf) 2021-10-01 13:51:10 +00:00
wallet_signmessagewithaddress.py test: added test for disabled wallet 2021-08-12 18:14:56 +05:30
wallet_startup.py
wallet_taproot.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_transactiontime_rescan.py test: add functional test to check transaction time determination during block rescanning 2021-09-28 21:49:22 +02:00
wallet_txn_clone.py tests: wallet_txn explicilty specify inputs 2021-09-23 13:33:25 -04:00
wallet_txn_doublespend.py tests: wallet_txn explicilty specify inputs 2021-09-23 13:33:25 -04:00
wallet_upgradewallet.py test: Add check that newkeypool flushes change addresses too 2021-10-14 16:52:59 +13:00
wallet_watchonly.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: