bitcoin/test/functional
MarcoFalke 685c16fcb2
Merge #21043: net: Avoid UBSan warning in ProcessMessage(...)
3ddbf22ed1 util: Disallow negative mocktime (MarcoFalke)
f5f2f97168 net: Avoid UBSan warning in ProcessMessage(...) (practicalswift)

Pull request description:

  Avoid UBSan warning in `ProcessMessage(...)`.

  Context: https://github.com/bitcoin/bitcoin/pull/20380#issuecomment-770427182 (thanks Crypt-iQ!)

ACKs for top commit:
  MarcoFalke:
    re-ACK 3ddbf22ed1 only change is adding patch written by me
  ajtowns:
    ACK 3ddbf22ed1 -- code review only

Tree-SHA512: e8d7af0457ca86872b75a4e406c0a93aafd841c2962e244e147e748cc7ca118c56be0fdafe53765f4b291410030b2c3cc8f76f733b37a955d34fc885ab6037b9
2021-02-11 12:40:12 +01:00
..
data test: remove type: comments in favour of actual annotations 2021-02-08 13:24:44 +08:00
test_framework test: remove unnecessary assignment in bdb 2021-02-09 10:22:50 -03:00
.gitignore
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py doc: Improve setup_clean_chain documentation 2021-02-01 23:13:35 +01:00
feature_abortnode.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
feature_asmap.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
feature_assumevalid.py test: remove assert_blockchain_height 2021-02-08 16:56:46 +01:00
feature_backwards_compatibility.py Disable upgrades tests that require BDB if BDB is not compiled 2021-01-27 12:52:46 -05:00
feature_bip68_sequence.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_block.py [tests] Recommend f-strings for formatting, update feature_block to use them 2020-11-09 17:53:50 +10:00
feature_blocksdir.py
feature_cltv.py rpc: Return wtxid from testmempoolaccept 2021-01-12 18:43:43 +01:00
feature_config_args.py Merge #17556: test: Change feature_config_args.py not to rely on strange regtest=0 behavior 2021-01-21 16:51:19 +01:00
feature_csv_activation.py test: Remove unused -blockversion from tests 2020-10-16 13:01:07 +02:00
feature_dbcrash.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
feature_dersig.py rpc: Return wtxid from testmempoolaccept 2021-01-12 18:43:43 +01:00
feature_fee_estimation.py init: don't create a CBlockPolicyEstimator if we don't relay transactions 2020-12-03 12:56:37 +01:00
feature_filelock.py Have feature_filelock.py test both bdb and sqlite, depending on compiled 2021-01-27 12:52:46 -05:00
feature_help.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_includeconf.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
feature_loadblock.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
feature_logging.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
feature_maxuploadtarget.py [refactor] clarify tests by referencing p2p objects directly 2020-09-10 07:37:14 -07:00
feature_minchainwork.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_notifications.py Setup wallets with descriptors for feature_notifications 2021-01-27 12:52:46 -05:00
feature_nulldummy.py doc: fix various typos 2021-01-04 12:31:31 +08:00
feature_proxy.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_pruning.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
feature_rbf.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_reindex.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_segwit.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
feature_settings.py Merge #19624: Warn on unknown rw_settings 2020-10-19 11:30:49 +02:00
feature_shutdown.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_signet.py signet: do not log signet startup messages for other chains 2020-10-01 11:25:42 +02:00
feature_taproot.py fix the unreachable code at feature_taproot 2021-02-04 10:57:37 -02:00
feature_uacomment.py
feature_versionbits_warning.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
interface_bitcoin_cli.py Setup wallets for interface_bitcoin_cli.py 2021-01-27 12:52:46 -05:00
interface_http.py
interface_rest.py
interface_rpc.py Test batch rpc with params 2020-09-13 13:43:03 -04:00
interface_zmq.py Setup wallets for interface_zmq.py 2021-01-27 12:52:46 -05:00
mempool_accept.py rpc: Return wtxid from testmempoolaccept 2021-01-12 18:43:43 +01:00
mempool_compatibility.py test: run mempool_compatibility.py even with wallet disabled 2021-01-07 12:24:24 -06:00
mempool_expiry.py test: run mempool_expiry.py even with wallet disabled 2020-12-10 10:14:35 -06:00
mempool_limit.py
mempool_package_onemore.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
mempool_packages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
mempool_persist.py rpc: Return total fee in mempool 2021-01-28 10:43:22 +01:00
mempool_reorg.py
mempool_resurrect.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
mempool_spend_coinbase.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
mempool_unbroadcast.py test: Replace use of (dis)?connect_nodes globals 2020-10-20 00:27:45 -07:00
mempool_updatefromblock.py refactor: test: use _ variable for unused loop counters 2020-08-06 18:39:33 +02:00
mining_basic.py test: Add test for -blockversion 2020-10-26 16:31:25 +01:00
mining_getblocktemplate_longpoll.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
mining_prioritisetransaction.py
p2p_add_connections.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_addr_relay.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_addrv2_relay.py net: advertise support for ADDRv2 via new message 2020-10-09 16:42:50 +02:00
p2p_blockfilters.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_blocksonly.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_compactblocks.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_disconnect_ban.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_dos_header_tree.py [refactor] clarify tests by referencing p2p objects directly 2020-09-10 07:37:14 -07:00
p2p_eviction.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_feefilter.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_filter.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_fingerprint.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_getaddr_caching.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_getdata.py test: use explicit p2p objects where available 2020-09-26 10:48:54 +02:00
p2p_ibd_txrelay.py test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_until 2020-07-19 13:37:54 +02:00
p2p_invalid_block.py [refactor] clarify tests by referencing p2p objects directly 2020-09-10 07:37:14 -07:00
p2p_invalid_locator.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_invalid_messages.py p2p: Ignore version msgs after initial version msg 2020-11-19 08:07:16 +01:00
p2p_invalid_tx.py doc: fix various typos 2021-01-04 12:31:31 +08:00
p2p_leak_tx.py test: add p2p_lock acquires in p2p_leak_tx.py 2020-10-12 00:22:16 +02:00
p2p_leak.py p2p: Ignore non-version msgs before version msg 2020-11-19 08:06:30 +01:00
p2p_message_capture.py test: remove type: comments in favour of actual annotations 2021-02-08 13:24:44 +08:00
p2p_nobloomfilter_messages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_node_network_limited.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_permissions.py [rpc] Remove deprecated "whitelisted" field from getpeerinfo 2020-12-26 13:30:54 -08:00
p2p_ping.py scripted-diff: Rename mininode to p2p 2020-08-21 15:52:20 +01:00
p2p_segwit.py rpc: Return wtxid from testmempoolaccept 2021-01-12 18:43:43 +01:00
p2p_sendheaders.py test: Update wait_until usage in tests not to use the one from utils 2020-08-26 18:01:59 +02:00
p2p_timeouts.py net: use peer=N instead of from=N in debug log 2021-01-28 16:04:04 +10:00
p2p_tx_download.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_unrequested_blocks.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
README.md doc: Improve setup_clean_chain documentation 2021-02-01 23:13:35 +01:00
rpc_bind.py
rpc_blockchain.py Merge #18772: rpc: calculate fees in getblock using BlockUndo data 2020-12-24 15:32:10 +01:00
rpc_createmultisig.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_decodescript.py
rpc_deprecated.py Remove deprecated bumpfee behavior 2021-01-08 18:58:58 -05:00
rpc_deriveaddresses.py
rpc_dumptxoutset.py
rpc_estimatefee.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
rpc_fundrawtransaction.py test: add coverage for passing fee rate as a string 2020-12-04 22:35:31 +01:00
rpc_generate.py rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining) 2020-08-14 12:37:19 +02:00
rpc_generateblock.py refactor: test: use _ variable for unused loop counters 2020-08-06 18:39:33 +02:00
rpc_getblockfilter.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_getblockstats.py
rpc_getchaintips.py
rpc_getdescriptorinfo.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_help.py rpc: Use RPCHelpMan for check-rpc-mappings linter 2021-01-28 08:16:34 +01:00
rpc_invalid_address_message.py Better error messages for invalid addresses 2021-01-24 02:44:53 +01:00
rpc_invalidateblock.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_misc.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_named_arguments.py
rpc_net.py Use MiniWallet in rpc_net.py 2021-01-27 12:52:46 -05:00
rpc_preciousblock.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_psbt.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
rpc_rawtransaction.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_scantxoutset.py wallet: Make -wallet setting not create wallets 2020-10-21 08:48:43 -04:00
rpc_setban.py test: add test for banning of non-IP addresses 2021-01-10 15:51:25 +01:00
rpc_signmessage.py
rpc_signrawtransaction.py tests: Test that a fully signed tx given to signrawtx is unchanged 2020-12-03 15:53:58 -05:00
rpc_txoutproof.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_uptime.py util: Disallow negative mocktime 2021-02-02 08:43:19 +00:00
rpc_users.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_whitelist.py
test_runner.py Merge #20267: Disable and fix tests for when BDB is not compiled 2021-02-05 14:26:10 +01:00
test-shell.md doc: Improve setup_clean_chain documentation 2021-02-01 23:13:35 +01:00
tool_wallet.py Merge #20267: Disable and fix tests for when BDB is not compiled 2021-02-05 14:26:10 +01:00
wallet_abandonconflict.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
wallet_address_types.py Do addmultisigaddress tests in legacy wallet mode in wallet_address_types.py 2020-11-01 17:54:19 -05:00
wallet_avoidreuse.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
wallet_backup.py wallet: Make -wallet setting not create wallets 2020-10-21 08:48:43 -04:00
wallet_balance.py Merge #19893: test: Remove or explain syncwithvalidationinterfacequeue 2020-12-06 19:13:10 +01:00
wallet_basic.py Better error messages for invalid addresses 2021-01-24 02:44:53 +01:00
wallet_bumpfee.py Remove deprecated bumpfee behavior 2021-01-08 18:58:58 -05:00
wallet_coinbase_category.py
wallet_create_tx.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_createwallet.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
wallet_descriptor.py Disable wallet_descriptor.py bdb format check if BDB is not compiled 2021-01-27 12:52:46 -05:00
wallet_disable.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_dump.py wallet: Make -wallet setting not create wallets 2020-10-21 08:48:43 -04:00
wallet_encryption.py doc: fix various typos 2021-01-04 12:31:31 +08:00
wallet_fallbackfee.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_groups.py -maxapsfee: follow-up fixes 2020-08-18 19:24:39 +09:00
wallet_hd.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
wallet_implicitsegwit.py
wallet_import_rescan.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_import_with_label.py
wallet_importdescriptors.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_importmulti.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_importprunedfunds.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_keypool_topup.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_keypool.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_labels.py Update wallet_labels.py to not require descriptors=False 2020-11-01 17:54:19 -05:00
wallet_listdescriptors.py wallet, rpc: add listdescriptors command 2021-01-27 21:22:13 +01:00
wallet_listreceivedby.py
wallet_listsinceblock.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_listtransactions.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_multiwallet.py rpc: Add specific error code for "wallet already loaded" 2021-01-25 07:55:35 +01:00
wallet_reorgsrestore.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_resendwallettransactions.py Merge #19893: test: Remove or explain syncwithvalidationinterfacequeue 2020-12-06 19:13:10 +01:00
wallet_send.py Fix wallet_send.py wallet setup to work with descriptors 2021-01-27 12:52:46 -05:00
wallet_startup.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_txn_clone.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_txn_doublespend.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_upgradewallet.py Require legacy wallet for wallet_upgradewallet.py 2021-01-27 12:52:46 -05:00
wallet_watchonly.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: