mirrors/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-11 17:57:14 +01:00
Code Issues Projects Releases Wiki Activity
bitcoin/src/util
History
MarcoFalke 5b24f6084e
Merge #16224: gui: Bilingual GUI error messages 
18bd83b1fe util: Cleanup translation.h (Hennadii Stepanov)
e95e658b8e doc: Do not translate technical or extremely rare errors (Hennadii Stepanov)
7e923d47ba Make InitError bilingual (Hennadii Stepanov)
917ca93553 Make ThreadSafe{MessageBox|Question} bilingual (Hennadii Stepanov)
23b9fa2e5e gui: Add detailed text to BitcoinGUI::message (Hennadii Stepanov)

Pull request description:

  This is an alternative to #15340 (it works with the `Chain` interface; see: https://github.com/bitcoin/bitcoin/pull/15340#issuecomment-502674004).
  Refs:
  - #16218 (partial fix)
  - https://github.com/bitcoin/bitcoin/pull/15894#issuecomment-487947077

  This PR:
  - makes GUI error messages bilingual: user's native language + untranslated (i.e. English)
  - insures that only untranslated messages are written to the debug log file and to `stderr` (that is not the case on master).

  If a translated string is unavailable only an English string appears to a user.

  Here are some **examples** (updated):

  ![Screenshot from 2020-04-24 17-08-37](https://user-images.githubusercontent.com/32963518/80222043-e2458780-864e-11ea-83fc-197b7121dba5.png)

  ![Screenshot from 2020-04-24 17-12-17](https://user-images.githubusercontent.com/32963518/80222051-e5407800-864e-11ea-92f7-dfef1144becd.png)

  * `qt5ct: using qt5ct plugin` message is my local environment specific; please ignore it.

  ---

  Note for reviewers: `InitWarning()` is out of this PR scope.

ACKs for top commit:
  Sjors:
    re-tACK 18bd83b1fe
  MarcoFalke:
    ACK 18bd83b1fe 🐦

Tree-SHA512: 3cc8ec44f84403e54b57d11714c86b0855ed90eb794b5472e432005073354b9e3f7b4e8e7bf347a4c21be47299dbc7170f2d0c4b80e308205ff09596e55a4f96
2020-05-08 12:17:55 -04:00
..
asmap.cpp Merge #18512: Improve asmap checks and add sanity check 2020-05-06 14:59:28 +02:00
asmap.h Add asmap sanity checker 2020-04-08 16:26:06 -07:00
bip32.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
bip32.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
bytevectorhash.cpp blockfilter: Use unordered_set instead of set in blockfilter. 2018-11-05 09:30:56 -08:00
bytevectorhash.h blockfilter: Use unordered_set instead of set in blockfilter. 2018-11-05 09:30:56 -08:00
check.h util: Add CHECK_NONFATAL and use it in src/rpc 2019-10-18 17:19:36 -04:00
error.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
error.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
fees.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
fees.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
golombrice.h tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode) 2020-04-20 14:57:48 +00:00
macros.h refactor: consolidate PASTE macros 2019-09-25 10:56:00 -04:00
memory.h
message.cpp Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan 2020-03-09 11:16:20 -04:00
message.h Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan 2020-03-09 11:16:20 -04:00
moneystr.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
moneystr.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rbf.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rbf.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
settings.cpp refactor: Remove null setting check in GetSetting() 2019-11-13 15:23:06 -05:00
settings.h util: Document why ArgsManager (con/de)structor is not inline 2020-04-16 12:26:09 -04:00
spanparsing.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
spanparsing.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
strencodings.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
strencodings.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
string.cpp util: Add Join helper to join a list of strings 2019-08-20 16:51:41 -04:00
string.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
system.cpp Merge #18437: util: Detect posix_fallocate() instead of assuming 2020-04-30 10:45:17 +02:00
system.h Merge #17509: gui: save and load PSBT 2020-04-23 13:16:23 +12:00
threadnames.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
threadnames.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
time.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
time.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
translation.h util: Cleanup translation.h 2020-05-05 04:51:29 +03:00
url.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
url.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
vector.h Add some general std::vector utility functions 2019-10-16 08:56:57 -07:00