bitcoin/test/functional
MarcoFalke 59c138d2f1
Merge #16898: test: Remove connect_nodes_bi
fadfd844de test: Remove unused connect_nodes_bi (MarcoFalke)
fa3b9ee8b2 scripted-diff: test: Replace connect_nodes_bi with connect_nodes (MarcoFalke)
faaee1e39a test: Use connect_nodes when connecting nodes in the test_framework (MarcoFalke)
1111bb91f5 test: Reformat python imports to aid scripted diff (MarcoFalke)

Pull request description:

  By default all test nodes are connected in a chain. However, instead of just a single connection between each pair of nodes, we end up with up to four connections for a "middle" node (two outbound, two inbound, from each side).

  This is generally redundant (tx and block relay should succeed with just a single connection) and confusing. For example, test timeouts after a call to `sync_` may be racy and hard to reproduce. On top of that, the test `debug.log`s are hard to read because txs and block invs may be relayed on the same connection multiple times.

  Fix this by inlining `connect_nodes_bi` in the two tests that need it, and then replace it with a single `connect_nodes` in all other tests.

  Historic background:

  `connect_nodes_bi` has been introduced as a (temporary?) workaround for bug #5113 and #5138, which has long been fixed in #5157 and #5662.

ACKs for top commit:
  laanwj:
    ACK fadfd844de
  jonasschnelli:
    utACK fadfd844de - more of less a cleanup PR.
  promag:
    Tested ACK fadfd844de, ran extended tests.

Tree-SHA512: 2d027a8fd150749c071b64438a0a78ec922178628a7dbb89fd1212b0fa34febd451798c940101155d3617c0426c2c4865174147709894f1f1bb6cfa336aa7e24
2019-09-18 14:41:21 -04:00
..
data Merge #14696: qa: Add explicit references to related CVE's in p2p_invalid_block test. 2019-09-18 16:00:54 +02:00
test_framework test: Remove unused connect_nodes_bi 2019-09-17 13:09:33 -04:00
.gitignore
combine_logs.py test/contrib: Fix invalid escapes in regex strings 2019-09-03 14:38:38 -04:00
combined_log_template.html
create_cache.py Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
example_test.py [qa] Fix race condition in example_test.py 2019-07-25 10:32:07 -04:00
feature_abortnode.py [qa] Test disconnect block failure -> shutdown 2019-06-05 05:05:49 -04:00
feature_assumevalid.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
feature_bip68_sequence.py [Consensus] Bury CSV deployment height 2019-08-14 15:52:52 -04:00
feature_block.py Merge #14696: qa: Add explicit references to related CVE's in p2p_invalid_block test. 2019-09-18 16:00:54 +02:00
feature_blocksdir.py test: Adapt test framework for chains other than "regtest" 2019-07-31 17:00:25 -04:00
feature_cltv.py [rpc] Tidy up reporting of buried and ongoing softforks 2019-08-13 15:53:02 -04:00
feature_config_args.py Merge #15864: Fix datadir handling 2019-08-19 10:01:30 -04:00
feature_csv_activation.py [Consensus] Bury CSV deployment height 2019-08-14 15:52:52 -04:00
feature_dbcrash.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
feature_dersig.py [rpc] Tidy up reporting of buried and ongoing softforks 2019-08-13 15:53:02 -04:00
feature_fee_estimation.py test: Explain why -whitelist is used in feature_fee_estimation 2019-08-02 11:16:24 -04:00
feature_filelock.py QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core 2019-04-25 20:43:04 +00:00
feature_help.py qa: Raise feature_help timeout to 5s 2018-08-03 17:41:21 -04:00
feature_includeconf.py init: Use InitError for all errors in bitcoind/qt 2019-07-11 19:39:25 -04:00
feature_logging.py test/contrib: Fix invalid escapes in regex strings 2019-09-03 14:38:38 -04:00
feature_maxuploadtarget.py test: Require standard txs in regtest 2019-06-21 16:45:16 -04:00
feature_minchainwork.py Changed functional tests which do not require wallets to run without 2018-09-17 08:25:10 -05:00
feature_notifications.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
feature_nulldummy.py [Consensus] Bury segwit deployment 2019-08-14 15:52:52 -04:00
feature_proxy.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
feature_pruning.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
feature_rbf.py test: Require standard txs in regtest 2019-06-21 16:45:16 -04:00
feature_reindex.py Changed functional tests which do not require wallets to run without 2018-09-17 08:25:10 -05:00
feature_segwit.py Merge #16521: rpc: Use the default maxfeerate value as BTC/kB 2019-09-18 16:49:18 +02:00
feature_shutdown.py qa: Remove race between connecting and shutdown on separate connections 2019-01-16 12:01:42 +00:00
feature_uacomment.py test/contrib: Fix invalid escapes in regex strings 2019-09-03 14:38:38 -04:00
feature_versionbits_warning.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
interface_bitcoin_cli.py test: Adapt test framework for chains other than "regtest" 2019-07-31 17:00:25 -04:00
interface_http.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
interface_rest.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
interface_rpc.py Add a 'logpath' field to getrpcinfo 2019-05-16 23:01:00 +02:00
interface_zmq.py qa: Relax so that the subscriber is ready before publishing zmq messages 2019-08-28 00:42:29 +01:00
mempool_accept.py Merge #16521: rpc: Use the default maxfeerate value as BTC/kB 2019-09-18 16:49:18 +02:00
mempool_limit.py test: Require standard txs in regtest 2019-06-21 16:45:16 -04:00
mempool_package_onemore.py Conservatively accept RBF bumps bumping one tx at the package limits 2019-09-04 15:53:14 -04:00
mempool_packages.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
mempool_persist.py rpc: Expose g_is_mempool_loaded via getmempoolinfo and /rest/mempool/info.json 2019-03-22 02:31:20 -07:00
mempool_reorg.py qa: Run all tests even if wallet is not compiled 2018-09-10 17:53:21 -04:00
mempool_resurrect.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
mempool_spend_coinbase.py qa: Run all tests even if wallet is not compiled 2018-09-10 17:53:21 -04:00
mining_basic.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
mining_getblocktemplate_longpoll.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
mining_prioritisetransaction.py test: Require standard txs in regtest 2019-06-21 16:45:16 -04:00
p2p_blocksonly.py Disconnect peers violating blocks-only mode 2019-09-04 14:58:36 -04:00
p2p_compactblocks.py [Consensus] Bury segwit deployment 2019-08-14 15:52:52 -04:00
p2p_disconnect_ban.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
p2p_dos_header_tree.py test: Test that low difficulty chain fork is rejected 2019-08-16 13:02:16 -04:00
p2p_feefilter.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
p2p_fingerprint.py Changed functional tests which do not require wallets to run without 2018-09-17 08:25:10 -05:00
p2p_invalid_block.py New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137. 2019-06-02 10:25:03 -07:00
p2p_invalid_locator.py Update copyright headers to 2018 2018-12-29 10:15:01 +01:00
p2p_invalid_messages.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
p2p_invalid_tx.py test: Require standard txs in regtest 2019-06-21 16:45:16 -04:00
p2p_leak_tx.py [tests] Test that nodes respond to getdata with notfound 2018-10-26 07:45:12 -04:00
p2p_leak.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
p2p_mempool.py tests: Use explicit imports 2018-08-13 14:13:39 +02:00
p2p_node_network_limited.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
p2p_permissions.py Reformat p2p_permissions.py 2019-08-17 00:43:37 +09:00
p2p_segwit.py [Consensus] Bury segwit deployment 2019-08-14 15:52:52 -04:00
p2p_sendheaders.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
p2p_timeouts.py test: Avoid racy test p2p_timeouts 2018-12-21 02:00:32 +01:00
p2p_tx_download.py test: Use connect_nodes when connecting nodes in the test_framework 2019-09-17 13:08:17 -04:00
p2p_unrequested_blocks.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
README.md qa: Add tool-prefix to functional test readme 2019-02-08 08:33:07 -05:00
rpc_bind.py test: Adapt test framework for chains other than "regtest" 2019-07-31 17:00:25 -04:00
rpc_blockchain.py Add window final block height to getchaintxstats 2019-08-29 06:24:44 -07:00
rpc_createmultisig.py signrawtransactionwithkey: better error messages for bad redeemScript/witnessScript 2019-09-10 15:41:50 +10:00
rpc_decodescript.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_deprecated.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_deriveaddresses.py Give more errors for specific failure conditions 2019-08-16 19:34:01 -04:00
rpc_fundrawtransaction.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
rpc_getblockfilter.py rpc: Add getblockfilter RPC method. 2019-04-06 12:10:55 -07:00
rpc_getblockstats.py rpc: faster getblockstats using BlockUndo data 2019-05-10 08:33:14 -04:00
rpc_getchaintips.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
rpc_help.py qa: Add test to ensure node can generate all help texts at runtime 2018-11-05 11:13:32 -05:00
rpc_invalidateblock.py test: Establish only one connection between nodes in rpc_invalidateblock 2019-08-27 15:22:40 -04:00
rpc_misc.py tests: Fail if RPC has been added without tests 2019-05-15 14:27:18 -04:00
rpc_named_arguments.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_net.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
rpc_preciousblock.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
rpc_psbt.py Merge #16898: test: Remove connect_nodes_bi 2019-09-18 14:41:21 -04:00
rpc_rawtransaction.py Merge #16898: test: Remove connect_nodes_bi 2019-09-18 14:41:21 -04:00
rpc_scantxoutset.py qa: Check scantxoutset result against gettxoutsetinfo 2019-09-09 00:51:31 +01:00
rpc_setban.py test: Remove incorrect and unused try-block in assert_debug_log 2019-09-04 13:10:37 -04:00
rpc_signmessage.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_signrawtransaction.py [rpc] Remove signrawtransaction warning 2019-03-22 10:30:25 -04:00
rpc_txoutproof.py Merge #13424: Consistently validate txid / blockhash length and encoding in rpc calls 2018-09-24 15:09:11 -04:00
rpc_uptime.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_users.py test: rpc_users: Make variable names more clear. 2019-07-08 16:13:35 -04:00
test_runner.py Merge #16551: test: Test that low difficulty chain fork is rejected 2019-09-12 13:28:49 +03:00
tool_wallet.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
wallet_abandonconflict.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_address_types.py Merge #16898: test: Remove connect_nodes_bi 2019-09-18 14:41:21 -04:00
wallet_avoidreuse.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
wallet_backup.py test: Bump timeouts in slow running tests 2019-09-16 13:32:13 -04:00
wallet_balance.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
wallet_basic.py Merge #16898: test: Remove connect_nodes_bi 2019-09-18 14:41:21 -04:00
wallet_bumpfee_totalfee_deprecation.py Add RPC bumpfee totalFee deprecation test 2019-07-26 14:09:03 -04:00
wallet_bumpfee.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
wallet_coinbase_category.py Test coinbase category in wallet rpcs 2018-12-01 13:00:38 -05:00
wallet_create_tx.py test: Add test for maxtxfee option 2019-07-10 11:58:46 +01:00
wallet_createwallet.py Allow createwallet to take empty passwords to make unencrypted wallets 2019-07-29 11:50:24 -04:00
wallet_disable.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
wallet_dump.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
wallet_encryption.py QA: Fix race condition in wallet_encryption test 2019-07-18 22:31:24 +02:00
wallet_fallbackfee.py qa: Run all tests even if wallet is not compiled 2018-09-10 17:53:21 -04:00
wallet_groups.py scripted-diff: Rename rpc_timewait to rpc_timeout 2018-12-22 17:23:25 +01:00
wallet_hd.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
wallet_import_rescan.py test: Test p2sh-witness and bech32 in wallet_import_rescan 2019-08-14 17:20:07 -04:00
wallet_import_with_label.py [tests] move wallet util functions to wallet_util.py 2019-01-04 17:49:17 -08:00
wallet_importmulti.py Avoid using mutable default parameter values 2019-08-26 10:45:25 +00:00
wallet_importprunedfunds.py rpc: Correctly name arguments 2018-11-13 14:24:40 -05:00
wallet_keypool_topup.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
wallet_keypool.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
wallet_labels.py [tests] Small fixups before deprecating generate 2018-10-16 11:27:13 -04:00
wallet_listreceivedby.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_listsinceblock.py test: Use connect_nodes when connecting nodes in the test_framework 2019-09-17 13:08:17 -04:00
wallet_listtransactions.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_multiwallet.py Merge #16796: wallet: Fix segfault in CreateWalletFromFile 2019-09-09 23:34:05 +12:00
wallet_reorgsrestore.py Add a test wallet_reorgsrestore 2019-08-29 12:01:51 -04:00
wallet_resendwallettransactions.py rpc: Clarify that block count means height excl genesis 2019-07-02 12:28:21 -04:00
wallet_txn_clone.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_txn_doublespend.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
wallet_watchonly.py test: add executable flag for wallet_watchonly.py 2019-08-28 18:25:00 +02:00
wallet_zapwallettxes.py qa: Run all tests even if wallet is not compiled 2018-09-10 17:53:21 -04:00

Functional tests

Writing Functional Tests

Example test

The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

test-framework modules

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for functional tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support P2P connectivity to a bitcoind.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: