mirrors/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-23 15:20:49 +01:00
Code Issues Projects Releases Wiki Activity
bitcoin/src/qt
History
Samuel Dobson 4f802e59a0
Merge #17509: gui: save and load PSBT 
764bfe4cba [psbt] add file size limit (Sjors Provoost)
1cd8dc2556 [gui] load PSBT (Sjors Provoost)
f6895301f7 [gui] save PSBT to file (Sjors Provoost)
1d05a9d80b Move DEFAULT_MAX_RAW_TX_FEE_RATE to node/transaction.h (Sjors Provoost)
86e22d23bb [util] GetFileSize (Sjors Provoost)
6ab3aad9a5 [gui] send dialog: split on_sendButton_clicked (Sjors Provoost)

Pull request description:

  This adds:
  * a dialog after Create Unsigned, which lets you save a PSBT file in binary format, e.g. to an SD card
  * a "Load PSBT" menu entry lets you pick a PSBT file. We broadcast the transaction if complete

  ## Save flow
  <img width="482" alt="Schermafbeelding 2020-01-04 om 20 39 34" src="https://user-images.githubusercontent.com/10217/71765684-ba60d580-2f32-11ea-8dea-0c4398eb6e15.png">

  <img width="287" alt="Schermafbeelding 2020-01-04 om 20 40 35" src="https://user-images.githubusercontent.com/10217/71765677-a0bf8e00-2f32-11ea-8172-12dfd34a89f3.png">

  <img width="594" alt="Schermafbeelding 2020-01-04 om 20 41 12" src="https://user-images.githubusercontent.com/10217/71765681-aa48f600-2f32-11ea-8e2c-c4f6bf9f5309.png">

  <img width="632" alt="Schermafbeelding 2020-01-04 om 20 41 28" src="https://user-images.githubusercontent.com/10217/71765691-d19fc300-2f32-11ea-97ff-70f5dd59987a.png">

  By default the file name contains the destination address(es) and amount(s).

  We only use the binary format for files, in order to avoid compatibility hell. If we do want to add base64 file format support, we should use a different extension for that (`.psbt64`?).

  ## Load flow

  Select a file:
  <img width="649" alt="Schermafbeelding 2020-01-04 om 21 08 57" src="https://user-images.githubusercontent.com/10217/71766089-2ba28780-2f37-11ea-875d-074794b5707d.png">

  Offer to send if complete:

  <img width="308" alt="Schermafbeelding 2020-01-04 om 21 09 06" src="https://user-images.githubusercontent.com/10217/71766088-2a715a80-2f37-11ea-807d-394c8b840c59.png">

  Tell user if signatures are missing, offer to copy to clipboard:
  <img width="308" alt="Schermafbeelding 2020-01-04 om 21 15 57" src="https://user-images.githubusercontent.com/10217/71766115-702e2300-2f37-11ea-9f62-a6ede499c0fa.png">

  Incomplete for another reason:

  <img width="309" alt="Schermafbeelding 2020-01-04 om 21 07 51" src="https://user-images.githubusercontent.com/10217/71766090-2c3b1e00-2f37-11ea-8a22-6188377b67a1.png">

ACKs for top commit:
  instagibbs:
    re-ACK  764bfe4cba
  achow101:
    ACK 764bfe4cba
  jb55:
    Tested ACK 764bfe4cba
  jonatack:
    ACK 764bfe4c
  promag:
    Code review ACK 764bfe4cba.

Tree-SHA512: d284ed6895f3a271fb8ff879aac388ad217ddc13f72074725608e1c3d6d90650f6dc9e9e254479544dd71fc111516b02c8ff92158153208dc40fb2726b37d063
2020-04-23 13:16:23 +12:00
..
forms gui: avoid QT Designer/Form Editor re-formatting 2020-03-24 14:04:16 +01:00
locale qt: Translations update pre-branch 2020-04-01 12:49:15 +02:00
res qt: Make bitcoin.ico non-executable 2020-04-15 10:59:10 +00:00
test wallet: Refactor WalletRescanReserver to use wallet reference 2020-04-19 14:04:37 +01:00
addressbookpage.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
addressbookpage.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
addresstablemodel.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
addresstablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
askpassphrasedialog.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
askpassphrasedialog.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
bantablemodel.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
bantablemodel.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
bitcoin.cpp gui: use PACKAGE_NAME in exception message 2020-04-15 15:35:47 +08:00
bitcoin.h scripted-diff: Bump copyright of files changed in 2020 2020-01-15 02:18:00 +07:00
bitcoin.qrc qt: Remove menu icons 2019-08-15 13:05:10 +02:00
bitcoin_locale.qrc qt: Translations update pre-branch 2020-04-01 12:49:15 +02:00
bitcoinaddressvalidator.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
bitcoinaddressvalidator.h Added "Core" to copyright headers 2014-12-19 19:55:32 +01:00
bitcoinamountfield.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
bitcoinamountfield.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
bitcoingui.cpp Merge #17509: gui: save and load PSBT 2020-04-23 13:16:23 +12:00
bitcoingui.h Merge #17509: gui: save and load PSBT 2020-04-23 13:16:23 +12:00
bitcoinstrings.cpp qt: Periodical translations update 2020-03-16 10:51:11 +01:00
bitcoinunits.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
bitcoinunits.h scripted-diff: Bump copyright of files changed in 2020 2020-01-15 02:18:00 +07:00
clientmodel.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
clientmodel.h gui: Avoid redundant tx status updates 2020-01-09 16:05:35 -04:00
coincontroldialog.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
coincontroldialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
coincontroltreewidget.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
coincontroltreewidget.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
createwalletdialog.cpp gui: rename encrypt(), blank(), and askPasshprase() 2019-09-09 10:56:38 +02:00
createwalletdialog.h gui: rename encrypt(), blank(), and askPasshprase() 2019-09-09 10:56:38 +02:00
csvmodelwriter.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
csvmodelwriter.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
editaddressdialog.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
editaddressdialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
guiconstants.h scripted-diff: Bump copyright of files changed in 2020 2020-01-15 02:18:00 +07:00
guiutil.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
guiutil.h refactor: Convert ping wait time from double to int64_t 2020-03-04 13:45:29 -05:00
intro.cpp Merge #17453: gui: Fix intro dialog labels when the prune button is toggled 2020-01-27 18:15:45 +01:00
intro.h gui: Make Intro consistent with prune checkbox 2020-01-14 19:14:14 +02:00
macdockiconhandler.h Remove obj_c for macOS Dock icon menu 2018-11-04 02:42:18 +02:00
macdockiconhandler.mm qt: Replace objc_msgSend with native syntax 2019-08-31 12:25:34 +03:00
macnotificationhandler.h convert C-style (void) parameter lists to C++ style () 2018-09-13 10:36:41 -07:00
macnotificationhandler.mm scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
macos_appnap.h macOS: disable AppNap during sync 2018-11-01 18:22:06 +03:00
macos_appnap.mm macOS: disable AppNap during sync 2018-11-01 18:22:06 +03:00
main.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
Makefile build: add stub makefiles for easier subdir builds 2014-06-05 16:05:43 -04:00
modaloverlay.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
modaloverlay.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
networkstyle.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
networkstyle.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
notificator.cpp Remove misplaced Q_UNUSED and others enhancements 2018-12-20 01:06:37 +02:00
notificator.h Remove misplaced Q_UNUSED and others enhancements 2018-12-20 01:06:37 +02:00
openuridialog.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
openuridialog.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
optionsdialog.cpp net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface 2020-01-08 12:35:59 +00:00
optionsdialog.h Merge #13248: [gui] Make proxy icon from statusbar clickable 2018-08-20 13:40:11 +02:00
optionsmodel.cpp Replace std::to_string with locale-independent alternative 2020-03-14 12:23:01 -07:00
optionsmodel.h Merge #17453: gui: Fix intro dialog labels when the prune button is toggled 2020-01-27 18:15:45 +01:00
overviewpage.cpp refactor: Get rid of Wallet::IsWalletFlagSet method 2020-03-19 15:26:04 -05:00
overviewpage.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
paymentserver.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
paymentserver.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
peertablemodel.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
peertablemodel.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
platformstyle.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
platformstyle.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
qrimagewidget.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
qrimagewidget.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
qvalidatedlineedit.cpp Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
qvalidatedlineedit.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
qvaluecombobox.cpp qt: Use new Qt5 connect syntax 2018-08-21 09:43:54 +01:00
qvaluecombobox.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
README.md Remove BIP70 Support 2019-10-24 16:01:43 -04:00
receivecoinsdialog.cpp refactor: Get rid of Wallet::IsWalletFlagSet method 2020-03-19 15:26:04 -05:00
receivecoinsdialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
receiverequestdialog.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
receiverequestdialog.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
recentrequeststablemodel.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
recentrequeststablemodel.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpcconsole.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpcconsole.h gui: Make RPCConsole::TabTypes an enum class 2019-10-15 13:46:34 +01:00
sendcoinsdialog.cpp Merge #17509: gui: save and load PSBT 2020-04-23 13:16:23 +12:00
sendcoinsdialog.h [gui] send dialog: split on_sendButton_clicked 2020-03-24 20:29:49 +01:00
sendcoinsentry.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
sendcoinsentry.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
sendcoinsrecipient.h refactor: Move SendCoinsRecipient in own header 2019-11-19 17:05:35 +02:00
signverifymessagedialog.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
signverifymessagedialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
splashscreen.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
splashscreen.h Cleanup SplashScreen class 2018-12-02 01:26:28 +02:00
trafficgraphwidget.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
trafficgraphwidget.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
transactiondesc.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
transactiondesc.h Remove unused adjustedTime parameter 2018-10-28 09:04:10 +02:00
transactiondescdialog.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
transactiondescdialog.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
transactionfilterproxy.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
transactionfilterproxy.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactionrecord.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
transactionrecord.h Don't label transactions "Open" while catching up 2019-01-03 00:10:24 +02:00
transactiontablemodel.cpp gui: Avoid redundant tx status updates 2020-01-09 16:05:35 -04:00
transactiontablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactionview.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
transactionview.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
utilitydialog.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
utilitydialog.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
walletcontroller.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
walletcontroller.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
walletframe.cpp [gui] load PSBT 2020-03-27 14:59:19 +01:00
walletframe.h [gui] load PSBT 2020-03-27 14:59:19 +01:00
walletmodel.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
walletmodel.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
walletmodeltransaction.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
walletmodeltransaction.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
walletview.cpp Merge #17509: gui: save and load PSBT 2020-04-23 13:16:23 +12:00
walletview.h Merge #17509: gui: save and load PSBT 2020-04-23 13:16:23 +12:00
winshutdownmonitor.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
winshutdownmonitor.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00

README.md

This directory contains the BitcoinQT graphical user interface (GUI). It uses the cross-platform framework Qt.

The current precise version for Qt 5 is specified in qt.mk.

Compile and run

See build instructions (macOS, Windows, Unix, etc).

To run:

./src/qt/bitcoin-qt

Files and directories

forms

Contains Designer UI files. They are created with Qt Creator, but can be edited using any text editor.

locale

Contains translations. They are periodically updated. The process is described here.

res

Resources such as the icon.

test

Tests.

bitcoingui.(h/cpp)

Represents the main window of the Bitcoin UI.

*model.(h/cpp)

The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.

ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

Used to process BIP21 payment URI requests. Also handles URI based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/mm): macOS dock icon handler
  • macnotificationhandler.(h/mm): display notifications in macOS

Contribute

See CONTRIBUTING.md for general guidelines. Specifically for Qt:

Using Qt Creator as IDE

You can use Qt Creator as an IDE. This is especially useful if you want to change the UI layout.

Download and install the community edition of Qt Creator. Uncheck everything except Qt Creator during the installation process.

Instructions for macOS:

  1. Make sure you installed everything through Homebrew mentioned in the macOS build instructions
  2. Use ./configure with the --enable-debug flag
  3. In Qt Creator do "New Project" -> Import Project -> Import Existing Project
  4. Enter "bitcoin-qt" as project name, enter src/qt as location
  5. Leave the file selection as it is
  6. Confirm the "summary page"
  7. In the "Projects" tab select "Manage Kits..."
  8. Select the default "Desktop" kit and select "Clang (x86 64bit in /usr/bin)" as compiler
  9. Select LLDB as debugger (you might need to set the path to your installation)
  10. Start debugging with Qt Creator (you might need to the executable to "bitcoin-qt" under "Run", which is where you can also add command line arguments)