bitcoin/src
Gregory Maxwell 3babbcb487 Remove confusing MAX_BLOCK_BASE_SIZE.
Some people keep thinking that MAX_BLOCK_BASE_SIZE is a separate
 size limit from the weight limit when it fact it is superfluous,
 and used in early tests before the witness data has been
 validated or just to compute worst case sizes.  The size checks
 that use it would not behave any differently consensus wise
 if they were eliminated completely.

Its correct value is not independently settable but is a function
 of the weight limit and weight formula.

This patch just eliminates it and uses the scale factor as
 required to compute the worse case constants.

It also moves the weight factor out of primitives into consensus,
 which is a more logical place for it.
2017-07-14 19:24:17 +00:00
..
bench Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp> 2017-07-04 18:05:18 +02:00
compat [trivial] Add end of namespace comments 2017-05-31 22:21:25 +02:00
config
consensus Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
crypto Limit variable scope 2017-06-05 00:52:36 +02:00
leveldb Fixed multiple typos 2017-06-22 19:18:10 +03:00
obj
obj-test
policy Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
primitives Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
qt Merge #10589: More economical fee estimates for RBF and RPC options to control 2017-07-11 11:58:02 +02:00
rpc Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
script Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp> 2017-07-04 18:05:18 +02:00
secp256k1 Fixed multiple typos 2017-06-22 19:18:10 +03:00
support Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2017-06-28 02:12:06 +02:00
test Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
univalue Merge commit '2ca7faab4205822b06dc2ab2bbda0a9a70fce7e0' into HEAD 2016-09-30 19:58:11 +02:00
wallet Fix rare edge case of paying too many fees when transaction has no change. 2017-07-11 12:20:41 -04:00
zmq Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2017-06-28 02:12:06 +02:00
.clang-format Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp> 2017-07-04 18:05:18 +02:00
addrdb.cpp Deduplicate addrdb.cpp and use CHashWriter/Verifier 2017-06-01 16:42:07 -07:00
addrdb.h Deduplicate addrdb.cpp and use CHashWriter/Verifier 2017-06-01 16:42:07 -07:00
addrman.cpp Merge #9792: FastRandomContext improvements and switch to ChaCha20 2017-04-24 14:28:49 +02:00
addrman.h Merge #9792: FastRandomContext improvements and switch to ChaCha20 2017-04-24 14:28:49 +02:00
amount.h Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module 2017-05-03 18:00:13 +02:00
arith_uint256.cpp Fix instantiation and array accesses in class base_uint<BITS> 2017-06-07 17:21:29 +00:00
arith_uint256.h Fix instantiation and array accesses in class base_uint<BITS> 2017-06-07 17:21:29 +00:00
base58.cpp Fix subscript[0] in base58.cpp 2017-07-08 13:33:01 -07:00
base58.h Fix subscript[0] in base58.cpp 2017-07-08 13:33:01 -07:00
bitcoin-cli-res.rc
bitcoin-cli.cpp Chainparams: Use a regular factory for creating chainparams 2017-05-03 18:15:47 +02:00
bitcoin-tx-res.rc
bitcoin-tx.cpp Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
bitcoind-res.rc
bitcoind.cpp Remove unused Boost includes 2017-06-09 10:25:26 +02:00
blockencodings.cpp Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
blockencodings.h [trivial] Fix typos in comments 2017-01-27 21:22:35 +01:00
bloom.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
bloom.h param variables made const 2017-02-13 14:39:48 +09:00
chain.cpp [MOVEONLY] Move LastCommonAncestor to chain 2017-06-26 10:45:48 -07:00
chain.h [MOVEONLY] Move LastCommonAncestor to chain 2017-06-26 10:45:48 -07:00
chainparams.cpp chainparams: make supported service bits option explicit 2017-06-22 15:21:22 -04:00
chainparams.h chainparams: make supported service bits option explicit 2017-06-22 15:21:22 -04:00
chainparamsbase.cpp Chainparams: Use a regular factory for creating chainparams 2017-05-03 18:15:47 +02:00
chainparamsbase.h Chainparams: Use a regular factory for creating chainparams 2017-05-03 18:15:47 +02:00
chainparamsseeds.h Pre-0.14.0 hardcoded seeds update 2017-02-10 11:04:34 +01:00
checkpoints.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
checkpoints.h [MOVEONLY] Move progress estimation out of checkpoints 2017-01-04 13:18:49 -08:00
checkqueue.h scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
clientversion.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
clientversion.h Fix build warning from #error text 2017-04-07 14:37:25 -04:00
coins.cpp Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
coins.h Merge #10558: Address nits from per-utxo change 2017-06-28 11:44:22 -07:00
compat.h compat: use unsigned int instead of u_int 2017-03-05 09:51:21 +00:00
compressor.cpp Fix subscript[0] in compressor.cpp 2017-07-08 13:33:01 -07:00
compressor.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
core_io.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
core_memusage.h Add RecursiveDynamicUsage overload for std::shared_ptr 2017-05-04 16:50:52 -04:00
core_read.cpp Replace MAX_OPCODE for OP_NOP10. 2017-07-11 16:45:42 +09:00
core_write.cpp Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
cuckoocache.h Merge #10577: Add an explanation of quickly hashing onto a non-power of two range. 2017-06-24 11:28:04 +02:00
dbwrapper.cpp Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2017-06-26 13:40:26 +02:00
dbwrapper.h Report on-disk size in gettxoutsetinfo 2017-05-26 13:33:39 -07:00
fs.cpp Remove unused Boost includes 2017-06-09 10:25:26 +02:00
fs.h [Trivial] Add BITCOIN_FS_H endif footer in fs.h 2017-05-19 02:01:28 -07:00
hash.cpp Cleanup (safe, it was checked) subscript[0] in MurmurHash3 (and cleanup MurmurHash3 to be more clear). 2017-07-08 13:33:01 -07:00
hash.h Add specialization of SipHash for 256 + 32 bit data 2017-05-26 13:24:25 -07:00
httprpc.cpp Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp> 2017-07-04 18:05:18 +02:00
httprpc.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
httpserver.cpp Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2017-06-28 02:12:06 +02:00
httpserver.h Fixed multiple typos 2017-06-22 19:18:10 +03:00
indirectmap.h prepend license statement to indirectmap 2016-07-27 16:27:07 -07:00
init.cpp Merge #10714: Avoid printing incorrect block indexing time due to uninitialized variable 2017-07-12 15:17:24 -07:00
init.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
key.cpp Fix subscript[0] potential bugs in key.cpp 2017-07-08 13:37:06 -07:00
key.h Remove unused C++ code not covered by unit tests 2017-04-26 21:20:02 +02:00
keystore.cpp Remove unused Boost includes 2017-06-09 10:25:26 +02:00
keystore.h Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2017-06-28 02:12:06 +02:00
limitedmap.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
Makefile.am Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp> 2017-07-04 18:05:18 +02:00
Makefile.bench.include leveldb: enable runtime-detected crc32 instructions 2017-06-09 19:25:36 -07:00
Makefile.leveldb.include Add extra LevelDB source to Makefile 2017-06-09 19:25:36 -07:00
Makefile.qt.include leveldb: enable runtime-detected crc32 instructions 2017-06-09 19:25:36 -07:00
Makefile.qttest.include leveldb: enable runtime-detected crc32 instructions 2017-06-09 19:25:36 -07:00
Makefile.test.include Merge #10544: Update to LevelDB 1.20 2017-06-13 19:48:13 +02:00
memusage.h scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
merkleblock.cpp Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
merkleblock.h Fixed typo in documentation for merkleblock.h 2017-04-22 07:22:17 -04:00
miner.cpp scripted-diff: Fully remove BOOST_FOREACH 2017-06-05 20:10:50 +02:00
miner.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
net.cpp Fix subscript[0] bug in net.cpp if GetGroup returns a 0-sized vector 2017-07-08 13:31:47 -07:00
net.h Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp> 2017-07-04 18:05:18 +02:00
net_processing.cpp Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp> 2017-07-04 18:05:18 +02:00
net_processing.h Add timeout for headers sync 2017-06-05 16:33:35 -04:00
netaddress.cpp Fix subscript[0] in netaddress.cpp 2017-07-08 13:33:01 -07:00
netaddress.h net: add an internal subnet for representing unresolved hostnames 2017-06-14 18:05:00 -04:00
netbase.cpp net: do not allow resolving to an internal address 2017-06-14 18:05:01 -04:00
netbase.h [net] Added SetSocketNoDelay() utility function 2017-04-05 11:31:43 -07:00
netmessagemaker.h Net: Make CNetMsgMaker more const 2017-01-31 23:29:28 +01:00
noui.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
noui.h
pow.cpp pow: GetNextWorkRequired never called with NULL pindexLast 2017-02-15 22:11:29 +09:00
pow.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
prevector.h Fix const_reverse_iterator constructor (pass const ptr) 2017-06-22 03:48:49 +02:00
protocol.cpp Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2017-06-26 13:40:26 +02:00
protocol.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
pubkey.cpp Fix 2 subscript[0] bugs in pubkey.cpp, and eliminate one extra size check 2017-07-08 13:31:47 -07:00
pubkey.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
random.cpp random: fix crash on some 64bit platforms 2017-06-16 15:19:15 -04:00
random.h Merge #10377: Use rdrand as entropy source on supported platforms 2017-06-14 15:22:15 +02:00
rest.cpp Fixed multiple typos 2017-06-22 19:18:10 +03:00
reverse_iterator.h Introduce src/reverse_iterator.hpp and include it... 2017-06-22 03:48:42 +02:00
reverselock.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
scheduler.cpp Expose if CScheduler is being serviced, assert its not in EmptyQueue 2017-07-10 21:08:19 -04:00
scheduler.h Expose if CScheduler is being serviced, assert its not in EmptyQueue 2017-07-10 21:08:19 -04:00
serialize.h Fix subscript[0] in validation.cpp 2017-07-08 13:33:01 -07:00
streams.h Fix subscript[0] in streams.h 2017-07-08 13:33:01 -07:00
sync.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
sync.h Remove unused Boost includes 2017-06-09 10:25:26 +02:00
threadinterrupt.cpp net: add CThreadInterrupt and InterruptibleSleep 2017-01-03 17:53:09 -05:00
threadinterrupt.h net: add CThreadInterrupt and InterruptibleSleep 2017-01-03 17:53:09 -05:00
threadsafety.h
timedata.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
timedata.h Merge #8808: Do not shadow variables (gcc set) 2017-03-03 15:48:53 +01:00
tinyformat.h util: Throw tinyformat::format_error on formatting error 2017-03-13 06:51:15 +01:00
torcontrol.cpp Fix subscript[0] in torcontrol 2017-07-08 13:33:01 -07:00
torcontrol.h
txdb.cpp Report [CANCELLED] instead of [DONE] when shut down during txdb upgrade 2017-06-29 17:48:13 +02:00
txdb.h Merge #10148: Use non-atomic flushing with block replay 2017-06-28 18:26:41 +02:00
txmempool.cpp Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp> 2017-07-04 18:05:18 +02:00
txmempool.h Merge #10685: Clarify CCoinsViewMemPool documentation. 2017-06-28 11:22:00 -07:00
ui_interface.cpp [wallet] Add high transaction fee warnings 2016-09-26 01:11:27 +02:00
ui_interface.h [Qt] allow to execute a callback during splashscreen progress 2017-06-29 17:48:08 +02:00
uint256.cpp uint256: replace sprintf with HexStr and reverse-iterator 2017-02-27 10:02:45 +01:00
uint256.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
undo.h Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
util.cpp Merge #10118: Util: Remove redundant calls to argsGlobal.IsArgSet() 2017-06-27 16:29:11 +02:00
util.h [RPC] Add an uptime command that displays the amount of time that bitcoind has been running 2017-06-25 20:25:45 +01:00
utilmoneystr.cpp Refactor: Remove using namespace <xxx> from util* 2017-03-08 08:47:02 -08:00
utilmoneystr.h
utilstrencodings.cpp Remove unnecessary branches in utilstrencodings string constructors. 2017-07-08 13:33:01 -07:00
utilstrencodings.h scripted-diff: Remove PAIRTYPE 2017-06-05 20:14:53 +02:00
utiltime.cpp [logging] log system time and mock time 2017-05-10 15:49:00 -04:00
utiltime.h [logging] log system time and mock time 2017-05-10 15:49:00 -04:00
validation.cpp Remove confusing MAX_BLOCK_BASE_SIZE. 2017-07-14 19:24:17 +00:00
validation.h Merge #10192: Cache full script execution results in addition to signatures 2017-06-29 20:19:21 +02:00
validationinterface.cpp Flush CValidationInterface callbacks prior to destruction 2017-07-07 12:55:57 -04:00
validationinterface.h Flush CValidationInterface callbacks prior to destruction 2017-07-07 12:55:57 -04:00
version.h Remove unused constant MEMPOOL_GD_VERSION 2017-06-09 01:45:36 +02:00
versionbits.cpp Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2017-06-28 02:12:06 +02:00
versionbits.h scripted-diff: s/BIP9DeploymentInfo/VBDeploymentInfo/ 2017-05-30 19:21:52 +02:00
warnings.cpp Move GetWarnings() into its own file. 2016-12-03 07:17:34 +00:00
warnings.h Move GetWarnings() into its own file. 2016-12-03 07:17:34 +00:00