fanquake cb1ee1551c Merge #19674: refactor: test: use throwaway _ variable for unused loop counters ... dac7a111bd refactor: test: use _ variable for unused loop counters (Sebastian Falbesoner) Pull request description: This tiny PR substitutes Python loops in the form of `for x in range(N): ...` by `for _ in range(N): ...` where applicable. The idea is indicating to the reader that a block (or statement, in list comprehensions) is just repeated N times, and that the loop counter is not used in the body, hence using the throwaway variable. This is already done quite often in the current tests (see e.g. `$ git grep "for _ in range("`). Another alternative would be using `itertools.repeat` (according to Python core developer Raymond Hettinger it's [even faster](https://twitter.com/raymondh/status/1144527183341375488)), but that doesn't seem to be widespread in use and I'm not sure about a readability increase. The only drawback I see is that whenever one wants to debug loop iterations, one would need to introduce a loop variable again. Reviewing this is basically a no-brainer, since tests would fail immediately if a a substitution has taken place on a loop where the variable is used. Instances to replace were found by `$ git grep "for.*in range("` and manually checked. ACKs for top commit: darosior: ACK dac7a111bd instagibbs: manual inspection ACK dac7a111bd practicalswift: ACK dac7a111bd -- the updated code is easier to reason about since the throwaway nature of a variable is expressed explicitly (using the Pythonic `_` idiom) instead of implicitly. Explicit is better than implicit was we all know by now :) Tree-SHA512: 5f43ded9ce14e5e00b3876ec445b90acda1842f813149ae7bafa93f3ac3d510bb778e2c701187fd2c73585e6b87797bb2d2987139bd1a9ba7d58775a59392406		2020-08-11 09:24:50 +08:00
..
__init__.py
address.py
authproxy.py
blocktools.py	[test] CScriptNum Decode Check as Unit Tests	2020-06-03 07:18:01 -07:00
coverage.py
descriptors.py
key.py	[tests] move generate_wif_key to wallet_util.py	2020-06-10 12:10:02 -04:00
messages.py
mininode.py
netutil.py
script.py
script_util.py
segwit_addr.py
siphash.py
socks5.py
test_framework.py
test_node.py
test_shell.py
util.py
wallet_util.py