bitcoin/src/test
MarcoFalke ae6943620a
Merge #17407: node: Add reference to mempool in NodeContext
fa538813b1 scripted-diff: Replace ::mempool with m_node.mempool in tests (MarcoFalke)
8888ad02e2 test: Replace recursive lock with locking annotations (MarcoFalke)
fac07f2038 node: Add reference to mempool in NodeContext (MarcoFalke)

Pull request description:

  This is the first step toward making the mempool a global that is not initialized before main.

  #### Motivation

  Currently the mempool is a global that is initialized before the `main` function. This is confusing and easy to get wrong. E.g. the mempool constructor queries state that has not been initialized, like randomness (fixed), or command line arguments (not an issue last time I checked). Also without having the chainstate (chain tip) initialized first, it doesn't make conceptually sense to have a mempool, since the mempool builds txs on top of the utxo set (chain tip).

  Finally, in the future someone might want to run a consensus-only full node (`-nowallet -noblockfilter -no... -nomempool` command line options) that only verifies blocks and updates the utxo set.

  This is conceptually the same change that has already been done for the connection manager `CConnman`.

ACKs for top commit:
  jnewbery:
    utACK fa538813b1
  ariard:
    Tested ACK fa53881.

Tree-SHA512: 2c446a8a51476354aad7126c2b833500d36b24490caa94f847b2bdc622054de0dae28980f23e3d91b1b492dc32931656d98dbd019af9e4e58f2f8c5375aac694
2019-11-21 10:18:02 -05:00
..
data Added comments referencing multiple CVEs in tests and production code. 2019-06-02 10:25:03 -07:00
fuzz Merge #17136: tests: Add fuzzing harness for various PSBT related functions 2019-11-18 12:17:08 -05:00
gen Integration of property based testing into Bitcoin Core 2018-08-27 08:51:51 -05:00
util node: Add reference to mempool in NodeContext 2019-11-15 13:40:00 -05:00
addrman_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
allocator_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
amount_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
arith_uint256_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
base32_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
base58_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
base64_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
bech32_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
bip32_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
blockchain_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
blockencodings_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
blockfilter_index_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
blockfilter_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
bloom_tests.cpp Merge #16978: test: Seed test RNG context for each test case, print seed 2019-11-07 10:18:40 -05:00
bswap_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
checkqueue_tests.cpp Merge #17342: refactor: Clean up nScriptCheckThreads 2019-11-07 10:07:11 -05:00
coins_tests.cpp Merge #16978: test: Seed test RNG context for each test case, print seed 2019-11-07 10:18:40 -05:00
compilerbug_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
compress_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
crypto_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
cuckoocache_tests.cpp Merge #16978: test: Seed test RNG context for each test case, print seed 2019-11-07 10:18:40 -05:00
dbwrapper_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
denialofservice_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
descriptor_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
flatfile_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
fs_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
getarg_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
hash_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
key_io_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
key_properties.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
key_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
limitedmap_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
logging_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
main.cpp test: Remove useless test_bitcoin_main.cpp 2019-02-28 15:44:02 -05:00
Makefile build: add stub makefiles for easier subdir builds 2014-06-05 16:05:43 -04:00
mempool_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
merkle_tests.cpp fix Typo: "merkelRoot" -> "merkleRoot" 2019-11-12 00:56:05 +08:00
merkleblock_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
miner_tests.cpp scripted-diff: Replace ::mempool with m_node.mempool in tests 2019-11-15 13:40:14 -05:00
multisig_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
net_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
netbase_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
pmt_tests.cpp Merge #16978: test: Seed test RNG context for each test case, print seed 2019-11-07 10:18:40 -05:00
policyestimator_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
pow_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
prevector_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
raii_event_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
random_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
README.md doc: Add documentation for new test/lib 2019-11-06 11:56:53 -05:00
reverselock_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
rpc_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
sanity_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
scheduler_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
script_p2sh_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
script_standard_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
script_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
scriptnum10.h tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests 2019-06-26 20:37:48 +02:00
scriptnum_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
serialize_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
settings_tests.cpp Add settings_tests 2019-11-07 23:08:22 -04:00
sighash_tests.cpp Merge #16978: test: Seed test RNG context for each test case, print seed 2019-11-07 10:18:40 -05:00
sigopcount_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
skiplist_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
streams_tests.cpp Merge #16978: test: Seed test RNG context for each test case, print seed 2019-11-07 10:18:40 -05:00
sync_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
timedata_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
torcontrol_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
transaction_tests.cpp test: add unit test for non-standard txs with too large scriptSig 2019-11-14 19:51:50 +01:00
txindex_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
txvalidation_tests.cpp scripted-diff: Replace ::mempool with m_node.mempool in tests 2019-11-15 13:40:14 -05:00
txvalidationcache_tests.cpp scripted-diff: Replace ::mempool with m_node.mempool in tests 2019-11-15 13:40:14 -05:00
uint256_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
util.cpp Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes 2019-10-25 19:20:24 -04:00
util.h Add unit test NextString, ForEachNoDup functions 2019-05-07 11:51:30 -04:00
util_tests.cpp Deduplicate settings merge code 2019-11-07 23:08:22 -04:00
util_threadnames_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
validation_block_tests.cpp Merge #17407: node: Add reference to mempool in NodeContext 2019-11-21 10:18:02 -05:00
validation_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
versionbits_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the bitcoind tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the bitcoind tests.

To add more bitcoind tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the bitcoin-qt tests manually, launch src/qt/test/test_bitcoin-qt

To add more bitcoin-qt tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:

test_bitcoin --log_level=all --run_test=getarg_tests

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdbor lldb and start debugging, just like you would with bitcoind:

gdb src/test/test_bitcoin