mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-03-01 14:05:01 +01:00
17220d6325
This avoid calling out to mempool state during coin selection, balance calculation, etc. In the next commit we ensure all wallet callbacks from CValidationInterface happen in the same queue, serialized with each other. This helps to avoid re-introducing one of the issues described in #9584 [1] by further disconnecting wallet from current chain/mempool state. Thanks to @morcos for the suggestion to do this. Note that there are several race conditions introduced here: * If a user calls sendrawtransaction from RPC, adding a transaction which is "trusted" (ie from them) and pays them change, it may not be immediately used by coin selection until the notification callbacks finish running. No such race is introduced in normal transaction-sending RPCs as this case is explicitly handled. * Until Block{Connected,Disconnected} and TransactionAddedToMempool calls also run in the CSceduler background thread, there is a race where TransactionAddedToMempool might be called after a Block{Connected,Disconnected} call happens. * Wallet will write a new best chain from the SetBestChain callback prior to having processed the transaction from that block. [1] "you could go to select coins, need to use 0-conf change, but such 0-conf change may have been included in a block who's callbacks have not yet been processed - resulting in thinking they are not in mempool and, thus, not selectable." |
||
|---|---|---|
| .. | ||
| test | ||
| coincontrol.h | ||
| crypter.cpp | ||
| crypter.h | ||
| db.cpp | ||
| db.h | ||
| feebumper.cpp | ||
| feebumper.h | ||
| fees.cpp | ||
| fees.h | ||
| init.cpp | ||
| init.h | ||
| rpcdump.cpp | ||
| rpcwallet.cpp | ||
| rpcwallet.h | ||
| wallet.cpp | ||
| wallet.h | ||
| walletdb.cpp | ||
| walletdb.h | ||