mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-03-10 17:17:14 +01:00
c504b6997b
When generating a block template through e.g. getblocktemplate RPC, we reserve 4000 weight units and 400 sigops. Pools use this space for their coinbase outputs. At least one pool patched their Bitcoin Core node to adjust these hardcoded values. They eventually produced an invalid block which exceeded the sigops limit. https://bitcoin.stackexchange.com/questions/117837/how-many-sigops-are-in-the-invalid-block-783426 The existince of such patches suggests it may be useful to make this value configurable. This commit would make such a change easier. The main motivation however is that the Stratum v2 spec requires the pool to communicate the maximum bytes they intend to add to the coinbase outputs. A proposed change to the spec would also require them to communicate the maximum number of sigops. This commit also documents what happens when -blockmaxweight is lower than the coinbase reserved value. Co-authored-by: Ryan Ofsky <ryan@ofsky.org> |
||
|---|---|---|
| .. | ||
| abort.cpp | ||
| abort.h | ||
| blockmanager_args.cpp | ||
| blockmanager_args.h | ||
| blockstorage.cpp | ||
| blockstorage.h | ||
| caches.cpp | ||
| caches.h | ||
| chainstate.cpp | ||
| chainstate.h | ||
| chainstatemanager_args.cpp | ||
| chainstatemanager_args.h | ||
| coin.cpp | ||
| coin.h | ||
| coins_view_args.cpp | ||
| coins_view_args.h | ||
| connection_types.cpp | ||
| connection_types.h | ||
| context.cpp | ||
| context.h | ||
| database_args.cpp | ||
| database_args.h | ||
| eviction.cpp | ||
| eviction.h | ||
| interface_ui.cpp | ||
| interface_ui.h | ||
| interfaces.cpp | ||
| kernel_notifications.cpp | ||
| kernel_notifications.h | ||
| mempool_args.cpp | ||
| mempool_args.h | ||
| mempool_persist.cpp | ||
| mempool_persist.h | ||
| mempool_persist_args.cpp | ||
| mempool_persist_args.h | ||
| miner.cpp | ||
| miner.h | ||
| mini_miner.cpp | ||
| mini_miner.h | ||
| minisketchwrapper.cpp | ||
| minisketchwrapper.h | ||
| peerman_args.cpp | ||
| peerman_args.h | ||
| protocol_version.h | ||
| psbt.cpp | ||
| psbt.h | ||
| README.md | ||
| timeoffsets.cpp | ||
| timeoffsets.h | ||
| transaction.cpp | ||
| transaction.h | ||
| txreconciliation.cpp | ||
| txreconciliation.h | ||
| types.h | ||
| utxo_snapshot.cpp | ||
| utxo_snapshot.h | ||
| warnings.cpp | ||
| warnings.h | ||
src/node/
The src/node/ directory contains code that needs to access node state
(state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar
classes).
Code in src/node/ is meant to be segregated from code in
src/wallet/ and src/qt/, to ensure wallet and GUI
code changes don't interfere with node operation, to allow wallet and GUI code
to run in separate processes, and to perhaps eventually allow wallet and GUI
code to be maintained in separate source repositories.
As a rule of thumb, code in one of the src/node/,
src/wallet/, or src/qt/ directories should avoid
calling code in the other directories directly, and only invoke it indirectly
through the more limited src/interfaces/ classes.
This directory is at the moment
sparsely populated. Eventually more substantial files like
src/validation.cpp and
src/txmempool.cpp might be moved there.