Andrew Chow
039ef215bc
tests: Use descriptor that requires both legacy and segwit
...
Github-Pull: #24454
Rebased-From: 9f5ab670e7
2022-06-09 12:07:02 +01:00
Andrew Chow
5fd25eb9cb
tests: Calculate input weight more accurately
...
The external input test with specifying input weight would make a
pessimistic estimate of the input weight. However this would result in a
test failure as it is sometimes too pessimistic when an ECDSA signature
ends up being smaller than usual. To correct this, we can calculate the
input weight more accurately.
Github-Pull: #24454
Rebased-From: 8a04a386f7
2022-06-09 12:06:41 +01:00
Andrew Chow
bd6d3ac8b7
windeploy: Renewed windows code signing certificate
...
Github-Pull: #25201
Rebased-From: 7e9fe6d800
2022-06-09 12:05:50 +01:00
brunoerg
32fa522a80
test: ensure createmultisig and addmultisigaddress are not returning any warning for expected cases
...
Github-Pull: #25220
Rebased-From: 3a9b9bb38e
2022-06-09 12:05:17 +01:00
brunoerg
7658055c4e
rpc: fix inappropriate warning for address type p2sh-segwit in createmultisig and addmultisigaddress
...
Github-Pull: #25220
Rebased-From: eaf6f630c0
2022-06-09 12:05:04 +01:00
laanwj
c3936cc53d
Merge bitcoin/bitcoin#25241 : [23.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck
...
7fcac965977fcac96597
2022-05-30 19:47:36 +02:00
Martin Zumsande
7fcac96597
rpc: Capture potentially large UniValue by ref for rpcdoccheck
...
Github-Pull: 25237
Rebased-From: 20ff4991e5
2022-05-30 10:46:02 +02:00
laanwj
fcf6c8f4eb
doc: Update manual pages for 23.0
...
Tree-SHA512: 0e683e928e3c8e2e5534b8a28eb288445caeadf698e27d1c307cad8a8edb02c151ec245de4ed64fc6b7f137dfcb808fec410bd9f968f6d3f80ee3067563ca97a
2022-04-21 21:28:32 +02:00
laanwj
4253c619cf
build: Bump to final
...
Tree-SHA512: 389a841cb36dd8b9c99279d63473a10c83c09700b0077bd16f73d1141d5d79c1bdbba462f6fcb4c1917c28260bbf1359bf93bbe695b150adde23c4533d6c85cd
2022-04-21 21:23:55 +02:00
laanwj
9549b28c04
doc: Update manual pages for 23.0rc5
...
Tree-SHA512: cc721bc9a0a916a33979b17d98bfea1c569bd827072d651d8882ee674a0f14f0981bf22e3cd9eff384e580d6afd90c7310a1928d99f204833fce4d06a3287a67
2022-04-14 18:05:18 +02:00
laanwj
cf42ffdaca
qt: 23.0rc5 translations update
...
Tree-SHA512: 86a246bf5a817084f077ace118edad16dc48d06ec8d39476d82d6d6c5010bde9ec91eec00d7bd9736fc3ecfd1b67629f06e38798d484e6a0f09768553a52a231
2022-04-14 18:05:02 +02:00
laanwj
30ad7ac8fe
build: Bump rc to 23.0rc5
...
Tree-SHA512: 394d58796c13d8ce2cef2fc0f2dc364cd2736cefe019e4cf6bef82b773c2c8a8ecb77ead67014eab9046c40d416096a56ebfaaacac2d4485c40f1ec9c4659638
2022-04-14 17:26:41 +02:00
laanwj
dabac355c8
Merge bitcoin/bitcoin#24843 : [23.x] rc5 backports
...
a75b8ec836https://github.com/bitcoin/bitcoin/pull/24842
ACKs for top commit:
gruve-p:
ACK a75b8ec836a75b8ec836a75b8ec836a75b8ec836
2022-04-14 17:25:53 +02:00
fanquake
a75b8ec836
guix: fix GCC 10.3.0 + mingw-w64 setjmp/longjmp issues
...
This commit backports a patch to the GCC 10.3.0 we build for Windows
cross-compilation in Guix. The commit has been backported to the GCC
releases/gcc-10 branch, but hasn't yet made it into a release.
The patch corrects a regression from an earlier GCC commit, see:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=357c4350680bf29f0c7a115424e3da11c53b5582
and
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=074226d5aa86cd3de517014acfe34c7f69a2ccc7 ,
related to the way newer versions of mingw-w64 implement setjmp/longjmp.
Ultimately this was causing a crash for us when Windows users were
viewing the network traffic tab inside the GUI. After some period, long
enough that a buffer would need reallocating, a call into FreeTypes
gray_record_cell() would result in a call to ft_longjmp (longjmp), which
would then trigger a crash.
Fixes: https://github.com/bitcoin-core/gui/issues/582 .
See also:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=e8d1ca7d2c344a411779892616c423e157f4aea8 .
https://bugreports.qt.io/browse/QTBUG-93476 .
Github-Pull: #24842
Rebased-From: 457148a803
2022-04-13 13:49:04 +01:00
laanwj
b6253829c1
doc: Update manual pages for 23.0rc4
...
Tree-SHA512: 0124eaf86ef7324c14a77eafab8f53f0f3da83b19bc63922218051dd50bc154ab8e47f427fdc4ac5c2c3c34004ffd8e2df7ec134c66a16a78c4917a4ce1edae4
2022-04-08 16:06:51 +02:00
laanwj
d37081e483
qt: 23.0rc4 translations update
...
Tree-SHA512: 1bf7ac70963fc6361b5cd117612355e6d4b1862721441003eb7b11f8366a706cb83d45a46533bfad421d7ea0dd12931b4e37881818eb0f0be845de19b823f98c
2022-04-08 16:05:58 +02:00
laanwj
5f8635541e
build: Bump rc to 23.0rc4
...
Tree-SHA512: 18e4560c9b04d1270449ed1938b4c3ce9a903b1b65257e92947884f12a2d45e64e4074f8e7738c7ccb7076f696f9e7fb2056a55f856335a98eed143e0c1167f3
2022-04-08 15:53:50 +02:00
laanwj
308a2022c0
Merge bitcoin/bitcoin#24807 : [23.x] Final rc4 backports
...
e3e4be9cd569cc83df696374e24887#24770
* #24806
ACKs for top commit:
laanwj:
Commit list and code review ACK e3e4be9cd5e3e4be9cd5
2022-04-08 15:53:08 +02:00
Luke Dashjr
e3e4be9cd5
RPC: Switch getblockfrompeer back to standard param name blockhash
...
This commit partially reverts 923312fbf6#24806
Rebased-From: 88917f93cc
2022-04-08 13:27:19 +01:00
Jon Atack
69cc83df69
Add DEBUG_LOCKCONTENTION documentation to the developer notes
...
Github-Pull: #24770
Rebassedd-From: 4394733331
2022-04-08 13:27:02 +01:00
Jon Atack
6374e24887
Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive
...
Github-Pull: #24770
Rebased-From: 39a34b6877
2022-04-08 13:26:34 +01:00
MarcoFalke
1ea76767d0
Merge bitcoin/bitcoin#24755 : [23.x] Further build backports
...
39396ab593db8a5d6094https://github.com/bitcoin/bitcoin/pull/24733
* https://github.com/bitcoin/bitcoin/pull/24736
ACKs for top commit:
gruve-p:
ACK 39396ab59339396ab59339396ab593
2022-04-05 08:51:54 +02:00
Hennadii Stepanov
39396ab593
build: Fix "ERR: Unsigned tarballs do not exist"
...
Github-Pull: #24733
Rebased-From: 7762c5683f
2022-04-04 10:49:17 +01:00
fanquake
db8a5d6094
guix: fix vmov alignment issues with gcc 10.3.0 & mingw-w64
...
This introduces a patch to our GCC (10.3.0) mingw-w64 compiler, in Guix, to make
it avoid using aligned vmov instructions. This works around a longstanding issue
in GCC, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412 , which was recently
discovered to be causing issues, see #24726 .
Note that distros like Debian are also patching around this issue, and that is
where this patch comes from. This would also explain why we haven't run into this
problem earlier, in development builds. See:
https://salsa.debian.org/mingw-w64-team/gcc-mingw-w64/-/blob/master/debian/patches/vmov-alignment.patch .
Fixes #24726 .
Alternative to #24727 .
See also:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939559
Github-Pull: #24736
Rebased-From: d6fae988ef
2022-04-04 10:48:33 +01:00
MarcoFalke
e089c68aa1
Merge bitcoin/bitcoin#24725 : 23.0: rc4 backport
...
1448c993804f3ba8517a1448c993801448c993801448c99380
2022-04-01 08:48:42 +02:00
Hennadii Stepanov
1448c99380
wallet: Postpone NotifyWalletLoaded() for encrypted wallets
...
Too early NotifyWalletLoaded() call in CWallet::Create() results the
notification goes before DescriptorScriptPubKeyMans were created and
added to an encrypted wallet.
Co-authored-by: Andrew Chow <achow101-github@achow101.com>
Github-Pull: bitcoin/bitcoin#24711
Rebased-From: 0c12f0116c
2022-03-31 19:04:04 +02:00
Hennadii Stepanov
4f3ba8517a
wallet, refactor: Add wallet::NotifyWalletLoaded() function
...
This change is a prerequisite for the following bugfix.
Github-Pull: bitcoin/bitcoin#24711
Rebased-From: aeee419c6a
2022-03-31 19:04:02 +02:00
laanwj
e181e94e86
doc: Update manual pages for 23.0rc3
...
Tree-SHA512: 5350255e4260b85b7f294e980f9c47fb0aa8370965711411e37c16702cd3eee010ea83c2135b1e4fe6241402b9b1b478bc7f6a181f3e6da2c261a024b45aa8ae
2022-03-31 16:13:45 +02:00
laanwj
752c9d82a6
qt: 23.0rc3 translations update
...
Tree-SHA512: 110fab39faae351f10a9bb3a8a852d29f1e8e4bae27b790a52198fc39c5e1a2261c0fe8f0289f4c626e3d39f237c9410ae80f311bdcf446f778c680bc0fdc367
2022-03-31 16:13:38 +02:00
laanwj
2a1d3a48c4
build: Bump rc to 23.0rc3
...
Tree-SHA512: 558379b8b0e9e12a84b563d673377712950b425fd5862f68dddcecde14090e9566917e30720a82ddf8cb1132f02e21bab1ab93594f507e9ca34d039408ca15b4
2022-03-31 16:13:25 +02:00
fanquake
c243e08351
Merge bitcoin/bitcoin#24512 : 23.x backports
...
174af33d5dded10fe3ea26c2f23f3685f85c7e5feaa04194b9235b042594b05a59b69f65b966743c7a553d4e6541483962294690e8af135d24f612d1b1646f1bb5ef6a37b7c42a6fcf9c13#24468
- #24528
- #24527
- #24609
- #24555
- #24663
- #24572
- #24636
- #24553
- #24659
- #24521
- #24523
- #24690
- #24710
Possibly also:
- #24579
- #24691
ACKs for top commit:
laanwj:
List-of-commits ACK 174af33d5d174af33d5d
2022-03-31 12:19:22 +01:00
Hennadii Stepanov
174af33d5d
util: Add inotify_rm_watch to syscall sandbox (AllowFileSystem)
...
Github-Pull: bitcoin#24690
Rebased-From: f05a4cd
2022-03-31 10:38:11 +02:00
Hennadii Stepanov
ded10fe3ea
build: Fix Boost.Process test for Boost 1.78
...
Github-Pull: bitcoin#24523
Rebased-From: 532c64a
2022-03-31 10:38:09 +02:00
Hennadii Stepanov
26c2f23f36
build: Fix Boost.Process detection on macOS arm64
...
Could be tested as follows:
```
% brew install boost@1.76
% ./autogen.sh
% ./configure --with-boost='/opt/homebrew/opt/boost@1.76'
```
Github-Pull: bitcoin#24521
Rebased-From: 1d4157a
2022-03-31 10:37:15 +02:00
fanquake
85f85c7e5f
util: add linkat to syscall sandbox (AllowFileSystem)
...
Github-Pull: bitcoin#24659
Rebased-From: 9809db3
2022-03-31 10:30:14 +02:00
Sebastian Falbesoner
eaa04194b9
contrib: fix signet miner (sighash mismatch)
...
PSBT signing was changed to use SIGHASH_DEFAULT by default in #22514 .
The signet miner script sets the sighash type of the created PSBT to
SIGHASH_ALL, hence this leads to a sighash mismatch when the
`walletprocesspsbt` RPC is called. Fix this by explicitly passing the
correct sighash type.
Note that the same change was needed in one of our functional tests,
see commit d3992669df12cc020
2022-03-31 10:30:12 +02:00
MarcoFalke
235b042594
rpc: Exclude descriptor when address is excluded
...
Github-Pull: bitcoin#24636
Rebased-From: faf37c2
2022-03-31 10:30:10 +02:00
MarcoFalke
b05a59b69f
ci: Temporarily use clang-13 to work around clang-14 TSan bug
...
Github-Pull: bitcoin#24572
Rebased-From: fa43933
2022-03-31 10:30:07 +02:00
Jon Atack
65b966743c
doc, init: add links to doc/cjdns.md
...
Github-Pull: bitcoin#24663
Rebased-From: daae288
2022-03-31 10:30:05 +02:00
Jon Atack
7a553d4e65
doc: update i2p.md with cjdns, improve local addresses section
...
Github-Pull: bitcoin#24555
Rebased-From: f44efc3
2022-03-31 10:30:02 +02:00
Jon Atack
4148396229
doc: update tor.md with cjdns and getnodeaddresses, fix tor grep,
...
and improve local addresses section
Github-Pull: bitcoin#24555
Rebased-From: 3bf6f0c
2022-03-31 10:29:25 +02:00
Jon Atack
4690e8af13
doc: create initial doc/cjdns.md for cjdns how-to documentation
...
Adapted in part from the CJDNS description in #23077 by Vasil Dimov
and from CJDNS documentation and feedback by Caleb James DeLisle.
Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
Github-Pull: bitcoin#24555
Rebased-From: ed15848
2022-03-31 10:28:29 +02:00
Jon Atack
5d24f612d1
Clarify in -maxtimeadjustment that only outbound peers influence time data
...
Github-Pull: bitcoin#24609
Rebased-From: 1bba72d
2022-03-28 12:49:51 +02:00
MarcoFalke
7d03cf632d
Merge bitcoin/bitcoin#24596 : [23.x] GUI backports
...
70f2c579b9642f2726de940694664dfc421d4c8cbitcoin-core/gui#555
- bitcoin-core/gui#568
ACKs for top commit:
Sjors:
utACK 70f2c579b970f2c579b9
2022-03-24 08:12:11 +01:00
Vasil Dimov
70f2c579b9
options: flip listenonion to false if not listening
...
If the user has unchecked "Allow incoming connections" in
`Settings->Options...->Network` then `fListen=false` is saved in
`~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false`
during startup, but leaves `-listenonion` to `true`.
This flipping of `-listen` is done in `OptionsModel::Init()` after
`InitParameterInteraction()` has been executed which would have flipped
`-listenonion`, should it have seen `-listen` being `false`
(this is a difference between `bitcoind` and `bitcoin-qt`).
Fixes: https://github.com/bitcoin-core/gui/issues/567
Github-Pull: bitcoin-core/gui#568
Rebased-From: 7f90dc26c8
2022-03-23 17:26:19 +01:00
laanwj
55a60b9718
Merge bitcoin/bitcoin#24593 : [23.x] macOS / build backports
...
61c021605ff541a252f6dd2c7f71fd2e7cde8f687f6420c833de528793b6#24549
* #24573
* #24588
* #24597
ACKs for top commit:
laanwj:
Code review ACK 61c021605f
2022-03-17 09:47:42 +01:00
Hennadii Stepanov
61c021605f
doc, guix: Include arm64-apple-darwin into codesigned archs
...
Github-Pull: #24597
Rebased-From: 1f4801b6b1
2022-03-17 08:38:58 +00:00
Sjors Provoost
642f2726de
gui: restore Send for external signer
...
Before this change the send confirmation dialog would keep the Send option disabled. The Create Unsigned choice would actually send. This is potentially confusing.
With this change the Create Unsigned button will not attempt to sign and always produce a PSBT. The Send button will attempt to sign, and only return a PSBT if more signatures are needed.
When using an external signer, the Create Unsigned option only appears when PSBT controls are enabled in the wallet settings.
This commit maintains the pre-existing behavior of filling the PSBT (without signing) even when not using an external signer.
Closes #551
Co-authored-by: Jon Atack <jon@atack.com>
Github-Pull: bitcoin-core/gui#555
Rebased-From: 2efdfb88aa
2022-03-17 07:28:50 +01:00
Sjors Provoost
940694664d
refactor: helper function signWithExternalSigner()
...
Does not change behavior.
Review hint:
git show --color-moved --color-moved-ws=allow-indentation-change
Github-Pull: bitcoin-core/gui#555
Rebased-From: 4b5a6cd149
2022-03-17 07:28:50 +01:00
Sjors Provoost
fc421d4c8c
move-only: helper function to present PSBT
...
This commit does not change behavior.
Review hint:
git show --color-moved --color-moved-ws=allow-indentation-change
Github-Pull: bitcoin-core/gui#555
Rebased-From: 026b5b4523
2022-03-17 07:28:50 +01:00
