Hennadii Stepanov
404373bc6a
qt, refactor: Pass WalletModel object to WalletView constructor
...
An instance of the WalletView class without walletModel data member
being set is invalid. So, it is better to set it in the constructor.
2021-08-26 16:27:56 +03:00
Hennadii Stepanov
fcdc8b0fcb
qt, refactor: Drop redundant signalling in WalletView::setWalletModel
...
This job will be done by WalletFrame::currentWalletSet signal being
emitted in the WalletFrame::setCurrentWallet function.
2021-08-14 19:19:03 +03:00
Hennadii Stepanov
37dcf161d3
qt, refactor: Emit WalletView::encryptionStatusChanged signal directly
2021-08-14 19:19:03 +03:00
Prateek Sancheti
0237d95323
qt: Add Load PSBT functionaliy with nowallet
2021-08-11 15:40:39 +05:30
Hennadii Stepanov
793f19599b
qt: Drop redundant WalletView::requestedSyncWarningInfo slot
...
This change makes a connection directly to the signal that was emitted
in the removed slot.
This commit does not change behavior.
2021-06-06 01:04:14 +03:00
Hennadii Stepanov
be1c512437
Merge bitcoin-core/gui#343 : Improve the GUI responsiveness when progress dialogs are used
...
4935ac583b75850106aehttps://doc.qt.io/qt-5/qprogressdialog.html ) estimates the time the operation will take (based on time for steps), and only shows itself if that estimate is beyond [`minimumDuration`](https://doc.qt.io/qt-5/qprogressdialog.html#minimumDuration-prop ).
The default `minimumDuration` value is [4 seconds](https://doc.qt.io/qt-5/qprogressdialog.html#details ), and it could make users think that the GUI is frozen.
This PR sets `minimumDuration` to zero for all progress dialogs, that affects ones in the `WalletControllerActivity` class.
ACKs for top commit:
ryanofsky:
Code review ACK 4935ac583b4935ac583b4935ac583b
2021-05-29 17:15:21 +03:00
Hennadii Stepanov
4935ac583b
qt: Improve GUI responsiveness
...
QProgressDialog estimates the time the operation will take (based on
time for steps), and only shows itself if that estimate is beyond
minimumDuration. The default minimumDuration value is 4 seconds, and it
could make users think that the GUI is frozen.
2021-05-22 22:04:27 +03:00
Hennadii Stepanov
8b77133651
qt: Replace disambiguation strings with translator comments
...
Translator comments is the right way to pass context to translators.
2021-05-16 01:06:22 +03:00
Hennadii Stepanov
cdbc2bd1f1
qt: Use template function qOverload in signal-slot connections
...
This commit does not change behavior.
2021-04-30 00:00:44 +03:00
Hennadii Stepanov
88df300f20
qt: Do not translate file extensions
2021-03-06 20:49:46 +02:00
Hennadii Stepanov
f886a20b02
qt, wallet: Drop unused parameter in Wallet{Frame|View}::encryptWallet
2020-10-23 20:09:55 +03:00
Hennadii Stepanov
6e950118a3
qt, wallet: Remove unused AskPassphraseDialog::Decrypt
...
Co-authored-by: Sehyun Chung <sehyun@berkeley.edu>
2020-10-23 19:55:23 +03:00
MarcoFalke
cccc2784a3
scripted-diff: Move ui_interface to the node lib
...
-BEGIN VERIFY SCRIPT-
# Move files
git mv src/ui_interface.h src/node/ui_interface.h
git mv src/ui_interface.cpp src/node/ui_interface.cpp
sed -i -e 's/BITCOIN_UI_INTERFACE_H/BITCOIN_NODE_UI_INTERFACE_H/g' src/node/ui_interface.h
# Adjust includes and makefile
sed -i -e 's|ui_interface|node/ui_interface|g' $(git grep -l ui_interface)
# Sort includes
git diff -U0 | clang-format-diff -p1 -i -v
-END VERIFY SCRIPT-
2020-06-27 11:49:28 -04:00
Hennadii Stepanov
4f9d9efb4e
qt: Remove needless headers
2020-06-24 14:10:01 +03:00
Glenn Willen
11a0ffb29d
[gui] Load PSBT from clipboard
2020-06-19 02:20:04 -07:00
Glenn Willen
a6cb0b0c29
[gui] PSBT Operations Dialog (sign & broadcast)
...
Add a "PSBT Operations" dialog, reached from the "Load PSBT..." menu
item, giving options to sign or broadcast the loaded PSBT as
appropriate, as well as copying the result to the clipboard or saving
it to a file.
2020-06-19 02:20:04 -07:00
fanquake
a8327fd71f
Merge #19072 : doc: Expand section on Getting Started
...
facef3d413fae2fb2a19100000d1b2fab893e0cafacef3d413facef3d413
2020-06-01 15:38:57 +08:00
Jonas Schnelli
5f75c5e7df
Merge #16432 : qt: Add privacy to the Overview page
...
8d7511584473d8ef7274Closes #16407
Privacy mode is OFF (the default behavior):
Privacy mode is ON:
ACKs for top commit:
jonatack:
Tested ACK 8d751158d75115844
2020-05-29 08:55:16 +02:00
MarcoFalke
fab893e0ca
doc: Fix unrelated typos reported by codespell
2020-05-27 12:37:08 -04:00
Hennadii Stepanov
8d75115844
qt: Add privacy feature to Overview page
2020-05-27 11:55:44 +03:00
Russell Yanofsky
2bc9b92ed8
Cancel wallet balance timer when shutdown requested
...
This doesn't fix any current problem, but it makes balance checking code less
fragile, and prevents use-after free travis error in next commit:
https://travis-ci.org/github/bitcoin/bitcoin/jobs/675367629#L4240
2020-05-01 06:59:09 -04:00
Samuel Dobson
4f802e59a0
Merge #17509 : gui: save and load PSBT
...
764bfe4cba1cd8dc2556f6895301f71d05a9d80b86e22d23bb6ab3aad9a5https://user-images.githubusercontent.com/10217/71765684-ba60d580-2f32-11ea-8dea-0c4398eb6e15.png ">
<img width="287" alt="Schermafbeelding 2020-01-04 om 20 40 35" src="https://user-images.githubusercontent.com/10217/71765677-a0bf8e00-2f32-11ea-8172-12dfd34a89f3.png ">
<img width="594" alt="Schermafbeelding 2020-01-04 om 20 41 12" src="https://user-images.githubusercontent.com/10217/71765681-aa48f600-2f32-11ea-8e2c-c4f6bf9f5309.png ">
<img width="632" alt="Schermafbeelding 2020-01-04 om 20 41 28" src="https://user-images.githubusercontent.com/10217/71765691-d19fc300-2f32-11ea-97ff-70f5dd59987a.png ">
By default the file name contains the destination address(es) and amount(s).
We only use the binary format for files, in order to avoid compatibility hell. If we do want to add base64 file format support, we should use a different extension for that (`.psbt64`?).
## Load flow
Select a file:
<img width="649" alt="Schermafbeelding 2020-01-04 om 21 08 57" src="https://user-images.githubusercontent.com/10217/71766089-2ba28780-2f37-11ea-875d-074794b5707d.png ">
Offer to send if complete:
<img width="308" alt="Schermafbeelding 2020-01-04 om 21 09 06" src="https://user-images.githubusercontent.com/10217/71766088-2a715a80-2f37-11ea-807d-394c8b840c59.png ">
Tell user if signatures are missing, offer to copy to clipboard:
<img width="308" alt="Schermafbeelding 2020-01-04 om 21 15 57" src="https://user-images.githubusercontent.com/10217/71766115-702e2300-2f37-11ea-9f62-a6ede499c0fa.png ">
Incomplete for another reason:
<img width="309" alt="Schermafbeelding 2020-01-04 om 21 07 51" src="https://user-images.githubusercontent.com/10217/71766090-2c3b1e00-2f37-11ea-8a22-6188377b67a1.png ">
ACKs for top commit:
instagibbs:
re-ACK 764bfe4cba764bfe4cba764bfe4cba764bfe4c764bfe4cba
2020-04-23 13:16:23 +12:00
MarcoFalke
fa488f131f
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2020-04-16 13:33:09 -04:00
Sjors Provoost
1cd8dc2556
[gui] load PSBT
...
co-authored-by: Glenn Willen <gwillen@nerdnet.org>
2020-03-27 14:59:19 +01:00
João Barbosa
cb8a86d9f9
gui: Remove WalletView and BitcoinGUI circular dependency
2020-01-30 11:38:06 +00:00
João Barbosa
ac3d10777d
gui: Add transactionClicked and coinsSent signals to WalletView
2020-01-30 11:31:07 +00:00
MarcoFalke
aaaaad6ac9
scripted-diff: Bump copyright of files changed in 2019
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2019-12-30 10:42:20 +13:00
Andrew Chow
2c530ea2ad
HTML escape address labels in more dialogs and notifications
2019-09-08 16:40:37 -04:00
Andrew Chow
1770a972d4
HTML escape the wallet name in more dialogs and notifications
2019-09-08 16:40:05 -04:00
João Barbosa
d2ae6be80f
gui: Set progressDialog to nullptr
2019-06-02 22:18:19 +01:00
Hennadii Stepanov
7c572c488d
Add workaround for QProgressDialog bug on macOS
...
See: QTBUG-65750, QTBUG-70357.
2019-01-15 01:28:00 +02:00
practicalswift
9096276e0b
Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)
...
Qt-only changes.
2019-01-13 03:25:14 -08:00
João Barbosa
6fc21aca6d
qt: Use GUIUtil::bringToFront where possible
2018-11-05 11:21:50 +00:00
João Barbosa
f78558f1e3
qt: Use new Qt5 connect syntax
2018-08-21 09:43:54 +01:00
DrahtBot
eb7daf4d60
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
João Barbosa
12dd101345
scripted-diff: Remove trailing whitespaces
...
-BEGIN VERIFY SCRIPT-
sed --in-place'' --regexp-extended 's/[[:space:]]+$//g' $(git grep -I --files-with-matches --extended-regexp '[[:space:]]+$' -- src test ':!*.svg' ':!src/crypto/sha256_sse4*' ':!src/leveldb' ':!src/qt/locale' ':!src/secp256k1' ':!src/univalue')
-END VERIFY SCRIPT-
2018-07-24 20:46:23 +01:00
Andrew Chow
69b01e6f8b
Add cancel button to rescan progress dialog
...
Adds a cancel button to the rescan progress dialog. When it is clicked,
AbortRescan is called to abort a rescan
2018-04-12 17:00:30 -04:00
Russell Yanofsky
17780d6f35
scripted-diff: Avoid interface keyword to fix windows gitian build
...
Rename `interface` to `interfaces`
Build failure reported by Chun Kuan Lee <ken2812221@gmail.com>
https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-379434756
-BEGIN VERIFY SCRIPT-
git mv src/interface src/interfaces
ren() { git grep -l "$1" | xargs sed -i "s,$1,$2,g"; }
ren interface/ interfaces/
ren interface:: interfaces::
ren BITCOIN_INTERFACE_ BITCOIN_INTERFACES_
ren "namespace interface" "namespace interfaces"
-END VERIFY SCRIPT-
2018-04-07 03:42:02 -04:00
Russell Yanofsky
a0704a8996
Remove most direct bitcoin calls from qt/walletmodel.cpp
2018-04-04 16:52:40 -04:00
Russell Yanofsky
fe6f27e6ea
Remove direct bitcoin calls from qt/clientmodel.cpp
2018-04-04 16:52:40 -04:00
Jonas Schnelli
12d8d2681e
Qt: When multiple wallets are used, include in notifications the name
2018-03-26 18:40:26 +07:00
Luke Dashjr
85d5319716
Qt: Ensure UI updates only come from the currently selected walletView
2018-03-06 12:03:26 +08:00
Sjors Provoost
e7d9fc5c53
[qt] navigate to transaction history page after send
...
The transaction will be selected. When sending to multiple
destinations, all will be selected (thanks @promag).
2018-03-01 10:40:36 +01:00
Akira Takizawa
595a7bab23
Increment MIT Licence copyright header year on files modified in 2017
2018-01-03 02:26:56 +09:00
MeshCollider
1a445343f6
scripted-diff: Replace #include "" with #include <> (ryanofsky)
...
-BEGIN VERIFY SCRIPT-
for f in \
src/*.cpp \
src/*.h \
src/bench/*.cpp \
src/bench/*.h \
src/compat/*.cpp \
src/compat/*.h \
src/consensus/*.cpp \
src/consensus/*.h \
src/crypto/*.cpp \
src/crypto/*.h \
src/crypto/ctaes/*.h \
src/policy/*.cpp \
src/policy/*.h \
src/primitives/*.cpp \
src/primitives/*.h \
src/qt/*.cpp \
src/qt/*.h \
src/qt/test/*.cpp \
src/qt/test/*.h \
src/rpc/*.cpp \
src/rpc/*.h \
src/script/*.cpp \
src/script/*.h \
src/support/*.cpp \
src/support/*.h \
src/support/allocators/*.h \
src/test/*.cpp \
src/test/*.h \
src/wallet/*.cpp \
src/wallet/*.h \
src/wallet/test/*.cpp \
src/wallet/test/*.h \
src/zmq/*.cpp \
src/zmq/*.h
do
base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f
done
-END VERIFY SCRIPT-
2017-11-16 08:23:01 +13:00
practicalswift
76fed838f3
Avoid NULL pointer dereference when _walletModel is NULL (which is valid)
2017-10-02 17:20:08 +02:00
practicalswift
90d4d89230
scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL
...
-BEGIN VERIFY SCRIPT-
sed -i 's/\<NULL\>/nullptr/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h src/qt/*/*.cpp src/qt/*/*.h src/wallet/*/*.cpp src/wallet/*/*.h src/support/allocators/*.h
sed -i 's/Prefer nullptr, otherwise SAFECOOKIE./Prefer NULL, otherwise SAFECOOKIE./g' src/torcontrol.cpp
sed -i 's/tor: Using nullptr authentication/tor: Using NULL authentication/g' src/torcontrol.cpp
sed -i 's/METHODS=nullptr/METHODS=NULL/g' src/test/torcontrol_tests.cpp src/torcontrol.cpp
sed -i 's/nullptr certificates/NULL certificates/g' src/qt/paymentserver.cpp
sed -i 's/"nullptr"/"NULL"/g' src/torcontrol.cpp src/test/torcontrol_tests.cpp
-END VERIFY SCRIPT-
2017-08-07 07:36:37 +02:00
isle2983
27765b6403
Increment MIT Licence copyright header year on files modified in 2016
...
Edited via:
$ contrib/devtools/copyright_header.py update .
2016-12-31 11:01:21 -07:00
Jonas Schnelli
24f72e9f3f
Merge #8371 : [Qt] Add out-of-sync modal info layer
...
08827dfd8b062ee3245b4e47052fa001f18bd44a040904c3c
2016-09-23 18:22:48 +02:00
Jonas Schnelli
08827df3ec
[Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul
2016-09-23 16:07:21 +02:00
