mirrors/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-10 09:06:15 +01:00
Code Issues Projects Releases Wiki Activity

[p2p] add TxDownloadOptions bool to make TxRequestTracker deterministic

Browse source 
Forward this bool to the TxRequestTracker ctor. This is needed for
stablity in TxDownloadManager fuzzers
This commit is contained in:
glozow 2024-08-27 12:12:12 +01:00
parent f803c8ce8d
commit fa584cbe72
3 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/net_processing.cpp
View file

@ -1889,7 +1889,7 @@ PeerManagerImpl::PeerManagerImpl(CConnman& connman, AddrMan& addrman,
m_banman(banman), m_banman(banman),
m_chainman(chainman), m_chainman(chainman),
m_mempool(pool), m_mempool(pool),
m_txdownloadman(node::TxDownloadOptions{pool, m_rng, opts.max_orphan_txs}), m_txdownloadman(node::TxDownloadOptions{pool, m_rng, opts.max_orphan_txs, opts.deterministic_rng}),
m_warnings{warnings}, m_warnings{warnings},
m_opts{opts} m_opts{opts}
{ {

2
src/node/txdownloadman.h
View file

@ -43,6 +43,8 @@ struct TxDownloadOptions {
FastRandomContext& m_rng; FastRandomContext& m_rng;
/** Maximum number of transactions allowed in orphanage. */ /** Maximum number of transactions allowed in orphanage. */
const uint32_t m_max_orphan_txs; const uint32_t m_max_orphan_txs;
/** Instantiate TxRequestTracker as deterministic (used for tests). */
bool m_deterministic_txrequest{false};
}; };
struct TxDownloadConnectionInfo { struct TxDownloadConnectionInfo {
/** Whether this peer is preferred for transaction download. */ /** Whether this peer is preferred for transaction download. */

2
src/node/txdownloadman_impl.h
View file

@ -128,7 +128,7 @@ public:
return *m_lazy_recent_confirmed_transactions; return *m_lazy_recent_confirmed_transactions;
} }
TxDownloadManagerImpl(const TxDownloadOptions& options) : m_opts{options} {} TxDownloadManagerImpl(const TxDownloadOptions& options) : m_opts{options}, m_txrequest{options.m_deterministic_txrequest} {}
struct PeerInfo { struct PeerInfo {
/** Information relevant to scheduling tx requests. */ /** Information relevant to scheduling tx requests. */