mirrors/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-13 11:35:20 +01:00
Code Issues Projects Releases Wiki Activity

wallet, logging: Switch LogInfo to LogError in AddWalletDescriptor

Browse source 
Seems like all of these cases are treated as errors, so it makes sense to use
the corresponding log level.

Change suggested by hodlinator in https://github.com/bitcoin/bitcoin/pull/30343#discussion_r1655434943
This commit is contained in:
Ryan Ofsky 2024-06-26 22:18:07 -04:00
parent b7e37883da
commit e8c6095c75
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/wallet/wallet.cpp
View file

@ -3948,13 +3948,13 @@ ScriptPubKeyMan* CWallet::AddWalletDescriptor(WalletDescriptor& desc, const Flat
AssertLockHeld(cs_wallet);
if (!IsWalletFlagSet(WALLET_FLAG_DESCRIPTORS)) {
LogInfo(m_log, "Cannot add WalletDescriptor to a non-descriptor wallet\n");
LogError(m_log, "Cannot add WalletDescriptor to a non-descriptor wallet\n");
return nullptr;
}
auto spk_man = GetDescriptorScriptPubKeyMan(desc);
if (spk_man) {
LogInfo(m_log, "Update existing descriptor: %s\n", desc.descriptor->ToString());
LogError(m_log, "Update existing descriptor: %s\n", desc.descriptor->ToString());
spk_man->UpdateWalletDescriptor(desc);
} else {
auto new_spk_man = std::unique_ptr<DescriptorScriptPubKeyMan>(new DescriptorScriptPubKeyMan(*this, desc, m_keypool_size));
@ -3973,7 +3973,7 @@ ScriptPubKeyMan* CWallet::AddWalletDescriptor(WalletDescriptor& desc, const Flat
// Top up key pool, the manager will generate new scriptPubKeys internally
if (!spk_man->TopUp()) {
LogInfo(m_log, "Could not top up scriptPubKeys\n");
LogError(m_log, "Could not top up scriptPubKeys\n");
return nullptr;
}
@ -3982,7 +3982,7 @@ ScriptPubKeyMan* CWallet::AddWalletDescriptor(WalletDescriptor& desc, const Flat
if (!desc.descriptor->IsRange()) {
auto script_pub_keys = spk_man->GetScriptPubKeys();
if (script_pub_keys.empty()) {
LogInfo(m_log, "Could not generate scriptPubKeys (cache is empty)\n");
LogError(m_log, "Could not generate scriptPubKeys (cache is empty)\n");
return nullptr;
}