Merge bitcoin/bitcoin#25963: CBlockLocator: performance-move-const-arg Clang tidy fixup

6b24dfe24d CBlockLocator: performance-move-const-arg Clang tidy fixups (Jon Atack)

Pull request description:

  Fix Clang-tidy CI errors on master.  See https://cirrus-ci.com/task/4806752200818688?logs=ci#L4696 for an example.

ACKs for top commit:
  MarcoFalke:
    review ACK 6b24dfe24d
  vasild:
    ACK 6b24dfe24d

Tree-SHA512: 7a67acf7b42da07b63fbb392236e9a7be8cf35c36e37ca980c4467fe8295c2eda8aef10f41a1e3036cd9ebece47fa957fc3256033f853bd6a97ce2ca42799a0a
This commit is contained in:
MacroFake 2022-08-31 15:59:52 +02:00
commit b936123110
No known key found for this signature in database
GPG Key ID: CE2B75697E69A548
2 changed files with 2 additions and 2 deletions

View File

@ -49,7 +49,7 @@ std::vector<uint256> LocatorEntries(const CBlockIndex* index)
CBlockLocator GetLocator(const CBlockIndex* index)
{
return CBlockLocator{std::move(LocatorEntries(index))};
return CBlockLocator{LocatorEntries(index)};
}
CBlockLocator CChain::GetLocator() const

View File

@ -123,7 +123,7 @@ struct CBlockLocator
CBlockLocator() {}
explicit CBlockLocator(const std::vector<uint256>& vHaveIn) : vHave(vHaveIn) {}
explicit CBlockLocator(std::vector<uint256>&& have) : vHave(std::move(have)) {}
SERIALIZE_METHODS(CBlockLocator, obj)
{