mirror of
https://github.com/bitcoin/bitcoin.git
synced 2024-11-19 09:53:47 +01:00
Fix issues identified by codespell 2.2.1 and update ignored words
and also fix spelling in test/lint/lint-locale-dependence.py not caught by the spelling linter and fix up a paragraph we are touching here in test/README.md.
This commit is contained in:
parent
8f2010de6e
commit
b6a65568df
@ -858,7 +858,7 @@ public:
|
||||
* @brief Retrieves all benchmark results collected by the bench object so far.
|
||||
*
|
||||
* Each call to run() generates a Result that is stored within the Bench instance. This is mostly for advanced users who want to
|
||||
* see all the nitty gritty detials.
|
||||
* see all the nitty gritty details.
|
||||
*
|
||||
* @return All results collected so far.
|
||||
*/
|
||||
|
@ -216,7 +216,7 @@ static bool AppInit(NodeContext& node, int argc, char* argv[])
|
||||
if (token) { // Success
|
||||
exit(EXIT_SUCCESS);
|
||||
} else { // fRet = false or token read error (premature exit).
|
||||
tfm::format(std::cerr, "Error during initializaton - check debug.log for details\n");
|
||||
tfm::format(std::cerr, "Error during initialization - check debug.log for details\n");
|
||||
exit(EXIT_FAILURE);
|
||||
}
|
||||
}
|
||||
|
@ -314,7 +314,7 @@ BOOST_FIXTURE_TEST_CASE(chainstatemanager_activate_snapshot, TestChain100Setup)
|
||||
|
||||
//! Test LoadBlockIndex behavior when multiple chainstates are in use.
|
||||
//!
|
||||
//! - First, verfiy that setBlockIndexCandidates is as expected when using a single,
|
||||
//! - First, verify that setBlockIndexCandidates is as expected when using a single,
|
||||
//! fully-validating chainstate.
|
||||
//!
|
||||
//! - Then mark a region of the chain BLOCK_ASSUMED_VALID and introduce a second chainstate
|
||||
|
@ -338,7 +338,7 @@ RPCHelpMan sendmany()
|
||||
{"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
|
||||
"\"" + FeeModes("\"\n\"") + "\""},
|
||||
{"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/vB."},
|
||||
{"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra infomration about the transaction."},
|
||||
{"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
|
||||
},
|
||||
{
|
||||
RPCResult{"if verbose is not set or set to false",
|
||||
|
@ -30,7 +30,7 @@ static void GroupCoins(FuzzedDataProvider& fuzzed_data_provider, const std::vect
|
||||
bool valid_outputgroup{false};
|
||||
for (auto& coin : coins) {
|
||||
output_group.Insert(coin, /*ancestors=*/0, /*descendants=*/0, positive_only);
|
||||
// If positive_only was specified, nothing may have been inserted, leading to an empty outpout group
|
||||
// If positive_only was specified, nothing may have been inserted, leading to an empty output group
|
||||
// that would be invalid for the BnB algorithm
|
||||
valid_outputgroup = !positive_only || output_group.GetSelectionAmount() > 0;
|
||||
if (valid_outputgroup && fuzzed_data_provider.ConsumeBool()) {
|
||||
|
@ -272,8 +272,8 @@ gdb /home/example/bitcoind <pid>
|
||||
Note: gdb attach step may require ptrace_scope to be modified, or `sudo` preceding the `gdb`.
|
||||
See this link for considerations: https://www.kernel.org/doc/Documentation/security/Yama.txt
|
||||
|
||||
Often while debugging rpc calls from functional tests, the test might reach timeout before
|
||||
process can return a response. Use `--timeout-factor 0` to disable all rpc timeouts for that partcular
|
||||
Often while debugging RPC calls in functional tests, the test might time out before the
|
||||
process can return a response. Use `--timeout-factor 0` to disable all RPC timeouts for that particular
|
||||
functional test. Ex: `test/functional/wallet_hd.py --timeout-factor 0`.
|
||||
|
||||
##### Profiling
|
||||
|
@ -1007,13 +1007,13 @@ def spenders_taproot_active():
|
||||
# input a valid signature with the passed pk followed by a dummy push of bytes that are to be dropped, and
|
||||
# will execute sigops signature checks.
|
||||
SIGOPS_RATIO_SCRIPTS = [
|
||||
# n OP_CHECKSIGVERFIYs and 1 OP_CHECKSIG.
|
||||
# n OP_CHECKSIGVERIFYs and 1 OP_CHECKSIG.
|
||||
lambda n, pk: (CScript([OP_DROP, pk] + [OP_2DUP, OP_CHECKSIGVERIFY] * n + [OP_CHECKSIG]), n + 1),
|
||||
# n OP_CHECKSIGVERIFYs and 1 OP_CHECKSIGADD, but also one unexecuted OP_CHECKSIGVERIFY.
|
||||
lambda n, pk: (CScript([OP_DROP, pk, OP_0, OP_IF, OP_2DUP, OP_CHECKSIGVERIFY, OP_ENDIF] + [OP_2DUP, OP_CHECKSIGVERIFY] * n + [OP_2, OP_SWAP, OP_CHECKSIGADD, OP_3, OP_EQUAL]), n + 1),
|
||||
# n OP_CHECKSIGVERIFYs and 1 OP_CHECKSIGADD, but also one unexecuted OP_CHECKSIG.
|
||||
lambda n, pk: (CScript([random_bytes(220), OP_2DROP, pk, OP_1, OP_NOTIF, OP_2DUP, OP_CHECKSIG, OP_VERIFY, OP_ENDIF] + [OP_2DUP, OP_CHECKSIGVERIFY] * n + [OP_4, OP_SWAP, OP_CHECKSIGADD, OP_5, OP_EQUAL]), n + 1),
|
||||
# n OP_CHECKSIGVERFIYs and 1 OP_CHECKSIGADD, but also one unexecuted OP_CHECKSIGADD.
|
||||
# n OP_CHECKSIGVERIFYs and 1 OP_CHECKSIGADD, but also one unexecuted OP_CHECKSIGADD.
|
||||
lambda n, pk: (CScript([OP_DROP, pk, OP_1, OP_IF, OP_ELSE, OP_2DUP, OP_6, OP_SWAP, OP_CHECKSIGADD, OP_7, OP_EQUALVERIFY, OP_ENDIF] + [OP_2DUP, OP_CHECKSIGVERIFY] * n + [OP_8, OP_SWAP, OP_CHECKSIGADD, OP_9, OP_EQUAL]), n + 1),
|
||||
# n+1 OP_CHECKSIGs, but also one OP_CHECKSIG with an empty signature.
|
||||
lambda n, pk: (CScript([OP_DROP, OP_0, pk, OP_CHECKSIG, OP_NOT, OP_VERIFY, pk] + [OP_2DUP, OP_CHECKSIG, OP_VERIFY] * n + [OP_CHECKSIG]), n + 1),
|
||||
|
@ -250,7 +250,7 @@ def main():
|
||||
exit_code = 1
|
||||
|
||||
if exit_code == 1:
|
||||
print("Unnecessary locale depedence can cause bugs that are very tricky to isolate and fix. Please avoid using locale dependent functions if possible.\n")
|
||||
print("Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. Please avoid using locale-dependent functions if possible.\n")
|
||||
print(f"Advice not applicable in this specific case? Add an exception by updating the ignore list in {sys.argv[0]}")
|
||||
|
||||
sys.exit(exit_code)
|
||||
|
@ -1,21 +1,23 @@
|
||||
asend
|
||||
ba
|
||||
blockin
|
||||
bu
|
||||
cachable
|
||||
creat
|
||||
desig
|
||||
clen
|
||||
fo
|
||||
fpr
|
||||
hights
|
||||
hist
|
||||
inout
|
||||
inflight
|
||||
invokable
|
||||
keypair
|
||||
mor
|
||||
nd
|
||||
nin
|
||||
ser
|
||||
siz
|
||||
stap
|
||||
unparseable
|
||||
unser
|
||||
useable
|
||||
warmup
|
||||
wit
|
||||
|
Loading…
Reference in New Issue
Block a user