mirrors/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2024-11-20 02:25:40 +01:00
Code Issues Projects Releases Wiki Activity

refactor: Simplify ApplyStats and ApplyHash

Browse Source
This commit is contained in:
Fabian Jahr 2021-02-21 23:09:50 +01:00
parent 9c8a265fd2
commit a8a46c4b3c
No known key found for this signature in database
GPG Key ID: F13D1E9D890798CD
1 changed files with 39 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
src/node/coinstats.cpp
View File

@ -26,8 +26,21 @@ static uint64_t GetBogoSize(const CScript& scriptPubKey)
scriptPubKey.size() /* scriptPubKey */; scriptPubKey.size() /* scriptPubKey */;
} }
static void ApplyHash(CCoinsStats& stats, CHashWriter& ss, const uint256& hash, const std::map<uint32_t, Coin>& outputs, std::map<uint32_t, Coin>::const_iterator it) //! Warning: be very careful when changing this! assumeutxo and UTXO snapshot
//! validation commitments are reliant on the hash constructed by this
//! function.
//!
//! If the construction of this hash is changed, it will invalidate
//! existing UTXO snapshots. This will not result in any kind of consensus
//! failure, but it will force clients that were expecting to make use of
//! assumeutxo to do traditional IBD instead.
//!
//! It is also possible, though very unlikely, that a change in this
//! construction could cause a previously invalid (and potentially malicious)
//! UTXO snapshot to be considered valid.
static void ApplyHash(CHashWriter& ss, const uint256& hash, const std::map<uint32_t, Coin>& outputs)
{ {
for (auto it = outputs.begin(); it != outputs.end(); ++it) {
if (it == outputs.begin()) { if (it == outputs.begin()) {
ss << hash; ss << hash;
ss << VARINT(it->second.nHeight * 2 + it->second.fCoinBase ? 1u : 0u); ss << VARINT(it->second.nHeight * 2 + it->second.fCoinBase ? 1u : 0u);
@ -41,11 +54,13 @@ static void ApplyHash(CCoinsStats& stats, CHashWriter& ss, const uint256& hash,
ss << VARINT(0u); ss << VARINT(0u);
} }
} }
}
static void ApplyHash(CCoinsStats& stats, std::nullptr_t, const uint256& hash, const std::map<uint32_t, Coin>& outputs, std::map<uint32_t, Coin>::const_iterator it) {} static void ApplyHash(std::nullptr_t, const uint256& hash, const std::map<uint32_t, Coin>& outputs) {}
static void ApplyHash(CCoinsStats& stats, MuHash3072& muhash, const uint256& hash, const std::map<uint32_t, Coin>& outputs, std::map<uint32_t, Coin>::const_iterator it) static void ApplyHash(MuHash3072& muhash, const uint256& hash, const std::map<uint32_t, Coin>& outputs)
{ {
for (auto it = outputs.begin(); it != outputs.end(); ++it) {
COutPoint outpoint = COutPoint(hash, it->first); COutPoint outpoint = COutPoint(hash, it->first);
Coin coin = it->second; Coin coin = it->second;
@ -55,27 +70,13 @@ static void ApplyHash(CCoinsStats& stats, MuHash3072& muhash, const uint256& has
ss << coin.out; ss << coin.out;
muhash.Insert(MakeUCharSpan(ss)); muhash.Insert(MakeUCharSpan(ss));
} }
}
//! Warning: be very careful when changing this! assumeutxo and UTXO snapshot static void ApplyStats(CCoinsStats& stats, const uint256& hash, const std::map<uint32_t, Coin>& outputs)
//! validation commitments are reliant on the hash constructed by this
//! function.
//!
//! If the construction of this hash is changed, it will invalidate
//! existing UTXO snapshots. This will not result in any kind of consensus
//! failure, but it will force clients that were expecting to make use of
//! assumeutxo to do traditional IBD instead.
//!
//! It is also possible, though very unlikely, that a change in this
//! construction could cause a previously invalid (and potentially malicious)
//! UTXO snapshot to be considered valid.
template <typename T>
static void ApplyStats(CCoinsStats& stats, T& hash_obj, const uint256& hash, const std::map<uint32_t, Coin>& outputs)
{ {
assert(!outputs.empty()); assert(!outputs.empty());
stats.nTransactions++; stats.nTransactions++;
for (auto it = outputs.begin(); it != outputs.end(); ++it) { for (auto it = outputs.begin(); it != outputs.end(); ++it) {
ApplyHash(stats, hash_obj, hash, outputs, it);
stats.nTransactionOutputs++; stats.nTransactionOutputs++;
stats.nTotalAmount += it->second.out.nValue; stats.nTotalAmount += it->second.out.nValue;
stats.nBogoSize += GetBogoSize(it->second.out.scriptPubKey); stats.nBogoSize += GetBogoSize(it->second.out.scriptPubKey);
@ -107,7 +108,8 @@ static bool GetUTXOStats(CCoinsView* view, BlockManager& blockman, CCoinsStats&
Coin coin; Coin coin;
if (pcursor->GetKey(key) && pcursor->GetValue(coin)) { if (pcursor->GetKey(key) && pcursor->GetValue(coin)) {
if (!outputs.empty() && key.hash != prevkey) { if (!outputs.empty() && key.hash != prevkey) {
ApplyStats(stats, hash_obj, prevkey, outputs); ApplyStats(stats, prevkey, outputs);
ApplyHash(hash_obj, prevkey, outputs);
outputs.clear(); outputs.clear();
} }
prevkey = key.hash; prevkey = key.hash;
@ -119,7 +121,8 @@ static bool GetUTXOStats(CCoinsView* view, BlockManager& blockman, CCoinsStats&
pcursor->Next(); pcursor->Next();
} }
if (!outputs.empty()) { if (!outputs.empty()) {
ApplyStats(stats, hash_obj, prevkey, outputs); ApplyStats(stats, prevkey, outputs);
ApplyHash(hash_obj, prevkey, outputs);
} }
FinalizeHash(hash_obj, stats); FinalizeHash(hash_obj, stats);