mirrors/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-23 15:20:49 +01:00
Code Issues Projects Releases Wiki Activity

util: Fail to parse empty string in ParseMoney

Browse source
This commit is contained in:
MarcoFalke 2020-02-29 00:29:04 +07:00
parent fab30b61eb
commit 8888461f68
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/test/util_tests.cpp
View file

@ -1199,6 +1199,12 @@ BOOST_AUTO_TEST_CASE(util_ParseMoney)
BOOST_CHECK(ParseMoney("0.00000001", ret)); BOOST_CHECK(ParseMoney("0.00000001", ret));
BOOST_CHECK_EQUAL(ret, COIN/100000000); BOOST_CHECK_EQUAL(ret, COIN/100000000);
// Parsing amount that can not be represented in ret should fail
BOOST_CHECK(!ParseMoney("0.000000001", ret));
// Parsing empty string should fail
BOOST_CHECK(!ParseMoney("", ret));
// Attempted 63 bit overflow should fail // Attempted 63 bit overflow should fail
BOOST_CHECK(!ParseMoney("92233720368.54775808", ret)); BOOST_CHECK(!ParseMoney("92233720368.54775808", ret));

4
src/util/moneystr.cpp
View file

@ -37,6 +37,10 @@ bool ParseMoney(const std::string& str, CAmount& nRet)
return false; return false;
} }
if (str.empty()) {
return false;
}
std::string strWhole; std::string strWhole;
int64_t nUnits = 0; int64_t nUnits = 0;
const char* p = str.c_str(); const char* p = str.c_str();