test: Refactor subtree exclusion in lint tests

This commit is contained in:
Brandon Odiwuor 2024-02-26 13:36:10 +03:00
parent c1223188e0
commit 80fa7da21c
5 changed files with 19 additions and 11 deletions

View File

@ -87,3 +87,7 @@ To do so, add the upstream repository as remote:
``` ```
git remote add --fetch secp256k1 https://github.com/bitcoin-core/secp256k1.git git remote add --fetch secp256k1 https://github.com/bitcoin-core/secp256k1.git
``` ```
lint_ignore_dirs.py
===================
Add list of common directories to ignore when running tests

View File

@ -12,19 +12,17 @@ import re
import sys import sys
from subprocess import check_output from subprocess import check_output
from lint_ignore_dirs import SHARED_EXCLUDED_SUBTREES
HEADER_ID_PREFIX = 'BITCOIN_' HEADER_ID_PREFIX = 'BITCOIN_'
HEADER_ID_SUFFIX = '_H' HEADER_ID_SUFFIX = '_H'
EXCLUDE_FILES_WITH_PREFIX = ['contrib/devtools/bitcoin-tidy', EXCLUDE_FILES_WITH_PREFIX = ['contrib/devtools/bitcoin-tidy',
'src/crypto/ctaes', 'src/crypto/ctaes',
'src/leveldb',
'src/crc32c',
'src/secp256k1',
'src/minisketch',
'src/tinyformat.h', 'src/tinyformat.h',
'src/bench/nanobench.h', 'src/bench/nanobench.h',
'src/test/fuzz/FuzzedDataProvider.h'] 'src/test/fuzz/FuzzedDataProvider.h'] + SHARED_EXCLUDED_SUBTREES
def _get_header_file_lst() -> list[str]: def _get_header_file_lst() -> list[str]:

View File

@ -14,13 +14,11 @@ import sys
from subprocess import check_output, CalledProcessError from subprocess import check_output, CalledProcessError
from lint_ignore_dirs import SHARED_EXCLUDED_SUBTREES
EXCLUDED_DIRS = ["contrib/devtools/bitcoin-tidy/", EXCLUDED_DIRS = ["contrib/devtools/bitcoin-tidy/",
"src/leveldb/", ] + SHARED_EXCLUDED_SUBTREES
"src/crc32c/",
"src/secp256k1/",
"src/minisketch/",
]
EXPECTED_BOOST_INCLUDES = ["boost/date_time/posix_time/posix_time.hpp", EXPECTED_BOOST_INCLUDES = ["boost/date_time/posix_time/posix_time.hpp",
"boost/multi_index/detail/hash_index_iterator.hpp", "boost/multi_index/detail/hash_index_iterator.hpp",

View File

@ -11,8 +11,11 @@ Note: Will exit successfully regardless of spelling errors.
from subprocess import check_output, STDOUT, CalledProcessError from subprocess import check_output, STDOUT, CalledProcessError
from lint_ignore_dirs import SHARED_EXCLUDED_SUBTREES
IGNORE_WORDS_FILE = 'test/lint/spelling.ignore-words.txt' IGNORE_WORDS_FILE = 'test/lint/spelling.ignore-words.txt'
FILES_ARGS = ['git', 'ls-files', '--', ":(exclude)build-aux/m4/", ":(exclude)contrib/seeds/*.txt", ":(exclude)depends/", ":(exclude)doc/release-notes/", ":(exclude)src/leveldb/", ":(exclude)src/crc32c/", ":(exclude)src/qt/locale/", ":(exclude)src/qt/*.qrc", ":(exclude)src/secp256k1/", ":(exclude)src/minisketch/", ":(exclude)contrib/guix/patches"] FILES_ARGS = ['git', 'ls-files', '--', ":(exclude)build-aux/m4/", ":(exclude)contrib/seeds/*.txt", ":(exclude)depends/", ":(exclude)doc/release-notes/", ":(exclude)src/qt/locale/", ":(exclude)src/qt/*.qrc", ":(exclude)contrib/guix/patches"]
FILES_ARGS += [f":(exclude){dir}" for dir in SHARED_EXCLUDED_SUBTREES]
def check_codespell_install(): def check_codespell_install():

View File

@ -0,0 +1,5 @@
SHARED_EXCLUDED_SUBTREES = ["src/leveldb/",
"src/crc32c/",
"src/secp256k1/",
"src/minisketch/",
]