Merge #14718: Remove unreferenced boost headers

c54e5a41c4 Remove unreferenced boost headers (Murray Nesbitt)

Pull request description:

  Building with clang (e.g. on FreeBSD) is very noisy due to `-Wthread-safety-analysis` warnings regarding boost. This change removes a number of unnecessary boost includes, and silences the rest of the warnings when building with clang. This allows more potentially interesting warnings to surface from the noise.

  Tested on FreeBSD 11.2

Tree-SHA512: 5e6a0623188b9be59aeae52866799aefb4c3c9ab5e569b07ee8d43fc92e0b5f1f76b96bb54c35c7043148df84641b4a96927fb71f6eb00460c20cd19cf250900

src/fs.h

@@ -12,7 +12,6 @@
 #endif
 
 #include <boost/filesystem.hpp>
-#include <boost/filesystem/fstream.hpp>
 
 /** Filesystem operations and types */
 namespace fs = boost::filesystem;

src/interfaces/node.cpp

@@ -35,7 +35,6 @@
 #endif
 
 #include <atomic>
-#include <boost/thread/thread.hpp>
 #include <univalue.h>
 
 class CWallet;

src/rpc/blockchain.cpp

@@ -39,7 +39,6 @@
 
 #include <univalue.h>
 
-#include <boost/algorithm/string.hpp>
 #include <boost/thread/thread.hpp> // boost::thread::interrupt
 
 #include <memory>

src/rpc/util.h

@@ -9,8 +9,6 @@
 #include <script/standard.h>
 #include <univalue.h>
 
-#include <boost/variant/static_visitor.hpp>
-
 #include <string>
 #include <vector>
 

src/util/system.cpp

@@ -73,7 +73,6 @@
 #include <malloc.h>
 #endif
 
-#include <boost/thread.hpp>
 #include <openssl/crypto.h>
 #include <openssl/rand.h>
 #include <openssl/conf.h>