mirrors/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2024-11-20 10:38:42 +01:00
Code Issues Projects Releases Wiki Activity

walletdb: Remove unused CreateMockWalletDatabase

Browse Source 
This has been superseded by the MockableDatabase. Remove to avoid
confusion as to which type of mock database to use for testing.
This commit is contained in:
Andrew Chow 2023-05-15 16:14:43 -04:00
parent d7700d3a26
commit 0282b2126d
2 changed files with 0 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/wallet/walletdb.cpp
View File

@ -1262,38 +1262,4 @@ std::unique_ptr<WalletDatabase> MakeDatabase(const fs::path& path, const Databas
status = DatabaseStatus::FAILED_BAD_FORMAT;
return nullptr;
}
/** Return object for accessing temporary in-memory database. */
std::unique_ptr<WalletDatabase> CreateMockWalletDatabase(DatabaseOptions& options)
{
std::optional<DatabaseFormat> format;
if (options.require_format) format = options.require_format;
if (!format) {
#ifdef USE_BDB
format = DatabaseFormat::BERKELEY;
#endif
#ifdef USE_SQLITE
format = DatabaseFormat::SQLITE;
#endif
}
if (format == DatabaseFormat::SQLITE) {
#ifdef USE_SQLITE
return std::make_unique<SQLiteDatabase>(":memory:", "", options, true);
#endif
assert(false);
}
#ifdef USE_BDB
return std::make_unique<BerkeleyDatabase>(std::make_shared<BerkeleyEnvironment>(), "", options);
#endif
assert(false);
}
std::unique_ptr<WalletDatabase> CreateMockWalletDatabase()
{
DatabaseOptions options;
return CreateMockWalletDatabase(options);
}
} // namespace wallet

4
src/wallet/walletdb.h
View File

@ -305,10 +305,6 @@ using KeyFilterFn = std::function<bool(const std::string&)>;
//! Unserialize a given Key-Value pair and load it into the wallet
bool ReadKeyValue(CWallet* pwallet, DataStream& ssKey, CDataStream& ssValue, std::string& strType, std::string& strErr, const KeyFilterFn& filter_fn = nullptr);
/** Return object for accessing temporary in-memory database. */
std::unique_ptr<WalletDatabase> CreateMockWalletDatabase(DatabaseOptions& options);
std::unique_ptr<WalletDatabase> CreateMockWalletDatabase();
} // namespace wallet
#endif // BITCOIN_WALLET_WALLETDB_H