bitcoin-s/release-notes/release-notes-1.9.1.md

# 1.9.1

This release is backwards compatible with the 1.9.0 release of bitcoin-s

See the individual module sections for more information on lower level updates to the codebase.

## Running Bitcoin-S

If you want to run the standalone server binary, after verifying gpg signatures, you
can `unzip bitcoin-s-server-1.9.1.zip` and then run it with `chmod +x ./bin/bitcoin-s-server && ./bin/bitcoin-s-server` to start the node. You will need to
configure the node properly first, you can find example
configurations [here](https://bitcoin-s.org/docs/config/configuration#example-configuration-file).

You can then unzip the `bitcoin-s-cli-1.9.1.zip` folder and start using the `bitcoin-s-cli` like this:

```bashrc
./bin/bitcoin-s-cli --help
Usage: bitcoin-s-cli [options] [<cmd>]

  -n, --network <value>    Select the active network.
  --debug                  Print debugging information
  --rpcport <value>        The port to send our rpc request to on the server
  -h, --help               Display this help message and exit
```

For more information on what commands `bitcoin-s-cli` supports check the documentation, here is where to
start: https://bitcoin-s.org/docs/next/applications/server#server-endpoints

## Verifying signatures

This release is signed with [Chris's signing key](https://bitcoin-s.org/docs/next/security#disclosure) with
fingerprint `339A49229576050819083EB3F99724872F822910`

To do the verification, first hash the executable using `sha256sum`. You should check that the result is listed in
the `SHA256SUMS.asc` file next to its file name. After doing that you can use `gpg --verify` to authenticate the
signature.

Example:

UPDATE ME!!!!!!!
```
$ sha256sum bitcoin-s-server-1.9.0.zip
aa1084edb5fcd3d1dbcafe0d0fba787abf4cd455bbe38809bd9a65a49c0cd0eb bitcoin-s-server-1.9.0.zip
$ gpg --verify SHA256SUMS.asc
gpg: Signature made Thu 24 Sep 2020 12:49:39 PM CDT
gpg:                using RSA key 339A49229576050819083EB3F99724872F822910
gpg:                issuer "stewart.chris1234@gmail.com"
gpg: Good signature from "Chris Stewart <stewart.chris1234@gmail.com>"
```

### Website

https://bitcoin-s.org/

### Releases

https://repo1.maven.org/maven2/org/bitcoin-s/

### Snapshot releases

https://oss.sonatype.org/content/repositories/snapshots/org/bitcoin-s/

# Executive Summary

- Implements `sendoffer` so you now can send a DLC offer to a peer
- Implements the DLC mailbox to allow aggregation of messages such as `sendoffer` from your peer
- Allow DLC payouts to an external address not in the bitcoin-s wallet
- Only sync compact filters since wallet's creation time. This reduces IBD significantly and saves 13GB in disk space.
- Improving the windows installation experience

## app commons

6e87eb1480 Offer.offerCollateralSatoshis to offerCollateral (#4148)
1bab51c1c6 Adjust appconfig logging to INFO (#4139)

## App server

The major feature this release is adding mempool support when bitcoind is as a backend. Now our wallet
will be informed of transactions relevant to the wallet that are in the mempool.

This release also reworks the label APIs in the wallet to make them easier to use.

Finally we expose the `offer-send` RPC so you can progmatically send an offer to another DLC wallet.

ff8f44282b Reduce parallelism to 4 (#4259)
10157d108f Reduce parallelism when fetches txs in mempool for bitcoind backend (#4257)
1bc3962cfb Async mempool processing (#4245)
4b96407408 Add a Tx callback for Bitcoin Core backend (#4243)
00bce5adae Fix peer configuration for docker-compose (#4225)
0770fe0550 Mempool support for the bitcoind RPC client (#4196)
73fe4099f9 Renable tor configuration by default (#4179)
668ab21ca1 2022 03 09 label refactor (#4175)
aeb3169884 `getdlcoffer` RPC (#4166)
56d0ae68ad `offer-send` RPC (#4153)
6b7058af4a Add the temporaryContractId field to the json rpc response for offers (#4146)
c315dce05b Add jdk version to log (#4142)
b86d4e492c Allow both lnmessage and raw tlv to be sent over rpc for acceptdlc (#4140)
44b2ca3c3d Improve validation error messages (#4141)

## bitcoind rpc

3c2ecd555f Make better error message when you cannot connect to bitcoind (#4200)

## bundle

bd7f35e9ed Set both bitcoin-s.proxy.enabled and bitcoin-s.tor.enabled in bitcoin-s-bundle.conf (#4194)

## Build

52bb6f6daf Update docker-compose.yml (#4218)
715639033c Support for Tor Docker (#4223)
b8539bf68c Upgrade sbt to 1.6.2 (#4187)
23f359821f 2022 03 08 Publish zip as part of `release.yml` (#4174)
30226219e6 2022 03 01 static wix upgrade product code (#4149)
8d47f804d9 Update previous stable version to 1.9.0 (#4143)
54e18e6a8d Update docker image to jdk 17 (#4128)
96d11163a6 Bump heap size on ci-release (#4118)
16f3da7ee0 Update setup scala action to v13 (#4113)
e98b2c6caa Update release.yml to use openjdk@1.17.0 (#4115)
eddcc94b03 Upgrade CI jdks to openjdk@1.17.0 (#4114)

## Core

Small bug fixes and renames this release for `core`.

07209ce670 2022 04 14 dlctxsigner err msg (#4262)
0a092e4e03 Add fromString for TransactionOutPoint (#4261)
f2fa56221d 2022 03 31 collateral invariant (#4232)
d5807daeab Remove SpendingInfoDb.txid parameter (#4199)
8d2a749df6 Rename WitnessScriptPubKeyV1 -> TaprootScriptPubKey (#4198)
c379cf4a73 Round Bitcoins to nearest Satoshi (#4154)
5e9be9d69e Fix hardened serialization (#4160)
c3300aec52 2022 03 03 hdpath fromstring factory exn (#4159)
d1fc32758b Fix tempContractId hash so we include LnMessage() bytes (#4150)
528e7c8f0e Remove TxoState.DoesNotExist (#4108)
f657510d80 Remove invoice max amount limit (#4104)

## DLC node

The major feature this release is the offer inbox. This allows a counterparty to send you
and offer for a DLC. Next time you open up your wallet, you can see offers that were sent to you
and decide to accept them or put them in the trash.

c1dccd7831 Offer inbox RPC (#4129)
5aa46be423 Add a warn log if tor is not enabled and we are booting up DLCServer (#4126)
f3c443804b Make DLCDataHandler more type safe (#4123)
34b7d18268 External payout addresses for acceptdlc (#4121)

## DLC wallet

The theme for this release was making database operations transactional to avoid corrupt wallet states.

We also included a new state for computing adaptor signatures. This can take signficant time on low resource
devices such as a raspberry pi. The new state `AdaptorSigComputationState` can now be used by UI developers
to signal to the user their DLC is in progress, specifically computing signatures.

The last feature is adding the ability to specify external payout addresses for a wallet to receive DLC payouts.
We plan on using this at Bitcoin 2022 in Miami to allow for users to receive payouts from a esports gaming DLC.

717533baec Make first set of database writes in signDLC be transactional (#4264)
37da24b94b Add SignDbState to fix rescan exception (#4246)
a2587677c3 Use upsert rather than create in dlcsign in case we have seen the inputs before (#4248)
30a061e549 Use upsert rather than create as offers can use the same outpoints if negotiation fails for some reason (#4247)
ddabc91294 2022 04 02 fix walletdlcsetup test (#4237)
b5bfcbc009 Increase amount so test fails more consistently (#4233)
8081772b57 Allow acceptor to upsert same outpoint multiple times for different offers (#4230)
5eabe7640f Don't send websocket events for DLCs while rescanning the wallet (#4222)
faac871db6 Make buildCreateOfferAction upsert funding inputs rather than insert (#4186)
3f18f7b04c Only allow executing a DLC if it is in the Broadcast or Confirmed state (#4185)
a747f84bbb Mark extarnal payout addresses (#4173)
37611ddea1 Move all initialization of accept into initDLCForAccept() (#4162)
0bb0d9acdb Add AdaptorSigComputation states to states that a DLC can be cancelled in (#4158)
ee98aa1d30 Increase offer message size (#4136)
ffd7d921a8 Database support for incoming offers (#4105)
5777ec1c31 Add an ability to set custom payout and change addresses (#4101)

## gui

ec384a8b39 2022 03 05 rescan gui (#4170)
8f02ebce10 2022 02 26 dynamic fee gui (#4135)

## keymanager

8e3b8c1f4f Improve key manager error message (#4161)
5113cac6c2 Log root xpub on keymanager startup (#4157)

## Lnd rpc

5c9d64647e Add PSBT functions for LND (#4124)
cff0e84440 Fix get txs for lnd (#4111)

## node

Only sync compact filters since wallet's creation time. This reduces IBD sigficantly and saves 13GB in disk space.
As a datapoint, for a wallet created in May of 2019 it takes ~50 minutes to do IBD. For a new wallet it takes 30 minutes.

This increases the IBD for a new wallet by 90% giving a much better UX. If you want to sync all compact filters from genesis,
the only way to currently do this is adjusting `creationTime` to be an older timestamp inside of the seed file found at
`$HOME/.bitcoin-s/seeds/encrypted-bitcoin-s-seed.json` by default.

22051d2550 Bumps user agent to 1.9.1 (#4226)
b46574c0c4 2022 02 18 sync since creationtime pt2 (#4109)

## wallet


27cb4a3c20 Add height to log message when processing block (#4251)
7c1c572081 Rescan failure logging (#4250)
24125eaca3 Fix case where we broadcast tx with a tag, and then also add the tag when we receive the tx in a block (#4239)
33171fd069 Use the set of addresses in the wallet when rescanning rather than generating more (#4211)
413dbcacbb Rename clearUtxosAndAddreses(account) -> clearUtxos(account) (#4206)
5475a994cf Bump default address gap limit to 100, add log indicating we didn't find funds in the last addressBatchSize addresses (#4201)
a3dba47970 Refactor pending receives/spent states into one spot (#4026)
46229d712c Rename `clearAllUtxosAndAddresses()` -> `clearAllUtxos()` (#4193)
ef41cce32d Log entire address path when the address is generated (#4191)
8214c0b931 Add the account to the address generation log (#4190)
c882372c45 Improve process compact filter logs (#4189)
1072078d7c Improve tx processing log to show when we have a relevant input/output to the wallet (#4172)
d63e845de4 Only update wallet's sync height if we don't have a match in processCompactFilter() (#4169)
f1bd0ea3a5 Add log message for the case where we match a script but do not have a matching address in our database (#4156)
4cefa56c99 Add unit test for address creation when we are already watching the script (#4152)
374c1d7b9f Upgrade RescanHandlingTest to use the newest release of bitcoind (#4151)
7a5c2971dd Refactor receive flow to use the same utxo state transitions (#4134)
c069b01e53 2022 02 24 rm prune addresses after rescan (#4130)
3ba95700b2 Add RescanState, make sure we don't start concurrent rescans (#4131)
940c66807e Add log for when a new address is generated (#4127)
e6bf7bd67e Segregate updating received utxos and spent utxos (#4093)

## testkit-core

c11d9ef1fe Fix unit test where coinbase input was sometimes selected (#4165)

## testkit 

5ad5993f1a Refactor WalletAppConfig test fixture destructions to stop the config… (#4266)

## tor

This release improves logging for our tor module.

3136b228fd Log hidden service address (#4212)
fe86233489 Add better tor message to UI (#4181)

## Website

3d86276902 Bump minimist from 1.2.5 to 1.2.6 in /website (#4249)
3a5ae90cc2 Add a section to README.md about running docker-compose up (#4224)
c51db2c57a 2022 03 24 update 1.9.1 release notes (#4213)
702b7cae15 Add instructions for how to use sdkman in getting-setup.md (#4208)
f16167642b Upgrade website dependencies with yarn upgrade (#4204)
049411ccd6 Add note about backing up oracle db (#4197)
b0d7bee008 First draft of 1.9.1 release notes (#4195)
7ddeae66d2 Add web UI build tutorial (#4183)
90ff59c6fe Add The Bitcoin Company to users list (#4177)

## Dependencies

d7f12be1d4 Update scalafx to 17.0.1-R26 (#3874)
666885bc11 Re-add javafx media,graphics dependnecies to fix GUI (#4107)
5b1b1ee149 Remove uneeded javafx deps (#4103)