Commit graph

4574 commits

Author SHA1 Message Date
Scala Steward
7c8acc4484
Update client3:core, ... to 3.9.3 (#5408) 2024-02-19 15:36:53 -06:00
Scala Steward
7ea72f279f
Update logback-classic to 1.5.0 (#5406) 2024-02-19 15:35:00 -06:00
benthecarman
195cfbd273
Fix handling invoice with minimal encoding of feature bits (#5405) 2024-02-19 08:37:18 -06:00
Chris Stewart
b89b31fe09
2024 02 18 peerfinder duplicate connect (#5403)
* Pull PeerFinder changes over from #5390

* Filter out peers we are already connected when attempting to discover peers inside of PeerFinder

* Try to work around mutable.Map.isEmpty bug by converting to immutable Map
2024-02-18 11:47:32 -06:00
Chris Stewart
155b4fbc76
Fix case were we weren't cancelling the syncFilter job onDisconnect() (#5402) 2024-02-17 17:41:34 -06:00
Chris Stewart
f5087c5e3f
Remove PeerManager.{getPeerMessageSender(), getPeerConnection()}, use NodeState.{getPeerMessageSender(), getPeerConnection()} (#5400) 2024-02-17 07:37:50 -06:00
Chris Stewart
e4fbfe73e6
2024 02 16 fix get filter sync marker from stop block header bug (#5401)
* Fix bug in getFilterSyncMarkerFromStopBlockHeader where we were previously querying for children rather than the block hashes at the given height for building the FilterSyncMarker for getcfilter request. Also introduce delay in sending getcfheader because of https://github.com/bitcoin/bitcoin/issues/27085

* Only fallback to reorg scenario if we find no headers at height + 1

* Remove the best filter's block header from the candidate headers in reorg scenarios
2024-02-17 06:26:55 -06:00
Chris Stewart
bc94a8b01f
2024 02 15 Fix duplicate sync bug when we have a misbehaving peer (#5399)
* Fix bug where we were attempting to sync twice when we had a MisBehavingPeer, also simplify some logic inside of onDisconnect()

* Pull over more small changes from #5390
2024-02-15 14:56:12 -06:00
Chris Stewart
fe33c2919c
Fix inconsistency of PeerDAO primary key usage (#5398)
* Fix inconsistency of PeerDAO primary key usage

* Add Peer.port helper method
2024-02-14 13:31:56 -06:00
Chris Stewart
536cc26ba5
Update last seen value in PeerDb on disconnect (#5397) 2024-02-13 16:38:18 -06:00
Chris Stewart
05d03e7da6
Remove skipPeers, better PeerFinder.toString() (#5396) 2024-02-13 09:01:50 -06:00
Chris Stewart
3f22e42ad4
Update scalatest to 3.2.18 (#5395) 2024-02-12 18:41:35 -06:00
Chris Stewart
2d3e481ce0
Use Future.successful() when removing peer as there is no underlying async computation (#5394) 2024-02-11 11:28:25 -06:00
Chris Stewart
9d58c9eb89
Implement health checks for peers, first check is if we have any blockfilter peers (#5393)
* Implement health checks for peers, first check is if we have any blockfilter peers

* Actually send HealthCheck message to stream
2024-02-11 10:37:57 -06:00
Chris Stewart
d4ae659887
Log instead of throwing exception when sending message to peer without an active connection (#5392) 2024-02-11 09:08:05 -06:00
Chris Stewart
cac546bb57
Fix bug where we were only setting bitcoin-s.node.inactivity-timeout on regtest (#5389)
* Fix bug where we were only setting bitcoin-s.node.inactivity-timeout on regtest

* Remove log, scalafmt
2024-02-08 21:36:15 -06:00
Scala Steward
5544a2efc4
Update janino to 3.1.12 (#5387) 2024-02-06 16:09:57 -06:00
Scala Steward
e30d1b1cad
Update slf4j-api to 2.0.12 (#5388) 2024-02-06 15:56:44 -06:00
Scala Steward
b45b8b7eb0
Update sbt-bloop to 1.5.15 (#5386) 2024-02-06 15:56:34 -06:00
Scala Steward
843e9ee23a
Update sqlite-jdbc to 3.45.1.0 (#5384) 2024-02-02 13:23:20 -06:00
Chris Stewart
1685c84eea
2024 01 31 Refactor BitcoindRpcTestUtil.{startSevers(),stopSevers()} to use Future.traverse() (#5382)
* Refactor BitcoindRpcTestUtil.startServers() to use Future.traverse()

* Refactor BitcoindRpcTestUtil.stopServers() to use Future.traverse()
2024-01-31 15:20:36 -06:00
Chris Stewart
451e019225
2024 01 31 Fix PeerManager.connect() bug where PeerFinder was unaware of peer (#5381)
* Fix bug in PeerManager.connect() where we would throw ane xception when our PeerFinder had not seen the peer before

* Remove ReConnectionTest case where we constantly try to reconenct o a peer we disconnected, revert logback-test.xml
2024-01-31 11:10:48 -06:00
Chris Stewart
af74450c62
Cancel polling job after walletTest is executed (#5379) 2024-01-31 10:24:44 -06:00
Chris Stewart
75881191d1
Guard NeutrinoNode.start() with isStarted flag (#5380) 2024-01-31 09:48:44 -06:00
Chris Stewart
018631dad4
Create NodeTestUtil.awaitConnectionCount() (#5378)
Refactor ReConnectionTest to use NodeTestUtil.awaitConnectionCount()

Refactor more of codebase to use NodeTestUtil.awaitConnectionCount()

Refactor PeerManagerTest to use NodeTestUtil.awaitConnectionCount()

Refactor more nodeTest to use NodeTestUtil.awaitConnectionCount()

use bitcoinds.size for expectedConnectionCount
2024-01-31 07:39:20 -06:00
Chris Stewart
75f6a3b4ec
Refactor PeerFinder.peerConnectionScheduler() into method (#5377) 2024-01-30 14:35:17 -06:00
Chris Stewart
76e468c5c4
2024 01 28 Refactor PeerFinder.start() to avoid initializing connections (#5376)
* Conslidate PeerFinder.start() logic into peerConnectionScheduler, add bitcoins-s.node.try-peers-start-delay config settig to indicate how long until we start attempting to connect to peers in PeerFinder

* Cleanup

* Revert logback-test.xml

* Add documentation

* Empty commit to run CI

* Rework NodeAppConfig.peers to return Vector[Peer] rather than Vector[String]

* Add higher priority to paramPeers
2024-01-29 09:46:31 -06:00
benthecarman
f01987160d
Lnd v0.17.3 (#5375) 2024-01-27 11:28:25 -06:00
Chris Stewart
d641c3da55
2024 01 25 Cache txid (#5374)
* Add LargeTransactionTest

* Remove unused ByteArrayOutputStream

* Add block test case for 00000000ce4a4666cce2205d760d37b5579cdedf3ac9e4295557e8ac962cde55

* Cache txId to avoid re-computing txids which can take alot of resources

* Cache WitnessTransaction.toBaseTx, remove println

* remove BlockTest as it didn't capture the bug
2024-01-27 10:57:33 -06:00
Chris Stewart
5885f4e99e
2024 01 26 rm lazy bytes (#5373)
* Remove lazy evaluation of bytes in {Transaction, TransactionInput, TransactionOutput}

* use ByteVector.concat in BytesUtil.writeCmpctSizeUInt()

* mv cmpct.bytes into ByteVector.concat()

* Remove uncessary lazy byteSize
2024-01-26 10:38:53 -06:00
Scala Steward
5bd5cc51dc
Update metrics-core, metrics-healthchecks, ... to 4.2.25 (#5372) 2024-01-26 09:20:40 -06:00
Chris Stewart
be1ec842c2
Fix bug in classifying things as MultiSigSPK that do not have enough public keys in the Script (#5371)
* Add test case for 3a8dd04bc1f8179d0b85c8e1a1e89d058833ae64a9a8c3681da3ca329297beb1

* Fix bug where we were classifying things are MultSigScriptPubKey that did not have maxSigs' number of public keys in the Script

* Remove redundant comment
2024-01-24 15:32:08 -06:00
Chris Stewart
a66925dba0
Fix bug where IndexOutOfBoundsException was occuring when parsing a script with only OP_CMS (#5370) 2024-01-24 11:42:21 -06:00
Chris Stewart
fd09724f48
2024 01 23 Validate we have maxSigs number of public keys in MultiSignatureScriptPubKey (#5369)
* Add test case for tx for 109c38

* Check that we have maxSigs' public keys in OP_CMS.isValidAsm()

* Fix val names
2024-01-23 16:43:23 -06:00
Chris Stewart
039144c2c8
Add access to underlying MultiSignatureScriptPubKey scriptNumbers represents requiredSigs, maxSigs (#5366) 2024-01-23 14:40:06 -06:00
Chris Stewart
62012b1ee6
Upgrade microPickle to 3.1.4 (#5368) 2024-01-22 18:05:35 -06:00
Scala Steward
217914432e
Update scalapb-runtime to 0.11.15 (#5367) 2024-01-22 10:44:14 -06:00
Chris Stewart
0f95a1f7bb
Fix bounds checking for MultiSignatureScriptPubKey.maxSigsRequired (#5365) 2024-01-21 09:17:24 -06:00
Chris Stewart
83a27e2775
Add new macOS CI matrix to try and speed up mac jobs (#5364)
* Add new macOS CI matrix to try and speed up mac jobs

* Remove appServer heading in wallet,node,dlc CI run

* Remove tests from other matrix
2024-01-20 18:20:35 -06:00
Chris Stewart
73785706d8
2024 01 20 Fix bug in parsing OP_CLTV and OP_CSV (#5363)
* Get test case setup for tx 1c1f50e

* Fix bug in OP_CHECKLOCKTIMEVERIFY.isValidAsm(), check that the ScriptNumber is lessthan or equal to 5 bytes in size

* Fix bug in OP_CHECKSEQUENCEVERIFY.isValidAsm(), check that the ScriptNumber is lessthan or equal to 5 bytes in size

* Fix bug to check <= rather than <

* Revert Constants.scala, ScriptNumberUtil.scala, remove superflous 'return'
2024-01-20 17:44:08 -06:00
Chris Stewart
618e1ca2d2
Fix bug in script parsing logic where we weren't checking if a ScriptNumber was negative for a MultiSignatureScriptPubKey (#5362) 2024-01-20 15:07:38 -06:00
Scala Steward
f6648a1cc3
Update metrics-core, metrics-healthchecks, ... to 4.2.24 (#5360) 2024-01-20 10:45:25 -06:00
Scala Steward
3c6fd85f4d
Update sqlite-jdbc to 3.45.0.0 (#5361) 2024-01-20 09:25:00 -06:00
Scala Steward
e6ceda44f2
Update play-json to 2.10.4 (#5356) 2024-01-19 06:37:56 -06:00
Chris Stewart
db21b8873e
Set flag nativeImageInstalled =: true so we don't overwrite system's nativeimage (#5358) 2024-01-19 05:39:34 -06:00
Chris Stewart
a7b67fc78d
2024 01 18 fix native image build (#5357)
* Try specifying graalvm download url to fetch modern native image

try explicitly stating version #

Add tgz+

try using simple OS to get thigns working

Try runner.os

* Add comment for where to find new jdks in the future
2024-01-18 17:16:53 -06:00
Scala Steward
1ad2778ab2
Update client3:core, ... to 3.9.2 (#5355) 2024-01-16 09:35:54 -06:00
Scala Steward
510ac32db5
Update metrics-core, metrics-healthchecks, ... to 4.2.23 (#5320) 2024-01-15 08:10:01 -06:00
Scala Steward
495197d380
Update postgresql to 42.7.1 (#5321) 2024-01-15 08:09:51 -06:00
Scala Steward
001a2f0970
Update slf4j-api to 2.0.11 (#5351) 2024-01-15 08:09:40 -06:00