mirrors/bitcoin-s
1
0
Fork 0
mirror of https://github.com/bitcoin-s/bitcoin-s.git synced 2025-03-26 13:25:49 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix handling invoice with minimal encoding of feature bits (#5405)

Browse source
This commit is contained in:
benthecarman 2024-02-19 14:37:18 +00:00 • committed by GitHub
parent b89b31fe09
commit 195cfbd273
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 25 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core-test/src/test/scala/org/bitcoins/core/protocol/ln/LnInvoiceUnitTest.scala
View file

@ -577,4 +577,12 @@ class LnInvoiceUnitTest extends BitcoinSUnitTest {
assert(invoice.nodeId == NodeId(priv.publicKey))
}
it must "parse an invoice with minimally encoded features" in {
val str =
"lnbc2u1pjaxtm0dqqpp5g7xpa2xz7jkfcaczxkr0c7k0hxeh8y30f6ec0rvj0qe6xzmcuyxssp5nqd0ac3ctaruwkykjzdqm9jks20wp93e5m0xt35ae7zp7jf4hrsq9qrsgqcqpjnp4qddsxf0zurpkk6uxe7fmlllsypajk0cwuqcmsv6g958am7fhsx24zxqrrssrzjqte649ct9zh8ecjylt7w3a5d9mvpdchtgsgecu22yycumagdx3uukqqqqqqqqqqqqyqqqqqqqqqqqqqqrc5sgm8xfdg57alvd4s83rgqrzvm95c76az5d5c7cr6jldxex4p0qhdesrwrhvtqfkh9mdv6vd75qam8v5dcsj5wx7tfx7576m6wx8f2sq64klgu"
val invoiceT = LnInvoice.fromStringT(str)
assert(invoiceT.isSuccess)
}
}

22
core/src/main/scala/org/bitcoins/core/protocol/ln/LnTags.scala
View file

@ -320,7 +320,7 @@ object LnTag {
RoutingInfo.fromU5s(payload)
case LnTagPrefix.Features =>
LnTag.FeaturesTag(bytes)
LnTag.FeaturesTag(payload)
case prefix: LnTagPrefix.Unknown =>
LnTag.UnknownTag(prefix, payload)
@ -329,12 +329,24 @@ object LnTag {
tag
}
case class FeaturesTag(features: ByteVector) extends LnTag {
case class FeaturesTag(encoded: Vector[UInt5]) extends LnTag {
override def prefix: LnTagPrefix = LnTagPrefix.Features
/** The payload for the tag without any meta information encoded with it */
override def encoded: Vector[UInt5] = {
Bech32.from8bitTo5bit(features)
def features: ByteVector = {
val u8s = Bech32.from5bitTo8bit(encoded)
UInt8.toBytes(u8s)
}
}
object FeaturesTag {
def apply(features: ByteVector): FeaturesTag = {
fromBytes(features)
}
def fromBytes(bytes: ByteVector): FeaturesTag = {
val u5s = Bech32.from8bitTo5bit(bytes)
FeaturesTag(u5s)
}
}