* Get things compiling again with default intellij build
* Cleanup compile of coreTestJVM so we don't have warnings that cause failures in intellij's build
* Get build started for 26.1
* Start introducing v26 data structures
* Switch BitcoindVersion.newest = V26
* Fix GetTxOutSetInfoResult to use hash_serialized_3
* Fix WalletRpcTest
* Refactor PeerInfoResponse to add transport_protocol_type and session_id fields in v25
* Add ServiceIdentifier.NODE_P2P_V2, add support for v2transport to addnode, add default config setting for bitcoind to have v2transport=1 in test framework, add unit test to make sure we can establish a v2 connection
* Remove V20AssortedRpc
* Add loadtxoutset
* Implement getchainstates
* Add getprioritisedtransactions
* Add getaddrmaninfo
* Add importmempool
* Cleanup println
* Update scalafmt-core to 3.8.1
* Update .scalafmt.conf settings to be factory default settings
* Fix typo
* scalafmt
* Empty commit to re-run CI
* Revert some scalafmt back to original scalafmt.conf
---------
Co-authored-by: Chris Stewart <stewart.chris1234@gmail.com>
* Integrate Descriptor class into 'getdescriptorinfo' RPC
* WIP: Invalid checksum that is valid according to bitcoin core
* Add descriptor.py in comments
* Get deriveaddresses RPC working with descriptors
* Parse descriptors in DescriptorsResult to Descriptor data type
* Implement unit tests for key expression fidelity to user input for hardened paths
* Create HardenedType, rework BIP32Node to take Option[HardenedType] as a parameter
* Fix docs
* Add DescriptorType, OutputDescriptor
* Get unit test passing for a descriptor with a xpub and bip32 path
* WIP: Implement checksum algo
* WIP: Implement polyMod
* Get checksum unit test case passing
* Get basic serialization test case passing
* Revert Bech32.scala
* WIP: Implement KeyExpression
* WIP: KeyOriginExpression
* Get basic KeyExpression test case passing
* Get basic unit tests workign for parsing Private/Public key descriptor expressions
* Add examples
* Get all key expression unit tests passing
* Get negative test vectors passing
* WIP: Get P2WPKHDescriptor tests working
* Get all serizliation tests passing for non-derivation path BIP382 descrioptors
* Get BIP382 derivation test cases passing
* Implement BIP382 failure test cases
* Get BIP381 test vectors passing
* Split key expressions into SingleKeyExpression,MultisigKeyExpression
* WIP: Multisig descriptors
* Remove custom building of scripts now that we have #5502
* Get BIP383 test vectors passing
* Get BIP384 test vectors passing
* Fix bug in runFailTest()
* Add RawSPKScriptExpression, use it with P2WSHExpression to ensure underlying spk is a RawScriptPubKey
* Get all negative test vectors working after fixing bug in runFailTest()
* Implement BIP385 raw() test vectors, skip addr() descriptor
* Get everything working up to dealing with taproot pubkey types
* Begin working on type hierarchy for different pubkeys
* Get things to the point of needing a custom pubkey type
* Get things compiling w/ PubKeyTypeExpression
* Get tr(WIF) example working
* WIP: Key reworking type hierachy to be PublicKey type specific
* WIP: Taproot helpers
* Get taproot descriptor working with both keypath and single level scriptpath
* Get recursive tapscript tree test vector working
* Implement negative test vectors for BIP386
* Add BIP386 derivation test
* Get extkey tr() descriptor test working
* Rename InternalPublicKeyExpression -> RawPublicXOnlyPublicKeyExpression
* Fix keyOrigin for tr() descriptors
* Cleanup comments
* Add comments
* Move leafVersion TapscriptControlBlock -> TapLeaf
* Add taproot wallet test vectors
* Get parsing logic working
* Get first test case passing
* Add TapLeaf
* Get test cases working with two TapLeaf
* Add TapscriptTree as the top level type for a recursive data structure for TapscriptPath's
* Remove control block parsing for now until we actually test control blocks
* scalafmt
* Get dependencies resolving, get tor module compiling
* Get everything compiling with pekko
* Rework configs/logging to use pekko namespace
* Rename AkkaUtil -> PekkoUtil, BitcoinSAkkaAsyncTest -> BitcoinSPekkoAsyncTest
* Add LargeTransactionTest
* Remove unused ByteArrayOutputStream
* Add block test case for 00000000ce4a4666cce2205d760d37b5579cdedf3ac9e4295557e8ac962cde55
* Cache txId to avoid re-computing txids which can take alot of resources
* Cache WitnessTransaction.toBaseTx, remove println
* remove BlockTest as it didn't capture the bug
* Add test case for 3a8dd04bc1f8179d0b85c8e1a1e89d058833ae64a9a8c3681da3ca329297beb1
* Fix bug where we were classifying things are MultSigScriptPubKey that did not have maxSigs' number of public keys in the Script
* Remove redundant comment
* Get test case setup for tx 1c1f50e
* Fix bug in OP_CHECKLOCKTIMEVERIFY.isValidAsm(), check that the ScriptNumber is lessthan or equal to 5 bytes in size
* Fix bug in OP_CHECKSEQUENCEVERIFY.isValidAsm(), check that the ScriptNumber is lessthan or equal to 5 bytes in size
* Fix bug to check <= rather than <
* Revert Constants.scala, ScriptNumberUtil.scala, remove superflous 'return'
* Fix bug where number needed to be interpreted as a UInt32 rather than Int32 by the ScriptInterpreter in the case of OP_CSV
* Add static test vector, fix another occurrence of bug
* WIP: Try to move byte streaming/parsing of p2p messages out of P2PClient
* WIP2: Work on killing the actor, replace it with a steram
* Get basic ability to send/receive version message working
* Transition PeerMessageReceiverState to Initializing inside of PeerMessagesender.connect()
* Refactor things out of PeerMessageSender.connect(), add some flow logs
* Get NeutrinoNodeTest be able to sync passing
* Fix some bugs, create ConnectionGraph helper class
* Use killswitch rather than Source.maybe to disconnect peer
* WIP: Debug
* Switch halfClose to false on Tcp.outgoingConnection() to not keep lingering connections
* Delete P2PClientActorTest
* Delete all P2PClient stuff
* Attempt implementing reconnection logic in PeerMessageSender
* remove supervisor
* Empty commit to re-run CI
* Small cleanups
* Implement sendResponseTimeout()
* Restore logback-test.xml
* Add callback to log error message on reconnect
* Increase queueSize/maxConcurrentOffers size
* Upgrade scalajs to 1.10.1
* Upgrade to scalajs to 1.11.0
* Try to re-order order tests are run in to avoid scoverage bug with scalajs
* remove duplicate run of asyncUtilsTestJS/test
* Add OrderedSchnorrSignatures, use it in OracleAttestment, propagate it threw the codebase
* Small cleanups
* Add SortedVecFactory
* Fix test case with out of order nonces
* Represent and handle SIGHASH_DEFAULT correctly in TaprootKeyPath
* Prevent construction of invalid TaprootKeyPath, fix tests
* Have SIGHASH_DEFAULT be SIGHASH_ALL in preTaproot cases
* Add static test vectors for Taproot and the ability to parse those test cases
Add TaprootWitness data structure, get parsing working for first static test case
WIP: Distinguish between TaprootKeyPath and TaprootScriptPath
Remove invariants and make val to method in TaprootScriptPath so we can parse test cases
Add TaprootTestCase.{txSigComponents, programs} methods
Try to run test case
WIP
Wrap failure case in Try
Get first test case passing
Fix building of sig component for p2sh
WIP test case legacy/pk-wrongkey
Get more test cases passing
Move where MAX_PUSH_SIZE is checked for segwit
Get another test case passing
Add links to bitcoin core in test case
Fix stack parsing for witness
Get success test cases passing (without signature verification?)
Add failure test cases
Fix basic compile failures except in javascript projects
Get basic TaprootKeyPath parsing working from ScriptWitness
Get invariants implemented correctly for TaprootScriptPath
WIP
WIP
Get first taproot signature serialization test working
Get tagged hash working correctly
Rework test framework, get 2nd success test case passing
Get compile working with rebase
Implement computeTapleafHash with a unit test case
Add scaffolding of computing merkle root test case
Implement computeTaprootMerkleRoot() with a unit test
Implement computeTapTweakHash() with a unit test
WIP: checkTapTweak()
WIP
Implement computeTapTweakHash() unit test
Rebase onto master
Get verifyTaprootCommitment() passing unit test
Refactors to be more readable
* WIP: Tapscript signature checking
* Get taproot script path signature serialization working for unit test
* Add carve out for unknown public key types
* WIP: OP_CHECKSIGADD
* Add test case to detect annex and compute its hash
* Get test case passing when using upgradable public keys with an annex on the stack
* Fix missing pattern match
* Fix bug with tapscript SIGHASH_ALL and add test case
* Add check if taproot flag is enabled
* Get signature verification working with annex hash
* Implement correct handling of fail case for OP_CHECKSIGADD
* Get test case passing
* DRY
* Fix bug, now we only allow tapscript sig checking when pubkey is 32 bytes in size
* Refactor evalChecksigTapscript to use XOnlyPubKey
* Get signature serialization working with OP_CODESEPARATOR
* Get SIGHASH_ANYONECANPAY|SINGLE example working
* Fix bug in BIP342 impl where we don't count op codes if the version is taproot
* Fix OP_CODESEPARATOR bug
* Implement calculating of OP_CODESEPARATOR idx relative to other opcodes, not push operations
* Fix OP_CHECKSIG tapscript bug where we didn't push OP_FALSE onto stack in case of signature validation failure
* Add annex to TaprootKeyPath
* Get signature chcking working with tapscript keypath annex
* Cleanup test framework code a bit to avoid casting exceptions
* Implement handling of OP_SUCCESS
* WIP: Segwit v0 serialization with nonstandard sighash flag
* Fix hash bug in segwit v0 serialization
* WIP
* Fix bug where we weren't defaulting to SIGHASH_DEFAULT when using tapscript
* Add disabled opcodes to OP_SUCCESS case
* Fix parsing for witnesses in test case
* Get a SIGHASH_SINGLE test case working
* Clean up rebase
* Fix default hash type in TaprootKeyPath
* Implement opCodeSeparator counting that does NOT work when OP_CODESEPARATOR is is not executed inside of an OP_IF, otherwise is very simple for the base case
* Cherry-pick ben's commits & rebase
* Remove script size limit for tap scripts
* Fix incorrect handling of unassigned spk
* Fix invariant
* get correct test case failing
* WIP: SIGHASH_ALL_ANYONECANPAY test case
* Cleanup logging/println
* Refactors & fix regressions in some simple unit tests
* Remove logback in core to get the entire project compiling again
* Make TapscriptPath.hasAnnex() more robust against exceptions
* Add validation of XOnlyPubKey to control block
* Implement known leaf versions in the control block
* Add TaprootUnknownPath and UnknownControlBlock
* Fix rebase
* Fix interpreter bug where v0 segwit wasn't failing when a wrong program was used
* Cleanup println
* Clean up println pt2
* Re-enable -Xfatal-warnings
* Turn off logback-test.xml
* Parallelize taproot success test cases
* Try to bump timeout
* Optimization: Reduce number of intersections in ScriptInterpreter.run()
* Ben's code review
* Take ben's clean stack bugfix
Co-authored-by: benthecarman <benthecarman@live.com>
* Get simple serialization symmetry working for taproot keypath
* Implement generators for TaprootScriptPath, check serialization symmetry
* Make sure bytes are symmetrical too
* Add check in TaprootScriptPath.hasAnnex() to make sure therer is more than one stack element
* Cleanup
* Address ben's review
* Fix pattern match
* Add TaprootUnknownPath and UnknownControlBlock
* Fix small bugs and make validation more resilient against exceptions
* Take ben's suggestion and use abstract class
* Fix bug in TaprootKeyPath's default hash type
* Fix comment
