1
0
mirror of https://github.com/bitcoin/bips.git synced 2024-11-19 01:40:05 +01:00
0 Comments:BIP 0171
Stéphane Traumat edited this page 2018-08-22 12:14:11 +02:00
This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

Cerise ( by straumat )

CERISE (website & github) provides :

Changes to make in the BIP ? ( by straumat )

“a GET request to a common URI with parameters encoded in application/x-www-form-urlencoded format” May I ask you why parameters should be encoded this way ? From what I have seen in other projects, they also allow json for get method.

In the samples you provided, all returned fields are not set. For example, signature is never set. Of course its not a problem but I think it would be a good idea to have at least a result with all fields set so i could implement all the unit test cases. I have the same comment for “archive” and “signature” fiedls in Currency-pair information. I have the same comment for “minrate” and “maxrate” parameters in Current exchange rate and nonce in result.

“digits - The type of digits to use for the quote currency's numbers. "arabic" should be used for common 0-9 digits.” Dont you think we should provide the list of supported digits ?

Things I dont understand ( by straumat )

I dont understand what means “XBTUSD-ver4” ? I dont see what it means. “Currency-pair information \ symbol : Any positive or negative symbols must be included in this prefix/suffix” I dont understand this rule. Can you explain it more please ?