mirrors/bitcoin-bips
1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-01-19 05:45:07 +01:00
Code Issues Projects Releases Wiki Activity
2,062 Commits 6 Branches 0 Tags 47 MiB
65f0b3dd62
Commit Graph

2062 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dmitry Petukhov
65f0b3dd62
BIP-174: test data: fix value length 
In the test case "Case: PSBT With invalid output witnessScript typed key", after PSBT_OUT_WITNESS_SCRIPT key with garbage data (which ends with `...478ef51309d`, follows value `2b` which would denote the length of the data value of the key. But the length of actual remaining data is only 7 bytes. Thus, an implementation that reads key-value pairs and checks for validity of the key data after it has read the current key-value pair, will not be able to hit the exact condition intended for this test case: extra data within the key itself. This is because such implementation will hit serialization error when it will try to read the data of the value and will get the short read.

Reading full key-value pair and then checking key format afterwards is fairly normal thing to do, as the format of the keys with all their meaning is an abstraction of higher level than just the simple key-value serialization format.

The proposed change is to replace byte `2b` after the key data to `06` and thus make the value length in the key-value pair valid (not going beyond the end of the data).

base64 encoding has been changed accordingly.
 2019-12-09 17:30:47 +05:00
Luke Dashjr
8431b22b2d
Merge pull request #856 from emilengler/emilengler-redefinition-of-the-term-address 
BIP 179: Name for payment recipient identifiers
 2019-11-08 16:10:12 +00:00
Emil Engler
d3ff4b1e9e
Add BIP 179: Name for payment recipient identifiers 2019-11-07 14:58:29 +01:00
Luke Dashjr
580e719221
Merge pull request #803 from kallewoof/bip-signet 
BIP 325: Signet
 2019-11-06 15:55:08 +00:00
Karl-Johan Alm
2a270d9419
BIP 325: Signet 2019-11-06 17:39:25 +09:00
Luke Dashjr
96382166b0
Merge pull request #851 from naumenkogs/master 
BIP 330: Transaction announcements reconciliation
 2019-11-05 18:02:48 +00:00
User
544e883488 update readme 2019-11-05 12:38:51 -05:00
User
affe5cb881 Add comments links and created date. 2019-11-05 11:55:26 -05:00
User
7f9ad3ebe5 add trailing zero to the file name 2019-11-04 13:39:01 -05:00
User
2e7dab87ef added missing leading zero 2019-11-04 13:30:08 -05:00
User
161c482f12 Merge branch 'master' of https://github.com/naumenkogs/bips 
* 'master' of https://github.com/naumenkogs/bips:
  Update bip-reconcil.mediawiki
 2019-11-04 13:24:31 -05:00
User
aae7384c46 Assigned a number, separated lines for authors, added License-Code field. 2019-11-04 13:24:24 -05:00
Luke Dashjr
8677fd5786
Merge pull request #767 from bitcoinbrisbane/patch-1 
Update the link to NBitcoin repo
 2019-11-04 15:50:32 +00:00
Luke Dashjr
a758915592
Merge pull request #857 from Roasbeef/bip-157-filter-request-limit 
BIP-0157: increase max getcfilters request to 1k blocks
 2019-11-04 15:01:24 +00:00
Luke Dashjr
ba804c9d52
Merge pull request #844 from kallerosenbaum/master 
BIP174: Remove misleading sentence
 2019-11-04 15:00:38 +00:00
Luke Dashjr
daed7bfa8d
Merge pull request #849 from achow101/bip174-extensions 
Bip174 extensions
 2019-11-04 14:06:54 +00:00
Luke Dashjr
fd89f0ad92
Merge pull request #845 from MarcoFalke/patch-1 
BIP 158: Fix mediawiki syntax typo, Remove remnants of the second filter type
 2019-10-25 14:00:37 +00:00
Olaoluwa Osuntokun
898559fd05
BIP-0157: increase max getcfilters request to 1k blocks 
In this commit, we effectively revert #699 by allow clients to request
filter for up to 1k consecutive blocks. Testing in the field has shown
that applications are able to reduce perceived latency from syncing to
full functionality after an app has been offline for several days by
batching requests for filters. A value of 100 would mean each additional
day behind adds an additional round trip, resulting in 10s of
seconds of lag after just a few days of being offline. A value of ~1k
allows implementations to catch up with roughly a week's worth of
filters in a single round trip.
 2019-10-24 19:51:37 -07:00
Luke Dashjr
6bcb38f226
Merge pull request #837 from clarkmoody/bip-45-formatting 
BIP-0045 - Formatting use <code> tags
 2019-10-11 23:11:31 +00:00
Luke Dashjr
aca1510b92
Merge pull request #816 from kallewoof/2019-07-bip154-withdraw 
BIP-154: change to withdrawn status
 2019-10-11 23:06:03 +00:00
Luke Dashjr
67f7e52fc7
Merge pull request #852 from MarcoFalke/1909-103nono 
BIP 103: Mark as withdrawn
 2019-10-11 03:05:50 +00:00
MarcoFalke
09d3d83d7e BIP 103: Withdrawn 2019-10-10 18:15:24 -04:00
MarcoFalke
d2277115ce travis: Remove unused sudo:false 
Builds in sudo-disabled docker containers are no longer available as of
last year and all builds happen on sudo enabled vms.

https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration#timeline---its-happening-fast
 2019-10-10 18:15:12 -04:00
Gleb Naumenko
394601bb3c
Merge pull request #2 from MarcoFalke/patch-2 
Update bip-reconcil.mediawiki
 2019-10-09 12:51:35 -04:00
Andrew Chow
bc3a81e698 Specify proprietary use type 2019-10-02 15:09:51 -04:00
Gleb Naumenko
32af098957 minor fixes 
Co-authored-by: Rusty Russel <rusty@rustcorp.com.au>
 2019-09-30 11:49:54 +03:00
Gleb Naumenko
0ee067c70e Acknowledge suhas' contributions 2019-09-26 07:59:06 +03:00
MarcoFalke
630052355d
Update bip-reconcil.mediawiki 
Fix mediawiki syntax for italic text
 2019-09-25 15:47:11 -04:00
Gleb Naumenko
63504d9f9c
Merge pull request #1 from MarcoFalke/patch-2 
bip-reconcil: Switch PD "license" to CC0
 2019-09-25 16:46:31 +03:00
MarcoFalke
be33606bfe
bip-reconcil: Switch PD "license" to CC0 
See https://github.com/bitcoin/bips/blob/master/bip-0002.mediawiki#recommended-licenses
 2019-09-25 08:33:20 -04:00
Gleb Naumenko
311c085cab bip for erlay messages 2019-09-25 14:11:03 +03:00
Luke Dashjr
b1b248fc6a Update BIP 100 status Draft->Rejected 2019-09-24 19:33:03 +00:00
Luke Dashjr
3a5477c7cc Merge BIP 100 2019-09-24 19:31:38 +00:00
Luke Dashjr
773a7fe993 README: Fix BIP 100 fields 2019-09-24 19:31:13 +00:00
MarcoFalke
af134f361f
Update bip-0158.mediawiki 
Fix:

* Render issue in `<ref>` tag (c.f. https://en.bitcoin.it/wiki/BIP_0158#Contents)
* Remove remnants of the second filter type
 2019-09-24 15:05:03 -04:00
Luke Dashjr
b5723035e2
Merge pull request #642 from psztorc/master 
BIP 300: Hashrate Escrows (Consensus layer)
 2019-09-20 17:59:18 +00:00
Luke Dashjr
34f0fe5b2a BIP 300: Fix preamble 2019-09-20 17:50:14 +00:00
Paul Sztorc
c78766c360 add number 300 and update README 2019-09-20 10:25:26 -07:00
Paul Sztorc
ecc00805c2 clarify + specific M4 example 2019-09-20 10:19:47 -07:00
Paul Sztorc
a9b0bc593a spellcheck 2019-09-20 10:19:46 -07:00
Paul Sztorc
c6da99018d typos 2019-09-20 10:19:46 -07:00
Paul Sztorc
99e57b086a compress 
We were able to dramatically shorten the BIP, by deleting superfluous explanations/justifications. Instead it just focuses on what the messages are.
 2019-09-20 10:19:46 -07:00
Paul Sztorc
3201b23119 typo 2019-09-20 10:19:46 -07:00
Paul Sztorc
dd02ff4c07 edit and shorten slightly 2019-09-20 10:19:46 -07:00
Kalle Rosenbaum
f1aff33f46 BIP174: Remove misleading sentence 
The sentence seems to suggest that the "master key fingerprint" can be the fingerprint of any intermediate node on the derivation path, which isn't true.
 2019-09-20 19:00:03 +02:00
Luke Dashjr
7e9fab150f
Merge pull request #810 from NicolasDorier/bips/global-xpub-test-vector 
bip174: Add test vector for global xpub
 2019-09-20 00:35:24 +00:00
Luke Dashjr
c7057971e1
Merge pull request #842 from darosior/174_typo 
Remove a typo in bip-0174
 2019-09-20 00:35:04 +00:00
Luke Dashjr
7d91fd1863
Merge pull request #775 from azuchi/fix-bip197-error 
[BIP197] Fix description of Refund Period
 2019-09-19 22:28:26 +00:00
Luke Dashjr
9e7d213e82
Merge pull request #796 from lukechilds/patch-2 
[bip174] Fix typo in signer pseudo code
 2019-09-19 22:18:45 +00:00
Luke Dashjr
df22d72c29
Merge pull request #811 from achow101/bip174-xpubs 
BIP 174: global xpubs serialization test vector
 2019-09-19 22:18:33 +00:00