1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-02-26 00:14:27 +01:00
Commit graph

2066 commits

Author SHA1 Message Date
Orfeas Stefanos Thyfronitis Litos
314e9fd904
Add missing quote 2019-11-18 17:00:39 +00:00
Pieter Wuille
6b906253b1
Merge pull request #147 from OrfeasLitos/fix-typo-sig
Fix typo in schnorr, footnote 2
2019-11-18 08:30:07 -08:00
Pieter Wuille
b9d12f79fb
Merge pull request #146 from MaxHillebrand/patch-1
make clear it's script branch
2019-11-18 07:41:49 -08:00
Orfeas Stefanos Thyfronitis Litos
cacb82fc6d
Fix typo in schnorr, footnote 2 2019-11-18 14:47:27 +00:00
Max Hillebrand
de14bad4dc
make clear it's script branch
In this context we are talking about the script branch, not the Merkle tree branch, right? If so, then this should clear things up a little.
2019-11-18 14:56:29 +08:00
Pieter Wuille
c5a7332ea3
Merge pull request #131 from afk11/fix-typo-bip-tapscript
tapscript: fix minor typo
2019-11-16 12:54:19 -08:00
Pieter Wuille
3e3ac64b53
Merge pull request #140 from jonatack/clarify-and-link-to-bip-schnorr-reference-code
bip-taproot: clarify bip-schnorr reference code
2019-11-16 12:53:10 -08:00
Pieter Wuille
a00c4a3dc9
Merge pull request #143 from OrfeasLitos/link-to-other-bips
Add links to unlinked BIPs
2019-11-16 12:50:17 -08:00
Pieter Wuille
a6d7059ce0
Merge pull request #137 from AdamISZ/hash-0-meaning
Add clarification of semantics of 0x00 hash type
2019-11-16 12:49:35 -08:00
Pieter Wuille
aa337b9fbb
Merge pull request #134 from hebasto/20191111-base-point
G refers to the secp256k1 base point rather generator
2019-11-16 12:49:11 -08:00
Pieter Wuille
5dab10b0b6
Merge pull request #135 from pyskell/patch-1
ADD: Require BIPs for Taproot and Tapscript
2019-11-16 12:48:23 -08:00
Pieter Wuille
bc0c57e1fd
Merge pull request #144 from devrandom/wording
Clarify 211 hash bytes and non-reuse of keys
2019-11-15 19:43:39 -08:00
Pieter Wuille
e5d6ee25e9
Merge pull request #145 from instagibbs/patch-11
remind reader where [:] is defined
2019-11-15 14:24:24 -08:00
Gregory Sanders
8861bd503a
remind reader where [:] is defined
in addition to `point`. This caused confusion for one reader who expected inclusive at end of range.
2019-11-15 13:46:35 -05:00
Dev Random
b8cbd419e6
tweak 211 bytes text 2019-11-14 10:55:32 -08:00
Devrandom
1a9c7f948a clarify 211 hash bytes and non-reuse of keys 2019-11-13 18:46:05 +01:00
Orfeas Stefanos Thyfronitis Litos
b417bb3c50
Add links to unlinked BIPs
Only first mention of each BIP is made into a link
2019-11-13 17:20:09 +00:00
Pieter Wuille
1e27c4e307
Merge pull request #142 from OrfeasLitos/python-typo
Replace R with P in taproot_tweak_seckey
2019-11-13 08:50:18 -08:00
Orfeas Stefanos Thyfronitis Litos
7bce5a0930
Replace R with P in taproot_tweak_seckey 2019-11-13 14:00:03 +00:00
Jon Atack
8b92d05be9
bip-taproot: clarify bip-schnorr reference code
- update the paragraph in question to more clearly convey that the helper
  functions, and not the Python3 example code, are from the bip-schnorr
  reference code

- add a link to the reference code in
  https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr/reference.py
2019-11-12 23:07:44 +01:00
Anthony
f620c87eb7 FIX: BIPs should be specified as lowercase to match filenames 2019-11-12 15:47:39 -05:00
Anthony
0af4a35295
ADD: Require Schnorr and Taproot BIPs for Tapscript
https://github.com/sipa/bips/pull/135#issuecomment-552754867
2019-11-12 14:08:09 -05:00
Adam Gibson
e5918b3b29
Add clarification of semantics of 0x00 hash type 2019-11-12 11:41:27 +00:00
Pieter Wuille
b79935a883
Merge pull request #136 from instagibbs/patch-10
BIP16 has no relation to bip-taproot/tapscript
2019-11-11 16:04:47 -08:00
Gregory Sanders
c98970085d
BIP16 has no relation to bip-taproot/tapscript
Previously did.
2019-11-11 15:32:57 -05:00
Anthony
5abcbca343
ADD: Require Schnorr BIP for Taproot
Per https://github.com/bitcoin/bips/blob/master/bip-0001.mediawiki:

"BIPs may have a Requires header, indicating the BIP numbers that this BIP depends on"
2019-11-11 13:40:42 -05:00
Hennadii Stepanov
7e98e2fd84
G refers to secp256k1 base point rather generator 2019-11-11 20:09:55 +02:00
Pieter Wuille
c936a9bc4b
Merge pull request #132 from agis/patch-2
Fix typo
2019-11-11 08:03:40 -08:00
Agis Anastasopoulos
af1638ce18
Fix typo 2019-11-11 12:39:53 +02:00
Pieter Wuille
c9931d156c
Merge pull request #130 from LaurentMT/patch-1
Fxied typo in taproot_sign_script()
2019-11-11 00:54:22 -08:00
Thomas Kerin
5ceb42b48b
tapscript: fix minor typo 2019-11-11 02:41:15 +00:00
LaurentMT
ad4156a394
Fxied typo in taproot_sign_script() 2019-11-11 01:20:28 +01:00
Pieter Wuille
3700e18055
Merge pull request #128 from codeShark149/tweak_pubkey_change
Internal pubkey calculation fixed in taproot_tweak_pubkey()
2019-11-06 12:48:56 -08:00
codeShark149
de82b3ad26 Internal pubkey calculation fixed in taproot_tweak_pubkey() 2019-11-06 23:48:29 +05:30
Pieter Wuille
230f6cb734
Merge pull request #125 from fjahr/patch-1
Link design section of BIP Schnorr in Specification
2019-11-06 07:44:44 -08:00
Pieter Wuille
73ade2d61b
Merge pull request #126 from MaxHillebrand/patch-1
fix: script spend, not key spend reveals tree depth
2019-11-06 07:44:00 -08:00
Max Hillebrand
78eb015f63
fix: script spend, not key spend
For the key spend the script tree depth is not revealed, it is only done for script spends. This sentence makes sense only for the script spend.
2019-11-06 05:58:11 +01:00
Pieter Wuille
3f62751809
Merge pull request #121 from jonasnick/add-test-vector
Fix point_from_bytes accepting out-of-range pubkeys and add test vector
2019-11-05 09:57:41 -08:00
Fabian Jahr
08622c9494
Link design section of BIP Schnorr in Specification 2019-11-05 14:53:16 +01:00
Jonas Nick
8a8a35bfc5 Update test-vectors.csv 2019-11-05 10:14:23 +00:00
Pieter Wuille
857dd625b5
Merge pull request #114 from real-or-random/patch-11
improve rationale for key prefixing
2019-11-04 16:06:29 -08:00
Jonas Nick
8e7aef083e Fix point_from_bytes accepting out-of-range pubkeys and add test vector 2019-11-05 00:05:07 +00:00
Pieter Wuille
1bb025aa22
Merge pull request #116 from jonasnick/test-vec-terminology
Adjust reference code and test vectors to latest bip
2019-11-04 16:00:42 -08:00
Jonas Nick
0ec01e9255 Fix typo in reference code comment 2019-11-04 23:35:55 +00:00
Jonas Nick
35f1fface5 Make more clear that signing function in test vectors generation code isn't intended to be used anywhere else 2019-11-04 23:35:31 +00:00
Jonas Nick
c0f0c8d43d Check infinity in is_positive 2019-11-04 23:35:24 +00:00
Jonas Nick
220df7da78 Adjust test vector generation code to latest terminology 2019-11-04 23:35:17 +00:00
Jonas Nick
854a33ab48 Fix test vector generation code after changing schnorrsig_sign api 2019-11-04 23:35:11 +00:00
Pieter Wuille
2f1c4d80ae
Merge pull request #124 from sipa/square_terminology
Settle on notation: is_square(y), has_square_y(P)
2019-11-04 13:59:59 -08:00
Pieter Wuille
0c6a9cffad Settle on notation: is_square(y), has_square_y(P) 2019-11-04 13:42:24 -08:00