mirror of
https://github.com/bisq-network/bisq.git
synced 2024-11-19 18:03:12 +01:00
da9b42fb83
The deposit confirmed state is set after we applied the mailbox messages, which led to a task failure due wrong phase and the message was not applied. Further it can be that the wallet is still syncing and the deposit confirmed state is set in any time in the future. To fix the first problem we add a bit of delay so that the trade has been updated when we apply the mailbox messages. A better fix would be to change the order of the methods but that is a bit tricky to get right and I dont want to risk that for that release. The second problem would require a large change to trigger the mailbox processing based on wallet state. We prefer to be more tolerant with the expected phase instead so allow the mailbox message to be processed also in the DEPOSIT_PUBLISHED state. This has no risks as the payout tx would be invalid anyway if the buyer has cheated and sent the msg in not confirmed deposit tx state (only possible with code manipulation). A better fix would to add a listener for the wallet and process the mailbox msg once wallet is ready and trade state set, but I leave that for another PR. |
||
---|---|---|
.. | ||
.tx | ||
src | ||
update_translations.sh |