bisq/core
ghubstan 7351b08850
Reduce # of hash calculations in UI OfferBook view
We can cache an offer payload hash as soon as its `offerFeePaymentTxId`
is set.  (The payload hash cannot be calculated until the object can
be transformed into a protobuf message, which requires a non-null
offerFeePaymentTxId.)

Another benefit is removal of the payload hash argument from the
`OfferBookListItem` constructor.

Changes include

- `OfferPayload` Added `transient byte[] hash` field + getter method
   (where hash is calculated and cached).

- `OfferBookService` Removed `P2PDataStorage.ByteArray hashOfPayload`
   parameter from `OfferBookChangedListener` listener methods
  `onAdded` & `onRemoved`.  (Hash is cached in `OfferPayload`.)

- `P2PDataStorage` Added null check to `ByteArray` class constructor.

- `OfferBook` Adjusted for change to `OfferBookChangedListener`.
   Also removed redundant payload hash null checks.

- `TakeOfferDataModel` and `MarketAlerts` Adjusted for change to
  `OfferBookChangedListener`.

- `OfferBookListItem` Removed overloaded constructor with
  `@Nullable P2PDataStorage.ByteArray hashOfPayload` parameter.
   (Field value is set from cached offer payload hash.)

- `OfferBookViewModelTest` and `OfferMaker`  Adjusted test and test fixture:
   do not attempt to create offer payloads without an `offerFeePaymentTxId`.
2021-09-01 15:48:35 -03:00
..
.tx
src Reduce # of hash calculations in UI OfferBook view 2021-09-01 15:48:35 -03:00
update_translations.sh Update translations for v1.5.0 and adding Czech and Italian 2020-11-09 09:18:47 +01:00