mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity
14,173 Commits 4 Branches 148 Tags 4.3 GiB
eabb173767
Commit Graph

14173 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
sqrrm
eabb173767
Add NGN as a default currency 2021-03-10 14:41:28 +01:00
sqrrm
463f87b39e
Merge pull request #5284 from ghubstan/07-validate-paymentacct-n-new-offer 
Validate offer <-> payment-acct in createoffer
 2021-03-09 16:51:56 +01:00
ghubstan
389abf459d
Check valid createoffer opt values with asserts 2021-03-09 10:43:05 -03:00
sqrrm
343d311a25
Merge pull request #5273 from ghubstan/05-doc-test-disputeagents 
Document test harness dispute agent registration
 2021-03-09 11:53:28 +01:00
sqrrm
3ab184c8da
Merge pull request #5259 from ghubstan/04-fix-feerate-validation-bug 
Fix CLI number opt validation, improve server-not-up msg
 2021-03-09 11:52:29 +01:00
sqrrm
6f0f0ef5fc
Merge pull request #5250 from ghubstan/03-fix-interceptor-method-key-lookup 
Fix call rate metering interceptor bug
 2021-03-09 11:50:08 +01:00
sqrrm
7fa1b8043f
Merge pull request #5249 from ghubstan/02-improve-server-error-logging 
Improve gRPC server error logging
 2021-03-09 11:44:03 +01:00
sqrrm
03f6468d26
Merge pull request #5246 from ghubstan/01-show-cost-in-trade-output 
Display buyer's cost in api's gettrade output
 2021-03-09 11:41:14 +01:00
Christoph Atteneder
11964e5ed8
Merge pull request #5280 from chimp1984/prevent-persist-at-startup 
Prevent persist at startup, flush at backup
 2021-03-09 11:40:27 +01:00
Christoph Atteneder
b938776aad
Merge pull request #5288 from wallclockbuilder/patch-1 
Replace slack with Keybase
 2021-03-09 09:21:44 +01:00
Christoph Atteneder
dd7550931f
Merge pull request #5262 from BtcContributor/fixwindowslinkdao 
Fix opening of proposal links in DAO on Windows
 2021-03-09 09:20:30 +01:00
Mawueli Kofi Adzoe
5a31461b3d
Replace slack with Keybase 2021-03-08 13:05:00 -08:00
ghubstan
2161c936f1
Adjust canceloffer to getmyoffer bugfix (commit d6c79fc) 2021-03-08 16:36:01 -03:00
ghubstan
d6c79fca70
Filter out 'my' offers from 'available' offers 2021-03-08 16:26:16 -03:00
ghubstan
04b52f873e
Fix setSelectedCurrency bug, and replace unnecessary reflection usage 
Commit de59c0a5f9 did not persist the
assigned selected currency, this fixes the bug.
 2021-03-08 16:02:18 -03:00
ghubstan
75d81d9095
Avoid test run repetition, add warning supressions 2021-03-08 15:26:15 -03:00
ghubstan
de59c0a5f9
Assign selected trading currency on new payment accts (api only) 
If a new account has a trading currency, assign it as the selected trading currency.

Also fixed a payment acct console formatting issue (left justify the ccy code).
 2021-03-08 15:22:28 -03:00
ghubstan
b4f4d90e05
Add tradeCurrencies field to Transferwise acct form 
These changes make tradeCurrencies a required twise acct form field.

Addresses issue https://github.com/bisq-network/bisq/issues/5281

- Added comment to PaymentAccountForm about special 'tradeCurrencies' field handling.
- Added support for Transferwise 'tradeCurrencies' to PaymentAccountTypeAdapter.
- Added instance of isTransferwiseAccount check to PaymentAccount.
- Added methods to CurrencyUtil to convert comma delimited code list to TradeCurrency list.
- Added methods to ReflectionUtil for getting fields and methods on class.
- Added required field check to CorePaymentAccountsService.
- Added CreatePaymentAccount test cases.
 2021-03-08 14:47:30 -03:00
ghubstan
baca7001ea
Fix unnecessary use of fully qualified name 'String.format' 2021-03-07 20:05:39 -03:00
ghubstan
99fea74e09
Validate offer <-> payment-acct in createoffer 
This change prohibits creation of new offers with incompatible payment
accounts with the api.

- PaymentAccountUtil
  Renamed isAnyTakerPaymentAccountValidForOffer -> isAnyPaymentAccountValidForOffer.
  Renmaed isTakerPaymentAccountValidForOffer -> isPaymentAccountValidForOffer.
  Deleted commented code.

- PaymentAccounts: Adjusted to PaymentAccountUtil method name changes.

- OfferFilter: Adjusted to PaymentAccountUtil method name changes.

- OfferBookViewModelTest: Adjusted to PaymentAccountUtil method name changes.

- Add CoreOffersService#verifyPaymentAccountIsValidForOffer

- ValidateCreateOfferTest, OfferTest: Added test cases.
 2021-03-07 19:51:29 -03:00
chimp1984
f43dc2032f
Handle flush at shutdown differently to flush at backup 2021-03-06 12:02:17 -05:00
chimp1984
6fac9b17f1
Trigger persistence at onAllServicesInitialized in case 
we got a requestPersistence called before initialized
 2021-03-06 10:59:55 -05:00
chimp1984
a055a8bd36
Call PersistenceManager.flushAllDataToDisk before doing backup 2021-03-06 10:36:14 -05:00
chimp1984
2f814fae47
Make allServicesInitialized final 2021-03-06 10:35:49 -05:00
chimp1984
ab5b29cd15
Refactor: Rename field 2021-03-06 10:24:58 -05:00
chimp1984
569a2de641
Call onAllServicesInitialized on PersistenceManager and 
prevent write to disk before it is called.

In case the user started Bisq 2 times, the second process
would have called the flushAllDataToDisk at shutdown and
overwrote data from the running app.
 2021-03-06 10:24:25 -05:00
ghubstan
a13ef79e6e
Handle require-arg options missing the = sign 
This change ensure a stylistically consistent error message is printed
to the CLI console if an option is present, but without the '=' sign.
 2021-03-05 12:28:10 -03:00
ghubstan
9c12b31019
Add new cli option parser test 
Does not check every combination of options for every method, but
we finally have an option parser test case to build on.
 2021-03-05 07:16:36 -03:00
ghubstan
304781ce92
Add jupiter test support to :cli subproject 2021-03-05 07:15:01 -03:00
ghubstan
d01a7b7fee
Improve required-argument opt validation 
Make sure non-empty opt values are present in the parsers' custom
validation, or jsimpleopt will throw exceptions with stylistically
inconsisent messages.
 2021-03-05 07:10:42 -03:00
ghubstan
62ff79d718
Update cli getoffers smoke test to posix style opts 2021-03-05 07:09:41 -03:00
ghubstan
cfaa539a5e
Fix opt validation bugs in CLI 
Unset empty string default values on some the createoffer method's
required option declarations in CreateOfferOptionParser, and adds a
check for presence of required currency-code option.

- Removes default "" value from required opt direction.
- Removes default "" value from required opt currency-code.
- Removes default "" value from required opt amount.
- Removes default "" value from required opt min-amount.
- Removes default "" value from required opt fixed-price.
- Removes default "" value from required opt security-deposit.
- Check for required currency-code option.

Unset empty string default values on some of the createoffer method's
required option declarations in TakeOfferOptionParser.

- Removes default "" value from required opt offer-id.
- Removes default "" value from required opt payment-account.

Other opt parser default values removed from:

- CancelOfferOptionParser#offer-id
- CreatePaymentAcctOptionParser#payment-account-form
- GetAddressBalanceOptionParser#address
- GetBTCMarketPriceOptionParser#currency-code
- GetOfferOptionParser#offer-id
- GetOffersOptionParser#direction
- GetOffersOptionParser#currency-code
- GetPaymentAcctFormOptionParser#payment-method-id
- GetTradeOptionParser#trade-id
- GetTransactionOptionParser#transaction-id
- RegisterDisputeAgentOptionParser#registration-key
- RegisterDisputeAgentOptionParser#dispute-agent-type
- RemoveWalletPasswordOptionParser#wallet-password
- SendBsqOptionParser#address
- SendBsqOptionParser#amount
- SendBtcOptionParser#address
- SendBtcOptionParser#amount
- SetTxFeeRateOptionParser#tx-fee-rate
- SetWalletPasswordOptionParser#wallet-password
- UnlockWalletOptionParser#wallet-password
- UnlockWalletOptionParser#timeout
- WithdrawFundsOptionParser#trade-id
- WithdrawFundsOptionParser#address
 2021-03-04 13:03:04 -03:00
ghubstan
a2000bdc33
Explain how to manually register test dispute agents 2021-03-03 12:44:29 -03:00
ghubstan
e0bf773564
Add link to api-beta-test-guide.md 2021-03-03 12:43:21 -03:00
Christoph Atteneder
3b1158a908
Merge pull request #5267 from jmacxx/fix_mailbox_bootstrap 
Fix mailbox bootstrap issue
 2021-03-03 11:57:20 +01:00
jmacxx
f936210717
fix mailbox bootstrap issue 2021-03-02 14:34:03 -06:00
ghubstan
8590c67670
Remove warning supression 2021-03-02 14:40:36 -03:00
ghubstan
2473ff6374
Fix tx-fee-rate formatting (and math) bug in cli/CurrencyFormat 
Now prints '<integer> sats/byte' to console.
 2021-03-02 13:28:51 -03:00
BtcContributor
e28843dd41
fix opening windows dao links 2021-03-02 13:14:25 +01:00
sqrrm
411395bf94
Merge pull request #5260 from bisq-network/hotfix/v1.5.8 
Hotfix/v1.5.8
 2021-03-02 11:55:37 +01:00
Christoph Atteneder
bdf6463e61
Merge branch 'master' of github.com:bisq-network/bisq into hotfix/v1.5.8 
# Conflicts:
#	build.gradle
#	desktop/package/linux/Dockerfile
#	desktop/package/linux/package.sh
#	desktop/package/linux/release.sh
#	desktop/package/macosx/create_app.sh
#	desktop/package/macosx/finalize.sh
#	desktop/package/macosx/insert_snapshot_version.sh
#	desktop/package/windows/package.bat
#	desktop/package/windows/release.bat
#	relay/src/main/resources/version.txt
 2021-03-02 10:06:49 +01:00
Christoph Atteneder
996e264cfb
Revert to SNAPSHOT version 2021-03-02 10:03:29 +01:00
ghubstan
392c0f58af
Fix CLI number opt validation, improve server-not-up msg 
- Fix tx-fee-rate opt validation bug.

- Tell user what option value is not a number.

- Append ", server may not be running" text to "io exception" exception msg.
 2021-03-01 15:20:08 -03:00
jmacxx
7c80934a17
Field id strings for FeeService extracted to Config.java 2021-03-01 11:25:04 +01:00
jmacxx
a043e3bdf1
Update Preferences tests to new constructor signature 2021-03-01 11:24:56 +01:00
jmacxx
6efeae09c5
Obtain minimumFee from mempool api in place of hardcoded value 2021-03-01 11:24:38 +01:00
Christoph Atteneder
5288d0840b
Bump version number for v1.5.8 2021-03-01 11:24:04 +01:00
Christoph Atteneder
0c9d278629
Merge pull request #5235 from jmacxx/mempool_minimumFee 
Obtain minimumFee from mempool api in place of hardcoded value
 2021-03-01 11:18:16 +01:00
ghubstan
3f84246f59
Improve interceptor's rate metering key definition and lookup 
This change replaces the hard coded strings used as keys in
interceptor rate-metering lookup maps.

Now, the fullMethodName defined in each bisq.proto.grpc.* class'
io.grpc.MethodDescriptor is used, not a hard coded String.

For example, the rate metering lookup key for 'GetBalances',
in 'GrpcWalletsService', is the

   fullMethodName = SERVICE_NAME + '/' + "GetBalances",

   where SERVICE_NAME = "io.bisq.protobuffer.Wallets".

Also adjusted affected tests, and tidy'd up interceptor logging.
 2021-02-28 17:10:51 -03:00
ghubstan
19aed84910
Fix getunusedbsqaddress test 2021-02-27 22:58:22 -03:00