Commit Graph

13342 Commits

Author SHA1 Message Date
chimp1984
e59f480392
Improve popup text in case a local node is detected 2020-12-20 19:02:06 -05:00
sqrrm
99184567b3
Merge pull request #4953 from chimp1984/cache-results-in-account-witness-domain
Cache results in account witness domain
2020-12-20 23:56:51 +01:00
chimp1984
f5bb702d6b
Improve arbitratorSignOrphanWitness method 2020-12-20 10:32:50 -05:00
chimp1984
1462673e57
Use getSignedWitnessSet instead of
iterations over getSignedWitnessMapValues
2020-12-20 10:29:46 -05:00
chimp1984
aea904d24f
We do not need to lookup in getSignedWitnessMapValues
anymore as we maintain the signedWitnessSetByAccountAgeWitnessHash
at each add/remove operation.
2020-12-20 10:28:28 -05:00
chimp1984
b6a01d0ac7
Rename signedWitnessSetCache to signedWitnessSetByAccountAgeWitnessHash
Change comments (after understanding the domain usage better)
Maintain the set at add and remove methods
Use HashMap instead of ConcurrentHashMap as that class is only used
from UserThread and other fields are not threadsafe either.
2020-12-20 10:00:28 -05:00
chimp1984
35e2bf6383
Rename getSignedWitnessSetCache to signedWitnessSetCache 2020-12-20 09:34:00 -05:00
sqrrm
b04a56e543
Merge pull request #4969 from ripcurlx/improve-translations-in-trade-details
Make it easier to translate trade roles
2020-12-18 19:06:49 +01:00
Christoph Atteneder
9a54ccc077
Make it easier to translate trade roles 2020-12-18 17:06:56 +01:00
Christoph Atteneder
ceecb404d2
Merge pull request #4899 from jmacxx/4061_privacy_improvement
Privacy improvements for manual payout
2020-12-17 15:32:44 +01:00
Christoph Atteneder
a3824f8151
Merge pull request #4961 from m52go/remove-btcnode-ip
Remove m52go btc node ip
2020-12-17 10:01:52 +01:00
jmacxx
e888be3192
review fix: try..catch around all parseCoin() 2020-12-16 22:15:16 -06:00
sqrrm
113bb4f7f2
Merge pull request #4963 from chimp1984/fix-case-if-no-data-store-service-is-available
Call completeHandler if services in store services is empty.
2020-12-17 00:55:26 +01:00
chimp1984
4c575098b7
Call completeHandler if services in store services is empty.
If oen starts with --daoActivated=false there is no service
set up in one of the data store services so it never calls
the result handler and the app never starts up.
2020-12-16 16:21:10 -05:00
m52go
4e4cb42f6a
Remove m52go btc node ip 2020-12-16 12:50:46 -05:00
sqrrm
86d81762f6
Merge pull request #4949 from chimp1984/show-pricedeviation-for-fixed-price-offers
Show price deviation in % for fixed price offers and BSQ
2020-12-16 15:30:14 +01:00
Christoph Atteneder
0789180bb0
Merge pull request #4957 from sqrrm/sign-single-account
Sign single account
2020-12-16 14:07:34 +01:00
sqrrm
4cdd94ac28
Merge pull request #4955 from chimp1984/cache-frequent-method-calls
Cache results of isFiatCurrency and isCryptoCurrency
2020-12-16 12:11:58 +01:00
sqrrm
25328167de
Merge pull request #4958 from chimp1984/disable-tx-broadcast-if-connected-to-local-node
Do not use tx broadcast to mempool nodes if a local btc nodes is used
2020-12-16 12:10:19 +01:00
chimp1984
bb3dbf3d78
Add null check (for tests) and fix missing param for test class.
Fix test with price display.
2020-12-15 23:29:53 -05:00
chimp1984
1106d01ff7
Set bsq30DayAveragePrice only at activate as its expensive
call and does not change frequently and is only used for
informational purpose as % display.
2020-12-15 23:29:52 -05:00
chimp1984
c858ac7b7d
Add check to not devide by 0
Cleanups
2020-12-15 23:29:52 -05:00
chimp1984
34f10d37ef
Add price deviation in % to BSQ using 30 day average 2020-12-15 23:29:52 -05:00
chimp1984
f97bb6228b
Show also % price deviation for fixed price and
sort according to it
Allow sorting at show all. This helps to spot
good offers with negative % over the whole market.
2020-12-15 23:29:52 -05:00
chimp1984
59cfb2d3a9
Do not use tx broadcast to mempool nodes if a local btc nodes is used
See discussion at: https://github.com/bisq-network/bisq/pull/4943#issuecomment-745615764
2020-12-15 20:04:38 -05:00
chimp1984
f2273e663d
Use ConcurrentHashMap for cache.
As the normal maps are not using a ConcurrentHashMap it is
likely unnecessary as well that I am not aware of a
multi-threaded access.
But as it does not show any difference in performance
it is likely the bit more safe option.
2020-12-15 19:15:40 -05:00
chimp1984
425bfa3bf7
Fix failing test (remove did operate on map
directly and we did not remove the item from the cache)

- Add getSignedWitnessMapValues method for access to signedWitnessMap values
- Remove Getter for signedWitnessMap
- Add removeSignedWitness method (used in test only)
- Use addToMap in test instead of direct access to map
- Remove getSignedWitnessSetCache entry matching
signedWitness.getHashAsByteArray() as well.
See comment. @sqrrm: Can you cross check?
2020-12-15 19:15:40 -05:00
chimp1984
359dc3759d
Add getSignedWitnessSetCache
The getSignedWitnessSet is called very often and is a bit
expensive. We cache the result in that map but we
remove the cache entry if we get a matching SignedWitness
added to the signedWitnessMap.
2020-12-15 19:15:40 -05:00
chimp1984
1314fd61a5
Add accountAgeWitnessCache
The accountAgeWitnessMap is very large (70k items) and
access is a bit expensive. We usually only access less
than 100 items, those who have offers online. So we
use a cache for a fast lookup and only if
not found there we use the accountAgeWitnessMap and
put then the new item into our cache.
2020-12-15 19:15:40 -05:00
chimp1984
ecad724046
Add null checks, improve comment 2020-12-15 19:08:37 -05:00
sqrrm
f61e62c7c0
Merge pull request #4956 from chimp1984/sort-paymentmethods-by-name
Sort payment methods by display string not by id.
2020-12-16 00:17:26 +01:00
sqrrm
fa01192661
Merge pull request #4952 from chimp1984/fix-priv-message-from-peer-icon
Allow sending private notifications from avatar icon at trade
2020-12-16 00:15:46 +01:00
sqrrm
9b8073b94a
Merge pull request #4954 from chimp1984/various-small-improvements
Various small improvements
2020-12-15 23:04:15 +01:00
sqrrm
bc60db39ae
Merge pull request #4943 from chimp1984/add-tx-broadcast-to-mempool-explorer-api
Add tx broadcast to mempool explorer api
2020-12-15 22:57:37 +01:00
sqrrm
26024bd6ec
Refactor: rename methods, move return statement 2020-12-15 19:35:49 +01:00
sqrrm
e0f4dc22e7
Fix formatting 2020-12-15 19:27:13 +01:00
sqrrm
4c33f9c999
Sign imported AccountAgeWitness,PubKey
Change the specific sign window to sign an imported account in the form
of accountAgeWitnessString,pubKeyString. The SignSpecificWitness never
worked due to missing pubKey data and this is a way to import the missing data.
2020-12-15 16:08:06 +01:00
chimp1984
0f084d3aec
Use ConcurrentHashMap
Add comment
2020-12-15 09:05:33 -05:00
sqrrm
de25105fa8
Copy account data to clipboard
Use ctrl+c to copy accountagewitness and pubkey to clipboard in a format to
be used by arbitrator to sign the account
2020-12-15 14:53:34 +01:00
chimp1984
7e145739c3
Cache hash to avoid expensive hash operation. 2020-12-15 01:05:16 -05:00
chimp1984
f7a706518c
Use PRIVATE_LOW_PRIO instead of PRIVATE for sequenceNumberMap
to reduce cpu load for persistence.
2020-12-15 01:03:52 -05:00
chimp1984
1ddde42e17
Keep Date as transient field to avoid recreating a
Data object at each getDate call.

Add JsonExclude to Offer.currencyCode

getDate get called very often and we have > 80k objects.
2020-12-15 01:02:49 -05:00
chimp1984
9fc4f61bf6
Cache currencyCode
Extract variable

getCurrencyCode get called very often (Comparatos) so we cache result.
2020-12-15 00:59:05 -05:00
chimp1984
02d163f5dc
Only log in case the operation took longer than 100 ms 2020-12-15 00:56:06 -05:00
chimp1984
5112b1a54b
Cache results of isFiatCurrency and isCryptoCurrency
They are called very often and accumulate cpu time as
shown in profilers.
2020-12-15 00:54:26 -05:00
chimp1984
d7a95fed03
Pass trade if available and use peers keyring 2020-12-15 00:40:45 -05:00
jmacxx
b1d22af1ae
Privacy improvements for manual payout
Redesign the UI
Add import/export of payout settings
Add ability to import from mediation ticket
Mediator does not need private key
User can sign using own wallet or private key
Validation of input fields
Calculate the tx fee based on inputs
Display of the generated txid & hex so it can be checked
2020-12-14 22:19:37 -06:00
sqrrm
0e7dd21745
Merge pull request #4916 from chimp1984/fix-access-from-wrong-thread-at-wallet-restore
Property fields must not be set from non JavaFX threads.
2020-12-14 23:56:14 +01:00
chimp1984
5c68ad0b47
Sort payment methods by display string not by id.
Apply sorting in drop down boxes.
2020-12-14 14:42:15 -05:00
Christoph Atteneder
7d12b94c6a
Merge pull request #4933 from chimp1984/add-num-items-to-tables
Improve funds and portfolio screens
2020-12-14 19:48:55 +01:00