chimp1984
544dd895fc
Rename trade.getState to getTradeState
2021-10-20 23:59:29 +02:00
chimp1984
5b0e9ab92f
Rename trade.getPhase to getTradePhase
2021-10-20 23:57:55 +02:00
chimp1984
e061d6a476
Replace Value with Getter
2021-10-20 23:54:50 +02:00
chimp1984
9d106468b0
Move getRandomOfferId method to OfferUtil
...
Add more methods to OfferUtil
Cleanups
2021-10-20 23:54:12 +02:00
chimp1984
a3b3d561ec
Simplify
2021-10-20 23:53:01 +02:00
chimp1984
d976f11e09
Add methods
2021-10-20 23:52:27 +02:00
chimp1984
8d2579866a
Replace Value annotation with Getter and EqualsAndHashCode
2021-10-20 23:51:16 +02:00
chimp1984
9e4be1367a
Change log level
2021-10-20 23:50:52 +02:00
chimp1984
02d7dfdaef
Only print stack trace if dev mode
2021-10-20 23:49:53 +02:00
chimp1984
d7f1b00221
Rename processModel.getTradingPeer to getTradePeer
2021-10-20 22:58:20 +02:00
chimp1984
c15fc0c0a7
Add comment, cleanups
2021-10-20 22:53:27 +02:00
chimp1984
cfc404b4c0
Rename signTx to signTxAndVerifyNoDustOutputs (no code change)
2021-10-20 16:29:00 +02:00
chimp1984
d95356be21
Add verifiedBalance field.
...
Use WalletService.signTx and WalletService.verifyNonDustTxo inside signTx instance method
2021-10-20 16:28:37 +02:00
chimp1984
5f8bc834f7
Remove unused signTx method
2021-10-20 16:27:48 +02:00
chimp1984
54e81d1473
Add signTx and verifyNonDustTxo methods
2021-10-20 16:27:34 +02:00
chimp1984
e582ffddad
Add new methods
2021-10-20 16:06:22 +02:00
chimp1984
0f6364d2bd
Inline TransactionWitness
...
Add line breaks, cleanups
2021-10-20 16:05:47 +02:00
chimp1984
47572888e7
Add isMine method. Add error logs
2021-10-20 15:53:01 +02:00
chimp1984
34c4eefb59
Add allowSpendMyOwnUnconfirmedTxOutputs flag to BsqCoinSelector
...
Extract variable for TxOutputKey
2021-10-20 15:47:30 +02:00
chimp1984
75072ebc26
Add deprecated annotation, null checks and comment to getRawInputFromTransactionInput
2021-10-20 13:41:21 +02:00
chimp1984
a927bea71f
Add scriptTypeId to RawTransactionInput
...
Add convenience methods
2021-10-20 13:36:41 +02:00
chimp1984
f8751a8c4d
Make TxConfidenceListener and its onTransactionConfidenceChanged method abstract
...
Use lombok getter
2021-10-20 13:28:32 +02:00
chimp1984
d4bb026e3e
Only check for localhost btc node if mainnet
2021-10-20 13:26:37 +02:00
chimp1984
88198be7ff
Rename availableConfirmedBalance to availableBalance
...
It does not include only confirmed txs as we include
the unconfirmed own change outputs.
2021-10-20 13:25:29 +02:00
chimp1984
dad19ba1c1
Add isFiat and isAltcoin methods.
...
Use isFiat instead of negation of isBlockchain.
Use isAltcoin if all non btc assets are targeted
2021-10-20 13:12:54 +02:00
chimp1984
6cf0a7c126
Rename paymentMethod.isAsset to paymentMethod.isBlockchain
...
We will need later to distinguish between BSQ and other Blockchain assets
2021-10-20 12:52:59 +02:00
chimp1984
dfbc746d5b
Move Offer.Direction one level up and rename to OfferDirection
2021-10-20 12:51:41 +02:00
chimp1984
d1d1706a7f
Add delegate methods to offer
...
Remove unused methods
2021-10-20 12:49:11 +02:00
chimp1984
dca0c93f47
Cleanups
2021-10-20 12:20:53 +02:00
chimp1984
734d429cc9
Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model
2021-10-20 11:58:04 +02:00
chimp1984
afed78813d
Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public
2021-10-20 11:58:04 +02:00
chimp1984
401880b64e
Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model
2021-10-20 11:58:04 +02:00
chimp1984
777287af95
Cleanups, refromatting, add final qualifier
2021-10-20 11:58:04 +02:00
chimp1984
2733af955a
Rename txID to txId
2021-10-20 11:58:04 +02:00
chimp1984
e1de502a9b
Rename ProcessModelServiceProvider to Provider
2021-10-20 11:58:04 +02:00
chimp1984
eacf446ab4
Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1
2021-10-20 11:58:04 +02:00
chimp1984
956ffc902d
Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1
2021-10-20 11:58:04 +02:00
chimp1984
e80cdf8ac7
Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1
2021-10-20 11:58:04 +02:00
chimp1984
fe2871baa5
Rename CleanupMailboxMessages to CleanupMailboxMessagesService
2021-10-20 11:58:04 +02:00
chimp1984
fd6934c4e3
Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package
2021-10-20 11:58:04 +02:00
chimp1984
cbf2822cdf
Move messages package into bisq.core.trade.protocol.bisq_v1 package
...
Move TradeMessage into bisq.core.trade.protocol package
2021-10-20 11:58:04 +02:00
chimp1984
97906e05db
Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package
2021-10-20 11:58:04 +02:00
chimp1984
508296c2a3
Move tasks package into bisq.core.trade.protocol.bisq_v1 package
2021-10-20 11:58:04 +02:00
chimp1984
1b2e798faa
Move protocol classes to bisq.core.trade.protocol.bisq_v1 package
2021-10-20 11:58:04 +02:00
chimp1984
e3eea6350c
Make setup in FluentProtocol public
2021-10-20 11:58:04 +02:00
chimp1984
d7b2e99e43
Make FluentProtocol.Event public
2021-10-20 11:58:04 +02:00
chimp1984
3474a2b695
Move TradableList to bisq.core.trade.model package
2021-10-20 11:58:04 +02:00
chimp1984
58cfcffeb9
Move Tradable to bisq.core.trade.model package
2021-10-20 11:58:04 +02:00
chimp1984
fc3177c23f
Move MakerTrade and TakerTrade to bisq.core.trade.model package
2021-10-20 11:58:04 +02:00
chimp1984
d42242762f
Move Trade to bisq.core.trade.model.bisq_v1 package
2021-10-20 11:58:04 +02:00
chimp1984
8b21b85c3e
Make updateDepositTxFromWallet public
2021-10-20 11:58:04 +02:00
chimp1984
1e9b606544
Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,
...
BuyerAsMakerTrade, BuyerAsTakerTrade, BuyerTrade
to bisq.core.trade.model.bisq_v1 package
2021-10-20 11:58:04 +02:00
chimp1984
1b4c4871c0
Rename OfferFilter to OfferFilterService
2021-10-20 11:58:04 +02:00
chimp1984
7197b316fc
Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1
2021-10-20 11:58:04 +02:00
chimp1984
1badd699a4
Move bisq.core.offer.messages package into package bisq.core.offer.availability
2021-10-20 11:58:04 +02:00
chimp1984
a2d1e8888d
Move AvailabilityResult into package bisq.core.offer.availability
2021-10-20 11:58:04 +02:00
chimp1984
e348000cb1
Move TakeOfferModel into package bisq.core.offer.bisq_v1
2021-10-20 11:58:04 +02:00
chimp1984
d9fd8a45f7
Move TriggerPriceService into package bisq.core.offer.bisq_v1
2021-10-20 11:58:04 +02:00
chimp1984
042476a68a
Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1
2021-10-20 11:58:04 +02:00
chimp1984
4341a7e0d2
Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1
2021-10-20 11:58:04 +02:00
chimp1984
edf5c3e097
Move CreateOfferService into package bisq.core.offer.bisq_v1
2021-10-20 11:58:04 +02:00
chimp1984
41d9d3f505
Move OfferPayload into package bisq.core.offer.bisq_v1
2021-10-20 11:58:04 +02:00
m52go
94d3638d98
Remove m52go bitcoin node
2021-10-20 10:29:12 +02:00
wiz
48a0ebe309
Add new v3 onions for wiz's bitcoin nodes
2021-10-19 19:30:36 +02:00
Christoph Atteneder
e39ae59683
Update translations for v1.7.5
2021-10-19 11:33:35 +02:00
Jakub Loucký
adf0562152
Remove duplicate "maximum" in payment descriptions
2021-10-16 23:45:38 +02:00
Jakub Loucký
b84df6ec2b
Fix typo
2021-10-16 23:39:23 +02:00
Jakub Loucký
69c563e3d4
Fix typo in Pix info
2021-10-16 23:33:07 +02:00
Jakub Loucký
bd27b45abe
Fix sentence about Strike
2021-10-16 23:33:06 +02:00
Jakub Loucký
dff043d8c4
Fix typo (SHA)
2021-10-16 22:53:36 +02:00
jmacxx
b72b70ee8c
Add payment methods Strike and Verse
2021-10-12 14:37:26 -05:00
Christoph Atteneder
596e819629
Merge pull request #5748 from jmacxx/fix_sepa_eu_countries_comparator
...
Fix logic of SEPA country comparison routine
2021-10-12 10:04:46 +02:00
Christoph Atteneder
9ad4671773
Merge pull request #5746 from jmacxx/missing_invalid_transaction_diagnostic
...
Fix issue of Trade Step 1 validation done too soon
2021-10-12 10:02:23 +02:00
jmacxx
9f95aa3607
Fix logic of SEPA country comparison routine
2021-10-11 17:38:05 -05:00
jmacxx
9ab659ceac
Fix issue of Trade Step 1 validation done too soon
...
Deprecate 4 states which are not used.
ShareBuyerPaymentAccountMessage can arrive before deposit broadcast completes.
2021-10-11 09:31:57 -05:00
Christoph Atteneder
2d3182ca2f
Merge pull request #5745 from jmacxx/add_monese_satispay
...
Add payment methods Monese and Satispay
2021-10-11 09:29:36 +02:00
Christoph Atteneder
2e38c3cf35
Merge pull request #5742 from jmacxx/trader_chat_trade_complete
...
Allow trader chat to continue after trade complete
2021-10-09 13:03:32 +02:00
jmacxx
df2d0b3332
Add payment methods Monese and SatisPay
2021-10-07 17:28:42 -05:00
jmacxx
c13fb950e3
Allow trader chat after trade complete
2021-10-06 19:25:39 -05:00
ghubstan
5f521068ea
Remove unused PriceFeedService
2021-10-05 14:46:06 -03:00
ghubstan
30135177f8
Remove transitive javafx.collections dependency
2021-10-05 14:44:30 -03:00
ghubstan
738d22fbdf
Rename method, add static import
2021-10-05 14:23:32 -03:00
ghubstan
999c4a516d
Refactor desktop Closed Tradable model utils for API use
...
Move some potentially sharable utility code from desktop's ClosedTrade
models to core's new ClosedTradeUtil.
The API's `gettrades --category=<open|closed|failed>` method will need
some of this logic on the server side, but the scope of this refactoring
is larger in the interest of a more complete refactor, and avoiding
duplication in the future.
2021-10-05 14:13:51 -03:00
sqrrm
bef38e6e01
Merge pull request #5736 from bisq-network/revert-5680-community-tab
...
Revert "Community tab"
2021-10-04 11:56:25 +02:00
Christoph Atteneder
b7859e3ce4
Merge pull request #5741 from jmacxx/add_payments_pix_bizum
...
Add payment methods Bizum and Pix
2021-10-04 10:32:03 +02:00
jmacxx
b156f034ad
add payment methods Bizum and Pix
2021-10-03 18:19:37 -05:00
ghubstan
db6e2a51b2
Move volume formatting from DisplayUtils to VolumeUtil
...
In practice, presentation/display logic should be kept in UIs, but the core
api will need to duplicate a very small part of the code in DisplayUtils if
a very small part of this refactoring is not done. Instead of moving a tiny
bit of the volume formatting methods, all of them are moved to core.
2021-10-02 17:33:25 -03:00
Christoph Atteneder
2cca574427
Merge pull request #5724 from jmacxx/add_nequi
...
Add Nequi payment method
2021-09-30 10:06:54 +02:00
Christoph Atteneder
94d56e4e47
Revert "Community tab"
2021-09-30 10:03:09 +02:00
Christoph Atteneder
f8e99c5a17
Merge pull request #5731 from chimp1984/remove-vs-seeds-from-monitor
...
Remove v2 nodes and backup nodes from DAO monitor
2021-09-30 09:53:30 +02:00
sqrrm
0df7e44c35
Merge pull request #5727 from ripcurlx/remove-trade-id-reference
...
Remove trade id reference for Amazon gift card
2021-09-28 16:25:44 +02:00
chimp1984
40003ff79b
Remove v2 seed nodes
2021-09-28 16:09:18 +02:00
sqrrm
5e84713520
Merge pull request #5730 from bisq-network/release/v1.7.4
...
Release/v1.7.4
2021-09-28 15:05:42 +02:00
jmacxx
f792db98d0
add Nequi payment method
...
Signed-off-by: jmacxx <47253594+jmacxx@users.noreply.github.com>
2021-09-28 07:51:06 -05:00
jmacxx
9e5a1c2fd4
add payment method CelPay
...
Signed-off-by: jmacxx <47253594+jmacxx@users.noreply.github.com>
2021-09-28 07:51:05 -05:00
Christoph Atteneder
14c2e37cca
Merge pull request #5704 from ghubstan/fix-cli-alt-trade-volume-bug
...
CLI bug fix: show trade's contract volume, not moving offer volume
2021-09-27 11:17:21 +02:00
Christoph Atteneder
e98ae2becf
Merge pull request #5719 from jmacxx/clockwatcher_popup
...
Show a warning if PC has been in sleep mode
2021-09-27 11:06:58 +02:00
Christoph Atteneder
b098656d0d
Merge pull request #5680 from xyzmaker123/community-tab
...
Community tab
2021-09-27 11:04:13 +02:00
Christoph Atteneder
2ec6e6f198
Remove trade id reference for Amazon gift card
2021-09-27 09:52:31 +02:00
Christoph Atteneder
c4d0117988
Merge pull request #5696 from jmacxx/add_indian_payment
...
Add five Indian payment methods
2021-09-27 09:40:21 +02:00
Christoph Atteneder
ccb73a3895
Merge pull request #5711 from chimp1984/fix-data-handling-if-dao-is-deactivated
...
Fix data handling if dao is deactivated
2021-09-26 19:01:05 +02:00
chimp1984
45af00a3c1
Update text
2021-09-23 20:52:40 +02:00
chimp1984
d01f82a5db
Adjust the UI in case the DAO is disabled
2021-09-23 19:11:09 +02:00
Christoph Atteneder
f8207c4b8f
Update bitcoinj checkpoints for v1.7.4
2021-09-23 09:59:38 +02:00
jmacxx
71c2278a68
show a warning if the computer was in sleep mode for > 10s
2021-09-22 21:22:22 -05:00
jmacxx
ec4b4cdb11
add payment method popup text per spec
2021-09-22 20:07:57 -05:00
jmacxx
566dbdc765
display agent keybase link
2021-09-22 09:13:00 -05:00
Christoph Atteneder
945202622e
Deactivate @KanoczTomas BTC core node until a Tor v3 address is provided
2021-09-21 10:19:34 +02:00
Christoph Atteneder
76cf477ef6
Deactivate @KanoczTomas BTC core node until a Tor v3 address is provided
2021-09-21 10:17:55 +02:00
sqrrm
f8af74aa76
Merge pull request #5713 from ripcurlx/Emzies-master
...
Update to BTC node Tor v3 onions
2021-09-21 09:33:05 +02:00
Christoph Atteneder
046b39f6be
Update translations for v1.7.4
2021-09-21 09:26:32 +02:00
Christoph Atteneder
ee0f1d74cc
Deactivate @wiz and @robkaandorp BTC nodes until Tor v3 addresses are provided
2021-09-21 09:21:51 +02:00
Christoph Atteneder
6581fc31cb
Fix formatting
2021-09-21 09:21:51 +02:00
Stephan Oeste
a2dc8a68a1
remove trailing space
2021-09-21 09:21:50 +02:00
Stephan Oeste
696bb770e8
Update to BTC node Tor v3 onions
2021-09-21 09:21:50 +02:00
Christoph Atteneder
8a7941a29f
Update @leo816 onion address
2021-09-21 09:21:03 +02:00
Christoph Atteneder
efc2883f01
Deactivate @wiz and @robkaandorp BTC nodes until Tor v3 addresses are provided
2021-09-21 09:09:38 +02:00
Christoph Atteneder
1dea1a134a
Fix formatting
2021-09-21 09:09:05 +02:00
chimp1984
2419e1dae5
Add dao activated toggle to preferences
...
We write the value to the properties file not to
the preferences as we need the value early at startup
before the preferences are loaded.
2021-09-21 01:31:13 +02:00
Christoph Atteneder
ec20bb1784
Update @leo816 onion address
2021-09-20 20:50:06 +02:00
Stephan Oeste
a6ca8985f3
remove trailing space
2021-09-20 20:20:52 +02:00
Stephan Oeste
3bee0cca96
Update to BTC node Tor v3 onions
2021-09-20 18:54:21 +02:00
ghubstan
484f882077
Show frozen fiat trade cost in CLI console
...
This is a bug fix for the CLI's displayed fiat trade cost
value, which should be trade.volume, not offer.volume. Offer volume
varies with BTC volatility, and the CLI should be showing the trade.volume
value instead, frozen when the contract is made.
2021-09-17 16:25:37 -03:00
sqrrm
fae1852220
Merge pull request #5685 from ghubstan/1-fix-api-payacct-ccy-support
...
Let API user set currencies in some payment account json forms
2021-09-17 14:07:09 +02:00
ghubstan
1a9cdfbdd3
Return early when field name match fails
...
Resolves https://github.com/bisq-network/bisq/pull/5685#discussion_r710002786
2021-09-16 09:31:22 -03:00
jmacxx
78cd61564c
Add five Indian payment methods
2021-09-15 15:25:43 -05:00
xyzmaker123
7f2c01e02d
Community tab - use AutoTooltip components, define elements in java instead fxml
2021-09-15 17:31:13 +02:00
xyzmaker123
393acf6961
Community tab
2021-09-15 12:26:31 +02:00
Christoph Atteneder
90b2f9eeae
Merge pull request #5672 from jmacxx/swift_payment_method
...
Add SWIFT payment method
2021-09-13 14:49:47 +02:00
jmacxx
51eca30770
customize payment popup fee info for SWIFT
2021-09-13 06:44:17 -05:00
jmacxx
e2dac437ab
text modifications by m52go
...
Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
2021-09-08 15:07:22 -05:00
jmacxx
3430055144
add SWIFT payment method
...
rebased to master
2021-09-08 14:57:08 -05:00
ghubstan
ab929d4435
Remove spurious PaymentAccount#canSupportMultipleCurrencies()
...
Method was added on the false assumption `PaymentAccount#hasMultipleCurrencies()`
would not always return a correct value when a `PaymentAccount` instance is created
via reflection. But `hasMultipleCurrencies()` will work as long as appropriate
PaymentAccount subclasses continue setting their `tradeCurrencies` fields within
their default constructors.
2021-09-07 11:31:56 -03:00
ghubstan
f7e6898077
Let users specify trade ccys and selected trade ccy in json form
...
Several payment methods support multiple trade currencies and a selected
trade currency, but the api's payment account creation has not let CLI
users specify them in the json form passed to the `createpaymentacct`
command.
This change adds `tradeCurrencies` and `selectedTradeCurrency` fields
to the appropriate json forms.
2021-09-06 12:24:51 -03:00
ghubstan
a2bc999692
Adjust to PaymentAccount change in commit de23fc0
2021-09-06 12:23:56 -03:00
ghubstan
19e9c78f51
Do single trade currency check in api generated payment acct
2021-09-06 12:21:29 -03:00
ghubstan
de23fc0083
Replace growing # of instanceof checks with boolean hasPaymentMethodWithId
2021-09-06 12:17:16 -03:00
ghubstan
80a72dc520
Format comments, add one
2021-09-06 12:13:16 -03:00
ghubstan
f39e611150
Wrap long i18n strings for use in API
...
Some i18n property values can be used by the API if long strings are
wrapped before written as commments to json payment account forms, or
written to the CLI console.
This change anticipates the addition of the more complex Swift payment
method (PR 5672). PR 5672's i18n property value for key "payment.swift.info"
will be wrapped and appended to the comments of the Swift payment account's
json form.
2021-09-06 12:12:09 -03:00
Christoph Atteneder
e8f417fdf5
Merge pull request #5679 from jmacxx/fix_deposit_received_from_network_issue
...
Fix failed trade / missing payment information
2021-09-06 11:34:55 +02:00
ghubstan
7351b08850
Reduce # of hash calculations in UI OfferBook view
...
We can cache an offer payload hash as soon as its `offerFeePaymentTxId`
is set. (The payload hash cannot be calculated until the object can
be transformed into a protobuf message, which requires a non-null
offerFeePaymentTxId.)
Another benefit is removal of the payload hash argument from the
`OfferBookListItem` constructor.
Changes include
- `OfferPayload` Added `transient byte[] hash` field + getter method
(where hash is calculated and cached).
- `OfferBookService` Removed `P2PDataStorage.ByteArray hashOfPayload`
parameter from `OfferBookChangedListener` listener methods
`onAdded` & `onRemoved`. (Hash is cached in `OfferPayload`.)
- `P2PDataStorage` Added null check to `ByteArray` class constructor.
- `OfferBook` Adjusted for change to `OfferBookChangedListener`.
Also removed redundant payload hash null checks.
- `TakeOfferDataModel` and `MarketAlerts` Adjusted for change to
`OfferBookChangedListener`.
- `OfferBookListItem` Removed overloaded constructor with
`@Nullable P2PDataStorage.ByteArray hashOfPayload` parameter.
(Field value is set from cached offer payload hash.)
- `OfferBookViewModelTest` and `OfferMaker` Adjusted test and test fixture:
do not attempt to create offer payloads without an `offerFeePaymentTxId`.
2021-09-01 15:48:35 -03:00
jmacxx
74f7061061
Fix race between mempool notify / P2P notify causing failed trade
2021-08-30 10:00:38 -05:00
sqrrm
fc329f6f15
Merge pull request #5678 from bisq-network/release/v1.7.3
...
Release/v1.7.3
2021-08-30 14:29:27 +02:00
sqrrm
58e09c96ee
Merge pull request #5666 from ghubstan/08-handle-extradata-in-editoffer
...
Adjust API 'editoffer' to PR 5651 (include extraData field when editing offer)
2021-08-30 10:46:23 +02:00
Christoph Atteneder
c036adb3eb
Update bitcoinj checkpoints for v1.7.3
2021-08-27 09:30:30 +02:00
jmacxx
984a269776
Add Payment Methods: Paysera and Paxum
2021-08-25 13:38:54 -05:00
Christoph Atteneder
9e72e5b445
Update translations for v1.7.3
2021-08-23 11:22:27 +02:00
ghubstan
b93f6ea28e
Remove sequence-number checks from OfferBook
...
Checking offer payload hashes in OfferBook's onAdded and onRemove methods
is sufficient to prevent incorrect removal of offer list items from the
UI OfferBook view (where api 'editoffer' causes onRemoved to be called
after onAdded on peers).
2021-08-20 11:49:00 -03:00
ghubstan
fb4e00fb6b
Fix OfferBookService bug causing extra check in OfferBook.onRemoved
...
Hash of protectedStorageEntry (should be offerPayload) was sometimes
resulting in incorrect hash being sent to OfferBook listener methods
onAdded(offer, hashOfPayload, sequenceNumber), and
onRemoved(offer, hashOfPayload, sequenceNumber).
Hash of OfferPayload is correctly passed to listener with this change.
Sending the correct hash allows removal of a dubious code block that
removed a book view list item when hash compare failed, and no matching
offer existed in the OfferBookService.
See https://github.com/bisq-network/bisq/pull/5659#discussion_r689634240
2021-08-18 14:27:20 -03:00
ghubstan
1c096d0e3a
Merge branch 'master' into 08-handle-extradata-in-editoffer
...
Resolve file conflicts resulting from merging PRs
https://github.com/bisq-network/bisq/pull/5577
https://github.com/bisq-network/bisq/pull/5651
2021-08-16 12:36:49 -03:00
sqrrm
15093720b9
Merge pull request #5625 from ripcurlx/unsigned-account-tooltip
...
Tooltip for unsigned accounts needs to provide more information
2021-08-16 12:15:43 +02:00
ghubstan
71a61c63da
Display Enabled=PENDING in CLI 'createoffer' output
...
A newly created offer has no OpenOffer+State (AVAILABLE || DEACTIVATED)
when displayed in the CLI's console. This change adds a 'bool isMyPendingOffer'
to the OfferInfo proto + wrapper, and the CLI's console offer output formatter
uses it to determine if it should display a new offer's Enabled column value
as PENDING, instead of an ambiguous NO value.
2021-08-14 16:58:47 -03:00
Christoph Atteneder
9db2c18f2c
Merge pull request #5649 from sqrrm/refund-double-payout-fix
...
Avoid creating more than one refund payout
2021-08-12 20:43:22 +02:00
ghubstan
6e2400fb0f
Ensure UI OfferBook items are correctly added and removed
...
Using the API's CLI to edit offers can sometimes result in add/remove messages
being received on peers in the same batch of envolopes, and these messages
are sometimes passed to the UI in (1) add, (2) remove order. This can result in
a newly edited offer being removed immediately after being added to the OfferBook
list. This change uses storage entry sequence number and storage entry payload
hash comparisons to avoid the problem.
- OfferBookListItem Added new constructor taking P2PDataStorage.ByteArray hashOfPayload,
and int sequenceNumber params. Added a new toString() method.
- OfferBook Added new checks on OfferBookListItem hashOfPayload and sequenceNumber while
determining if offer candidates should be added or removed from the UI's OfferBook List.
See OfferBook contructor's implementation of OfferBookChangedListener#onAdded and
OfferBookChangedListener#onRemoved. Added many comments explaining the add/remove rules,
and plenty of debug statements to help trace the add/remove event process.
- OfferBookService#OfferBookChangedListener Added new P2PDataStorage.ByteArray hashOfPayload,
and int sequenceNumber params to listener's onAdded and onRemoved method signatures.
Added these two new paramater values to listener.onAdded and listener.onRemoved calls.
- TakeOfferDataModel Replaced unused, old tradeManager param in offerBook.removeOffer()
with (null) P2PDataStorage.ByteArray hashOfPayload, and (-1) int sequenceNumber params.
OfferBook will remove the candidate offer as before.
- MarketAlerts Adjusted onAdded() & onRemoved listener method signatures, even though
new P2PDataStorage.ByteArray hashOfPayload, int sequenceNumber params are not used
by the implementations.
2021-08-07 14:06:38 -03:00
ghubstan
369372880d
Merge branch 'master' into 05-update-api-beta-test-guide
2021-08-04 16:41:52 -03:00
sqrrm
8c666dba92
Avoid creating more than one refund payout
...
Double clicking the close ticketbutton creates two payout transactions.
This fix makes sure only one payout transaction is created for the
dispute.
Restarting the client allows for creating another refund transaction
for the dispute if needed.
2021-08-02 10:17:17 +02:00
Christoph Atteneder
fa4238c162
Merge pull request #5644 from jmacxx/fix_payment_account_deserialize_issue
...
Fix issue for deprecated payment account imported from backup
2021-08-01 20:50:20 +02:00
ghubstan
b8379e2003
Merge branch 'master' into 05-update-api-beta-test-guide
2021-07-30 11:53:34 -03:00
jmacxx
670ff92f4c
fix deserialize issue for deprecated payment account imported from backup
2021-07-29 21:56:44 -05:00
jmacxx
5cc3f8680e
keep chatview listener open until ack, mailbox, or error
2021-07-23 08:05:56 +02:00
Christoph Atteneder
e2e23a8611
Update bitcoinj checkpoints for v1.7.2
2021-07-19 15:34:08 +02:00
Christoph Atteneder
f0258d6dd1
Remove unused translation
2021-07-19 13:55:12 +02:00
BtcContributor
fb639c1e6d
Add missing info text for Capitual payment method
2021-07-19 13:55:11 +02:00
BtcContributor
870448f5fa
Add review feedbacks from KaiWitt
2021-07-19 13:55:11 +02:00
BtcContributor
50b6f42525
Add Capitual payment method. Waiting for final Info text to add.
2021-07-19 13:55:10 +02:00
Christoph Atteneder
57473a6e23
Update translations for v1.7.2
2021-07-16 20:38:58 +02:00
xyzmaker123
5a2592c832
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: Christoph Atteneder <christoph.atteneder@gmail.com>
2021-07-16 09:19:50 +02:00
xyzmaker123
b6e8f66553
Tooltip for unsigned accounts needs to provide more information
2021-07-16 09:19:49 +02:00
sqrrm
eace7c2b61
Merge pull request #5598 from ripcurlx/add-pazza-as-mediator
...
Add @pazza's mediator onion address and Keybase user name
2021-07-13 10:25:39 +02:00
sqrrm
30b100dfc0
Merge pull request #5621 from ripcurlx/add-payment-account-payload-safeguards
...
Add payment account payload safeguards
2021-07-13 10:24:49 +02:00
Christoph Atteneder
e4b00c6e32
Merge pull request #5611 from harrigan/master
...
List RSK Smart Bitcoin (R-BTC)
2021-07-13 09:25:35 +02:00
Christoph Atteneder
23a3c63e0f
Merge pull request #5614 from jmacxx/fix_payment_account_deserialize_issue
...
Fix payment account deserialize issue (e.g. CHASE_QUICK_PAY)
2021-07-13 09:20:23 +02:00
jmacxx
ab565d1368
fix payment account deserialize issue (e.g. CHASE_QUICK_PAY)
2021-07-12 06:58:05 -05:00
Christoph Atteneder
5ba7f043d4
Handle potential PaymentAccountPayload null values when detecting multiple holder names
2021-07-12 11:26:28 +02:00
Christoph Atteneder
51af19e5ec
Check if PaymentAccountPayload is null bfore trying to apply filter
2021-07-12 11:25:23 +02:00
Christoph Atteneder
c15958a94d
Return empty if no PaymentAccountPayload is available
2021-07-12 10:24:35 +02:00
chimp1984
8859503e49
Update comment
2021-07-08 01:09:50 +02:00
chimp1984
28a8116997
Add gc calls at areas where memory usage spikes are expected
2021-07-08 01:06:20 +02:00
chimp1984
0a5c1ca72c
Add txOutputsByTxOutputType map for performance improvement
...
Profiler reported the getTxOutputsByTxOutputType got called
very often. To avoid those iterations we use a lookup map.
2021-07-07 22:51:58 +02:00
chimp1984
4727f09066
Add System.gc() before we clone daoState and before we apply it to store.
...
Add it also before and after daoState monitor checks.
When letting the app run over night I saw that a lot of memory was not
released if System.gc() was not called.
By calling System.gc() it got to the expected state. Tested with the
G1 GC but saw similar behaviour with master with default GC version (parallel).
We could also run it periodically every 10 minutes or so, but I guess the block
interval covers that pretty good as well and those are the moment where load is
added and risk to run out of memory is higher.
We add a bit of delay to take into account that listeners might
react on the state change and to apply the gc after the event is processed completely.
2021-07-07 11:58:10 +02:00
chimp1984
da5dd523fb
Optimize DaoState snapshot behaviour
...
- Run persistence call in thread instead of user thread (serialisation
is very slow and had blocked user thread)
- Create new snapshot only after persistence is completed to avoid to
have 3 daoState objects in memory
- Set DaoState in store to null to let gc remove the old reference (was
left there before so we had 3 instances of daoStates in memory)
2021-07-06 17:59:44 +02:00
Christoph Atteneder
93df5c2849
Merge pull request #5599 from jmacxx/fix_chatmessage_status
...
Fix bug in chat message status display
2021-07-06 16:13:23 +02:00
Christoph Atteneder
f4ca766a97
Merge pull request #5602 from jmacxx/fix_withdrawal_fee_bug
...
Fix custom withdrawal fee bug
2021-07-06 16:04:22 +02:00
sqrrm
030a76522c
Merge pull request #5606 from bisq-network/release/v1.7.0
...
Release/v1.7.0
2021-07-06 12:40:52 +02:00
jmacxx
4a6eab1af3
fix custom withdrawal fee bug
2021-07-05 08:54:36 -05:00
jmacxx
a5f185484a
fix bug in chatmessage timeout status
2021-07-02 08:52:53 -05:00
Christoph Atteneder
a837c36e12
Add @pazza83's mediator onion address and Keybase user name
2021-07-02 10:55:53 +02:00
Christoph Atteneder
ab475724fe
Merge pull request #5593 from devinbileck/new-relaynode-address
...
Update relay-node address
2021-07-02 09:08:33 +02:00
Huey
26d33e10b2
Remove wiz monero explorer
...
@wiz is no longer running a Monero explorer
https://github.com/bisq-network/bisq/pull/4790
2021-07-01 09:12:34 +01:00
Devin Bileck
0eb8da083f
Update relay-node address
...
With Tor v2 addresses being deprecated soon, now is a good time to
update the relay-node used for mobile notifications with a new v3 onion
address.
2021-06-29 23:30:11 -07:00
Christoph Atteneder
3d88f9f112
Check if makerPaymentMethodId is available falling back to the payload object if not
...
This is the case for old dispute cases
2021-06-28 09:48:03 +02:00
Christoph Atteneder
e5765aeef2
Delay sending of payment account information during trade by @chimp1984
...
It also removes the op return from the multisig transaction
2021-06-28 09:47:52 +02:00
Christoph Atteneder
c7891e4a44
Update bitcoinj checkpoints for v1.7.0
2021-06-25 16:17:19 +02:00
m52go
4399885e61
Make edits as suggested in #5583
2021-06-24 18:17:28 -04:00
Christoph Atteneder
e6c3499384
Update translations for v1.7.0
2021-06-23 14:28:58 +02:00
sqrrm
8bc60d0909
Merge pull request #5573 from ripcurlx/add-hint-to-upgrade-to-tor-v3
...
Add hint to upgrade to tor v3
2021-06-23 13:41:03 +02:00
Christoph Atteneder
8d18e07f52
Apply PR Review suggestion by @sqrrm
2021-06-23 12:25:46 +02:00
Christoph Atteneder
6ab5ceca1a
Merge pull request #5563 from xyzmaker123/open-address-explorer
...
Fix incorrect tx link to tx explorer - fixes #5548
2021-06-22 16:45:49 +02:00
Martin Harrigan
639f6ee337
List RSK Smart Bitcoin (R-BTC)
2021-06-20 12:19:53 +01:00
ghubstan
81158662cf
Merge branch '03-api-editoffer-method' into 04-edit-bsq-offer
2021-06-19 11:25:45 -03:00
ghubstan
0a3e011ef5
Merge branch '02-refactor-for-api-editoffer-method' into 03-api-editoffer-method
2021-06-19 11:23:34 -03:00
ghubstan
ab2edac454
Merge branch 'master' into 02-refactor-for-api-editoffer-method
2021-06-19 11:21:07 -03:00
ghubstan
e32e0d1fbb
Add altcoin (bsq) offer editing validation check
...
BSQ offers are fixed-price only. This change blocks an
attempt to change an altcoin offer to a margin price based
offer, or set a trigger price.
2021-06-18 17:46:16 -03:00
ghubstan
a603044f2e
Pass isMyOffer flag to trade/offer proto wrappers from core services
2021-06-18 17:41:45 -03:00
ghubstan
0e9c6650e3
Include isMyOffer flag in API's trade/offer proto wrappers
...
Optionally displaying an ENABLED column in CLI side getoffer output
depends on the value of offer.isMyOffer, which is passed via new
boolean arguments to the trade & offer pojo builders.
2021-06-18 17:40:21 -03:00
Christoph Atteneder
5a8e1cf688
Adapted tor migration message
...
Based on feedback by @m52go
2021-06-17 15:26:00 +02:00
ghubstan
1a56a5161a
Force codacy check after codacy config change
2021-06-17 10:13:18 -03:00
Christoph Atteneder
1a59e92910
Merge pull request #5551 from jmacxx/chat_msg_ack
...
Improve Chat message reliability
2021-06-17 15:04:22 +02:00
jmacxx
e75a4ef0de
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
2021-06-16 08:43:14 -05:00
ghubstan
3d38a8555f
Make codacy just a bit happier
2021-06-15 13:40:33 -03:00
ghubstan
bc1576efbc
Throw exception is edit altcoin offer is attempted
...
Support for editing BSQ offers is in place, but will be added
in another PR.
2021-06-15 13:13:52 -03:00
ghubstan
e5b5a06b9b
Remove unused field
2021-06-15 12:04:39 -03:00
ghubstan
738d2f70ef
Fix editoffer validation bugs, tidy up CoreOffersService
2021-06-15 11:18:07 -03:00
ghubstan
32688a713f
Add bool isMyOffer to OfferInfo proto
2021-06-15 11:17:02 -03:00
xyzmaker123
cfdd4b4757
Fix incorrect tx link to tx explorer - update translations
2021-06-15 12:27:06 +02:00
Christoph Atteneder
ddd2ab490b
Merge pull request #5559 from jmacxx/dispute_tag_avatar
...
Feature to enable disputes user avatars and tag editing
2021-06-15 09:45:26 +02:00
Christoph Atteneder
54006dc0ef
Not require Tor v3 addresses on Regtest
...
Local dev environment normally uses localhost:PORT addresses not connecting through Tor.
2021-06-14 17:13:47 +02:00
Christoph Atteneder
8acd578ff2
Prevent nodes with Tor v2 address to participate in trading
...
After the date specified take offer requests by nodes with Tor v2 addresses will be rejected and their offers will be invisible to everyone else.
2021-06-14 17:01:40 +02:00
Christoph Atteneder
e9ef413722
Display a tor node address v3 upgrade prompt
...
whenever the client is in a state to do so without any problems.
2021-06-14 16:10:47 +02:00
ghubstan
21ac46ac0f
Fix log arg spec bug
2021-06-13 17:22:04 -03:00
ghubstan
54efad097d
Fix codacy issue
2021-06-13 14:05:00 -03:00
ghubstan
05f3985447
Fix problems found in codacy check
2021-06-13 13:54:16 -03:00
ghubstan
2344285ed3
Add editoffer method help
2021-06-13 12:55:23 -03:00
ghubstan
2b8b53bba8
Add server/core editOffer, adjust getMyOffer(s) impls
...
- Add editOffer to GrpcOffersService, CoreApi, CoreOffersService.
- Set editOffer call rate meter to 1 / minute.
- Use new EditOfferValidator to verify editOffer params OK.
- Adust getMyOffer(s) rpc impl and OfferInfo model to use OpenOffer
for accessing activation state and trigger price.
2021-06-13 12:24:45 -03:00
ghubstan
d9dd718b4c
Fix comment
2021-06-12 18:42:14 -03:00
ghubstan
81da6fbe5a
Refactor EditOfferDataModel for new editoffer api method
...
- Define set of editable offer payload fields in MutableOfferPayloadFields.
- Move bulk of EditOfferDataModel#onPublishOffer logic to OfferUtil.
2021-06-12 18:35:27 -03:00
ghubstan
786b2ec42b
Remove commented out test
2021-06-12 17:46:33 -03:00
Christoph Atteneder
fb55e436f5
Only allow failed trade to be moved to pending trades if local node address matches contract
2021-06-09 11:47:41 +02:00
Christoph Atteneder
ab7fe6673e
Only allow dispute to be reopened if local node address matches contract node address
2021-06-09 11:32:57 +02:00
jmacxx
cc7346544b
feature to enable user avatars and tags in Disputes
2021-06-08 15:15:52 -05:00
Christoph Atteneder
992a6aad72
Merge pull request #5552 from jmacxx/warn_user_dao_out_of_sync
...
Remind user when their DAO state needs to be refreshed
2021-06-08 09:31:23 +02:00
andyheko
5a955e8d24
Remove Chase QuickPay as a payment method
...
Solved #5547
2021-06-07 16:34:52 -07:00
jmacxx
87261eca04
warn user when DAO needs resync
2021-06-07 16:20:19 -05:00
sqrrm
a8013f8bc0
Merge pull request #5543 from ripcurlx/minor-ui-cleanups
...
Minor UI cleanups
2021-06-02 15:28:36 +02:00
jmacxx
e4f88bef15
ChatMessage show error if no ACK received
2021-06-01 12:49:32 -05:00
Christoph Atteneder
7883df2977
Merge pull request #5500 from BtcContributor/fix_uphold
...
Add Account owner full name field to Uphold payment method
2021-06-01 12:52:13 +02:00
BtcContributor
6de7a0d861
Improve code readability
2021-06-01 09:57:41 +02:00
Bisq GitHub Admin
806253b1bd
Merge pull request #5541 from bisq-network/release/v1.6.5
...
Release/v1.6.5
2021-05-31 15:34:27 +02:00
Christoph Atteneder
4f75d83bc3
Remove offer duplication new feature info
2021-05-31 11:04:11 +02:00
Christoph Atteneder
a3e7d539b9
Remove XMR auto confirm feature hint
2021-05-31 11:03:33 +02:00
Christoph Atteneder
670ba8720b
Merge pull request #5534 from sqrrm/fix-send-bsq-change
...
Manually create BSQ outputs
2021-05-27 15:38:15 +02:00
sqrrm
9b023a371f
Manually create BSQ outputs
...
Avoid relying on bitcoinj completeTx for creation of BSQ change
outputs as dust BSQ would be used for mining fee, thus burning
the BSQ.
2021-05-27 11:23:32 +02:00
sqrrm
e9d61dd3d3
Manually create BSQ outputs
...
Avoid relying on bitcoinj completeTx for creation of BSQ change
outputs as dust BSQ would be used for mining fee, thus burning
the BSQ.
2021-05-26 15:32:32 +02:00
sqrrm
262b768d98
Add pending callbacks to FeeService
...
This fix guarantees a callback if there is a pending request rather than just
dropping the fee request.
When requestFee() is called the callbacks are added to a list of callBacks.
Once the next fee request completes all callbacks in the list are called
and the list cleared.
2021-05-25 12:49:49 +02:00
Christoph Atteneder
3a31ed7867
Update bitcoinj checkpoints for v1.6.5
2021-05-25 10:39:36 +02:00
Christoph Atteneder
7233979d94
Merge pull request #5521 from m52go/wait-wording
...
Address #5513 and add minor improvements
2021-05-22 22:10:39 +02:00
Christoph Atteneder
d66a858d51
Update translations for v1.6.5
2021-05-21 19:59:42 +02:00
Christoph Atteneder
1fa5724b7b
Remove unused imports
2021-05-21 19:58:27 +02:00
Christoph Atteneder
2fd5f40239
Reduce the number of connected BTC nodes from 9 to 7
2021-05-21 19:58:09 +02:00
m52go
8b9046525a
Address #5513 and add minor improvements
2021-05-21 13:49:38 -04:00
