Christoph Atteneder
d390af8c65
Merge pull request #6221 from ghubstan/block-takeoffer-with-insufficient-btc
...
Block API takeoffer attempt if !sufficient btc in wallet
2022-05-30 09:52:11 +02:00
Christoph Atteneder
a0e73d7329
Merge pull request #6227 from jmacxx/pricenode_config_provider_ccy_excl
...
Pricenode: configurable exclusion by provider currency
2022-05-30 09:51:27 +02:00
jmacxx
0310958967
Remove Huobi provider.
2022-05-28 16:51:59 -05:00
jmacxx
0b4b57ca5d
Configurable exclusion property for provider currency.
2022-05-27 10:31:52 -05:00
chimp1984
6c2b3629d4
Change link
2022-05-27 15:35:40 +02:00
chimp1984
259b799ae6
Move Monero related classes to xmr package
2022-05-26 23:42:30 +02:00
chimp1984
69b1a0027b
Compare canonicalTxKey with strict case check
...
Cleanups
2022-05-26 23:40:46 +02:00
chimp1984
7127bd5223
Add methods to ExcludesDelegateMethods
2022-05-26 23:35:13 +02:00
chimp1984
d2557181d0
Add popup and info about using dedicated wallets when changing Bisq data dir
2022-05-26 23:31:30 +02:00
chimp1984
7fe93d9be7
Add littleEndian conversions
2022-05-26 12:36:59 +02:00
chimp1984
ed4eaafcdf
Add toCanonicalTxKey method (not correct still)
2022-05-26 12:17:51 +02:00
chimp1984
5194aff311
Extract test
2022-05-26 11:57:17 +02:00
chimp1984
08a76229c1
Add knaccc package and dependent other packages
2022-05-26 11:46:32 +02:00
ghubstan
a648bf9756
Fix test name
2022-05-22 17:12:45 -03:00
ghubstan
c9f3aa9edf
Block API takeoffer attempt if !sufficient btc in wallet
...
This API bug was relying on offer availability checks, but those do
not check the taker's wallet. The take offer model makes the check convenient,
and a core.api NotAvailableException can be thrown from CoreTradesService,
then mapped to the appropriate gPRC UNAVAILABLE exception sent to clients.
A new test case is added for this change: Bob's wallet is emptied, he
fails to take an offer, and Alice returns Bob's BTC.
2022-05-22 17:00:33 -03:00
ghubstan
9506386753
Do not run test daemon in debug mode (by default)
...
Thie test case is @Disabled anyway, but run inside a suite instead,
where it was not running the test daemon in debug mode (anyway).
2022-05-21 17:14:05 -03:00
ghubstan
3fe72b7425
Remove -txindex=1 from seednode's bitcoin.conf
...
This change needs thorough review before being merged.
See bitcoin-core Issue "Remove txindex migration code #22626 ":
https://github.com/bitcoin/bitcoin/pull/22626
And comment about change not having a release note:
https://github.com/bitcoin/bitcoin/pull/22626#issuecomment-893220371
See src: https://github.com/bitcoin/bitcoin/blob/v23.0/src/txdb.cpp#L35
For API test suites:
This change is backward compatible for bitcoin-core v22.
This change has not been tested against bitcoin-core v21, v20, v19.
Change needs to be thoroughly tested with desktop UI.
2022-05-21 17:07:06 -03:00
ghubstan
7feecc9aca
Adjust to CJDNS network support in bitcoin-core v23
...
This change is backward compatible for bitcoin-core v22.
This change has not been tested against bitcoin-core v21, v20, v19.
See https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-23.0.md#p2p-and-network-changes
See https://github.com/bitcoin/bitcoin/blob/23.x/doc/cjdns.md
2022-05-21 17:03:14 -03:00
chimp1984
19643488b1
Add test
2022-05-21 01:43:20 +02:00
chimp1984
f97cc86470
Use equalsIgnoreCase for replay protection checks
...
Add check for duplicate txHash
Rename wrongly names variables at startRequestsIfValid
2022-05-21 00:32:52 +02:00
chimp1984
e97ba5aebb
Add comment to viewkey/txKey mismatch due dual mode explorer API
2022-05-21 00:30:19 +02:00
ghubstan
0b66c2f9a2
Remove legacy bitcoind txindex param from apitest harness
...
It was put there thinking it would be needed by the test harness and suites,
which work fine without it, and it must be removed before API test harness
can run against bitcoin-core v23.
See https://github.com/bitcoin/bitcoin/pull/22626#issuecomment-893220371
2022-05-19 15:56:37 -03:00
Christoph Atteneder
0ced87cd22
Merge pull request #6213 from jmacxx/check_trade_init_app_close
...
Improve wording & appearance of trade shutdown dialog.
2022-05-19 09:21:37 +02:00
jmacxx
62719615a9
Prevent shutdown if trade is in process of being taken.
2022-05-18 18:05:05 -05:00
Bisq GitHub Admin
671263c430
Merge pull request #6209 from ripcurlx/fix-matching-account-toggle
...
Update matching account toggle state when tab is selected
2022-05-18 11:34:07 +02:00
Christoph Atteneder
1a5dad0e0b
Merge pull request #6190 from ghubstan/restful-dao-node-example
...
2nd attempt at a tiny daonode rest service with 1 endpoint
2022-05-18 09:41:36 +02:00
Christoph Atteneder
ecbd10d766
Merge pull request #6211 from jmacxx/check_trade_init_app_close
...
Prevent shutdown if trade is in process of being taken.
2022-05-18 09:38:32 +02:00
jmacxx
0726bdff7e
Prevent shutdown if trade is in process of being taken.
2022-05-17 12:10:23 -05:00
ghubstan
578d43f75c
Do not manually throw NullPointerException
2022-05-17 10:05:01 -03:00
Christoph Atteneder
0edfd17ef3
Update matching account toggle state when tab is selected
...
Fixes #6199 .
2022-05-17 11:13:08 +02:00
Bisq GitHub Admin
6fa87aea11
Merge pull request #6204 from chimp1984/add-revenue-chart
...
Add chart series for total trade fees
2022-05-16 16:58:27 +02:00
Christoph Atteneder
5ff04a1e48
Merge pull request #6207 from ghubstan/fix-gettrades-category-param-uppercase-bug
...
Fix API CLI gettrades bug: category param can be uppercase
2022-05-16 16:18:47 +02:00
Christoph Atteneder
52b1e13d46
Merge pull request #6200 from jmacxx/fix_issue_6175
...
Refactor BSQ fee validation to handle multiple txins.
2022-05-16 16:15:25 +02:00
Christoph Atteneder
ad1685c646
Merge pull request #6201 from jmacxx/fix_issue_6151
...
Fix refresh issue with x-axis tick labels (Market/Trade charts)
2022-05-16 16:13:08 +02:00
Christoph Atteneder
0925370121
Merge pull request #6202 from ghubstan/fix-editoffer-price-bug
...
Fix API editoffer bug: set fixed-price=0 on margin offers
2022-05-16 16:11:48 +02:00
Christoph Atteneder
2662ef8461
Merge pull request #6206 from jmacxx/add_inbound_connectivity_test2
...
Attempt self-ping 3 times before reporting error with connectivity.
2022-05-16 16:07:56 +02:00
ghubstan
a6ab373079
Add license banners to daonode/web classes
2022-05-16 10:55:34 -03:00
ghubstan
b3e6160f19
Keep CLI console output text lowercase where possible
...
Be consistent.
2022-05-15 18:57:23 -03:00
chimp1984
0ed03fc790
Add series for burned BSQ from btc fees and arbitration
2022-05-15 23:42:18 +02:00
ghubstan
8e5acf277d
Fix API CLI gettrades bug: category param can be upcase
...
When category param value was uppercase, e.g.,
$ ./bisq-cli --password=xyz --port=9998 gettrades --category=OPEN
CLI validation failed:
Error: No enum constant bisq.cli.opts.GetTradesOptionParser.CATEGORY.OPEN
This fixes the bug, and --category=open now passes CLI validation.
Based on `master`.
2022-05-15 16:26:29 -03:00
jmacxx
574510d172
Attempt self-ping 3 times before reporting error with connectivity.
2022-05-15 12:48:39 -05:00
chimp1984
cb4eacdb64
Change colors, move seriesRevenue left
2022-05-15 18:58:55 +02:00
chimp1984
492182a97d
Add half-year and quarter periods
2022-05-15 17:35:02 +02:00
chimp1984
5f2a430e4e
Add chart series for total trade fees
...
Fix missing color adoption for BSQ supply series
2022-05-15 15:39:59 +02:00
ghubstan
381985ec3a
Fix API editoffer bug: set fixed-price=0 on margin offers
...
This is causing erroneous PRICE_OUT_OF_TOLERANCE errors when trying
to take offers having (fixed) price!=0, and isUsingMktPriceMargin=true
in the payload.
The API daemon editoffer's treatment of (fixed) price and
isUsingMktPriceMargin flag in the API has been inconsistent with the UI.
With this change: when isUsingMktPriceMargin=true, (fixed) price is
set to 0 on the server. API clients, however, still must show the
calculated price when isUsingMktPriceMargin=true, making this fix hard
to test in the client. The server will now throw an exception if
(fixed) price and isUsingMktPriceMargin flag in the API are not
properly set in the API server.
This fix is intended to prevent issues such as
https://github.com/bisq-network/bisq/issues/6170 from happening for
this reason. The offer maker edited offers with API, creating
inconsistent state described above. It is hoped the user's offers
can be fixed by editing them in the UI.
Based on `master`.
2022-05-14 18:14:49 -03:00
jmacxx
0535279378
Fix refresh issue with x-axis tick labels.
2022-05-13 12:02:39 -05:00
jmacxx
17a949e4d1
Refactor BSQ fee validation to handle multiple txins.
2022-05-12 21:14:26 -05:00
Christoph Atteneder
a1eedafce7
Merge pull request #6197 from jmacxx/fix_issue_6196
...
Bugfix: Signed account must show signed age.
2022-05-11 21:10:56 +02:00
jmacxx
336f335de5
Bugfix: Signed account must show signed age.
2022-05-11 08:57:36 -05:00
Christoph Atteneder
cc252f69b4
Merge pull request #6106 from xyzmaker123/6100-total-bsq-supply
...
Show changes in BSQ Supply over time
2022-05-10 11:50:35 +02:00