Manfred Karrer
c0d776e536
Fix wrong check for isVoteRevealInputValid
2018-10-03 21:45:49 -05:00
Manfred Karrer
248c5546be
Refactor parser classes
...
- Move unlockBlockHeight field from Tx to TxOutput
2018-10-03 21:31:26 -05:00
Manfred Karrer
097fa66c99
Refactor parser classes
...
- Add isUnLockInputValid to TxInputParser
- Continue to refactor to make methods more testable
- Clean up
2018-10-03 20:55:25 -05:00
Manfred Karrer
5df40f7e1f
Refactor parser classes
...
- Continue to refactor to make methods more testable
2018-10-03 20:13:16 -05:00
Manfred Karrer
7d14ab8376
Refactor parser classes
...
- Remove voteRevealInputState and replace with isVoteRevealInputInValid
in TxInputParser
- Rename optionalVerifiedOpReturnType to optionalOpReturnType
- Replace if checks with checkNotNull if case must not happen
- Remove unused isLastOutput param
- Inline handleOpReturnOutput code to processOpReturnOutput
- Remove class fields remainingInputValue and use a local var instead
- Rename getOptionalVerifiedOpReturnType to getOptionalOpReturnType
2018-10-03 19:03:43 -05:00
Manfred Karrer
744f0cc516
Refactor TxOutputParser
...
- Remove unneeded isLastOutput
- Rename bsqOutputs to tempTxOutputs
- Rename commitTxOutputs to commitTxOutputsForValidTx
2018-10-03 17:59:34 -05:00
Manfred Karrer
0c8d475c24
Improve string
2018-10-03 17:58:01 -05:00
Manfred Karrer
69210d9125
Fix missing updates of enum entries
2018-10-03 17:50:36 -05:00
Manfred Karrer
294c941512
Fix missing updates of enum entries
2018-10-03 17:34:40 -05:00
Manfred Karrer
e11e2b3c9e
Fix PB enum
...
As PB handles enums globally there must not be same entries in 2 diff.
enums. Therefore I postfixed with _OUTPUT 3 entries in TxOutputType.
2018-10-03 17:32:34 -05:00
Manfred Karrer
275286690b
Improve logs
2018-10-03 17:28:54 -05:00
Manfred Karrer
48fa9e75c9
Fix incorrect TxType entries in PB definitions
2018-10-03 17:28:44 -05:00
Manfred Karrer
7d045f028f
Fix incorrect/missing TxOutputType entries in PB definitions
2018-10-03 17:12:51 -05:00
Manfred Karrer
126d279e6e
Merge pull request #1718 from sqrrm/refactor-dao-parser
...
[WIP] Refactor dao parser
2018-10-03 17:10:13 -05:00
Manfred Karrer
fd97c3c7f9
Merge pull request #1738 from ManfredKarrer/dao-fixes
...
Dao fixes
2018-10-03 13:41:56 -05:00
sqrrm
bc262460a1
Merge remote-tracking branch 'origin/master' into refactor-dao-parser
2018-10-03 10:51:49 +02:00
Manfred Karrer
d68f9b5474
Fix wrong validation checks on proposals and ballots
...
- We cannot validate the txType at startup as the blockchain is nto ready at that moment. So we cannot apply that validation when we receive the payloads. We do the validation instead at the access to the lists.
- We fix a glitch with missing cycle start time in ResultsOfCycle
- Cleanup in VoteResultView
2018-10-01 21:19:12 -05:00
Manfred Karrer
2de9c7282e
Make DaoFacade implement DaoSetupService
...
- Fixes a bug that the phaseProperty was not set in DaoFacade as the
class was instantiated on demand and missed updates.
2018-10-01 21:16:02 -05:00
Manfred Karrer
030dc0209b
Change btcd-cli4j to 3864e1c4
2018-10-01 12:17:40 -05:00
Manfred Karrer
b981737775
Change log msg with update to new btcd-cli4j
2018-10-01 12:17:28 -05:00
Manfred Karrer
7ac2a02279
Fix startHeight, handle errors
2018-10-01 11:39:45 -05:00
Manfred Karrer
6873d03216
Merge pull request #1735 from ManfredKarrer/master
...
Fixes and improvements
2018-09-29 12:27:04 -05:00
Manfred Karrer
012dab9ad2
Add isUnspent to JsonTxOutput
2018-09-28 19:58:03 -05:00
Manfred Karrer
3de2746834
Rename outputIndex
2018-09-28 19:49:36 -05:00
Manfred Karrer
54fc96a5d7
Update json classes for BSQ explorer
2018-09-28 19:34:08 -05:00
Manfred Karrer
dcd0ff5efd
Add tx validation for proposals
2018-09-28 14:53:27 -05:00
Manfred Karrer
1760094286
Handle reorgs
2018-09-28 14:52:59 -05:00
Manfred Karrer
d7be7f48f2
Remove unneeded BtcWalletService field
2018-09-28 13:05:06 -05:00
Manfred Karrer
2b5731ce7f
Add buyers payment account name to trade screen
...
In case the buyer has setup multiple accounts for a payment method
we show the used payment account for that offer in the trade screen.
See: https://github.com/bisq-network/bisq/issues/1733
2018-09-28 12:04:09 -05:00
Manfred Karrer
bd44aea27a
Add comment for @ripcurlx to add some visual element
...
If we have multiple payment accounts we should show some info/warning to
make sure the user has selected the account he wants to use.
To use a popup is not recommended as we have already 3 popups at the
first time (if user has not clicked
don't show again).
@ripcurlx Maybe a similar warn triangle as used in create offer
might work?
See: https://github.com/bisq-network/bisq/issues/1733
2018-09-28 11:25:07 -05:00
Manfred Karrer
afdd14e391
Remove remaining "N/A" in offer screen after price is set
...
- If the price is not available we display "N/A". Once the price
becomes available the listener handler was not removing the text (N/A).
2018-09-28 11:09:22 -05:00
Manfred Karrer
2f8172f704
Apply rounding or fiat volume to trade statistics
2018-09-28 10:46:25 -05:00
Manfred Karrer
0508489191
Add comment, cleanup
2018-09-27 21:26:21 -05:00
Manfred Karrer
19f1d2b565
Add log
2018-09-27 20:17:53 -05:00
Manfred Karrer
774b2b3c51
Add missing scriptType enum
2018-09-27 20:16:57 -05:00
Manfred Karrer
0414b1baec
Update to btcd-cli4j 1763d7ef
...
- Fixes missing scriptType enum
2018-09-27 20:16:44 -05:00
Manfred Karrer
91153c2d6e
Merge pull request #1730 from devinbileck/Fix-last-update-timestamp-in-price-feed-service
...
Fix last request timestamp in price feed service
2018-09-27 19:06:12 -05:00
Devin Bileck
3663d6cf14
Fix last update timestamp in price feed service
2018-09-27 12:55:02 -07:00
Christoph Atteneder
5c66385834
Merge pull request #1728 from ManfredKarrer/master
...
Small improvements/fixes
2018-09-27 16:26:22 +02:00
Manfred Karrer
a9e32c0bdd
Move maker classes back to desktop module
2018-09-27 00:16:24 -05:00
Manfred Karrer
29193ad928
Fix failing test
2018-09-26 23:58:58 -05:00
Manfred Karrer
dbe0993fae
Fix nullpointer
2018-09-26 23:58:47 -05:00
Manfred Karrer
8eabd665c7
Fix snapshot handling
...
- Fix wrong start height
- Improve logging
2018-09-26 22:41:41 -05:00
Manfred Karrer
97479e295c
Fix wrong logging
...
- If both verifiedOpReturnType and opReturnTypeCandidate are empty we
got an error logged. We change that so that only of both are present
but not matching we log a warning.
2018-09-26 22:40:50 -05:00
Manfred Karrer
2b6cf13e5c
Close notifications onMousePressed event
2018-09-26 21:27:10 -05:00
Manfred Karrer
fc5c0da159
Fix wrong minDecimals for BSQ in trade volume display
2018-09-26 21:04:18 -05:00
Manfred Karrer
fd87ff369c
Refactor and fix asset checks
2018-09-26 18:37:41 -05:00
Manfred Karrer
c231750900
Move classed from desktop to core
2018-09-26 16:03:42 -05:00
Manfred Karrer
4cd26882fe
Merge branch 'master' into DAO-improvements
2018-09-26 15:31:42 -05:00
Manfred Karrer
c11070f7c4
Fixes assetMatchesNetwork method, rename method
...
- Rename excludeBsqUnlessDaoTradingIsActive to
isNotBsqOrBsqTradingActivated to make it more clear
- Fix wong check with getDefaultBaseCurrencyNetwork (use
getBaseCurrencyNetwork instead)
- Add comment to support network check or Tokens
2018-09-26 15:30:21 -05:00
