The install_java.sh script was not setting the appropriate java and
javac as default. This is not an issue if no other JDK is installed, but
if so it could cause the wrong JDK to be used. So it now sets the
appropriate default system JDK.
Also, added a comment at the top of the install_java.sh and
install_java.bat files indicating it configures the default system
JDK and informs the user how to go about selecting a different
default JDK if necessary.
Add updateButtonDisabledState() to onPaymentAccountSelected() in
TakeOfferViewModel since changing the account dropdown in the take
offer screen does not trigger an update of the "Next Step" button.
The default amount of an offer should not change to less than what is
actually offered, change onPaymentAccountSelected() in
TakeOfferDataModel to take into account the min. amount offered.
In TakeOfferView, the payment account defaults to the last one
selected. Make sure TakeOfferViewModel and TakeOfferDataModel take
this into account in a couple locations.
To avoid performance issues we omit the listener calls at
onParseBlockComplete as long we are in the batch processing of blocks.
Without that optimization it took about 50 sec. for 4000 blocks, with it
we could reduce it to 4 seconds.
If the phase and cycle for the vote reveal tx was missed we still
publish it but it is considered invalid. We do not throw an exception
but filter such txs away from the vote result evaluation.
We cannot use the strategy to unlock the BSQ from the vote tx in such a
case because the blind vote tx is already in the past and is not parsed
again (snapshot).
Alternatively we could have used a different tx type for the unlock
purpose but we prefer to keep such an exceptional case simple.
- Use the chain tip height and not the current chain height in the
parsing to check if we are in the correct phase and cycle. Only
publish the tx if we are in the correct cycle.
- We want to know for the vote reveal service what is the latest block.
Currently that is not exposed in the DAO only in the BitcoinJ classes,
but we don't want to access it from there.
If a seednode is using netwlayer version 0.6.2 (or 0.6.1) it is not
reachable from other nodes. Still unclear what causes that and if it
would affect also normal Bisq nodes, but to be careful we revert to
latest stable netlayer version which fixes the issue.
