Christoph Atteneder
9005808a4d
Merge pull request #5110 from Jakub-CZ/fix-spaces-in-cashByMail
...
"Cash by Mail" instructions improvements
2021-01-24 15:06:00 +01:00
Christoph Atteneder
f54ec2f6ae
Merge pull request #5111 from jmacxx/fix_unnecessary_exception_log
...
Fix log message when opening browser link
2021-01-24 15:01:03 +01:00
jmacxx
2533a52120
Fix log message when opening browser link
2021-01-23 23:15:25 -06:00
Jakub Loucký
e2de30a6e4
Resolve unintended ellipsis. Make popup wider.
2021-01-23 23:46:48 +01:00
Jakub Loucký
fafa81811b
Fix wording
2021-01-23 23:46:09 +01:00
Jakub Loucký
803d373e44
Add details about mediation in "Cash by mail"
2021-01-23 23:40:14 +01:00
Jakub Loucký
966502247b
Fix spaces in "Cash by Mail"
2021-01-23 19:21:49 +01:00
Christoph Atteneder
80cd4a8ad6
Merge pull request #5101 from chimp1984/fix-nullpointer-at-bsq-tx-cvs-export
...
Fix null pointer
2021-01-22 19:12:24 +01:00
chimp1984
0169bd334c
Fix null pointer
2021-01-22 10:02:19 -05:00
Christoph Atteneder
5b0716eb76
Merge pull request #5099 from jmacxx/bugfix_emerg_payout_tool
...
Manual payout tool: prevent absurdly high fee payout
2021-01-22 11:26:28 +01:00
jmacxx
db76346cde
Manual payout tool: prevent absurdly high fee payout
...
- trims whitespace from numeric input fields before parsing
- adds percentage display of the tx fee
- validates that the tx fee percentage is not higher than 10%
2021-01-21 12:49:08 -06:00
Christoph Atteneder
334fbdbc86
Merge pull request #5092 from jmacxx/add_cashbymail3
...
Add payment method "Cash by mail"
2021-01-21 10:26:59 +01:00
Christoph Atteneder
570d6a8b38
Merge pull request #5093 from ghubstan/02-trading-scripts
...
Add api trade simulation scripts
2021-01-21 09:42:14 +01:00
jmacxx
2ab96d997f
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
2021-01-20 16:34:43 -06:00
ghubstan
b2d8faf2cd
Log price feed request warnings, do not throw to CLI
...
The price feed service throws PriceRequestExceptions when switching
currencies, log those exceptions as warnings in the server and don't
pass them up to the CLI.
2021-01-20 19:27:35 -03:00
ghubstan
d18b2d5a10
Run an async price feed request when CLI needs market price
...
The CLI was receiving stale, cached market prices from the feed service.
2021-01-20 17:46:35 -03:00
ghubstan
184ffd14db
Enclose $vars in double quotes
2021-01-20 15:26:36 -03:00
ghubstan
78d0024368
Re-add exports to make codacy happy
2021-01-20 15:25:22 -03:00
ghubstan
7fa61c9a32
Remove deprecated python script
2021-01-20 15:14:20 -03:00
ghubstan
20e16493aa
Get current mkt price from server, not directly from feed
2021-01-20 15:13:07 -03:00
ghubstan
ced422e930
Add new api CLI method 'getbtcprice'
...
The server impl was there, but it is now needed by the trading
sim scripts (CLI) to get the price from the Bisq server instead
of the feed. (The server does not request prices more than
once a minute.)
2021-01-20 15:01:16 -03:00
ghubstan
3244db12c4
Print current market price just before offer is created
...
This may help confirm offer.price correctness in periods of BTC
price stability.
2021-01-20 13:08:52 -03:00
sqrrm
59852298b2
Merge pull request #5096 from ripcurlx/fix-typo
...
Fix typo in trigger price tooltip
2021-01-20 16:14:05 +01:00
ghubstan
078f010125
Remove api dev/test log statement
...
This server log output was intended as an aid to api devs, but
is no longer needed after the change to posix-sytle method opts
with self explanatory labels (replacing the ambiguous positional
CLI method opts).
2021-01-20 12:03:21 -03:00
ghubstan
cb96f27f1c
Remove uneeded ${curlies}
...
For requested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560941709
2021-01-20 11:52:29 -03:00
ghubstan
8b4938a9eb
Do not export vars from lowest level child script
...
For requested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560932201
2021-01-20 11:36:01 -03:00
ghubstan
0c06abdc56
Replace shortform '. with longform 'source'
...
For requested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560958418
2021-01-20 11:28:42 -03:00
Christoph Atteneder
f0f27db83e
Fix typo in trigger price tooltip
2021-01-20 15:22:25 +01:00
ghubstan
6c322d4aae
Put $N variable references in double quotes
...
For requested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560938698
2021-01-20 11:20:30 -03:00
ghubstan
73c6b3d96b
Fix typo, group mutually exclusive opts around '||'
2021-01-20 11:16:54 -03:00
ghubstan
67eed01d74
Fix tx-fee-rate opt description
...
For requested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560906913
2021-01-20 11:12:21 -03:00
ghubstan
72731e5c03
Add parens around (sats/byte)
2021-01-20 11:07:55 -03:00
ghubstan
11096d5c85
Fix tx-fee-rate opt description
...
For requested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560907371
2021-01-20 11:05:23 -03:00
ghubstan
031b18edfa
Fix typo
...
For requested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560906396
2021-01-20 11:02:09 -03:00
ghubstan
fce3aab40d
Improve description
...
For suggested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560905251
2021-01-20 10:59:49 -03:00
ghubstan
86758414b7
Fix punctuation
...
For suggested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560902858
2021-01-20 10:45:41 -03:00
ghubstan
71ffa0f997
Explain that paid tx fees are forfeited
...
For suggested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560901896
2021-01-20 10:41:21 -03:00
ghubstan
4eabb9804e
Fix indentation
...
For suggested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560898873
2021-01-20 10:35:53 -03:00
sqrrm
2c348f7d7a
Merge pull request #5094 from chimp1984/fix-bug-with-ignoreLocalBtcNode
...
Fix bug with ignoreLocalBtcNode
2021-01-20 13:24:39 +01:00
chimp1984
ccc6f3f466
Do not pass proxySocketFactory to BlockingClientManager
...
if we use a local Bitcoin node.
2021-01-19 15:08:49 -05:00
ghubstan
cf419d2d58
Make price request frequency configurable
...
Added a -w option to allow user to control the frequency of price requests.
The minimum value = 20s, default value = 120s.
2021-01-19 16:13:21 -03:00
ghubstan
48a326b990
Add env requirement and usage comments
2021-01-19 15:00:47 -03:00
ghubstan
93c3735f9c
Fix bash bugs & style problems for codacy
2021-01-19 14:38:22 -03:00
ghubstan
873c661218
Add api trade simulation scripts
...
Two regtest trading simulation scripts are contained in this change:
- trade-simulation.sh goes through the steps of creating F2F payment
accounts for Bob & Alice, and each step of a trade from createoffer to
completion.
- limit-order-simulation.sh shows one way to trigger creation of an offer
when a limit price is reached.
Each script prints CLI commands just before they are run.
Both scripts depend on functions contained in supporting bash and python3
scripts.
Examples:
trade-simulation.sh
Simulate the entire trade protocol between Bob (taker) & Alice (maker),
where Alice buys 0.1 BTC from Bob, paying in Renminbi (CYN).
Note the script takes a country code (CN) not a currency code, so the
script can create the appropriate country based face to face payment accounts.
$ apitest/scripts/trade-simulation.sh -d buy -c cn -m 0.0 -a 0.1
limit-order.sh
Create a CAD/BUY 0.1 BTC order at mkt price margin of 0.0% if price falls to
or below 47900 CAD.
Note the script takes a country code (CA) not a currency code, so the script
can create the appropriate country based face to face payment accounts.
$ apitest/scripts/limit-order-simulation.sh -l 47900 -d buy -c CA -m 0.0 -a 0.1
Create a USD/SELL 0.1 BTC order at mkt price margin of 0.0% if price rises to
or above 37200 USD.
$ apitest/scripts/limit-order-simulation.sh -l 37200 -d sell -c US -m 0.0 -a 0.1
2021-01-19 13:46:55 -03:00
ghubstan
fbc31a5e86
Merge branch 'master' into 01-add-method-help-docs
2021-01-19 10:23:41 -03:00
jmacxx
531e8ca408
Add CASH_BY_MAIL to TradeStatistics3 enum
2021-01-19 07:12:14 -06:00
sqrrm
71b6b84b43
Merge pull request #5087 from ripcurlx/improve-responsiveness
...
Keep main navigation items left aligned
2021-01-19 11:12:03 +01:00
Christoph Atteneder
728439eecb
Merge pull request #5077 from stejbac/fix-reimbursement-validator
...
Fix request amount bounds in ReimbursementValidator
2021-01-19 11:00:17 +01:00
Christoph Atteneder
071e1e5a57
Merge pull request #5090 from jmacxx/disable_cpu_intensive_animations
...
Disable CPU-intensive animations
2021-01-19 10:54:12 +01:00
Christoph Atteneder
3d9e2a5ad8
Merge pull request #5083 from stejbac/fix-btc-node-converter-test
...
Avoid reverse DNS lookup in BtcNodeConverterTest
2021-01-19 10:37:27 +01:00