chimp1984
b73fff0aad
Refactor: Move AsciiLogo to common
2020-09-30 21:50:47 -05:00
chimp1984
7e847cd95b
Only check pubKey for trade messages. Before we got it called for instance when the mediator sent the dispute-opened-by-peer msg, causing an error as its mediators key not peers key.
...
We need to check first for the message type and then apply the check.
2020-09-30 13:45:27 -05:00
chimp1984
24e1155eea
Set peers pubkey at constructor instead of onInitialized
2020-09-30 13:44:15 -05:00
Oscar Guindzberg
5db273010f
Use bitcoinj 0.15.8 (commit 44ddbdc)
2020-09-30 13:10:05 -03:00
Christoph Atteneder
4d7e26d87d
Merge pull request #4576 from chimp1984/fix-filter-bug
...
Fix bug with missing remove of old filter when new filter is added.
2020-09-30 16:30:48 +02:00
chimp1984
5d41574931
Refactor: Rename TradeDataValidation.validatePayoutTx to TradeDataValidation.validateDelayedPayoutTx
2020-09-29 23:46:38 -05:00
chimp1984
18c1fc1410
Fix bug with missing remove of old filter when new filter is added.
...
- Add handling for removing invalid filters
When adding a new filter invalid filters get removed if they have been created with the same priv key.
2020-09-29 23:25:22 -05:00
chimp1984
3926a36c3a
Use params for trace logs.
2020-09-29 12:55:23 -05:00
chimp1984
e9d7e53882
Merge branch 'fix-delayed-payout-tx-issues' of https://github.com/chimp1984/bisq into fix-delayed-payout-tx-issues
2020-09-29 01:07:42 -05:00
chimp1984
25e64cd6b5
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:06:44 -05:00
chimp1984
e071d5e025
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:06:28 -05:00
chimp1984
9cf368c449
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:06:09 -05:00
chimp1984
c3d3e5230e
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:05:46 -05:00
chimp1984
6c114b44e8
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:05:21 -05:00
chimp1984
77ae1bddfa
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:04:45 -05:00
chimp1984
92902102ec
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:04:27 -05:00
chimp1984
4e2ccf249b
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:04:17 -05:00
chimp1984
1fef02e6f1
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:04:04 -05:00
chimp1984
dc15c7dfa7
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:03:53 -05:00
chimp1984
e3cc62ed60
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:03:41 -05:00
chimp1984
126f99668d
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:03:30 -05:00
chimp1984
08e2a2e0b0
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:03:18 -05:00
chimp1984
c448b1b58d
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:03:01 -05:00
chimp1984
285003743d
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:02:49 -05:00
chimp1984
6be21fa86c
Update core/src/main/resources/i18n/displayStrings.properties
...
Co-authored-by: m52go <mfiver@gmail.com>
2020-09-29 01:02:11 -05:00
chimp1984
f46e132195
Add rocket icon to xmr offers which have enabled autoconf
...
Add info to tooltip and to offer window
Add center css to actions column. It looks weird that title is left aligned and button is centered.
only "last-column", "avatar-column" worked, making an new style e.g. center-column did not succeed... css is not my friend....
Shorten "Time since signing" to "Signed since" header to avoid truncation
2020-09-29 00:45:31 -05:00
chimp1984
7280fb822d
Add new extraMap entry for offer.
...
If maker is seller and is a xmr offer and has autoConf enabled we set a flag ("1")
2020-09-28 23:26:29 -05:00
chimp1984
e8ab4c7222
Merge branch 'master_upstream' into fix-delayed-payout-tx-issues
2020-09-28 20:46:34 -05:00
chimp1984
0258205211
Fix typos
2020-09-28 18:10:42 -05:00
chimp1984
eec13cd276
Refactor: Return early if not valid
2020-09-28 18:08:07 -05:00
chimp1984
ad83183cba
Revert copyright text from un-intended change
2020-09-28 18:05:09 -05:00
Oscar Guindzberg
1e65af51ea
Remove unused WalletService.freshKey()
2020-09-28 18:37:53 -03:00
ghubstan
fc94b97a00
Throw exception to CLI if attempted offer placement fails
2020-09-28 18:11:08 -03:00
ghubstan
94996a5e25
Fix tx result handling in GrpcOffersService
...
Separates offer placement from offer creation to fix tx result
handling problem in GrpcOffersService, and readies the core api
for a new CLI 'placeoffer' implementation. Offer placement still
happens in the api's 'createoffer', but we may want to change it
to show the created offer to a CLI user for review, prior to manual
placement via a new 'placeoffer offer-id' (of 'confirmoffer offer-id'?)
api method.
2020-09-28 11:48:56 -03:00
ghubstan
f3761530b5
Codacy requires default label in switch
2020-09-28 09:38:08 -03:00
ghubstan
d9ece9f5ba
Revert "Fix 'switch statements should have a default label' codacy problem"
...
This reverts commit 50d4b9f5e1
.
Back out codacy fix; it did not work.
2020-09-27 17:25:44 -03:00
ghubstan
50d4b9f5e1
Fix 'switch statements should have a default label' codacy problem
...
This is an ugly, temporary fix. Need to refactor again.
2020-09-27 17:18:50 -03:00
ghubstan
35a77be7e4
Redefine DisputeAgentType REFUNDAGENT as REFUND_AGENT
...
The CLI needs to be able to register a REFUND_AGENT using the
'refund_agent' or 'refundagent' parameter value (in any case),
so an alt-name mapping was added to the enum def.
2020-09-27 15:23:19 -03:00
sqrrm
20135a1662
Merge pull request #4561 from oscarguindzberg/codeCleanup
...
Remove unnecessary WalletService.removeSignatures()
2020-09-27 14:44:43 +02:00
sqrrm
a408dd5a89
Merge pull request #4552 from oscarguindzberg/WalletConfigCleanup
...
Wallet config cleanup
2020-09-27 14:40:51 +02:00
sqrrm
3174778018
Merge pull request #4560 from jmacxx/fix_xmr_amount_check
...
XMR autoconf should get amount from trade not offer
2020-09-27 14:40:23 +02:00
chimp1984
2191693946
Apply stupid Codacy rule
...
https://stackoverflow.com/questions/1750435/comparing-java-enum-members-or-equals
```
enum Color { BLACK, WHITE };
Color nothing = null;
if (nothing == Color.BLACK); // runs fine
if (nothing.equals(Color.BLACK)); // throws NullPointerException
```
```
enum Color { BLACK, WHITE };
enum Chiral { LEFT, RIGHT };
if (Color.BLACK.equals(Chiral.LEFT)); // compiles fine
if (Color.BLACK == Chiral.LEFT); // DOESN'T COMPILE!!! Incompatible types!
```
"To summarize, the arguments for using == on enum are:
It works.
It's faster.
It's safer at run-time.
It's safer at compile-time.
"
2020-09-27 02:13:39 -05:00
chimp1984
28a85c1ce5
Fix display strings
2020-09-27 02:04:35 -05:00
chimp1984
ab30e546b0
Merge branch 'master_upstream' into fix-delayed-payout-tx-issues
2020-09-27 01:28:51 -05:00
chimp1984
d08591551b
Add state listeners to warn icon columns to get correct state updates
2020-09-27 01:26:48 -05:00
chimp1984
6deeecb846
Move handling of mailbox messages from TradeManager to TradeProtocol
...
Make removal of mailbox messages automated in TradeProtocol
2020-09-26 23:38:01 -05:00
chimp1984
84a4982732
Remove TradeProtocol from Trade
...
We keep the TradeProtocol now in TradeManager in a hashmap.
As TradeProtocol constructors get called now earlier we need to add an onInitialized method which signals that the TradeProtocol is ready.
The processModel needs to get set the transient fields after construction.
2020-09-26 21:34:28 -05:00
chimp1984
cabc5af2c6
Make processModel in Trade final and pass in constructor instead of in init method
2020-09-26 19:36:07 -05:00
chimp1984
5309f04b40
DO not deactivate move to failed trades button. Use different text in popup if all txs are valid.
...
Fix icon style issues.
2020-09-26 18:33:25 -05:00
chimp1984
6c6332d68d
Allow also Trade.Phase.PAYOUT_PUBLISHED in onPaymentReceived to support in failure situations to resend the msg
2020-09-26 17:37:34 -05:00