Commit Graph

13920 Commits

Author SHA1 Message Date
sqrrm
874d923e35
Merge pull request #5129 from ghubstan/03-rolling-offers-simulation
Add apitest rolling offer simulation script
2021-02-03 16:56:50 +01:00
sqrrm
de38bc7067
Merge pull request #5126 from ghubstan/do-wallet-check-on-createoffer
Check wallet is avaiable and/or unlocked on createoffer
2021-02-03 16:22:06 +01:00
ghubstan
072364b490
Explain 'payment sent' implies 'funds deposited'
There is no need to simulate the time it takes between
receiving a 'payment sent' msg and having funds (fiat) deposited
in the seller's bank account.  But there is need to explain
that in the script.
2021-02-03 12:11:33 -03:00
sqrrm
5278973472
Merge pull request #5128 from ghubstan/02-refactor-simulation-scripts
Make some trade simulation functions re-usable
2021-02-03 13:43:31 +01:00
sqrrm
803e4001da
Merge pull request #5116 from ghubstan/01-fix-bash-syntax
Fix bash syntax inconsistencies
2021-02-03 13:31:04 +01:00
sqrrm
9252d4bf34
Merge pull request #5125 from ghubstan/gitignore-apitest-dao-setup
Git-ignore apitest dao-setup files
2021-02-03 13:28:15 +01:00
Christoph Atteneder
f447d5b341
Merge pull request #5146 from ripcurlx/hide-trigger-price-in-confirmation
[v1.5.5] Hide trigger price box if not used in confirmation step
2021-02-02 09:15:31 +01:00
Christoph Atteneder
d9f51afb8d
Hide trigger price box if not used in confirmation step 2021-02-01 19:52:31 +01:00
sqrrm
1a8aba8221
Merge pull request #5145 from ripcurlx/improve-pending-trades-list
[v1.5.5] Improve pending trades list rendering
2021-02-01 13:05:03 +01:00
Christoph Atteneder
dcfcf6c214
Add sanity check 2021-02-01 11:24:20 +01:00
sqrrm
a819e9e9ca
Merge pull request #5133 from ripcurlx/fix-ui-overlap-for-offer-matching-feature
[v1.5.5] Prevent overlapping in offer book tools bar
2021-02-01 11:16:35 +01:00
Christoph Atteneder
ade1c86c72
Reset references to enable GC 2021-02-01 10:52:21 +01:00
Christoph Atteneder
fd3f0e6d25
Minor cleanup 2021-02-01 10:52:06 +01:00
Christoph Atteneder
1af7e6a971
Bottom align elements in offerbook tools box 2021-02-01 09:30:37 +01:00
Christoph Atteneder
7c81e1e47b
Merge pull request #5141 from chimp1984/fix-incorrect-order-of-onUpdatedDataReceived-method-calls
onUpdatedDataReceived must be called in the correct order.
2021-02-01 09:11:46 +01:00
chimp1984
4db71e5d64
onUpdatedDataReceived must be called in the correct order.
We cannot use a listener at RequestDataManager as the order
is not defined if doing so.
So we use P2PService as our controlling entity to call
further clients in the correct order.
2021-01-31 13:35:28 -05:00
Christoph Atteneder
4164c77cf9
Cleanup code 2021-01-30 16:56:38 +01:00
Christoph Atteneder
2839b7a73a
Prevent overlapping of offer tools
Moves everything into box to prevent hiding of information in all languages
2021-01-30 16:56:02 +01:00
ghubstan
99af81d51d
Remove DONE flag
There should not be a check on that flag in the rolling offers script.
Terminate the script with ^C.
2021-01-29 18:13:34 -03:00
ghubstan
e3f707fea6
Make executetrade simulation more realistic
Demonstrate how traders poll trade status as they go through
the protocol.
2021-01-29 18:04:02 -03:00
Christoph Atteneder
3781b5f8b3
Merge pull request #5122 from stejbac/fix-stale-trade-statistics-list-view
Fix stale trade statistics list view when new entries arrive
2021-01-29 19:34:58 +01:00
ghubstan
da5e1e5ade
Add functions for checking trade status 2021-01-29 13:53:23 -03:00
ghubstan
d580e77bf8
Try alternative syntax to make codacy happy
The codacy issue "$/${} is unnecessary on arithmetic variables"
seems to not apply to $(echo $((1 + $RANDOM % 10))), but we
try another syntax to make her happy.
2021-01-29 11:47:37 -03:00
Christoph Atteneder
e5175068cb
Merge pull request #5118 from jmacxx/word_change_m52go
Wording change for CashByMail
2021-01-29 11:47:43 +01:00
ghubstan
27a4a31dcc
Add apitest rolling offer simulation script
The script demonstrats a way to always keep one offer in the market.
As soon as the offer is taken and the trade is completed, another
offer is placed.
2021-01-28 20:11:09 -03:00
ghubstan
74008e9385
Move createoffer command generation to its own function 2021-01-28 19:56:15 -03:00
ghubstan
5a78d18103
Refactor createpaymentacct and trade protocol functions
Code duplication needs to be reduced as new scripts are added.

- Refactor the createpaymentacct functions.
  The steps required to create a payment account are still
  displayed, but only for Alice, not Bob.

- Treat the trade protocol simulation as an atomic function.
  This will reduce 'main' simulation script size as new
  ones are added.
2021-01-28 19:33:21 -03:00
ghubstan
017db11217
Check wallet is avaiable and/or unlocked on createoffer
Do not attempt to create an offer if the server wallet is
unavailable.  And if the wallet is encrypted, do not attempt
to create an offer if the wallet is not unlocked.
2021-01-28 14:50:22 -03:00
ghubstan
1eaa081e77
Git-ignore apitest dao-setup files
Added .gitignore line for apitest dao-setup files.  Regtest/DAO
setup files downloaded during a build should not be tracked by git,
nor saved in the repo.  These are the files downloaded, unzipped
and installed by the gradle task installDaoSetup:
    $ ./gradlew clean build :apitest:installDaoSetup
2021-01-28 14:21:30 -03:00
Steven Barclay
0a38aebdf8
Fix stale trade stats list view when new entries arrive
Ensure the trade statistics list in TradesChartsView doesn't go stale
upon new stats arrivals, by moving a fillList() call from the currency
combobox onChangeConfirmed event handler to the selectedTradeStatistics
(TradesChartsViewModel field) listener.

Also avoid unnecessary use of an ObservableList as a temporary variable.
2021-01-27 20:42:52 +00:00
jmacxx
7ea3f1c9d9
Wording change for CashByMail suggested by @m52go 2021-01-25 22:24:57 -06:00
ghubstan
30a0f99861
Fix bash syntax inconsistencies
Many unnecesary braces around ${VARIABLE} references were removed.
2021-01-25 12:30:59 -03:00
Christoph Atteneder
694f96806e
Merge pull request #5114 from jmacxx/cbm_currencies
Cash By Mail currency selection to use drop down combo
2021-01-24 20:05:55 +01:00
jmacxx
dbdaadba89
CBM currency selection to use drop down combo
This changes CBM to use one currency per payment account.
2021-01-24 11:21:41 -06:00
Christoph Atteneder
9005808a4d
Merge pull request #5110 from Jakub-CZ/fix-spaces-in-cashByMail
"Cash by Mail" instructions improvements
2021-01-24 15:06:00 +01:00
Christoph Atteneder
f54ec2f6ae
Merge pull request #5111 from jmacxx/fix_unnecessary_exception_log
Fix log message when opening browser link
2021-01-24 15:01:03 +01:00
jmacxx
2533a52120
Fix log message when opening browser link 2021-01-23 23:15:25 -06:00
Jakub Loucký
e2de30a6e4
Resolve unintended ellipsis. Make popup wider. 2021-01-23 23:46:48 +01:00
Jakub Loucký
fafa81811b
Fix wording 2021-01-23 23:46:09 +01:00
Jakub Loucký
803d373e44
Add details about mediation in "Cash by mail" 2021-01-23 23:40:14 +01:00
Jakub Loucký
966502247b
Fix spaces in "Cash by Mail" 2021-01-23 19:21:49 +01:00
Christoph Atteneder
80cd4a8ad6
Merge pull request #5101 from chimp1984/fix-nullpointer-at-bsq-tx-cvs-export
Fix null pointer
2021-01-22 19:12:24 +01:00
chimp1984
0169bd334c
Fix null pointer 2021-01-22 10:02:19 -05:00
Christoph Atteneder
5b0716eb76
Merge pull request #5099 from jmacxx/bugfix_emerg_payout_tool
Manual payout tool: prevent absurdly high fee payout
2021-01-22 11:26:28 +01:00
jmacxx
db76346cde
Manual payout tool: prevent absurdly high fee payout
- trims whitespace from numeric input fields before parsing
- adds percentage display of the tx fee
- validates that the tx fee percentage is not higher than 10%
2021-01-21 12:49:08 -06:00
Christoph Atteneder
334fbdbc86
Merge pull request #5092 from jmacxx/add_cashbymail3
Add payment method "Cash by mail"
2021-01-21 10:26:59 +01:00
Christoph Atteneder
570d6a8b38
Merge pull request #5093 from ghubstan/02-trading-scripts
Add api trade simulation scripts
2021-01-21 09:42:14 +01:00
jmacxx
2ab96d997f
Update core/src/main/resources/i18n/displayStrings.properties
Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
2021-01-20 16:34:43 -06:00
ghubstan
b2d8faf2cd
Log price feed request warnings, do not throw to CLI
The price feed service throws PriceRequestExceptions when switching
currencies, log those exceptions as warnings in the server and don't
pass them up to the CLI.
2021-01-20 19:27:35 -03:00
ghubstan
d18b2d5a10
Run an async price feed request when CLI needs market price
The CLI was receiving stale, cached market prices from the feed service.
2021-01-20 17:46:35 -03:00