Android-X13
fdd288b2bd
Check if localnet is deployed and wipe dead screens
2022-11-21 04:45:31 +02:00
HenrikJannsen
671ab1f373
Cleanup
...
Improve toString methods
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:55:04 -05:00
HenrikJannsen
0f14ea29c9
Improve handling of case when Bitcoin Core sync is not completed.
...
We repeat with a quadratically increasing delay 5 times, then we give up.
In the previous code we repeated forever which could be risky in case that
code branch is called unexpectedly.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:51:15 -05:00
HenrikJannsen
811ae52f27
Fix bug with using getPreviousBlockHash instead of getHash
...
It had no consequences as it was only used for info logging
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:46:38 -05:00
HenrikJannsen
1e72e265f7
Cleanup comments
...
Improve toString methods
Rename var for more clear meaning
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:44:58 -05:00
HenrikJannsen
de654c15b3
Improve handling of ConnectionState.expectedInitialDataResponses
...
Rename to expectedInitialDataResponses as we compare with numInitialDataResponses.
Add comment to make it more clear how its used.
Let the LiteNode increment only if getBlocks get called (e.g. blocks are missing).
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:41:32 -05:00
Android-X13
d4a01491a3
Request correct payment method for SEPA/SEPA Instant trades
2022-11-17 18:56:04 +02:00
Bisq GitHub Admin
60522218a7
Merge pull request #6412 from bisq-network/release/v1.9.6
...
Merge release branch
2022-11-15 21:03:40 +01:00
Christoph Atteneder
900fa47138
Revert to SNAPSHOT version
2022-11-13 10:48:44 +01:00
jmacxx
66a7a6569d
Change arbitration payout to implement proposal 386...
...
Do not pay out the security deposit of the trade peer to the
arbitration case winner.
Amounts are filled out based on which option the
Arbitrator chooses:
If BTC buyer is selected as case winner they will get
trade amount + buyer security deposit.
If BTC seller is selected as case winner they will get
trade amount + seller security deposit.
If custom payout is selected arbitrator can specify
custom amounts as they wish.
2022-11-12 21:52:13 -06:00
sqrrm
3dd9b0e575
Merge pull request #6403 from HenrikJannsen/disable-deactivation-of-dao
...
Require the DAO is enabled for traders
2022-11-04 11:44:26 +01:00
HenrikJannsen
b8637d067c
Move requestingTxsPopup.hide() before if/else case
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 17:16:13 -05:00
HenrikJannsen
81be778df3
Remove deposit tx output size check.
...
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 14:14:32 -05:00
HenrikJannsen
e653262751
Fix param in test
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 12:26:59 -05:00
HenrikJannsen
cba35b6342
Remove deposit tx output size check.
...
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 12:21:47 -05:00
HenrikJannsen
8d8cdc14b4
Cleanup
2022-11-03 12:12:02 -05:00
sqrrm
212cd77db4
Merge pull request #6402 from HenrikJannsen/refactor-dispute-validation
...
Refactor dispute validation
2022-11-03 17:54:04 +01:00
HenrikJannsen
8d0b0be505
Fix wrong rowSpan values (was bug in current version)
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 11:19:30 -05:00
HenrikJannsen
b5df4afd40
Remove DevEnv.isDaoActivated method as not used anymore
...
Remove daoActivatedToggleButton from PreferencesView and NewsView
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 11:16:10 -05:00
HenrikJannsen
114bda22cd
Remove DevEnv.isDaoActivated() from combined if statements with && as isDaoActivated is always true
...
In case of a `||` the statement gets removed as it always is true.
At getUserPaymentAccounts we refactor further the steam to a HashSet constructor operation as the filter method gets removed.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 11:04:36 -05:00
HenrikJannsen
e8a9132d30
Remove if blocks with !DevEnv.isDaoActivated() and combined && as isDaoActivated is always true the whole statement is always false
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 11:00:23 -05:00
HenrikJannsen
80e7dc7203
Remove tertiary operator DevEnv.isDaoActivated() ? as isDaoActivated is always true
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 11:00:22 -05:00
HenrikJannsen
3e99a110d7
Remove if (!DevEnv.isDaoActivated()) checks as !isDaoActivated is always false
2022-11-03 11:00:22 -05:00
HenrikJannsen
72d97b8d97
Remove if (DevEnv.isDaoActivated()) checks as isDaoActivated is always true
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 10:51:01 -05:00
HenrikJannsen
008cfaac57
Remove daoActivated options
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 10:46:26 -05:00
HenrikJannsen
14312f08af
Add validateDisputeData, validateTradeAndDispute and validateSenderNodeAddress methods
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:59:12 -05:00
HenrikJannsen
04e501d450
We had not updated the contract hash after setting the signature.
...
We verify later the contract hash in disputes and that would fail otherwise.
2022-11-02 23:56:25 -05:00
HenrikJannsen
c49b811da3
Add verification of chain of transactions at DisputeSummaryWindow
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:24:05 -05:00
HenrikJannsen
60cd8b1e16
Add requestBlockchainTransactions and verifyTradeTxChain methods to RefundManager
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:15:41 -05:00
HenrikJannsen
0553a0f9d4
Add cachedDepositTx field to Dispute
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:15:11 -05:00
HenrikJannsen
0388c7c88a
Add block explorer tx as hex request using completeable future api
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:03:55 -05:00
HenrikJannsen
7f5675f054
Remove if case for old clients
...
Remove null check for dispute
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:51:39 -05:00
HenrikJannsen
97648c51f3
Rename to make use case more clear
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:49:57 -05:00
HenrikJannsen
0bf44f061d
Remove addressAsString null check. That was when the donationAddress got added to support not updated nodes. Now there are none of such nodes.
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:48:55 -05:00
HenrikJannsen
710dba9f36
Remove validateDonationAddress method without dispute param
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:47:39 -05:00
HenrikJannsen
5daaa60779
Refactor validateDonationAddress
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:44:58 -05:00
HenrikJannsen
3007652f4a
Remove dispute field from TradeDataValidation.ValidationException
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:41:46 -05:00
HenrikJannsen
cfb3780e6b
Move null check for address to validateDonationAddress method
...
Remove dispute as unused param
Remove redundant methods
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:39:56 -05:00
HenrikJannsen
e8c6b0ae14
Remove daoFacade as unused parameter
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:32:28 -05:00
HenrikJannsen
cfc67dcc9c
Move validateDonationAddress to DisputeValidation
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:29:59 -05:00
HenrikJannsen
d86071db4a
Remove validateDonationAddress call inside validateDelayedPayoutTx.
...
Add call to validateDonationAddress at client calling validateDelayedPayoutTx
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:28:41 -05:00
HenrikJannsen
2484fa4371
Part of a multistep refactoring to separate dispute related validation out of TradeDataValidation
...
Refactor donationAddress validation out to new method
Rename addressAsString to delayedPayoutTxOutputAddressAsString
Recreate delayedPayoutTxOutputAddress at new validateDonationAddress method from relevant data
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:25:11 -05:00
HenrikJannsen
e49e634956
Move testIfAnyDisputeTriedReplay and related methods to DisputeValidation
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:14:55 -05:00
HenrikJannsen
37457ed132
Move validateDonationAddress to DisputeValidation
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:12:55 -05:00
HenrikJannsen
12686deff6
Move validateNodeAddress to DisputeValidation
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:11:23 -05:00
HenrikJannsen
aa22bd366a
Add DisputeValidation class for validation methods and exceptions of the dispute domain.
...
Move AddressException, NodeAddressException and DisputeReplayException to DisputeValidation.
Use DisputeValidation.ValidationException as type for DisputeManager.validationExceptions.
Remove Nullable annotation for dispute field in those exceptions.
Remove null checks when those DisputeValidation.ValidationException are used.
2022-11-02 22:09:30 -05:00
HenrikJannsen
d7deb169a1
Add /.run to gitignore
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 21:23:59 -05:00
HenrikJannsen
43fb0cc635
Reformat code and reorg imports
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 21:22:35 -05:00
jmacxx
bc8b05ea45
Log readability will be improved by lowering to trace the repetitive
...
logging of: `The requester had version x.x.x. Our historical data
store has version y.y.y As the requester version is not older as our
historical store we do not add the data to the result map.`
Which takes up many screenfuls of log for every client getDataRequest.
2022-10-31 10:46:12 -05:00
dependabot[bot]
dac2561cef
Bump gradle/wrapper-validation-action from 1.0.4 to 1.0.5
...
Bumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action ) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/gradle/wrapper-validation-action/releases )
- [Commits](e6e38bacfd...55e685c48d
2022-10-31 14:22:28 +00:00
