Commit graph

2223 commits

Author SHA1 Message Date
chimp1984
406bcfb064
Remove PublishTradeStatistics from buyer protocol
We let seller publish trade stats to avoid those issues with duplicated entries as trade date is different.
We could fix that to use the same trade date,  but it seems to be not needed that both traders are publishing and the
risk if a trade stat does not get successfully published does not cause real problems.
There is guarantee anyway that the data is broadcast even if both do it.

In case we still want to do it from both sides we need to use the sellers trade date which is exchanged early in the trade
protocol but yet not further used beside for account age check.
2020-10-08 18:48:17 -05:00
Oscar Guindzberg
f9f5d92941
Add segwit/legacy checbox for address creation 2020-10-08 16:33:52 -03:00
cd2357
0a1b581d32
Remove --runtime-image option using separate JDK
Remove the --runtime-image jpackage option, which was packaging Java 11 in the resulting installers. Reason is that jpackage 15 does not properly package the Java 11 runtime, but contains necessary features for signing and notarizing the app. On the other hand, jpackage 14 does package the Java 11 runtime correctly in the resulting installers, but does not support proper signing and notarizing.
2020-10-08 13:29:40 +02:00
cd2357
696a788e5e
Disable '-Djdk.module.illegalAccess=deny' javaoption
Disable the java option because it causes issues in the resulting app if packaged with a recent Java Runtime (tested with Java 11, 14 and 15).
2020-10-08 13:15:08 +02:00
Christoph Atteneder
5294820eb6
Bump version number for v1.4.0 2020-10-08 09:39:01 +02:00
chimp1984
2d99ae7d09
Remove isDisputed checks 2020-10-06 11:04:20 -05:00
chimp1984
b4bd1df27f
Refactor: Move method 2020-10-06 10:45:19 -05:00
chimp1984
4a0fe3e62e
Move checks to enable confirm to Trade
Use it in view to disable button
2020-10-06 10:40:39 -05:00
chimp1984
f0606f9266
Refactor: Remove commented out code and comments 2020-10-06 10:26:11 -05:00
cd2357
0b40dff95d
Set -Djdk.module.illegalAccess=deny
Backport #4600 into this PR.

Set `-Djdk.module.illegalAccess=deny` in order to reduce warning in startup logs.
2020-10-06 11:41:36 +02:00
Christoph Atteneder
454b3a97d5
Merge pull request #4587 from wiz/update-tac-for-price-indices
Update text/URL in Terms and Conditions window for Bisq Price Indices
2020-10-06 10:10:21 +02:00
chimp1984
be204c457d
Setting jvm option -Djdk.module.illegalAccess=deny avoids the warning logs at startup
Not sure how to add it to gradle so its set at normal compilation as well...

User get confused by the warning as it sounds somehow alerting.

`WARNING: An illegal reflective access operation has occurred
 WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/Users/dev/.gradle/caches/modules-2/files-2.1/com.google.inject/guice/4.2.2/6dacbe18e5eaa7f6c9c36db33b42e7985e94ce77/guice-4.2.2.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
 WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
 WARNING: All illegal access operations will be denied in a future release`
2020-10-06 00:19:50 -05:00
cd2357
e409b496ed
Fix macOS dmg background image
Update macOS setup script to use the tiff image in the installer bundle, as this is the type of background image expected and included by jpackage.

Convert Bisq-background.png to Bisq-background.tiff using imagemagick.
2020-10-04 22:14:12 +02:00
cd2357
45a27aff64
Remove jpackage Windows TODO
Remove TODO, since previous argument concatenation fix addressed the issue (desktop and start menu shortcuts are created now).
2020-10-04 12:56:34 +02:00
cd2357
ebadce5cee
Fix jpackage option concatenation
Fixed typo affecting jpackage option concatenation, where a missing "+" caused subsequent options to not be considered. Surround concatenated options with parentheses, to ensure such a typo in the future is marked as a syntax error, and therefore avoided.
2020-10-04 12:16:29 +02:00
chimp1984
e9db7c6808
Rename Priority to Source. This should make it more clear what is the intention of the usage.
Rename:
LOW to NETWORK
MID to PRIVATE_LOW_PRIO
HIGH to PRIVATE

Change delay of MID/PRIVATE_LOW_PRIO from 30 min to 2 hours (we had different datastores before using it, now its only real low prio stores)

Add comment to each enum
2020-10-03 12:48:23 -05:00
chimp1984
137b5e81d1
Enforce that clients set the priority. Remove the initialize methods which did not have priority as a param.
Make initializePersistenceManager in StorageService abstract to enforce in concrete class to define priority.

Change priorities for future renaming to a different meaning. instead of priority we want to describe the category: private data, public data,.... will come in next commit
2020-10-03 12:48:22 -05:00
chimp1984
32238f2050
Rename getClosedTradables and getFailedTrades to getObservableList 2020-10-03 12:48:22 -05:00
chimp1984
e242c54dab
Refactor: Rename getTradesAsObservableList to getObservableList 2020-10-03 12:48:22 -05:00
chimp1984
ccfda5b043
Cleanups, add generics, add final, remove unused code/comments/todos, 2020-10-03 12:48:21 -05:00
chimp1984
fa0d261397
Fix remaining issues, cleanups, add persit calls, remove unused code,...
Sorry too tired to create another 20 commits...
2020-10-03 12:48:21 -05:00
chimp1984
b901f358a7
Add missing persist calls. Add generics. Remove persist method. Add final. 2020-10-03 12:48:21 -05:00
chimp1984
486e6f4985
Use PersistenceManager 2020-10-03 12:48:20 -05:00
chimp1984
e825613f5c
Use PersistenceManager 2020-10-03 12:48:20 -05:00
chimp1984
d4f460b4b0
Use PersistenceManager 2020-10-03 12:48:19 -05:00
chimp1984
4f3ded6acf
Use PersistenceManager instead of Storage for import/export 2020-10-03 12:48:15 -05:00
chimp1984
802dcad2fb
Refactor: Rename CorruptedDatabaseFilesHandler 2020-10-03 12:48:14 -05:00
chimp1984
23507102dd
Refactor: Move CorruptedDatabaseFilesHandler 2020-10-03 12:48:14 -05:00
chimp1984
8aff1f8665
Refactor: Move FileUtil 2020-10-03 12:48:14 -05:00
cd2357
91190ee101
macOS binaries: remove pkg
Update build script to only build the dmg for macOS.
2020-10-03 17:27:06 +02:00
wiz
4dc27d9c2a
Remove extra "is" word in TaC text 2020-10-02 22:03:51 +09:00
Christoph Atteneder
8137cb982f
Remove translation to prevent clipping after jFoenix update
The drawback of this is that the floating label on top of the
Field is not properly left aligned anymore.
A proper fix would mean more re-writing of the jFoenix library
which would make it harder and harder to maintain for applying
library updates.
2020-10-02 09:57:14 +02:00
wiz
1a80da2bb7
Update text/URL in Terms and Conditions window for Bisq Price Indices
Since this is a legal agreement, the goal is to limit the liability of
the facilitators of the service, not to explain how we calculate the
price indicies - users can find that information on the "about" page.

Also updates URL for Dispute Resolution to the new wiki article.

Fixes #4571
2020-10-02 08:48:37 +09:00
chimp1984
ff1380481d
Merge branch 'master_upstream' into improve-startup-routines
# Conflicts:
#	core/src/main/java/bisq/core/app/BisqSetup.java
2020-10-01 10:34:43 -05:00
chimp1984
fb41a1984b
Merge branch 'master_upstream' into fix-delayed-payout-tx-issues
# Conflicts:
#	core/src/main/java/bisq/core/trade/TradeManager.java
#	desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java
2020-10-01 09:24:46 -05:00
Christoph Atteneder
a1778ed701
Merge pull request #4578 from chimp1984/show-if-maker-has-xmr-autoconf-enabled
Show if maker has xmr autoconf enabled
2020-10-01 09:11:45 +02:00
chimp1984
c3e1ae691b
Remove cryptoSetupFailedHandler 2020-09-30 22:39:13 -05:00
chimp1984
bb99eef059
Refactor: Move AvoidStandbyModeService from BisqApp to BisqExecutable.setupAvoidStandbyMode 2020-09-30 22:26:42 -05:00
chimp1984
4f9a6ea436
Refactor: Move periodic printSystemLoad to commonSetup 2020-09-30 22:17:36 -05:00
chimp1984
aa7315b32d
Refactor: Rename onUiReadyHandler to onApplicationStartedHandler 2020-09-30 22:16:32 -05:00
chimp1984
9d12bf7d52
Refactor: Move sig int handlers to CommonSetup 2020-09-30 22:10:44 -05:00
chimp1984
9232a5765b
Improve handling of UncaughtExceptionHandler 2020-09-30 22:06:51 -05:00
chimp1984
7ea3676c55
Refactor: Rename setup to setupUncaughtExceptionHandler
rename setupErrorHandler to checkCryptoPolicySetup
move UncaughtExceptionHandler code to setupUncaughtExceptionHandler
2020-09-30 21:55:50 -05:00
Christoph Atteneder
4d7e26d87d
Merge pull request #4576 from chimp1984/fix-filter-bug
Fix bug with missing remove of old filter when new filter is added.
2020-09-30 16:30:48 +02:00
chimp1984
137d9185e3
Only add a row if xmr offer 2020-09-30 00:56:40 -05:00
chimp1984
5d41574931
Refactor: Rename TradeDataValidation.validatePayoutTx to TradeDataValidation.validateDelayedPayoutTx 2020-09-29 23:46:38 -05:00
chimp1984
18c1fc1410
Fix bug with missing remove of old filter when new filter is added.
- Add handling for removing invalid filters

When adding a new filter invalid filters get removed if they have been created with the same priv key.
2020-09-29 23:25:22 -05:00
chimp1984
f46e132195
Add rocket icon to xmr offers which have enabled autoconf
Add info to tooltip and to offer window
Add center css to actions column. It looks weird that title is left aligned and button is centered.
only "last-column", "avatar-column" worked, making an new style e.g. center-column did not succeed... css is not my friend....
Shorten "Time since signing" to "Signed since" header to avoid truncation
2020-09-29 00:45:31 -05:00
chimp1984
e8ab4c7222
Merge branch 'master_upstream' into fix-delayed-payout-tx-issues 2020-09-28 20:46:34 -05:00
sqrrm
37ce52ba8c
Merge pull request #4555 from jmacxx/fix_security_deposit_display
Display the calculated security deposit at order entry
2020-09-27 14:42:48 +02:00