mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-24 15:10:44 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove PublishTradeStatistics from buyer protocol

Browse source 
We let seller publish trade stats to avoid those issues with duplicated entries as trade date is different.
We could fix that to use the same trade date,  but it seems to be not needed that both traders are publishing and the
risk if a trade stat does not get successfully published does not cause real problems.
There is guarantee anyway that the data is broadcast even if both do it.

In case we still want to do it from both sides we need to use the sellers trade date which is exchanged early in the trade
protocol but yet not further used beside for account age check.
This commit is contained in:
chimp1984 2020-10-05 15:26:16 -05:00
parent 00bed02839
commit 406bcfb064
No known key found for this signature in database
GPG key ID: 9801B4EC591F90E3
2 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/src/main/java/bisq/core/trade/protocol/BuyerProtocol.java
View file

@ -24,7 +24,6 @@ import bisq.core.trade.messages.DepositTxAndDelayedPayoutTxMessage;
import bisq.core.trade.messages.PayoutTxPublishedMessage;
import bisq.core.trade.messages.TradeMessage;
import bisq.core.trade.protocol.tasks.ApplyFilter;
import bisq.core.trade.protocol.tasks.PublishTradeStatistics;
import bisq.core.trade.protocol.tasks.TradeTask;
import bisq.core.trade.protocol.tasks.buyer.BuyerProcessDepositTxAndDelayedPayoutTxMessage;
import bisq.core.trade.protocol.tasks.buyer.BuyerProcessPayoutTxPublishedMessage;
@ -114,8 +113,7 @@ public abstract class BuyerProtocol extends DisputeProtocol {
removeMailboxMessageAfterProcessing(message);
}))
.setup(tasks(BuyerProcessDepositTxAndDelayedPayoutTxMessage.class,
BuyerVerifiesFinalDelayedPayoutTx.class,
PublishTradeStatistics.class)
BuyerVerifiesFinalDelayedPayoutTx.class)
.using(new TradeTaskRunner(trade,
() -> {
stopTimeout();

2
desktop/src/main/java/bisq/desktop/main/debug/DebugView.java
View file

@ -179,7 +179,6 @@ public class DebugView extends InitializableView<GridPane, Void> {
BuyerProcessDepositTxAndDelayedPayoutTxMessage.class,
BuyerVerifiesFinalDelayedPayoutTx.class,
PublishTradeStatistics.class,
ApplyFilter.class,
MakerVerifyTakerFeePayment.class,
@ -216,7 +215,6 @@ public class DebugView extends InitializableView<GridPane, Void> {
BuyerProcessDepositTxAndDelayedPayoutTxMessage.class,
BuyerVerifiesFinalDelayedPayoutTx.class,
PublishTradeStatistics.class,
ApplyFilter.class,
TakerVerifyMakerFeePayment.class,