Commit Graph

11853 Commits

Author SHA1 Message Date
chimp1984
70d98d9554
Ensure the division is not by 0 and add try catch to MovingAverage 2020-09-14 16:06:52 -05:00
chimp1984
71d57298b0
Add try/catch at setSuggestedSecurityDeposit code 2020-09-14 16:05:47 -05:00
Christoph Atteneder
a19c662b44
Merge pull request #4511 from sqrrm/return-on-null
Return if setting not present
2020-09-11 16:53:21 +02:00
Christoph Atteneder
2b9445d50f
Merge pull request #4507 from chimp1984/fix-bug-with-seed-restore-and-open-offers
Fix bug with seed restore and open offers
2020-09-11 16:52:11 +02:00
Christoph Atteneder
425ae87870
Merge pull request #4496 from freimair/tor_0.4.3.6
Tor 0.4.3.6
2020-09-11 16:46:10 +02:00
Christoph Atteneder
43fac2cc31
Merge pull request #4513 from wiz/revert-tether-usd-assets
Revert Tether USD for now due to various issues
2020-09-10 21:30:18 +02:00
wiz
de48b3b040
Revert Tether USD for now due to various issues 2020-09-11 00:51:19 +09:00
Christoph Atteneder
9ab53eb099
Merge pull request #4512 from wiz/fix-name-of-liquid-tetherusd
Fix name of L-USDT asset to Tether USD (Liquid)
2020-09-10 17:09:56 +02:00
wiz
8004186ff4
Fix name of L-USDT asset to Tether USD (Liquid) 2020-09-10 23:30:39 +09:00
sqrrm
a8f19a938a
Merge pull request #4508 from ripcurlx/updates-for-v1.3.8
Update data stores for v1.3.8
2020-09-10 10:53:35 +02:00
sqrrm
db8c02b40b
Return if setting not present 2020-09-10 10:29:05 +02:00
sqrrm
579c2c416b
Merge pull request #4510 from devinbileck/add-xmr-explorer
Add new Monero explorer xmrblocks.bisq.services with onion
2020-09-10 10:23:52 +02:00
Devin Bileck
18496b71e2
Add new Monero explorer xmrblocks.bisq.services with onion
As per https://github.com/bisq-network/proposals/issues/257
2020-09-09 21:17:15 -07:00
Christoph Atteneder
be4e905018
Update data stores for v1.3.8 2020-09-09 22:08:58 +02:00
chimp1984
00d267e4db
Merge branch 'master_upstream' into fix-bug-with-seed-restore-and-open-offers 2020-09-09 14:29:27 -05:00
chimp1984
6821c582e9
Add check for open offers and remove them if present at restore from seed 2020-09-09 14:12:03 -05:00
chimp1984
1bea05d8c6
Fix bug with wallet restore with same seed and when there was
an open offer.

Improve handling of restore and add more checks to avoid invalid
entries.
2020-09-09 13:52:34 -05:00
chimp1984
77e5d71ca4
Remove unused method 2020-09-09 13:50:42 -05:00
chimp1984
7fb42f37eb
Improve toString method 2020-09-09 13:47:32 -05:00
Christoph Atteneder
91d70ad8fd
Merge pull request #4506 from chimp1984/fix-revolut-account-id-bug
Fix revolut accountID bug
2020-09-09 20:42:32 +02:00
chimp1984
20cb98aa93
Remove side effect in setUserName method and add extra handling for the
moment we save the account. Only at that moment we check if we need to
set the accountId with the value of the userName.
We do that in the domain layer to avoid more domain logic code in the UI
layer.

Fixes bug found at:
https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-485066342
2020-09-09 11:21:43 -05:00
Christoph Atteneder
a0c298e000
Merge pull request #4503 from chimp1984/xmr-tool-bugfix-ignore-future-results-after-terminal-result
Xmr tool bugfix: Ignore future results after terminal result
2020-09-09 14:59:01 +02:00
chimp1984
54fdb5267f
Instead of renaming the AddressEntryList to a backup file we keep it
at restore from seed and create a backup copy.
I don't know what was the motivation of removing the original file
(probably the use case that the seeds are different and thus there
is no match of existing entries with the new addresses) as
that breaks the internal association of addresses with trades/offers and
the reserved balances display.

This should be tested well though with the related use cases
(diff. offer and trade states, wallet restore with same seed of with
foreign seed -> in that case we need to recreated the AddressEntryList
but that should be handled in the related domain)

- Add copyFile method
2020-09-08 19:14:38 -05:00
chimp1984
fa0224550c
Refactoring
- Add SharedPresentation class for methods in GUIUtil which are no
utility methods.
- Move restoreSeedWords to SharedPresentation
2020-09-08 19:00:16 -05:00
chimp1984
fa987d1461
- Change entrySet to CopyOnWriteArraySet to avoid potential ConcurrentModificationExceptions
- Make entrySet final
- Avoind unneeded wrapping
- Remove visibility of entrySet
- Add getAddressEntriesAsListImmutable method. This is the only access for the hashSet
so we ensure it cannot be changed from outside.
- Remove stream() method
- Remove unused return types
- Improve some stream structures
- Renaming, improve comments
2020-09-08 18:53:32 -05:00
chimp1984
e197b4ce25
Use a hash set instead of a list to avoid duplicates
In dev testing I got the case of duplicated address entries and thus
incorrect balance. I could not reproduce it later but looking in the
AddressEntry code it was unsafe using the add operation on list without
a contains check. Better instead to use a HashSet and avoid possibility
of duplicated entries by the chosen data structure.
Note that the protobuf representation is still a list and get converted
to a HashSet.
2020-09-08 18:09:48 -05:00
chimp1984
b39e6b5934
Improve text in UI in case of failure or error 2020-09-08 16:22:28 -05:00
chimp1984
b01ecb6b93
Rearrange fields and improve toString method 2020-09-08 16:10:05 -05:00
chimp1984
8c6177742c
Ignore future results in case we had a terminal result already.
Avoid that a success result overwrites an earlier failed/error result.
2020-09-08 16:09:29 -05:00
sqrrm
f1a284ceb0
Merge pull request #4492 from wiz/use-https-for-xmr-explorer-api
Use https:// for XMR explorer API endpoints, except if localhost or Tor
2020-09-08 18:17:11 +02:00
sqrrm
38d62dbf1b
Merge pull request #4501 from wiz/update-mempool-explorer-urls
Update old Bisq Explorer URLs with new Mempool Explorer URLs, tweak strings
2020-09-08 13:50:24 +02:00
wiz
906805ec2e
Rename Monero Explorer to friendlier hostname explorer.monero.wiz.biz 2020-09-08 20:26:23 +09:00
wiz
245027bff4
Fix codacy complaining about missing space character 2020-09-08 20:20:30 +09:00
wiz
a2c6f279a6
Merge remote-tracking branch 'bisq/master' into use-https-for-xmr-explorer-api 2020-09-08 20:19:20 +09:00
Christoph Atteneder
f05e67028b
Merge pull request #4495 from Emzy/patch-4
XMRexplorer change from http port 80 clearnet to https 443
2020-09-08 11:37:18 +02:00
Christoph Atteneder
d73a284991
Merge pull request #4497 from m52go/add-autoconfirm-note
Add note to SetXmrTxKeyWindow
2020-09-08 11:36:06 +02:00
wiz
41bebd7811
Tweak strings of "BSQ Explorer" -> "Bisq Explorer" and "Bitcoin Explorer" 2020-09-08 12:44:33 +09:00
wiz
4076784697
Replace old Bisq Explorer URLs with new Mempool URLs for the 3 we have 2020-09-08 12:38:10 +09:00
wiz
5d83ca5c23
Add friendly name for node77.monero.wiz.biz -> explorer.monero.wiz.biz 2020-09-08 12:09:31 +09:00
wiz
1461d95b0b
Tweak string for "Service Addresses" to "Monero Explorer URLs" 2020-09-08 12:08:44 +09:00
m52go
2265d8f9e1
Add note to SetXmrTxKeyWindow
To convey what it's about, and that it's optional.
2020-09-07 11:36:32 -04:00
wiz
0869f9a016
Use lots of regex to add http or https for XMR explorer API endpoint
* If Tor *.onion hostname, use HTTP with Tor proxy
* If 127.0.0.1 or localhost, use HTTP without Tor proxy
* If LAN address or *.local FQDN, use HTTP without Tor proxy
* If any other FQDN hostname, use HTTPS with Tor proxy
2020-09-08 00:26:56 +09:00
Florian Reimair
e3193e5daf
Tor 0.4.3.6 2020-09-07 14:23:30 +02:00
Stephan Oeste
447c6ce9aa
Change from http port 80 clearnet to https 443
To be compatible to https://github.com/bisq-network/bisq/pull/4492
2020-09-07 12:38:50 +02:00
Christoph Atteneder
e7d24efb4a
Merge pull request #4489 from chimp1984/various-small-improvements
Various small improvements
2020-09-07 10:58:59 +02:00
Christoph Atteneder
ee8e931e34
Merge pull request #4494 from chimp1984/fix-xmr-tool-bug-with-single-httpClient
Bugfix: Create new HttpClient for each request.
2020-09-07 09:59:18 +02:00
Christoph Atteneder
b81e804bb1
Merge pull request #4491 from chimp1984/bugfix-xmr-tool
Bug fixes
2020-09-07 09:56:44 +02:00
Christoph Atteneder
38cff29d97
Merge pull request #4490 from jmacxx/origin/add-xmr-tx-key-service-fix
Minor bug fixes for XMR tx proof feature
2020-09-07 09:54:38 +02:00
Christoph Atteneder
27a9f9636f
Merge pull request #4493 from chimp1984/deactive-confirm-buttons-once-mediation-started
Deactive confirm buttons once mediation started
2020-09-07 09:42:59 +02:00
chimp1984
2ab779f9b8
Remove DevTestXmrTxProofHttpClient 2020-09-07 01:05:07 -05:00