Commit Graph

14115 Commits

Author SHA1 Message Date
ghubstan
6b2c386a7c
Fix call rate metering interceptor bug
The gRPC interceptor was not using the correct method/ratemeter
map key, and failing to find a rate meter for the server call.

- Fix the rate meter key lookup bug.

- Disable most strict, default call rate meters in tests.
  Made an adjustment to the test harness' scaffold setup so an interceptor
  testing or disabling config file is always picked up by bob and alice
  daemons.

- Set arbitration daemon's registerDisputeAgent rate @ 10/second, so
  it does not interfere with the test harness.  (There is no pre-existing
  arb node appDataDir before that daemon starts.)

Note:  The test harness cannot install the custom rate metering file in
an arb daemon's appDataDir before it starts because there is no dao-setup
file for that node type.

TODO:  Adjust api simulation scripts to interceptor bug fix.
2021-02-27 21:47:52 -03:00
ghubstan
f90d2cee57
Fix test bug 2021-02-27 18:24:57 -03:00
ghubstan
e8d1f03792
Clean up call rate meter config file in test teardown 2021-02-27 18:10:06 -03:00
ghubstan
98ff6cf9ef
Fix test bug 2021-02-27 18:01:45 -03:00
ghubstan
320e63c0a1
Log 'trade not found' a warning instead of full stack trace 2021-02-27 17:25:49 -03:00
ghubstan
e5a0a3998d
Permit some gRPC excptions to be logged only as warning
A new handleExceptionAsWarning method logs warn(ex.msg) instead of
the full stack trace.
2021-02-27 17:14:22 -03:00
ghubstan
e5291e9f45
Use the logger of the gRPC service throwing an exception 2021-02-27 17:09:54 -03:00
ghubstan
e2bb64de7d
Merge branch 'master' into 01-show-cost-in-trade-output 2021-02-27 08:40:51 -03:00
sqrrm
80c722803d
Merge pull request #5247 from bisq-network/release/v1.5.7
Release/v1.5.7
2021-02-26 22:34:08 +01:00
Christoph Atteneder
52c90dc9c1
Revert to SNAPSHOT version 2021-02-26 21:06:35 +01:00
ghubstan
d60c0dd3ca
Display buyer's cost in api's gettrade output
The offer volume is shown so traders know how much fiat
they are sending or receiving without having to call getoffer.

Changed the 'Fiat Sent' and 'Fiat Received' column headers
to show which fiat is being transfered, e.g., 'EUR Sent',
'EUR Received'.

Adjusted apitest's trade-simulation-utils.sh to the modified
gettrade output.
2021-02-26 15:25:31 -03:00
cd2357
fb3ed20d74
Bump netlayer and tor-binary versions
Update dependencies to use tor v0.4.5.6
2021-02-26 17:20:01 +01:00
Christoph Atteneder
4051d196c2
Merge pull request #5245 from cd2357/update-netlayer-tor-binary-v0.4.5.6
Bump netlayer and tor-binary versions
2021-02-26 17:19:34 +01:00
sqrrm
11a1167b44
Merge pull request #5244 from ghubstan/001-adjust-apitest-for-grpc-client
Refactor apitest cases to use GrpcClient
2021-02-26 13:54:42 +01:00
sqrrm
acaa115355
Merge pull request #5240 from ghubstan/000-refactor-grpc-client
Refactor grpc stub boilerplate from CliMain to GrpcClient
2021-02-26 13:53:45 +01:00
sqrrm
b5793b59f4
Merge pull request #5238 from ghubstan/03-fix-settxfeerate-bug
Adjust api to new minimum fee per vbyte
2021-02-26 13:42:23 +01:00
sqrrm
8b70278174
Merge pull request #5203 from ghubstan/02-scripted-bot-test
Add CLI testing bot to :apitest
2021-02-26 13:31:39 +01:00
ghubstan
6c0eac8942
Fix param order 2021-02-26 08:24:16 -03:00
cd2357
146531d8b1
Bump netlayer and tor-binary versions
Update dependencies to use tor v0.4.5.6
2021-02-26 12:20:06 +01:00
ghubstan
ce2a523309
Remove unused imports 2021-02-25 22:24:56 -03:00
ghubstan
3bc5d05bb6
Refactor apitest cases to use GrpcClient
This is a follow up to PR https://github.com/bisq-network/bisq/pull/5240,
which moved client side gRPC boilerplate to a new, reusable GrpcClient class.

From this change forward, all (including test) client side gRPC request/response
boilerplate should now live in GrpcClient.
2021-02-25 22:05:21 -03:00
ghubstan
a5e5b9fc39
Refactor grpc stub boilerplate from CliMain to GrpcClient
CliMain no longer uses gRPC stubs directly, just parses &
validates command options, and prints responses.

Also, anticipates reuse by java bots (avoiding grpc boilerplate
duplication on the client side), reduces size of CliMain class, and
will allow clean up of duplicated grpc boilerplate in apitest cases.
2021-02-25 14:27:55 -03:00
ghubstan
e125ba8ab8
Prepare to adjust api to new minimum fee per vbyte (from feeService)
Commit c33ac1b983 changed the source of
the min tx fee rate, and the api will adjust after the associated PR
is merged.  For now, the required change is a comment.
2021-02-25 11:53:12 -03:00
ghubstan
b725f06514
Adjust api to new minimum fee per vbyte
The BaseCurrencyNetwork#getDefaultMinFeePerVbyte now returns
15 (sats/byte) since commit b341bb6e89.

This change adjusts the api to the new min tx fee rate by validating
the api's setTxFeeRatePreference param, and throwing an appropirate
exception if the param value is below the minimum.  Also adjusted a broken
test, and added a new test to check the appropriate exception is received
from the server.
2021-02-25 11:31:13 -03:00
ghubstan
3dde3cbeef
Fix typo in toString 2021-02-25 10:37:30 -03:00
ghubstan
b341bb6e89
Merge branch 'master' into 02-scripted-bot-test 2021-02-25 10:08:32 -03:00
Christoph Atteneder
0feb1079b8
Merge pull request #5223 from BtcContributor/lengthcheck
Fix length check text on manual payout tool
2021-02-24 10:33:06 +01:00
Christoph Atteneder
7ffb1bcd26
Merge pull request #5219 from jmacxx/fix_issue_5210
Fix initialization ordering issue
2021-02-24 10:20:13 +01:00
jmacxx
dab8b638ae
TraderChatManager to handle onAllServicesInitialized
Upon receipt of onAllServicesInitialized, TraderChatManager should
call tryApplyMessages in order to process any pending mailbox
messages stored up while offline.
2021-02-24 09:14:02 +01:00
jmacxx
b3263be5e9
Fix initialization ordering issue
TradeManager must be inited before MailboxMessageService
2021-02-24 09:13:52 +01:00
jmacxx
cee20edfce
codacy 2021-02-24 09:12:47 +01:00
jmacxx
43e461ea0d
Start pricenode providers asynchronously
Fixes #4441
2021-02-24 09:12:37 +01:00
Christoph Atteneder
dc3811749c
Merge pull request #4890 from jmacxx/fix_pricenode
Start pricenode providers asynchronously
2021-02-24 09:12:04 +01:00
jmacxx
cb5cc3525d
Increase min withdrawal tx fee to 15 sats/vB 2021-02-24 09:10:49 +01:00
Christoph Atteneder
f4d6986308
Merge pull request #5224 from jmacxx/increase_withdrawal_fee
Increase min withdrawal tx fee to 15 sats/vB
2021-02-24 09:10:37 +01:00
jmacxx
d3b62b1a58
TraderChatManager to handle onAllServicesInitialized
Upon receipt of onAllServicesInitialized, TraderChatManager should
call tryApplyMessages in order to process any pending mailbox
messages stored up while offline.
2021-02-23 21:12:59 -06:00
BtcContributor
6edb318236
Fix length check text on manual payout tool 2021-02-23 17:57:47 +01:00
jmacxx
b59f022ec5
Increase min withdrawal tx fee to 15 sats/vB 2021-02-23 10:29:33 -06:00
sqrrm
fd6ec136cd
Merge pull request #5217 from ripcurlx/update-data-stores-for-v1.5.7
Update of data stores and translations for v1.5.7
2021-02-23 11:29:07 +01:00
Christoph Atteneder
a691b26de4
Update witness stores 2021-02-23 11:16:29 +01:00
jmacxx
0e5c7e5de7
Fix initialization ordering issue
TradeManager must be inited before MailboxMessageService
2021-02-22 17:56:30 -06:00
Christoph Atteneder
aae52f801a
Update translations for v1.5.7 2021-02-22 15:54:53 +01:00
Christoph Atteneder
8e78cfa2b7
Update data stores for v1.5.7 2021-02-22 15:52:18 +01:00
Christoph Atteneder
5e743b2171
Add missing version number update for script 2021-02-22 15:51:50 +01:00
Christoph Atteneder
c30fd72990
Update bitcoinj checkpoints for v1.5.7 2021-02-22 15:51:33 +01:00
ghubstan
4ac9fa5b8d
Add --help option to bot-script.json generator 2021-02-20 16:37:06 -03:00
Christoph Atteneder
314e6ce314
Merge pull request #5142 from chimp1984/add-coin-input-control
Add coin input control
2021-02-19 19:13:31 +01:00
chimp1984
3c38fd67eb
Remove boolean return value for requestPreliminaryData
and call onNoSeedNodeAvailable instead.
2021-02-19 10:09:05 +01:00
chimp1984
f73408a79e
Call onNoSeedNodeAvailable if return value from requestPreliminaryData is false
We did not do all the calls before (like on p2pDataStorage), so that changes behaviour.
2021-02-19 10:09:05 +01:00
chimp1984
e57c26ecb0
Refactor: Extract method from duplicated code 2021-02-19 10:09:05 +01:00